{"id":2228692,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228692/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-26-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-26-philmd@linaro.org>","date":"2026-04-27T08:07:31","name":"[v4,25/32] monitor: Forward-declare the MonitorDef type","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"96df2130d490929ea9119a299d6b2859430d25db","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-26-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228692/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228692/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=vIpp4t7V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x9M0KrGz1yJs\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 18:11:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHH3F-0008LC-Lb; Mon, 27 Apr 2026 04:10:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH38-0007yR-58\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:39 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH35-0002b6-D0\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:36 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-48909558b3aso98958715e9.0\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 01:10:33 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7bf7besm280894725e9.34.2026.04.27.01.10.30\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:10:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277432; x=1777882232; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=/VyMpbZZBycD9uof5+Mpu9kfOlAUg4ZoswdMUmEvtEU=;\n b=vIpp4t7VkMzVW+R+oE4YRUXLC2z7owgFIl6fqZTccFUV0ljJux1pJYZhkWeJdeYLWw\n LzHxxD38E9TGEz7cm1Z4xQD8GmsOdH3djdTkaZ1KbmDUEquUVCCghocLhyISAZMf3RXD\n mjrbNxJcF2yvCiIr1vgkWav6sVC2sE8lnWP3wZ0BpM+jb/nC8NlaZIVWWcOu6AkKirLb\n ZaPs3+ADJF3vv0MbxyyAZWbqhn0mUyXgemxH/1oCrTQaFcttNqMKvHvrDRj/PmmpcVKM\n 28rZGIGoEOL6c9j2+zQntEyT3usbFAN00CdQjNem/ryVoMTv/C0mRJjZaGjI4kuvTsq/\n 9YkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277432; x=1777882232;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=/VyMpbZZBycD9uof5+Mpu9kfOlAUg4ZoswdMUmEvtEU=;\n b=q8F+ybM3+gUqHw6MjvqM7Fvvyle2qCY5YWFl65B/VIGP1D2WntVCi0j0Usw2RN+y7t\n jFPdKbmZl1SZfP1DgyY+kAlnI1he4xxGwOJ9CTSnc5/8s3yfICsipZCe567DodqgFBr+\n l7HGa4fJt06+O05nW8hMZZgwbaRJznIdMK7gC3cugOiX6OXs1RF0v6x/htfIUHtI3umO\n s+a+KTG/J5uyEKoKaIlxIC6FGaCvIUY20nsEQi3ETIf0rk0oiTvDOWYEswlkVfzeAez8\n KxCCvqFdGrQHAbMm38DnxpPkVrYYnzQHaVTdBFO7bDafLvcCM6EuVlbfQvj5SGCrCuuz\n nZPw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8Jgb0tbXPOQJy57LqMj36Wq8tQNrDqH9+NU652+o13fO9sKB1JtrkS+StQY1fbU7IpT2hH6FQl6L62@nongnu.org","X-Gm-Message-State":"AOJu0Yxnag+owCtjG7/beDkr8ONhzPlPsRfctS38YILThW9Ju6po+XZT\n SFGagPjNgfT9QvIQXWoamkso5Q6KlNgKUHZKyPbFyU8qUrVlI6hC0SRHyIIFYNK/++g=","X-Gm-Gg":"AeBDiev/qbvI7bIQMfVm0FNbYN/cgJRIeB1YfIkkE4gT+IJdW+uwjAdLaZQ81VzzrnH\n NNjzvKdofAUvem/uNRmNBLI9dUz2ptL8dBkJf1TMQQVGZ5aFSSs1w3QsXXkC0pbdC+fM+eH4NMX\n 2m9pYb1w9w6GR2NkZdAx7gyUq5417k1WKMMTrWajcp3uqEnsF/y7KpPUDbFt8LkgKSwpa9uBIwu\n LHnWhdQ+/tiFeDpjK4Q49dpXaB/iA6LH35QlfsdPpXGOecY4BqfK6ggdtzLZ6CRlIOPuaxHidG/\n M40cYhK+a/T0F6tqGH+VEFiMolvBlkpG9yImQFBYRXjp76Tf3MPh7srYi6YQqXHK0DtCnIZ/zTI\n sDe+Fqe7C/uMVnAvwDZqIqq3mTRGVTsNDF38f0V/c+rk4B2gSLA68maAA10ZESRX/wf6MDbstOy\n nXKPjAuLgwZJQJnJLDKjBZW+oDxY2lCxkYaLy4g2F8U5biiPZyLH77fsH3ZHjyWDT2G5IUK8JnD\n UTg9xmFitE=","X-Received":"by 2002:a05:600c:37c4:b0:48a:5501:7995 with SMTP id\n 5b1f17b1804b1-48a55017b71mr410419755e9.18.1777277431729;\n Mon, 27 Apr 2026 01:10:31 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","To":"Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 25/32] monitor: Forward-declare the MonitorDef type","Date":"Mon, 27 Apr 2026 10:07:31 +0200","Message-ID":"<20260427080738.77138-26-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rather than having core header forced to include \"monitor/hmp.h\"\nto get the MonitorDef type declaration, forward-declare it in\n\"qemu/typedefs.h\".\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n---\n include/monitor/hmp.h   | 6 +++---\n include/qemu/typedefs.h | 1 +\n 2 files changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h\nindex 8abe3168924..22784bd4c79 100644\n--- a/include/monitor/hmp.h\n+++ b/include/monitor/hmp.h\n@@ -24,11 +24,11 @@\n         g_assert_not_reached(); \\\n     }\n \n-typedef struct MonitorDef {\n+struct MonitorDef {\n     const char *name;\n     int offset;\n-    int64_t (*get_value)(Monitor *mon, const struct MonitorDef *md, int offset);\n-} MonitorDef;\n+    int64_t (*get_value)(Monitor *mon, const MonitorDef *md, int offset);\n+};\n \n const MonitorDef *target_monitor_defs(void);\n \ndiff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h\nindex 416a8c9acea..07f2ae7c9f1 100644\n--- a/include/qemu/typedefs.h\n+++ b/include/qemu/typedefs.h\n@@ -72,6 +72,7 @@ typedef struct MemoryRegionSection MemoryRegionSection;\n typedef struct MigrationIncomingState MigrationIncomingState;\n typedef struct MigrationState MigrationState;\n typedef struct Monitor Monitor;\n+typedef struct MonitorDef MonitorDef;\n typedef struct MSIMessage MSIMessage;\n typedef struct NetClientState NetClientState;\n typedef struct NetFilterState NetFilterState;\n","prefixes":["v4","25/32"]}