{"id":2228690,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228690/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-27-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-27-philmd@linaro.org>","date":"2026-04-27T08:07:32","name":"[v4,26/32] cpus: Introduce SysemuCPUOps::monitor_defs hook","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"07f39719becfcebaaf4b3bfab16d284507e1f7ec","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-27-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228690/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228690/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kuNWx5cm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x9K6Bwyz1xvV\n\tfor ; Mon, 27 Apr 2026 18:11:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH3F-0008OB-U7; Mon, 27 Apr 2026 04:10:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH3C-00087g-0T\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:42 -0400","from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH3A-0002jQ-6U\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:41 -0400","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-488ad135063so90591685e9.0\n for ; Mon, 27 Apr 2026 01:10:39 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc1cfbf2sm813858135e9.15.2026.04.27.01.10.37\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:10:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277439; x=1777882239; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=CX4HMtCLtaKxWP+CnhHEeurJGMT23nAqgS5xqErMf6U=;\n b=kuNWx5cmwiMbTjs01Aw1rnjiR9pST/+QTRKfG09bJg4k/WdpVVs2fO7ysHitrWQ+CZ\n dOZZkCTA6pP8t0E5+ILpuc2H3VuV7ByNcdKPELmYbBD6fCWLp9/1shswT5qv55xBSfxd\n Eng3yIO5PzX8TzXX4tsbVXKiOL8qK7qbspoPWW6dc/fI/WPq+yEeTcp6ifvEwEXLujp5\n NaV3y2/3fdryafGgIByJUaAWLAyU7PDNbiX8RY02bOMB3wEJ0SrbDwfwe7omNCeON6ID\n v3NQSZk6LfAue5ilus3utqVmFJkjfGCZotZ6+oG/pF6Ai7a86SPJyDZm29lwwrjIFEZd\n xz5w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277439; x=1777882239;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=CX4HMtCLtaKxWP+CnhHEeurJGMT23nAqgS5xqErMf6U=;\n b=HUMuO9/XxEFFi5VuACX1de8qTL8RdNDD4gTEEsoys0ZBOmr8YqHGxRuP9jS5wLxaT5\n G4NauphGGs3oDBk77NjY4zwNrC8tMaY/8pjMUfZpmFsh/ZJRqmQiUWZHHppvNmGSf/do\n KSBOWLD+Sa9+IXDToFAdiVPkdMFeC+BgqNnWrxU75qPoITtSvezThBhrUXjI0mPuBevq\n v6m+cCZCTFf+Pi0gSX3UoAVVDJpjJ0M8fdXgjlbBCnbl02X+o28eDOWGDYy1NTjXOpu4\n EFNxpWcVQYdKq33OSeSUGUsS4H3aNn/Q6isSS0nsfoJBNtNnr/l8l3gj4t9007ZRasfY\n SOAQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+0UGHOzrn8fB2PxYG0chQ6UnRnzgqfPBEmedMGvSp46H1NGqbTv89aKzpXUS4Ui4sJK1ch8QVVWU8x@nongnu.org","X-Gm-Message-State":"AOJu0YzbBGshRg1vzoN5L7CHNu72cH9BjJaH4/H+bHo2w0NEQruEFdut\n f2WSywF3/kNQ8TiYiGz80g42aPEGF8M6eQM6Xr+FfuF8C4ztIBDyksEQoYKQSyQOUqGdk1GRubB\n ha8CgtfI=","X-Gm-Gg":"AeBDieveWLDv1u8pv48AiAemh2+qqpBZyf21G+wzdzXSku7T2j9gH7pWF8wo1ggZwDn\n BpLf/8h0Y2jTW1//LUt1R77s+1r9KcDq0PzEUowaq7mMG7fNlPgYIs6oOGpLCP0vUpKgUOjowPZ\n 9w5eqJvZelNKQD0GtW3m8nUuJbp3NAtTLDpiHT30mKAqrJvzvtCh79tbmOOxKPAByOJMPU5SFvr\n MrYcw4DFM5sNLSfqeUWUeUZHV2WoH0RwcchEoX5LF1VASsQPu/V8EbwiQTVVbxrn0guEFMIcvpx\n hoXJBFlw/isI3g0MR6yVS82vuTxlbaN6THBHCn6/oAvH5W3H32oxLsdJOrGM0uNtfbONKGHYKD2\n FTJR5ERcrZVity8YaKIkXnYeFpuWQGgd2A+XWyLKyRGHL6PIWsRND66PuDYLRkwOlnZOOoI6JoF\n KT1MaUvRSwZ77UmXm31cGpKEAuRNF3NazP9+BSUr4lsgAKCXzZqVaMXMd1fIM6artRIpkEwUl38\n i0anB1hcxZ7y+R1lMxGhg==","X-Received":"by 2002:a05:600c:4e4f:b0:488:ab37:b442 with SMTP id\n 5b1f17b1804b1-488fb793c6bmr605724035e9.28.1777277438510;\n Mon, 27 Apr 2026 01:10:38 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 26/32] cpus: Introduce SysemuCPUOps::monitor_defs hook","Date":"Mon, 27 Apr 2026 10:07:32 +0200","Message-ID":"<20260427080738.77138-27-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Allow targets to register their legacy target_monitor_defs()\nin SysemuCPUOps; check it first in get_monitor_def() otherwise\nfall back to previous per-target helper.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n include/hw/core/sysemu-cpu-ops.h | 6 ++++++\n monitor/hmp.c | 8 ++++++--\n 2 files changed, 12 insertions(+), 2 deletions(-)","diff":"diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h\nindex 5b831393cf4..94e36ecdd18 100644\n--- a/include/hw/core/sysemu-cpu-ops.h\n+++ b/include/hw/core/sysemu-cpu-ops.h\n@@ -93,6 +93,12 @@ typedef struct SysemuCPUOps {\n */\n int (*monitor_get_register)(CPUState *cs, const char *name, int64_t *pval);\n \n+ /**\n+ * @monitor_defs: Array of MonitorDef entries. This field is legacy,\n+ * use @gdb_core_xml_file to dump registers instead.\n+ */\n+ const MonitorDef *monitor_defs;\n+\n /**\n * @legacy_vmsd: Legacy state for migration.\n * Do not use in new targets, use #DeviceClass::vmsd instead.\ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex d7b2f731def..70e5e5c2367 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -1608,11 +1608,15 @@ void monitor_register_hmp_info_hrt(const char *name,\n */\n static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n {\n- const MonitorDef *md = target_monitor_defs();\n CPUState *cs = mon_get_cpu(mon);\n+ const MonitorDef *md;\n void *ptr;\n \n- if (cs == NULL || md == NULL) {\n+ if (cs == NULL) {\n+ return -1;\n+ }\n+ md = cs->cc->sysemu_ops->monitor_defs ?: target_monitor_defs();\n+ if (md == NULL) {\n return -1;\n }\n \n","prefixes":["v4","26/32"]}