{"id":2228689,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228689/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-31-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-31-philmd@linaro.org>","date":"2026-04-27T08:07:36","name":"[v4,30/32] monitor: Remove target_monitor_defs()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ec04cdbd2b5ee543a9ba762e35b66d17579d3658","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-31-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228689/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228689/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ysV6eUVL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x9G1tTLz1xvV\n\tfor ; Mon, 27 Apr 2026 18:11:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH3g-0001Q3-H9; Mon, 27 Apr 2026 04:11:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH3d-00011g-Rw\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:11:10 -0400","from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH3b-0002qd-Hn\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:11:08 -0400","by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-43d43e09de5so5444920f8f.1\n for ; Mon, 27 Apr 2026 01:11:06 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-44123d23e0bsm38922744f8f.15.2026.04.27.01.11.04\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:11:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277466; x=1777882266; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=5jsZtofjbXJHOZasZf01XJnCpN2qoJicQAKP7JiukTk=;\n b=ysV6eUVLlBSRJ7N3sg1r3YEsa49oaJCQqymSJHs6DwYLc0V54qPfiNBiDMvXlsSkz5\n CVziqpOtGQU3p7XMG9nyymv6sUu1ZfQSEoAwctE/RdtXXPYiyCSScQDsgFRdYcMkdNzs\n OI0MQSW1UrGEY0DwyBEVIwkAONdFl55nSSj/Uyipeou12MPbkdyb8eKjT2e1TSZjhmKy\n wy1DfWFGKKojqBvcoz8TXOB4OQXuqb6h9uWdiJ9MGcb0ls2Cm8+MI/FnyJy7G/ZEUcLu\n He4EupYNKeAEtxCwAXgzaVb7h9CCTqsER4AfmrIlZ7Hc0zVZRgg+8yCVJC9/CUAJBUCx\n nZ5w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277466; x=1777882266;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=5jsZtofjbXJHOZasZf01XJnCpN2qoJicQAKP7JiukTk=;\n b=bCOqZ2iwLp3cTYcUMZNHWTYCGKkNO1mAaUWijZzhaZScgRNM9JjPyaxrmvzomipRDE\n 4/U00Qyx6Xj4cdiblz9EFZ1uY5F43CJJlUyPcky1Ulrw6atw+z4PI+BxFCB4XBZy+TVf\n Ms5OQM6YY4c46i5HFu7679BlExBrTHNMp8j873UGlI2FrB1hOh1CXNMOyZIqyP5FJisT\n EFzBvJyPFWxRyWrANaZJC+Ud1TVIJalb9nI2LWaw/flgIjWS56y07L6bhw1X4ZIcQeNm\n 5wAEFlzeNU0Ao/uNPqJMaYDHO4ieSR2TErNqadZfOrv8KVcPFnhevJqMiwskoz+erM9f\n To1A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9YF8iH0mZabf4fAZrnOUa476Pt5XgTYAALilnI31VTnfxGX/9mF+U8If3Vu1IPi/si/V2q29UdLUGo@nongnu.org","X-Gm-Message-State":"AOJu0YzTYp6QEuokwqhckK/j2majDFo5ZFvDER4T82e76TS8YEmu7YIj\n zGj3YbVNrzVrqqnfxMzpEfnSb4RVxkdFlIt8Hy/9SUFPnhRpi2wDfWBFuuF9gjh1tnn6ZQq2UZg\n 7M4OQiLA=","X-Gm-Gg":"AeBDieu/Nxv96KEhSiuR30AMRNEPTy9qvFUhQGgRurguJzd4vh2NM4Bq/+OJknIGvo8\n FDNaazu1kmsKvl878c+4WfRCACxO4CQvptEIDBMw+1ysa99KOmud+PbA91GmoT4d5IU7g4mWi2O\n BZtxYQgcyuN9wTvsDv0tKpbGZ4VZ8VcKTNt+TJ476uTgoLZyZgcuCuTmI0nOS+JsO5vwIX9uh5N\n YjtCHXx5jDK9x2O17qQWr9CP1GrxZ/HGjbIsOEPIQjxmaQy94pAa5mHsNB2O/BvyrgJv4w7cG3+\n PN+26y3Bk1C+nTN8/CHe8hTyXGoblHfmYGhDOJleFpyQNniSlONd4rGPLaAfgOAOlm8XPVq5mWc\n EWVJ7Cr48cMtem33zCGYB/eIsOLqIF94cUz6IOEj96J4uQq1aqz9/IHwZcKLr3TYb76YjkPphjm\n yIMVi1cnqVhwg+ourdX9K/GckCJdo2ZQlC4HtDPgmRtPECQInuJWioK1jxS8KWrg5oDJleSTdbA\n u0o+/s4NnNsWbadLZJKlQ==","X-Received":"by 2002:a5d:64e4:0:b0:43e:a69b:d810 with SMTP id\n ffacd0b85a97d-43fe3e0fe56mr64744060f8f.38.1777277465488;\n Mon, 27 Apr 2026 01:11:05 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 30/32] monitor: Remove target_monitor_defs()","Date":"Mon, 27 Apr 2026 10:07:36 +0200","Message-ID":"<20260427080738.77138-31-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42d;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"target_monitor_defs() is now only a dead stub. Remove as pointless.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n include/monitor/hmp.h | 2 --\n monitor/hmp.c | 2 +-\n stubs/target-monitor-defs.c | 7 -------\n stubs/meson.build | 1 -\n 4 files changed, 1 insertion(+), 11 deletions(-)\n delete mode 100644 stubs/target-monitor-defs.c","diff":"diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h\nindex 22784bd4c79..c8ce8579424 100644\n--- a/include/monitor/hmp.h\n+++ b/include/monitor/hmp.h\n@@ -30,8 +30,6 @@ struct MonitorDef {\n int64_t (*get_value)(Monitor *mon, const MonitorDef *md, int offset);\n };\n \n-const MonitorDef *target_monitor_defs(void);\n-\n CPUArchState *mon_get_cpu_env(Monitor *mon);\n CPUState *mon_get_cpu(Monitor *mon);\n \ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex 70e5e5c2367..6d0f5b251b9 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -1615,7 +1615,7 @@ static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n if (cs == NULL) {\n return -1;\n }\n- md = cs->cc->sysemu_ops->monitor_defs ?: target_monitor_defs();\n+ md = cs->cc->sysemu_ops->monitor_defs;\n if (md == NULL) {\n return -1;\n }\ndiff --git a/stubs/target-monitor-defs.c b/stubs/target-monitor-defs.c\ndeleted file mode 100644\nindex 0dd4cdb34f6..00000000000\n--- a/stubs/target-monitor-defs.c\n+++ /dev/null\n@@ -1,7 +0,0 @@\n-#include \"qemu/osdep.h\"\n-#include \"monitor/hmp.h\"\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return NULL;\n-}\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 3489b1f20dd..3b2f2680b19 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -75,7 +75,6 @@ if have_system\n stub_ss.add(files('igvm.c'))\n endif\n stub_ss.add(files('kvm.c'))\n- stub_ss.add(files('target-monitor-defs.c'))\n stub_ss.add(files('win32-kbd-hook.c'))\n stub_ss.add(files('xen-hw-stub.c'))\n stub_ss.add(files('qmp-arm-gic.c'))\n","prefixes":["v4","30/32"]}