{"id":2228688,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228688/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-24-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-24-philmd@linaro.org>","date":"2026-04-27T08:07:29","name":"[v4,23/32] monitor: Reduce target-specific methods further","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e33300e8eb93fcc29ef4537bc498bdcf764bb35f","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-24-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228688/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228688/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Uc8C1Dgq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x9850grz1xvV\n\tfor ; Mon, 27 Apr 2026 18:11:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH37-0007pa-T8; Mon, 27 Apr 2026 04:10:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH2s-0007iw-1I\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:22 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH2q-0002We-2S\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:21 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-48909558b3aso98954845e9.0\n for ; Mon, 27 Apr 2026 01:10:19 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a52d232afsm162750135e9.31.2026.04.27.01.10.17\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:10:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277418; x=1777882218; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=FEYVG77IATzxHN9K3rUtTEhkQ/61nsqF8+QMsN3xQbQ=;\n b=Uc8C1DgqWPsZqioqAaBQGH90WS98LNdP1O701eDwPWd+W57jckuo+7ud5fVZlD/QEZ\n jUof8KLE+W5rIpDrMVhd8x6hkfuZrfdmGNWVCtBZCjdw/D2X/LF3SjkCA+VVFPcpF1GP\n TzBKKhslIu2YNb7RUEHUYAkcPUiETG9ejWrtPHCnKPQQpTeYgo5ue+BNylo1y/vuvYFK\n 5zvS1uUuHeCePfsx3N6Vh5/Hy9Vm9dv0LeoQaU3Ql1Q/I8cm84xL79nVc64R/pjGdcLo\n Av64zlC0sLXiPXcv1hmlvMxBFOdXc3H+rSmBs4RCHVZ2H0NvJu1v+oaab3fib8DF1RNU\n PjdQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277418; x=1777882218;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=FEYVG77IATzxHN9K3rUtTEhkQ/61nsqF8+QMsN3xQbQ=;\n b=e7RYnqsAj0r8rmEXmFZ9YlBZeuFiJwmuuGnma+PLPW4vDFx854cbYGPZZTMfRozlRM\n tl6infX4SPrBVHZgWcArt0rTuPIM64DnKLeS+c3aF89VBjATkc/MPP8YKEP0TYDF5NU7\n irIlsAb6DOuFtglpuIzHOg50BFMp64f3z6rOBey4Gl0ei0mWm8jFr1XtpgNZMJE8TF8M\n Zj6pQkC/i0Mg7jGKPXKZIqIaAkjtIvcs2lNfYBXfJwjG04/SK6zFu6JPxo1KvMAFHzr5\n yRKZ8BKuL8pEtaS1V4L8rGIFd+paj1G5QLldrHEVUcRtmKKMi4Ji5SDmulIiiRMihZzN\n 4OWA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ85G3TD48KUxO7Ojeca9s07GJytXFyU6ms3qdVYg5qT+zPZi8GA0NXJ3LDFvXB89OY/zvxbVl2Y8LZC@nongnu.org","X-Gm-Message-State":"AOJu0YzO08hvHnfYP1fEnuAOBm/U8TBlvuymg8aDEEDsAVlMxRzTdI/Q\n 7LTPLmsxrTNSrkF8rO2TZxr91oRMdcU+vWfbNk6ELhng3dEE/2xFZwrdghDcqXYFpD85ReOScjA\n YOwaRd3o=","X-Gm-Gg":"AeBDieuSpOQr097Mv341ZSk/dHJogW6JTgWOwvwqquBFb87pKCo6/1WiRtlX54CfkNw\n oxdcRlt4mYbleB0TpBILRnBmWNpDZjBus1S3KQF1H4tHMbjZx1sBf3FIyD+JEr53YQr7k/75Niq\n GCNZ4B9wrkRIjpPXLlhMProeSEZ4Ou8uEM27DXXALx+ZRwGS8zaCxtrprBEn32FfEcdcPq1Myv2\n FkR2OCih0vnQlP3OURIS/Cgqquuu9A1F2K4hYIAY/QV1TKi9kUHVA4JNvX/95VQ63ksCpWwyyPz\n /q7pjIXU77hQb+xY0CPc0FxyrHV1WMfDWPKOVNLubw3t4kcpQXyKsJlkFyVn1H0PAljKiNEoLva\n WKiNmEfuQZZ3AgCcEjp3VPY/RHvbk13BPyTTHYOxTu+ITuVQy5QzaXjM/hijEF3NfjMmPC0P8PL\n RiVkTK+jzrWRkAOXX+tkXq0dJrAYCqrVRA853Ur7bFdgonA/vVAyxnFXJzpK5sZOdmYnimXcJvx\n ZU2rC9eZSs=","X-Received":"by 2002:a05:600c:c09c:b0:48a:5363:8cac with SMTP id\n 5b1f17b1804b1-48a53638e07mr285628435e9.22.1777277418079;\n Mon, 27 Apr 2026 01:10:18 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 23/32] monitor: Reduce target-specific methods further","Date":"Mon, 27 Apr 2026 10:07:29 +0200","Message-ID":"<20260427080738.77138-24-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"get_monitor_def() doesn't use any target-specific declaration\nanymore, move it to hmp.c to compile it once.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Dr. David Alan Gilbert \nReviewed-by: Richard Henderson \nReviewed-by: Pierrick Bouvier \n---\n monitor/monitor-internal.h | 1 -\n monitor/hmp-target.c | 33 ---------------------------------\n monitor/hmp.c | 36 ++++++++++++++++++++++++++++++++++++\n 3 files changed, 36 insertions(+), 34 deletions(-)","diff":"diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex eaf9a607783..a5c4aba306e 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -191,7 +191,6 @@ void monitor_data_destroy_qmp(MonitorQMP *mon);\n void coroutine_fn monitor_qmp_dispatcher_co(void *data);\n void qmp_dispatcher_co_wake(void);\n \n-int get_monitor_def(Monitor *mon, int64_t *pval, const char *name);\n void handle_hmp_command(MonitorHMP *mon, const char *cmdline);\n int hmp_compare_cmd(const char *name, const char *list);\n \ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex c2ddcd67e51..550a7178052 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -57,39 +57,6 @@ HMPCommand *hmp_cmds_for_target(bool info_command)\n return info_command ? hmp_info_cmds : hmp_cmds;\n }\n \n-/*\n- * Set @pval to the value in the register identified by @name.\n- * return 0 if OK, -1 if not found\n- */\n-int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n-{\n- const MonitorDef *md = target_monitor_defs();\n- CPUState *cs = mon_get_cpu(mon);\n- void *ptr;\n-\n- if (cs == NULL || md == NULL) {\n- return -1;\n- }\n-\n- for(; md->name != NULL; md++) {\n- if (hmp_compare_cmd(name, md->name)) {\n- if (md->get_value) {\n- *pval = md->get_value(mon, md, md->offset);\n- } else {\n- CPUArchState *env = mon_get_cpu_env(mon);\n- ptr = (uint8_t *)env + md->offset;\n- *pval = *(int32_t *)ptr;\n- }\n- return 0;\n- }\n- }\n-\n- if (!cs->cc->sysemu_ops->monitor_get_register) {\n- return -1;\n- }\n- return cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n-}\n-\n static int\n compare_mon_cmd(const void *a, const void *b)\n {\ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex e881c26c305..618ded40207 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -25,6 +25,7 @@\n #include \"qemu/osdep.h\"\n #include \n #include \"hw/core/qdev.h\"\n+#include \"hw/core/sysemu-cpu-ops.h\"\n #include \"monitor-internal.h\"\n #include \"monitor/hmp.h\"\n #include \"monitor/hmp-target.h\"\n@@ -359,6 +360,8 @@ static bool gdb_get_register(Monitor *mon, int64_t *pval, const char *name)\n static const char *pch;\n static sigjmp_buf expr_env;\n \n+static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name);\n+\n static G_NORETURN G_GNUC_PRINTF(2, 3)\n void expr_error(Monitor *mon, const char *fmt, ...)\n {\n@@ -1599,3 +1602,36 @@ void monitor_register_hmp_info_hrt(const char *name,\n }\n g_assert_not_reached();\n }\n+\n+/*\n+ * Set @pval to the value in the register identified by @name.\n+ * return 0 if OK, -1 if not found\n+ */\n+static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n+{\n+ const MonitorDef *md = target_monitor_defs();\n+ CPUState *cs = mon_get_cpu(mon);\n+ void *ptr;\n+\n+ if (cs == NULL || md == NULL) {\n+ return -1;\n+ }\n+\n+ for(; md->name != NULL; md++) {\n+ if (hmp_compare_cmd(name, md->name)) {\n+ if (md->get_value) {\n+ *pval = md->get_value(mon, md, md->offset);\n+ } else {\n+ CPUArchState *env = mon_get_cpu_env(mon);\n+ ptr = (uint8_t *)env + md->offset;\n+ *pval = *(int32_t *)ptr;\n+ }\n+ return 0;\n+ }\n+ }\n+\n+ if (!cs->cc->sysemu_ops->monitor_get_register) {\n+ return -1;\n+ }\n+ return cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n+}\n","prefixes":["v4","23/32"]}