{"id":2228685,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228685/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-22-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-22-philmd@linaro.org>","date":"2026-04-27T08:07:27","name":"[v4,21/32] monitor: Remove target_get_monitor_def()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5927f704e773c476a09603f19ac4036e41779ccc","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-22-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228685/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228685/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=yHNrIgS3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x8R1Tmbz1xvV\n\tfor ; Mon, 27 Apr 2026 18:10:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH2h-0006cE-Uq; Mon, 27 Apr 2026 04:10:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH2e-0006AB-I1\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:08 -0400","from mail-wr1-x436.google.com ([2a00:1450:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH2c-0002QM-Ct\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:08 -0400","by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-43fde5b81a1so7438089f8f.0\n for ; Mon, 27 Apr 2026 01:10:05 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4d112sm82866871f8f.29.2026.04.27.01.10.03\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:10:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277405; x=1777882205; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=5MbZLdHokWB3HHK4f6Bx4RdN98ey138uSNMtx96pK2A=;\n b=yHNrIgS3hOTrhHGBzpiWc17qMJk8gegizMA6bRFxeRnPeH02sHEV1dlyDSCudrJKJW\n BFRb0ESNdOamq9Gfd2T9mt8ydpcyeiFM7hUKTPWvkN5PJt7ecmuKuA2d7jTIyjFYVJmB\n koALeVha0ZuuzFxPNeNaUGF60MLIDkz7fmbH2Mwj06B5RD5xCqiB5d7eqQkzmNbe+lWY\n HMAFzDAdh/PXUUQMFt9jLb01MCDPH2svTaUOEb4tAO2jNvUe/7cPDCYY8CHoptZUB1iv\n GHYcC+YeMFGba+BeaPo9HHJjwFyAJwpZoN5+zmrROx6VZBfCReqOoftYY3Nofh74EMpj\n nKIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277405; x=1777882205;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=5MbZLdHokWB3HHK4f6Bx4RdN98ey138uSNMtx96pK2A=;\n b=QrigV0Y5zC8AQpBP2CIbmH/5uwNsueX05MTbfo2wjYZVuU1/MF+Gkhk/sdQVUZOtvU\n 0zcII0u2jdTYwGKXq96KCB5A6ouaOePFCHvNGh1wBNhrqn07KzkWXecl1jHj8aZo+AHA\n 01wq+kY44dNd837JrZXnNj0vSFJXAr3sUjnCLtHMNd4fdmEdOxUOlGly1/WsVyaFBRWN\n NaMWJ4meqPT3+ucrnaeauRPHL09VNdaD+5un45OYEJLhXo2VywcX+tKxdJrGnYNO3y6j\n plEri+zmmZvDuE/0AA4VpLQbCudOFtlI0KUmFTevOK61iuobL+RBJ63uzLCokb3fjLsK\n OKgQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8+5CaQVP6gEfDoMdCp3S4R0rJ41UGNyoGGiDeyneuUt1oF7a9pE9jOM79sDinsW2p1m8nbsN3zrreO@nongnu.org","X-Gm-Message-State":"AOJu0Yxgx8AiHwpZa7PiJr4qm4UMTMNF9Nv87tOWb+xCTTgzxHNB7XJR\n IK2eGPz1ag43vCaUwUiOEs4kJJFTRDNDElxFYUssfznnUG0r9ybA3b+d/yd2/yMbzOuFU165xlw\n zlp37W+g=","X-Gm-Gg":"AeBDiesoKSlU4v15ySRq6i0L6gEG6C1q6hAzfVOOz7INSfP8C/d9tcGw+XY+1b9K+YX\n Ib2+XylS4quW4uWHZtCYS9zSZowmWpJOymIrIgKeiFLO+oI+huPAjomocJ9G/YkXDIGFstQHPGS\n hV4jpmqayykfSBKkJIINBBZXeMa/8AB7QCr2SJlceWLRVig/Hn37CnuEIBuVQUUvK/IqKWKS/BS\n 2kssKlfXEai4CuzLM1ZNbj0W3HWZhLrp4AzajDGH4KTUDo/lGLNOBxtnme14hmSEYPOm+VhUK5U\n qyC40UYIJntga/hH/RuZI+18JEb65iZ3ODxpmCuRJscn9vXLw0K8VLc17yKxzMBBX0Tom15zsXb\n fQkqwGNZeQZWw7Cm/6O/liSSAiouUwRYmKD4Edg4VC99dOqYoxrAV4CXx8G2hSvsDHNmb1EDlns\n XE676Rq+P2zjyIQ4itHqAnkIgzYAtS0WfWTZ/Fa4K39jQCBq2fdt3udB4bLEqisf7Rk0BCHCT0Y\n eOPNA2JwPQ=","X-Received":"by 2002:a05:6000:200c:b0:439:bd70:610f with SMTP id\n ffacd0b85a97d-43fe3e13c17mr64355324f8f.44.1777277404597;\n Mon, 27 Apr 2026 01:10:04 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 21/32] monitor: Remove target_get_monitor_def()","Date":"Mon, 27 Apr 2026 10:07:27 +0200","Message-ID":"<20260427080738.77138-22-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::436;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"target_get_monitor_def() is now only a dead stub. Remove as pointless.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n include/monitor/hmp-target.h | 1 -\n monitor/hmp-target.c | 14 +++-----------\n stubs/target-get-monitor-def.c | 29 -----------------------------\n stubs/meson.build | 1 -\n 4 files changed, 3 insertions(+), 42 deletions(-)\n delete mode 100644 stubs/target-get-monitor-def.c","diff":"diff --git a/include/monitor/hmp-target.h b/include/monitor/hmp-target.h\nindex ce0bb1983cc..008c1a6570c 100644\n--- a/include/monitor/hmp-target.h\n+++ b/include/monitor/hmp-target.h\n@@ -38,7 +38,6 @@ struct MonitorDef {\n #endif\n \n const MonitorDef *target_monitor_defs(void);\n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\n \n CPUArchState *mon_get_cpu_env(Monitor *mon);\n CPUState *mon_get_cpu(Monitor *mon);\ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex 46ccbd14aec..c2ddcd67e51 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -66,8 +66,6 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n const MonitorDef *md = target_monitor_defs();\n CPUState *cs = mon_get_cpu(mon);\n void *ptr;\n- uint64_t tmp = 0;\n- int ret;\n \n if (cs == NULL || md == NULL) {\n return -1;\n@@ -86,16 +84,10 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n }\n }\n \n- if (cs->cc->sysemu_ops->monitor_get_register) {\n- ret = cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n- } else {\n- ret = target_get_monitor_def(cs, name, &tmp);\n- if (!ret) {\n- *pval = (target_long) tmp;\n- }\n+ if (!cs->cc->sysemu_ops->monitor_get_register) {\n+ return -1;\n }\n-\n- return ret;\n+ return cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n }\n \n static int\ndiff --git a/stubs/target-get-monitor-def.c b/stubs/target-get-monitor-def.c\ndeleted file mode 100644\nindex 394e0f9a7d2..00000000000\n--- a/stubs/target-get-monitor-def.c\n+++ /dev/null\n@@ -1,29 +0,0 @@\n-/*\n- * Stub for target_get_monitor_def.\n- *\n- * Copyright IBM Corp., 2015\n- *\n- * Author: Alexey Kardashevskiy \n- *\n- * This program is free software; you can redistribute it and/or modify\n- * it under the terms of the GNU General Public License as published by\n- * the Free Software Foundation; either version 2 of the License,\n- * or (at your option) any later version.\n- *\n- * This program is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n- * GNU General Public License for more details.\n- *\n- * You should have received a copy of the GNU General Public License\n- * along with this program; if not, see .\n- */\n-\n-#include \"qemu/osdep.h\"\n-\n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\n-\n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval)\n-{\n- return -1;\n-}\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 2f4e1ab4300..3489b1f20dd 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -75,7 +75,6 @@ if have_system\n stub_ss.add(files('igvm.c'))\n endif\n stub_ss.add(files('kvm.c'))\n- stub_ss.add(files('target-get-monitor-def.c'))\n stub_ss.add(files('target-monitor-defs.c'))\n stub_ss.add(files('win32-kbd-hook.c'))\n stub_ss.add(files('xen-hw-stub.c'))\n","prefixes":["v4","21/32"]}