{"id":2228683,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228683/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-18-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-18-philmd@linaro.org>","date":"2026-04-27T08:07:23","name":"[v4,17/32] monitor: Do not check TARGET_I386/RISCV to build 'info mem' command","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3dedd15334ad116b3d7979d45285f88189bec90a","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-18-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228683/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228683/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=i5f9AJbN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x8M4t2Qz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 18:10:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHH2K-0002t1-0f; Mon, 27 Apr 2026 04:09:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH2D-0002SH-C8\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:43 -0400","from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH2B-00025R-Mz\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:41 -0400","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso103276075e9.1\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 01:09:39 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a5aa3ae83sm778866945e9.12.2026.04.27.01.09.37\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:09:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277378; x=1777882178; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=JshNpgqW4cCYul7Q+y/QdsSlweDRsNaeeQFwo1ONxPo=;\n b=i5f9AJbNGReyeQIM2GEWxADBdMZ2QavQlXBQP1nsOL9y4n45YbaV7wV489zlN3TXGc\n 3mjnyJ4iVhvMKP3tZsXBi3qyqtWXZNX69RnGElBSEVcpwmV4m/EX7PUiieQ/tPz8u5mm\n olxTdnoTN17XiOmDB3XZQVkyy7y5GB+C9hu+de5EknSWRHI4GNppLDsxBQXsPanRupfG\n gKR1dtKgny4rG9iYaNudyiKnF9G6oI406su4yB4tljfvazo3F6vnn/1xtn4z/MSiHFAg\n ehqOMiesxw6YblKbd8/hOzgnakn3GZjbXA56hg2r+RPw3ZMSSEfpJZYyMgrWhBDefNvR\n s9sA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277378; x=1777882178;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=JshNpgqW4cCYul7Q+y/QdsSlweDRsNaeeQFwo1ONxPo=;\n b=GGYccJRpNUj5W/aHyBcQLQ575m8OGpRQbmtS73cHKs9za6DBfXDaFON/p6RJFJlxAW\n VV9Zjy8xoFUPnZ4bxSlktb3cyVz9a7q9/B5WXcjKgmlblCgxAGdG0yF0nCHlwKG6wfDh\n tN53No1I2inPLDXj4V4aR+B95J0R89d3LvliXTvH6ud415InMHUyFxZd/Zzjlm+cIaHG\n A6x1UCf6HJi1pa5JVeDs6RXY237Yo7q2h28fYoOJhdmOtXuR0OjXn+Z9vlQI4AedUY7C\n Sye23tabjE7RF7wXQj6x+Yd3Wk3f4LB3UKLbZN37dSaUwe+wYyX7aJxgeZDqTkBl0JU5\n FyMg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/q3gj4dnjSrAPtXNzQ623QmXhVZjCKCv+9Bk9GwcnMs3Q6Y9p+z0bsasuurkazyMdKmy9WPg+wdqUc@nongnu.org","X-Gm-Message-State":"AOJu0YzMy5aAQlUr9zvqhw2e7V64Rq3CGEmQTA1BpJKyh2U0oi6stBFI\n Sun658azwtnOCaPoELnnuXYzVXdZfeMVaESM2RZnUmSbEQySQ53oMTTxn6qus5hUZA53bF+/XB+\n 0ec6DNYA=","X-Gm-Gg":"AeBDiethfjIddgFL2UpEpjLc9siBThFndLl8oatiAWsFp6lE55xU8MfKVX+GfLBaUv5\n Z7OfvCft68LGb7/eZylvLGDBzkeTuzMYPwEJDXLAhRWEEBl5eaA7BGoSp2zwsfDNVD9qaTPhZI2\n NPH/7kRLyBLHO1RtUgtbEa/DYCbTlJiSnjj+oCST/si2NDaOryUdkdKI+BCvBR5/JkIPMze54lp\n pKLJXJoImNgoHFanEyeiFTGzoiQaxG0DQdvXcl55jqpnjATjEfvOON2hKkCnRlg2oahfc9EiVP+\n 9c/K+zK7p06BgX+rpuEWuDzdm9oAhqja4V98TKBlh0SaevduO69WJeOetjryGmQQ0QDYaBt1bSu\n utSWIX6iriObfzGjAD/qHshfsxR2a+TYFfuHzp/PQm1fqP1C5rmj9qD1kpVw047BLldYTeejA9d\n JpbEOj59qGCRgN/39aHGdap1NnxFCoVQqJSM9jmA7NkX2hD+itS5zRoH7jSVg3YtHWM4FeovdY4\n PLQB+zypZWBq6PGqhsODA==","X-Received":"by 2002:a05:600c:3f10:b0:485:35d3:ce59 with SMTP id\n 5b1f17b1804b1-488fb753c9amr565831465e9.10.1777277377790;\n Mon, 27 Apr 2026 01:09:37 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","To":"Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 17/32] monitor: Do not check TARGET_I386/RISCV to build\n 'info mem' command","Date":"Mon, 27 Apr 2026 10:07:23 +0200","Message-ID":"<20260427080738.77138-18-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This command is filtered at build-time for i386/x86_64 and\nriscv32/riscv64 binaries. By using the recently introduced\nHMPCommand::arch_bitmask flag we can filter it at runtime,\nmaking it possible to compile hmp-commands-info.hx once.\n\nSince the method depends on a pair of distinct targets,\ndefine it in its own stub file.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n---\n stubs/hmp-cmd-info_mem.c | 12 ++++++++++++\n hmp-commands-info.hx     |  3 +--\n stubs/meson.build        |  1 +\n 3 files changed, 14 insertions(+), 2 deletions(-)\n create mode 100644 stubs/hmp-cmd-info_mem.c","diff":"diff --git a/stubs/hmp-cmd-info_mem.c b/stubs/hmp-cmd-info_mem.c\nnew file mode 100644\nindex 00000000000..8a53e367a9f\n--- /dev/null\n+++ b/stubs/hmp-cmd-info_mem.c\n@@ -0,0 +1,12 @@\n+/*\n+ * Human Monitor 'info mem' stub\n+ *\n+ * Copyright (c) Linaro\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"monitor/hmp.h\"\n+\n+HMP_STUB(info_mem)\ndiff --git a/hmp-commands-info.hx b/hmp-commands-info.hx\nindex 336ab870a2c..2d0a8f7d48f 100644\n--- a/hmp-commands-info.hx\n+++ b/hmp-commands-info.hx\n@@ -209,15 +209,14 @@ SRST\n     Show virtual to physical memory mappings.\n ERST\n \n-#if defined(TARGET_I386) || defined(TARGET_RISCV)\n     {\n         .name       = \"mem\",\n         .args_type  = \"\",\n         .params     = \"\",\n         .help       = \"show the active virtual memory mappings\",\n         .cmd        = hmp_info_mem,\n+        .arch_bitmask = QEMU_ARCH_I386 | QEMU_ARCH_RISCV,\n     },\n-#endif\n \n SRST\n   ``info mem``\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex f086521cde4..33053d932c8 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -87,6 +87,7 @@ if have_system\n   stub_ss.add(files('qmp-cpu.c'))\n   stub_ss.add(files('qmp-cpu-s390x.c'))\n   stub_ss.add(files('qmp-cpu-s390x-kvm.c'))\n+  stub_ss.add(files('hmp-cmd-info_mem.c'))\n   stub_ss.add(files('hmp-cmd-info_sev.c'))\n   stub_ss.add(files('hmp-cmds-hw-s390x.c'))\n   stub_ss.add(files('hmp-cmds-target-i386.c'))\n","prefixes":["v4","17/32"]}