{"id":2228681,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228681/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-5-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-5-philmd@linaro.org>","date":"2026-04-27T08:07:10","name":"[v4,04/32] monitor: Extract completion declarations to 'monitor/hmp-completion.h'","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"489281084cacbda8c58794e10c260f16ce542510","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-5-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228681/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228681/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=xPbbklx0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x8J65s9z1xvV\n\tfor ; Mon, 27 Apr 2026 18:10:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH0v-0000d6-2b; Mon, 27 Apr 2026 04:08:21 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH0s-0000cD-R8\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:08:18 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH0m-0001Tw-I7\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:08:18 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-43cfde3c3f3so10075425f8f.3\n for ; Mon, 27 Apr 2026 01:08:12 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a7b4sm73442112f8f.22.2026.04.27.01.08.08\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:08:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277289; x=1777882089; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=TmErLYkkyC0UQ3cHtYrsC9C+y1iumERnceYY02O3hcE=;\n b=xPbbklx0SYfMg1/FSHscTSWVkaylF6ZZkBzOpcdVeVR19UHHUMTGX2gBXPTapk4M39\n 24RiufFM7ZzajxWxALAf+nTSQCVn+4xBvZZyIu0jdiU95bgIq8h4AQj55JVdTs50e1ZE\n wiHiABicMijUBxPzqzPPepc8af/soovipmRyJH539loFJSS/fg7z48I6Y56tlqfP/NnA\n 19XwPHTUCOU3HV/1c7GBZ/qUOVGjGvpdDIvOyf6Cy2A5fq0KH5ALZu9CHD5tyol355PV\n Jt0G3hyXHD1JaiwK8WeVK6ykT2XJOdjj+HwJ+/ohaUOjNe6oDDRD38p6Bji5UIpFLtpv\n 88zA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277289; x=1777882089;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=TmErLYkkyC0UQ3cHtYrsC9C+y1iumERnceYY02O3hcE=;\n b=HDgx9L9YV7WMo6s+RJ/1YIdCqiKk5laIGq6rd6b0EFUjePogguCCQv7I6sOZJbgzQW\n bYsSs9cC6YfcspzCwMmkI0Fx5aqNXbtXZ5uMCxWZXIVGnn1nhjFwXDJ4dQq8zjeuBV8I\n 88zdQlEAVgNY42KMT2UU8U9OcNYpqWw3io50b19Lsh5TjrXmOwehKQA5oUQxzfpcp3ro\n dOlZ18+mKK0+xs7MzSJbxbi06QLumxViBgfj+u9gOKkZpM037oesf4Z7w7Yh1K3Z2CFa\n wRo+434SaJRb8jqMbPiYF9i9ZGHI3MICxjLC5HFMW05LZb7ktiRYk2VHXR3ocUw9vaiB\n ITQQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ86JhtWS++1go10AsHYa7uvK1YQGyP3L+tZTfBOiJbn0JGfGo0IRiKd3d0+zu8Lgu1P5YjY0owWfpu1@nongnu.org","X-Gm-Message-State":"AOJu0YwzHf+KYoJDOBbYwrP4rxLVQIWlFywVsV2KCuDD1CKT+q9KLgHJ\n WX6NnpGPRiathWmTafXurpsiQAlxInNTJzMBKDr7/qLyhzAgPAeCcP80BMhVqM7zl5wxi0uDbOW\n 6ipv2rvA=","X-Gm-Gg":"AeBDiesezDmd0RKb19NjVSjtFYMJ1JvTqelYNWrM+kOIXYqsYfAGnBgBPxOUXPh+xqp\n BGs5N7t+aqUGiXDqgCpaVAsYBltIF3STfX1VS7v8e23N7fNfSt6uk4SH/0f4+a8wfEB3u5W31KJ\n t2DDYm0AsgtJxXjnaoYjrV8ekZxT/Lk6gZa28TpSbwtoCIFN6d8DefXVB78uKYJzeiTJHmIp9dQ\n bDSqWE1E9GQVPxZJ/MJzFJF+O77/J6KP3fcKIo4o42W4xPZtfGufnPQ16Db0M0x/KlvdlYviwf4\n cYnTQyG4gwoG2f6sv0wvqX2wUklekf3Mbw05TCT+3W3M8PfKBPj6R+TAGXjpHC0BdreelOskWXJ\n 2ZDxouTU6HNXt/+u5oysu2jKo7WZa5emxxGKG1WIMxpB5q4YHVMZPEqDElbHjmm9v43zssToa6G\n zqtAN9lQqnlFQlTQrKjhfKLDtxhmHyEjw11AxKHE5OA65aT2g1jRsfLXDROunBHn9QW0irHqApb\n DTbKnCH5l7dM3iQWpB7Yg==","X-Received":"by 2002:a05:6000:200c:b0:43d:77f4:7145 with SMTP id\n ffacd0b85a97d-43fe3dd407dmr66647608f8f.19.1777277289285;\n Mon, 27 Apr 2026 01:08:09 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 04/32] monitor: Extract completion declarations to\n 'monitor/hmp-completion.h'","Date":"Mon, 27 Apr 2026 10:07:10 +0200","Message-ID":"<20260427080738.77138-5-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Many files include \"monitor/hmp.h\", but few of them really need\nthe completion declarations: move them to a distinct header.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Pierrick Bouvier \n---\n MAINTAINERS | 2 ++\n include/monitor/hmp-completion.h | 40 ++++++++++++++++++++++++++++++++\n include/monitor/hmp.h | 21 -----------------\n chardev/char-hmp-cmds.c | 1 +\n migration/migration-hmp-cmds.c | 1 +\n monitor/hmp-target.c | 1 +\n net/net-hmp-cmds.c | 1 +\n qom/qom-hmp-cmds.c | 1 +\n system/qdev-monitor.c | 1 +\n system/runstate-hmp-cmds.c | 1 +\n trace/trace-hmp-cmds.c | 1 +\n ui/ui-hmp-cmds.c | 1 +\n 12 files changed, 51 insertions(+), 21 deletions(-)\n create mode 100644 include/monitor/hmp-completion.h","diff":"diff --git a/MAINTAINERS b/MAINTAINERS\nindex 35529266a26..fda43a7605b 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -3383,6 +3383,8 @@ F: monitor/monitor.c\n F: monitor/hmp*\n F: hmp.h\n F: hmp-commands*.hx\n+F: include/monitor/hmp.h\n+F: include/monitor/hmp-completion.h\n F: include/monitor/hmp-target.h\n F: tests/qtest/test-hmp.c\n F: include/qemu/qemu-print.h\ndiff --git a/include/monitor/hmp-completion.h b/include/monitor/hmp-completion.h\nnew file mode 100644\nindex 00000000000..dab21867dc9\n--- /dev/null\n+++ b/include/monitor/hmp-completion.h\n@@ -0,0 +1,40 @@\n+/*\n+ * Human Monitor Completion handlers\n+ *\n+ * Copyright IBM, Corp. 2011\n+ *\n+ * Authors:\n+ * Anthony Liguori \n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef HMP_COMPLETION_H\n+#define HMP_COMPLETION_H\n+\n+#include \"qemu/readline.h\"\n+\n+void object_add_completion(ReadLineState *rs, int nb_args, const char *str);\n+void object_del_completion(ReadLineState *rs, int nb_args, const char *str);\n+void device_add_completion(ReadLineState *rs, int nb_args, const char *str);\n+void device_del_completion(ReadLineState *rs, int nb_args, const char *str);\n+void sendkey_completion(ReadLineState *rs, int nb_args, const char *str);\n+void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str);\n+void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str);\n+void set_link_completion(ReadLineState *rs, int nb_args, const char *str);\n+void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str);\n+void netdev_del_completion(ReadLineState *rs, int nb_args, const char *str);\n+void ringbuf_write_completion(ReadLineState *rs, int nb_args, const char *str);\n+void info_trace_events_completion(ReadLineState *rs, int nb_args,\n+ const char *str);\n+void trace_event_completion(ReadLineState *rs, int nb_args, const char *str);\n+void watchdog_action_completion(ReadLineState *rs, int nb_args,\n+ const char *str);\n+void migrate_set_capability_completion(ReadLineState *rs, int nb_args,\n+ const char *str);\n+void migrate_set_parameter_completion(ReadLineState *rs, int nb_args,\n+ const char *str);\n+void delvm_completion(ReadLineState *rs, int nb_args, const char *str);\n+void loadvm_completion(ReadLineState *rs, int nb_args, const char *str);\n+\n+#endif\ndiff --git a/include/monitor/hmp.h b/include/monitor/hmp.h\nindex e222bea60cd..9c2330205fc 100644\n--- a/include/monitor/hmp.h\n+++ b/include/monitor/hmp.h\n@@ -114,27 +114,6 @@ void hmp_vhost_queue_status(Monitor *mon, const QDict *qdict);\n void hmp_virtio_queue_element(Monitor *mon, const QDict *qdict);\n void hmp_xen_event_inject(Monitor *mon, const QDict *qdict);\n void hmp_xen_event_list(Monitor *mon, const QDict *qdict);\n-void object_add_completion(ReadLineState *rs, int nb_args, const char *str);\n-void object_del_completion(ReadLineState *rs, int nb_args, const char *str);\n-void device_add_completion(ReadLineState *rs, int nb_args, const char *str);\n-void device_del_completion(ReadLineState *rs, int nb_args, const char *str);\n-void sendkey_completion(ReadLineState *rs, int nb_args, const char *str);\n-void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str);\n-void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str);\n-void set_link_completion(ReadLineState *rs, int nb_args, const char *str);\n-void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str);\n-void netdev_del_completion(ReadLineState *rs, int nb_args, const char *str);\n-void ringbuf_write_completion(ReadLineState *rs, int nb_args, const char *str);\n-void info_trace_events_completion(ReadLineState *rs, int nb_args, const char *str);\n-void trace_event_completion(ReadLineState *rs, int nb_args, const char *str);\n-void watchdog_action_completion(ReadLineState *rs, int nb_args,\n- const char *str);\n-void migrate_set_capability_completion(ReadLineState *rs, int nb_args,\n- const char *str);\n-void migrate_set_parameter_completion(ReadLineState *rs, int nb_args,\n- const char *str);\n-void delvm_completion(ReadLineState *rs, int nb_args, const char *str);\n-void loadvm_completion(ReadLineState *rs, int nb_args, const char *str);\n void hmp_rocker(Monitor *mon, const QDict *qdict);\n void hmp_rocker_ports(Monitor *mon, const QDict *qdict);\n void hmp_rocker_of_dpa_flows(Monitor *mon, const QDict *qdict);\ndiff --git a/chardev/char-hmp-cmds.c b/chardev/char-hmp-cmds.c\nindex 8e9e1c1c021..f377e00b699 100644\n--- a/chardev/char-hmp-cmds.c\n+++ b/chardev/char-hmp-cmds.c\n@@ -16,6 +16,7 @@\n #include \"qemu/osdep.h\"\n #include \"chardev/char.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-char.h\"\ndiff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c\nindex 0a193b8f54a..d5712d11b8c 100644\n--- a/migration/migration-hmp-cmds.c\n+++ b/migration/migration-hmp-cmds.c\n@@ -17,6 +17,7 @@\n #include \"block/qapi.h\"\n #include \"migration/snapshot.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-migration.h\"\ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex 3f019ae2a28..da7dd7f31f2 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -29,6 +29,7 @@\n #include \"system/device_tree.h\"\n #include \"monitor/hmp-target.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"block/block-hmp-cmds.h\"\n #include \"qapi/qapi-commands-control.h\"\n #include \"qapi/qapi-commands-misc.h\"\ndiff --git a/net/net-hmp-cmds.c b/net/net-hmp-cmds.c\nindex e7c55d27876..2b24c9e6049 100644\n--- a/net/net-hmp-cmds.c\n+++ b/net/net-hmp-cmds.c\n@@ -16,6 +16,7 @@\n #include \"qemu/osdep.h\"\n #include \"migration/misc.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor.h\"\n #include \"net/net.h\"\n #include \"net/hub.h\"\ndiff --git a/qom/qom-hmp-cmds.c b/qom/qom-hmp-cmds.c\nindex 32e40630c96..47110ca58c0 100644\n--- a/qom/qom-hmp-cmds.c\n+++ b/qom/qom-hmp-cmds.c\n@@ -8,6 +8,7 @@\n #include \"qemu/osdep.h\"\n #include \"hw/core/qdev.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-qom.h\"\ndiff --git a/system/qdev-monitor.c b/system/qdev-monitor.c\nindex 1ac6d9a8575..2ed95e83602 100644\n--- a/system/qdev-monitor.c\n+++ b/system/qdev-monitor.c\n@@ -20,6 +20,7 @@\n #include \"qemu/osdep.h\"\n #include \"hw/core/sysbus.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor.h\"\n #include \"monitor/qdev.h\"\n #include \"system/arch_init.h\"\ndiff --git a/system/runstate-hmp-cmds.c b/system/runstate-hmp-cmds.c\nindex be1d6769926..02d1d42bf39 100644\n--- a/system/runstate-hmp-cmds.c\n+++ b/system/runstate-hmp-cmds.c\n@@ -16,6 +16,7 @@\n #include \"qemu/osdep.h\"\n #include \"exec/cpu-common.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-run-state.h\"\ndiff --git a/trace/trace-hmp-cmds.c b/trace/trace-hmp-cmds.c\nindex 45f4335ff5d..390173095cf 100644\n--- a/trace/trace-hmp-cmds.c\n+++ b/trace/trace-hmp-cmds.c\n@@ -24,6 +24,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-trace.h\"\ndiff --git a/ui/ui-hmp-cmds.c b/ui/ui-hmp-cmds.c\nindex 6c93d452c9c..1e9bc77bd80 100644\n--- a/ui/ui-hmp-cmds.c\n+++ b/ui/ui-hmp-cmds.c\n@@ -18,6 +18,7 @@\n #include \n #endif\n #include \"monitor/hmp.h\"\n+#include \"monitor/hmp-completion.h\"\n #include \"monitor/monitor-internal.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-ui.h\"\n","prefixes":["v4","04/32"]}