{"id":2228677,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228677/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-19-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-19-philmd@linaro.org>","date":"2026-04-27T08:07:24","name":"[v4,18/32] monitor: Do not check multiple TARGET_* to build 'info tlb' command","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"554b1ff226a8bf55beb25ccd66a7049af272f7dc","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-19-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228677/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228677/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bSjpvvv7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x7n16R3z1yJs\n\tfor ; Mon, 27 Apr 2026 18:10:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH2L-0003C1-KR; Mon, 27 Apr 2026 04:09:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH2J-0002sh-Of\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:47 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH2I-00029A-2r\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:47 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-48896199cbaso98648275e9.1\n for ; Mon, 27 Apr 2026 01:09:45 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cb1249sm75288495f8f.5.2026.04.27.01.09.43\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:09:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277385; x=1777882185; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=pik3BU464hnFHYYfndKD9+oHzuH7HfW/xw+RI/N+w7I=;\n b=bSjpvvv7UM2GLcRF4dHVXuZ2kYxSqZ0BT7i0xGGYLMfq17tFZtYoXQCKoFIlYklmw2\n /gZtTnySIefvoPNAUdR4wMZmcllGSmC+2NY6nW+7jmXGn1j4tlleqTx27efroWvX3BFQ\n MZPcIT/Lfpq5D2XIb89+cI1NCRsD5irrUd1nbTpZKnHWQMSrj2HuPtSyIaYWqXTb4oQ2\n Bl6W3xoCdgFORB5anwTAHQA0Mn9HUTQVmY16xxcu8T1BajD/SS7L51wSMDT3/lMqO/Hf\n ELD2vkxTLDnUyi2E/6cilF3hwSuGj0t8lQLubL3Q71RAXN9gFFHaqpIj9MYlTyu7Pelp\n Iing==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277385; x=1777882185;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=pik3BU464hnFHYYfndKD9+oHzuH7HfW/xw+RI/N+w7I=;\n b=o+3IpP7Hp3QxbASraIPFadtaCNUp4fgp7R58kTN9IlzuD3646K1NgS5FVaTqnFCeuT\n 2b5DNaTlPawCHyDTfF9V3rJ507zvSXi2E21V4LzlbEC+EfsKcBotRSdkMkHa9Fz72XZ+\n 5zh2Yjch/9hfkfnOPSpgnfJq7Qz4li1d46oUyyJioBXHN5PWgN9eESliL4n0QA1uPwD/\n 01suneU4LVzTnvjh99nHU6IqmV+cyDlTbQfgGterXE9TVp3Jxopw47Gd3t55K/D5CoM8\n SS+wFABiBogG274gaL9HQi/IejTNStT6ZlfNxFMik/d3n13GXyokCVhXozZKYellPuY7\n 3Sxg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8VkcAPuRJMszwKyNKDDiFoVK5YwwV3VvcBGF5ubXaLIZJeBG32IS5KkaO1sAulzBItVqOoAmJF1Jmi@nongnu.org","X-Gm-Message-State":"AOJu0Yxw34d+cuMKyERZbKWyzLLk1K05iKmq1LQGnvoSEcFoqJeACter\n I/3aSNjuIYWm2Ks0jTTu3p21zFN+UANytZuauZfVvaWKldO+DKeV81JCNb3kC990IK4=","X-Gm-Gg":"AeBDiesSONercqFo4gCC0y0o6yI6ArlAwVU18UFsdNpt38uX/Xc2u4ae6eCVLDV/wKO\n 2JgdEbqmdeMBLSXaC0Q3v0xFEWOUnyZmH6lbjmuDuwmX9eaciwYOCrnGa5TzD3f9pVfXJQ0A8wN\n 3nVjkV2GRQ90aGAL3f9XmOFdnI/1iUxTqVPhfg9BlqM0ztnF5eyFwueblCLqw/YtLJbCmpZ80TL\n a+MOPNTpTQi5Z+s9LNh07sgYqiHkyT33qHPnAH/dpCvAW/IW2FZOzXWWkN9MtE/9KSEz1hIk/wM\n 3Y3kyWq9eR/YFC66i4rLiQI5b0rpBS8sriI4GEKFjVaWpoBj4bZgEweLdFZMXfamIyDzZ38JByi\n thQBwxUOvtfV7wKIZoaoTr8bM0+ASB92JGUXviY8o9zt87lBWIcdVVZTeatGpBh2HrsJ9mn6Fmj\n U65cDgmt+tQW5lzT8BkdkslhdVH0/beHw8G/26W1TqewKKyi+UpWR3yf06YVNDYwMFbGoli57A7\n i9yjHM61WM=","X-Received":"by 2002:a05:600c:a416:b0:488:e7e4:8425 with SMTP id\n 5b1f17b1804b1-488fb787674mr473342705e9.23.1777277384463;\n Mon, 27 Apr 2026 01:09:44 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 18/32] monitor: Do not check multiple TARGET_* to build\n 'info tlb' command","Date":"Mon, 27 Apr 2026 10:07:24 +0200","Message-ID":"<20260427080738.77138-19-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This command is filtered at build-time for a selection of binaries.\nBy using the recently introduced HMPCommand::arch_bitmask flag we\ncan filter them at runtime, making it possible to compile\nhmp-commands-info.hx once.\n\nSince the method depends on a pair of distinct targets,\ndefine it in its own stub file.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n stubs/hmp-cmd-info_tlb.c | 12 ++++++++++++\n hmp-commands-info.hx | 5 ++---\n stubs/meson.build | 1 +\n 3 files changed, 15 insertions(+), 3 deletions(-)\n create mode 100644 stubs/hmp-cmd-info_tlb.c","diff":"diff --git a/stubs/hmp-cmd-info_tlb.c b/stubs/hmp-cmd-info_tlb.c\nnew file mode 100644\nindex 00000000000..a144e68c1c7\n--- /dev/null\n+++ b/stubs/hmp-cmd-info_tlb.c\n@@ -0,0 +1,12 @@\n+/*\n+ * Human Monitor 'info tlb' stub\n+ *\n+ * Copyright (c) Linaro\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"monitor/hmp.h\"\n+\n+HMP_STUB(info_tlb)\ndiff --git a/hmp-commands-info.hx b/hmp-commands-info.hx\nindex 2d0a8f7d48f..0898221a486 100644\n--- a/hmp-commands-info.hx\n+++ b/hmp-commands-info.hx\n@@ -193,16 +193,15 @@ SRST\n Show PCI information.\n ERST\n \n-#if defined(TARGET_I386) || defined(TARGET_SH4) || defined(TARGET_SPARC) || \\\n- defined(TARGET_PPC) || defined(TARGET_XTENSA) || defined(TARGET_M68K)\n {\n .name = \"tlb\",\n .args_type = \"\",\n .params = \"\",\n .help = \"show virtual to physical memory mappings\",\n .cmd = hmp_info_tlb,\n+ .arch_bitmask = QEMU_ARCH_I386 | QEMU_ARCH_SH4 | QEMU_ARCH_SPARC \\\n+ | QEMU_ARCH_PPC | QEMU_ARCH_XTENSA | QEMU_ARCH_M68K,\n },\n-#endif\n \n SRST\n ``info tlb``\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 33053d932c8..2f4e1ab4300 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -89,6 +89,7 @@ if have_system\n stub_ss.add(files('qmp-cpu-s390x-kvm.c'))\n stub_ss.add(files('hmp-cmd-info_mem.c'))\n stub_ss.add(files('hmp-cmd-info_sev.c'))\n+ stub_ss.add(files('hmp-cmd-info_tlb.c'))\n stub_ss.add(files('hmp-cmds-hw-s390x.c'))\n stub_ss.add(files('hmp-cmds-target-i386.c'))\n endif\n","prefixes":["v4","18/32"]}