{"id":2228675,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228675/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-20-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-20-philmd@linaro.org>","date":"2026-04-27T08:07:25","name":"[v4,19/32] cpus: Introduce SysemuCPUOps::monitor_get_register() hook","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fce56202ceb92af08c170c6d8a55909109f74b1b","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-20-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228675/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228675/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Es8YNFZN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x7j5TKNz1yJX\n\tfor ; Mon, 27 Apr 2026 18:10:09 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH2U-0004bH-V8; Mon, 27 Apr 2026 04:09:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH2R-00047G-8S\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:55 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH2O-0002BL-PC\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:54 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-488af96f6b2so130183795e9.0\n for ; Mon, 27 Apr 2026 01:09:52 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e591cesm106514862f8f.36.2026.04.27.01.09.50\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:09:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277391; x=1777882191; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=e+EDDgWhJI3ORltCGjgBjB3nc854c+rlyGvs0etBPgA=;\n b=Es8YNFZNny+dY5dEvhgmsb4sr8EMpY8g9DqoNHYlJDeCkgK7szn9jk/jqpRIsdC7uY\n AypSBjhi+uI1dOaVcbzODkJ7K1jKOqb6+va+yfGlkDhxANrsUKcMp+z/PNkbFIRjx9nf\n bxFc27TBADtwisn+A0UKfoLze/a7hRjpmaOFOEPNONptEYbGvvR4vhSHD4HbFfSgKalm\n hmPsddMOKyMmVjgGTkYvr4MQ5K1zgn6U2ADDVVm+u7JVhy4rrkUsVVCGtz6TM6LTJDsx\n UHXvCjB/TdDCDBbbEsQd2QlULL8mTmzsyd9b4ZU3pAP2HQJuB6DfguQCc1ER9dYLMq3x\n AgBQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277391; x=1777882191;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=e+EDDgWhJI3ORltCGjgBjB3nc854c+rlyGvs0etBPgA=;\n b=ibuIN7BVZSccsLAHgxIodfVY0BRc9KIErEx+TkazRXatJgt9y7/veV/GWPqE83vY0s\n T+G0CWcl3nxMHGdaB0w1o5RUjgjTt1KCH8asJHj5rciAiUHHbp2nRstYm+cgb2BOMTPh\n O2Lwd7OpFAMXnXD+RoesS6ND0jO7u4NQO7kzZfWpMiT7rHAPiC1NBT7H+u6E8WKTJc7E\n rilXa/5fB8KnK4vAtghddUTp1RO/JZISMuR6v5tEh2RZVfIcmRhaeYIERNcrIKLaoUGr\n eKyxOYz8mMN0WOYkgseLbYsf5Z78KlhTnOs0r96VCq7YUrDslr7F7nao2u8xAGDzZT7k\n autQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8eEevAXLBeJpYEbKzoold59AUG0cEREV3njwrU/8C2w/tYBv7XFcfbJqadNrW9wwSozsKRpV1rEIYC@nongnu.org","X-Gm-Message-State":"AOJu0YwibuKZ9nXsOo9GN4CgTauk6CvOATPU3aFY9zW/jzBsRiJkzRdf\n j7WCDYn+lDLXOOlaibyjyOxRQtzt6HMlQkqaBU3AOTZuTRCVULWwuni3VJbza11JgaIJfqib3gX\n Uowjn0Oo=","X-Gm-Gg":"AeBDietNcChuJH0Fgqc8kyHHCsOyLYouHGpvkVCBo5rGg5FqpbEEJYbyN/fv6UT9dmp\n DpRg46AAOqyXlZqvB9sXe1dkdL39XKtyVR7qSi6RBj3CGD8HjIZAMx/tKtyIYSDMIHD6yS+Vk+K\n 8fw2mbvwj9o/zZCLB5mkeE5R9bBDEWka7x/a14RVu9zzf/jRmbORKdGsIs2l9g6qcKWykMYcHRr\n dGm1Ocujkh/F61njRWuHWMPs8YicYvT/kj01oonUzolvmbL+SGbR/AR/Qs34xofJaOLszz821UN\n POgF997SZXE7ZIQS2+y5UQhXcc5cWUVp27IpTSGfSHdQoTvhcvqT6laSk4XNm7m+yFIW4lYeVAh\n 1A7PHS0V6ievUhe1Ue1uwBAS3dUJLVwteoZHzxi8mkMbgdsfMJ8Kr675ZPHEqaAkc3igXbLpCZM\n AKIU8vtiPxfBxcUaX4xzlmkkbtwJSE60C1SEm8WXnB2EIDhAhDVOoliitRS686R1XRrIavq+88k\n PwRf5nQf7A=","X-Received":"by 2002:a05:600c:8483:b0:488:7ff6:1f75 with SMTP id\n 5b1f17b1804b1-488fb782d91mr633195655e9.21.1777277391201;\n Mon, 27 Apr 2026 01:09:51 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 19/32] cpus: Introduce SysemuCPUOps::monitor_get_register()\n hook","Date":"Mon, 27 Apr 2026 10:07:25 +0200","Message-ID":"<20260427080738.77138-20-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Allow targets to register their legacy target_get_monitor_def()\nin SysemuCPUOps; check it first in get_monitor_def() otherwise\nfall back to previous per-target helper.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n include/hw/core/sysemu-cpu-ops.h | 8 ++++++++\n monitor/hmp-target.c | 11 ++++++++---\n 2 files changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h\nindex 7b2d2d2610f..5b831393cf4 100644\n--- a/include/hw/core/sysemu-cpu-ops.h\n+++ b/include/hw/core/sysemu-cpu-ops.h\n@@ -85,6 +85,14 @@ typedef struct SysemuCPUOps {\n */\n bool (*internal_is_big_endian)(CPUState *cpu);\n \n+ /**\n+ * @monitor_get_register: Callback to fill @pval with register @name value.\n+ * This field is legacy, use @gdb_core_xml_file\n+ * to dump registers instead.\n+ * Returns: 0 on success or negative errno on failure.\n+ */\n+ int (*monitor_get_register)(CPUState *cs, const char *name, int64_t *pval);\n+\n /**\n * @legacy_vmsd: Legacy state for migration.\n * Do not use in new targets, use #DeviceClass::vmsd instead.\ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex a222fd4c96a..46ccbd14aec 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -35,6 +35,7 @@\n #include \"qapi/qapi-commands-control.h\"\n #include \"qapi/qapi-commands-misc.h\"\n #include \"qapi/qapi-commands-machine.h\"\n+#include \"hw/core/sysemu-cpu-ops.h\"\n \n /* Make devices configuration available for use in hmp-commands*.hx templates */\n #include CONFIG_DEVICES\n@@ -85,9 +86,13 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n }\n }\n \n- ret = target_get_monitor_def(cs, name, &tmp);\n- if (!ret) {\n- *pval = (target_long) tmp;\n+ if (cs->cc->sysemu_ops->monitor_get_register) {\n+ ret = cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n+ } else {\n+ ret = target_get_monitor_def(cs, name, &tmp);\n+ if (!ret) {\n+ *pval = (target_long) tmp;\n+ }\n }\n \n return ret;\n","prefixes":["v4","19/32"]}