{"id":2228669,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228669/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-15-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-15-philmd@linaro.org>","date":"2026-04-27T08:07:20","name":"[v4,14/32] monitor: Do not check TARGET_I386 to build target/i386/ commands","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dcc08de8fbc83f52f64067627dbb74192e6e4bc6","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-15-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228669/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228669/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=k2fx1BVd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x725s4Mz1yHv\n\tfor ; Mon, 27 Apr 2026 18:09:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH1z-0001lr-91; Mon, 27 Apr 2026 04:09:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH1t-0001QQ-NX\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:22 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH1s-0001zJ-1b\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:21 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-48a563e4ef7so65805275e9.0\n for ; Mon, 27 Apr 2026 01:09:19 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc10019bsm797040345e9.4.2026.04.27.01.09.17\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:09:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277358; x=1777882158; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=O7UCdCKJ1c5qVGsxeGNM3DP4EYb+8E6FPBO3612XPg8=;\n b=k2fx1BVd0JdohBqCRPX/OnkgLDcJQ8HagO8csgISU4zGlGPp69MdSNs45LO9i1oLdg\n ebL9IbwrO9Qy1IJQ6aP38HnSCqaOyxfc5klpb+5kcXmWXnDPKZOYGw0Fxnt4E8vE6FkS\n NM3HJCXmYI1pDHbtsEhK9toBgvYE+o7d6lDU84Uq+IhUIOZg5N6KxmrC2XkNE+0SV/+z\n ygkfXP+EKmYXkvK7rVyg8GCs5CZo2PGLJIkkYoZLsHvZfOu+Wb8SL+a2E5gH/ahMt7hD\n BGgPJ69utj7Ohl3cQ5lY1T2CJL0i3l5kmWTWC5Yg92pJdOezsa4po+EtLnNy0pGBhyqj\n u9qA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277358; x=1777882158;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=O7UCdCKJ1c5qVGsxeGNM3DP4EYb+8E6FPBO3612XPg8=;\n b=UnDvN9VcluiVgeT2r/tdjdxfKpCVwPZoE3b3ZwoUJzdkobPPFE9zbp1bw2/kRPCZB4\n bZBsw0ohz7X8kq6fqzq/G6oCJxaWp4C0OmJLwEU8WggExAZBHW8r2JdG5e/Zhg216O4w\n o9DFLXsOBWvBeLf3QskhetiFxuI47CN0RhvUhRGv3n8RQgUQTNko4Ysb1co4S+3TQAj9\n M69mgCxWVb+nKoPk7M+a/2M+Lft+mEEcFVeXjHVC3IByKNy2a07gbDF2cF8bxAKAvr1V\n q5mhbp1WEHsPRQfGKG1rRwZd/9XT9zhzctKRqsiE2VBzgODqF+PScetKbWX3ryYcvty8\n 46OA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/jxQs9ame+Nqjgp9eK2JeqnnZOVHlfKjDRnunwcxZTJuL/wG/LoljXhHGNHmP3u+dpIf7wZzXlbeGD@nongnu.org","X-Gm-Message-State":"AOJu0Yy3dD5JyO8KCGy2sUZ4siJtu8u6zuDcRoOeQOmtFbPgZrssnRV/\n ZgOcxfhcFa5NYMC8gdqJA70IR+nS52RwuPqod07i9LvFOVARFXffSN+939yXzQEmOJk=","X-Gm-Gg":"AeBDiestYr3lEBZccVtYzHLRn3luEYEsjwEC8jFR5FlGeLN403vlJrWHm2tdiz9BMJE\n kQMIndJdQXru2NHXComv0sfC44wWhOpV/ae+2QuIUWh3m6k9tvociIpuytJETlYbTWTuvA8hyA9\n +RM6WovKZooVoMgVjiFll/FmP6ZfpG6nUlazi9kZi+npi0IHVQ7g4M0xlww3t/yi3d3sdehK+bH\n vFu8z47kRcEDCT9ihGQfCWyiSr/46l1AhXI/dzWFrIS9S+v+8Au/NSb+uZWHvY3Nl1CIhzGRH+t\n wVxdDKUBLeo0Lfh4apv5P5DmM7pTAe1aqrUlnTFdechb6XaWbA39KjhGFPbdcmXka4S6nsVBR02\n Uuc1H3g4Fb+F3v3X3u1+O393Lua8F57XTtJl6+SfSNf4iKGAEkBNL4ZdNUValyg2E3alx99Vn5D\n ZvDpN5E9/z2qGXM6ty6Aelp6qvk5xcyOkw72XdF/bYgRZkRRL/vms2CC9MGB044QYolKQD4EKHs\n cxokjvAAas=","X-Received":"by 2002:a05:600c:a30a:b0:48a:581c:ead with SMTP id\n 5b1f17b1804b1-48a581c113cmr262189365e9.10.1777277357847;\n Mon, 27 Apr 2026 01:09:17 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 14/32] monitor: Do not check TARGET_I386 to build\n target/i386/ commands","Date":"Mon, 27 Apr 2026 10:07:20 +0200","Message-ID":"<20260427080738.77138-15-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"These commands are filtered at build-time for i386/x86_64 binaries.\nBy using the recently introduced HMPCommand::arch_bitmask flag\nwe can filter them at runtime, making it possible to compile\nhmp-commands[-info].hx files once.\n\nSince these methods are used inconditionally within target/i386/,\ndefine them in the same stub file.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n MAINTAINERS | 1 +\n stubs/hmp-cmds-target-i386.c | 13 +++++++++++++\n hmp-commands-info.hx | 4 +---\n hmp-commands.hx | 5 +----\n stubs/meson.build | 1 +\n 5 files changed, 17 insertions(+), 7 deletions(-)\n create mode 100644 stubs/hmp-cmds-target-i386.c","diff":"diff --git a/MAINTAINERS b/MAINTAINERS\nindex 5583df5087f..8493b12a342 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -148,6 +148,7 @@ F: configs/targets/i386-softmmu.mak\n F: configs/targets/x86_64-softmmu.mak\n F: docs/system/i386/\n F: docs/system/target-i386*\n+F: stubs/hmp-cmds-target-i386.c\n F: target/i386/*.[ch]\n F: target/i386/Kconfig\n F: target/i386/meson.build\ndiff --git a/stubs/hmp-cmds-target-i386.c b/stubs/hmp-cmds-target-i386.c\nnew file mode 100644\nindex 00000000000..43a167056d5\n--- /dev/null\n+++ b/stubs/hmp-cmds-target-i386.c\n@@ -0,0 +1,13 @@\n+/*\n+ * Human Monitor x86 stubs\n+ *\n+ * Copyright (c) Linaro\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"monitor/hmp.h\"\n+\n+HMP_STUB(info_local_apic)\n+HMP_STUB(mce)\ndiff --git a/hmp-commands-info.hx b/hmp-commands-info.hx\nindex 28dec25642d..b575e4ac993 100644\n--- a/hmp-commands-info.hx\n+++ b/hmp-commands-info.hx\n@@ -113,16 +113,14 @@ SRST\n Show the cpu registers.\n ERST\n \n-#if defined(TARGET_I386)\n {\n .name = \"lapic\",\n .args_type = \"apic-id:i?\",\n .params = \"[apic-id]\",\n .help = \"show local apic state (apic-id: local apic to read, default is which of current CPU)\",\n-\n .cmd = hmp_info_local_apic,\n+ .arch_bitmask = QEMU_ARCH_I386,\n },\n-#endif\n \n SRST\n ``info lapic``\ndiff --git a/hmp-commands.hx b/hmp-commands.hx\nindex ff65b39b454..cfd53bdc744 100644\n--- a/hmp-commands.hx\n+++ b/hmp-commands.hx\n@@ -1488,18 +1488,15 @@ SRST\n Stop the QEMU embedded NBD server.\n ERST\n \n-\n-#if defined(TARGET_I386)\n-\n {\n .name = \"mce\",\n .args_type = \"broadcast:-b,cpu_index:i,bank:i,status:l,mcg_status:l,addr:l,misc:l\",\n .params = \"[-b] cpu bank status mcgstatus addr misc\",\n .help = \"inject a MCE on the given CPU [and broadcast to other CPUs with -b option]\",\n .cmd = hmp_mce,\n+ .arch_bitmask = QEMU_ARCH_I386,\n },\n \n-#endif\n SRST\n ``mce`` *cpu* *bank* *status* *mcgstatus* *addr* *misc*\n Inject an MCE on the given CPU (x86 only).\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 99a89c00066..6142e0f4d9d 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -88,6 +88,7 @@ if have_system\n stub_ss.add(files('qmp-cpu-s390x.c'))\n stub_ss.add(files('qmp-cpu-s390x-kvm.c'))\n stub_ss.add(files('hmp-cmds-hw-s390x.c'))\n+ stub_ss.add(files('hmp-cmds-target-i386.c'))\n endif\n \n if have_system or have_user\n","prefixes":["v4","14/32"]}