{"id":2228667,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228667/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-8-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-8-philmd@linaro.org>","date":"2026-04-27T08:07:13","name":"[v4,07/32] monitor: Restrict monitor_set_cpu() method scope","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2cb88a31568e67d7d9658fbe3d31f039d226e39b","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-8-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228667/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228667/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=EHS+Mcx6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x6d5yngz1yJs\n\tfor ; Mon, 27 Apr 2026 18:09:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH1W-00017Y-Qo; Mon, 27 Apr 2026 04:08:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH18-0000na-Kg\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:08:37 -0400","from mail-wr1-x432.google.com ([2a00:1450:4864:20::432])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH16-0001ca-TD\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:08:34 -0400","by mail-wr1-x432.google.com with SMTP id\n ffacd0b85a97d-43d77f60944so7303917f8f.3\n for ; Mon, 27 Apr 2026 01:08:30 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4411c9f4f03sm48330850f8f.1.2026.04.27.01.08.28\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:08:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277310; x=1777882110; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=UfM0rjL9l7HImwIhQNZz86yWfS4Ppx2p9yTZq5d663s=;\n b=EHS+Mcx6CHsrAT5+EfeEVoSInqXK5jx/3jCuMDP4G8BwMS4i3vdcruOXShk1HWzBbK\n vM6uwzLtF+OolhIzPIRK62gH+9c6Cmu+b9rMJAK2u4D+BgbrxXYvPjChGTp1nly2HpYg\n tQt430Ni3gm2v1j0cm70RfK56IIna+nBnBhQZKibo04RqmBiO2H8MeE3OZ6qabw14/n4\n S+aK7cA80a/VDo8ZYGC7nXeae7O/Y/FW9vVa2WQKcnKqqMhmKZwqGuSFSH+H5HuX5TaH\n VQXu9OfPrDCsb8RsZ6eQ07mhtttZTU4p9NdKp3bAXvIGryqa28gtbezFMNnB8lwF3hyn\n Kd9A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277310; x=1777882110;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=UfM0rjL9l7HImwIhQNZz86yWfS4Ppx2p9yTZq5d663s=;\n b=UM5W9yhsdNJbnPoA8MS7JBbkwjxg2R86lV/ZtQMWP9Zx1I+XldIBr5btONybeQYs2d\n /nP8lIgXYo/pilnOOPWC7dBfhI5MPlIENOyq570yOlooLXJ7vIDRytNjko3lEE9s1Zm0\n nMIOX0EB96vb/dgOKh6qmgOinek56ncIQEd4yaSkrg/PiISDA4NmVlYJ7ThCZJhnl0no\n PmwXVDUXa4CzvLb3xgDZVIjLgM9JLNpthAqrTPq22r1RjwOtAK+gGmjInHwehqSrulDM\n MQLxQiOAKpS0d3I2PcrnG3lqI9w3JD4e8nKBJTPkfoXdXNo5afB9SaIngLuEKoZCw/zV\n v71Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+c3HVHGHvPJHIBhHOaB1FiDhz0YDzsGlCLAvvieUckRsWjlfyof7urIrXDqyMRLoIROuT5MkvwDIUv@nongnu.org","X-Gm-Message-State":"AOJu0Yz/0Qn7tWizipz0gmTJJFmDI9kI8RF0yDnSh31dxcLFQEmih19U\n QmpdeNLLpXtWIt0Yg3v91hN9CS04r0KVIgub/p327+XdyApazXwb2zlwFyreUFMhaS4fSTzc2sH\n D7RNBPSs=","X-Gm-Gg":"AeBDieuoAYpAeaPvRcH5ZMKeL+7l2XFqSHXLhsv8fbU6xy9q4ZMypzULj5MkwSkjQe3\n jJ2aZyEMFmsfl2LmBvwELMGRes2JrFAi5jaHzIfAB4e0Py5xyUVHKlJL5TURzBZMHGm0Rdty3Ra\n 7RxFhs6GCNIXcaJ5YZM8NPkQpEWZXoftzN4ilLZdFWzGFWLLkmSSXlwH/mFJxS2S5FDcRC1OAI2\n 0Dm/qadLM5UIgCwIy7qlywPc6d39LwbTmRdukq3FOclsOQLeqwk/4EC6KB+13Z2chZ46XKakuK0\n hwl7iOSIqgZsubgBCRccTvB22Jr3Z0CQfXghyWAHH6bYDI0J4rIOyvHV1NLrRAK6mMnVc5DfTTK\n Q2d2VHvAsFsOER1nsgQ8OKkS0JfOjfPZYtXXipuh5+7qI240k8r1tPoCyOdywpFuBs/ZqoRU9EH\n NQf8+WFFq1Msj5DYI0RRojKLIICkzblvbDTwo1lDRJH3TtQkxM9WzxJnmKMgzlz3EBld3NoDjs4\n /fsJhg49ozDIlhrQ6mp9g==","X-Received":"by 2002:a5d:5f82:0:b0:437:711c:8754 with SMTP id\n ffacd0b85a97d-43fe3dc842bmr66027146f8f.7.1777277309482;\n Mon, 27 Apr 2026 01:08:29 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 07/32] monitor: Restrict monitor_set_cpu() method scope","Date":"Mon, 27 Apr 2026 10:07:13 +0200","Message-ID":"<20260427080738.77138-8-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::432;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"As mentioned in commit 755f196898e (\"qapi: Convert the cpu\ncommand\") 15 years ago, the monitor_set_cpu() method is a\ntemporary bridge between QMP -> HMP and shouldn't be used\nelsewhere. Make its scope internal to monitor/.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n include/monitor/monitor.h | 1 -\n monitor/monitor-internal.h | 1 +\n 2 files changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h\nindex 296690e1f1c..55649a86641 100644\n--- a/include/monitor/monitor.h\n+++ b/include/monitor/monitor.h\n@@ -37,7 +37,6 @@ int monitor_vprintf(Monitor *mon, const char *fmt, va_list ap)\n int monitor_printf(Monitor *mon, const char *fmt, ...) G_GNUC_PRINTF(2, 3);\n void monitor_printc(Monitor *mon, int ch);\n void monitor_flush(Monitor *mon);\n-int monitor_set_cpu(Monitor *mon, int cpu_index);\n int monitor_get_cpu_index(Monitor *mon);\n \n int monitor_puts_locked(Monitor *mon, const char *str);\ndiff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex feca111ae31..80b4a8150bf 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -175,6 +175,7 @@ void monitor_data_destroy(Monitor *mon);\n int monitor_can_read(void *opaque);\n void monitor_list_append(Monitor *mon);\n void monitor_fdsets_cleanup(void);\n+int monitor_set_cpu(Monitor *mon, int cpu_index);\n \n void qmp_send_response(MonitorQMP *mon, const QDict *rsp);\n void monitor_data_destroy_qmp(MonitorQMP *mon);\n","prefixes":["v4","07/32"]}