{"id":2228666,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228666/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-7-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260427080738.77138-7-philmd@linaro.org>","date":"2026-04-27T08:07:12","name":"[v4,06/32] monitor/meson: Use SPICE with migration HMP commands","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"751a4e7e866d59562b1035c9b574a859edc55031","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-7-philmd@linaro.org/mbox/","series":[{"id":501599,"url":"http://patchwork.ozlabs.org/api/1.1/series/501599/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599","date":"2026-04-27T08:07:06","name":"monitor: Remove need of per-target handlers","version":4,"mbox":"http://patchwork.ozlabs.org/series/501599/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228666/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228666/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ggZb/aWJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x6d3Wksz1yHv\n\tfor ; Mon, 27 Apr 2026 18:09:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHH1G-0000oe-RZ; Mon, 27 Apr 2026 04:08:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHH10-0000iR-4s\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:08:27 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHH0y-0001b6-Hb\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:08:25 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-4890098abbaso77827915e9.0\n for ; Mon, 27 Apr 2026 01:08:24 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb77b001sm369730625e9.3.2026.04.27.01.08.21\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:08:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277303; x=1777882103; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=qNtUCJEojkga+haWLj/ILWXdDy+o/7LVCJo0CbKm7kQ=;\n b=ggZb/aWJYZTF7XOIzFGBKOKWLn43BG0G86jPt71pU2fn9HZ2QfcHTpvB9tCfgjomm+\n RoOyvAHLZWl34xNZR9fhRZSZYBgbnoF9WhI4KRZJ3W4/BR1X8z24R8cMKSMtmJHd1LKc\n nofGRWQqZXKZStUDBTh62bOVBFQjlsNc7m3dUPcYHajOBMWZy17kvs2Xk175vJBgIY2L\n a2vIjRcwHy8ZBn07sDx0To58P9mPKmytY6rxA9+ytXaUrjoSjQb1k7PI8bdXD3qm4AQe\n uTg93f5jhCRTpAnIglVzMPgbOnew2xZnwvoj8iH2Lnez/h/SPRDPDD75MUrxSerwmjCI\n 9DmQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277303; x=1777882103;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=qNtUCJEojkga+haWLj/ILWXdDy+o/7LVCJo0CbKm7kQ=;\n b=PynT5+wLcGmPfLVJhMgvOQOAa2FD0tQmfCt9yd+c25kI+jNClA0oPdDluFnuJ+aEmu\n vB4uAt/u5ITDQcV0qnGE4DtFJghNVcntxV+qLRQTzdjmzf45H/orhP5rMVm+FKi1jssr\n r5HOCG2SWi3nI3mx+GsV9X780y0elb2yqv8aMDuFkef8yCZwfZC+42A54KdYHFa09/3R\n sUGDDHoGiB6oFnQNlMJ55o5aSKAAjHpkfHRyXBTkGKU8/TBgya0r7z3GJfgLJIq/9hgm\n aIFySEIjM4nfx+XLv5icbh1PLVblmYm8EbzDv2/KmQmo9PaHh0afHe4qGWOF/SCO0EPt\n m3qg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9Bsbvce+GTXDXiltTcRBbzbn679Jp79EUNUlUY24WjV3v6fmrqbNJXAG846TymACVumulWD4lfC16I@nongnu.org","X-Gm-Message-State":"AOJu0YyR1QC3w55/xHj0crKrx/ysLxSBfETCqcSkgBjoWM1hM8M76dSa\n HTnrn69s61q0q9Re4CPZUVAAzHTpMd0nvSRAuun4D36Xcir8fzMXSdkCcshg2ZU8FmDXcL2o0dK\n gPFHbQ08=","X-Gm-Gg":"AeBDiet9s1xQrJj7/pstY6El2aAP3DuTiLJCSXdShwiYXXVFQh7tM0z6hFlzXwGS8f9\n Nv5LUjV/SUmL8J4vA0H7wnfDv3RM6Jsd83gTTKXGgwLhkuUcRaKxVuKp36r3zTDpHSgki17Q4Aq\n s5/X09BOcltPQ7kKAnAJDooVop31a3FZu6lyfhIJXE1epVhAG7f1ygE+lFFxNJJRBeCMubPe2OE\n u+UiMLn/pGSTWiQUCvF0cEd1qEHZilbkyXsRMxsPNiQ5gmqz1k+lAlneSfjWiJP2a/DNrhVwImG\n XsHu7gOydt230FI5VOgBFc9rGcSRqMxDrfTQ3xEzAHWaHFEmdf32hMzi/Tnijg5d5lKSNVtvx/h\n hj1eUYoa/gnVinjsFMJi001jR70XjhbOv88Sy2ng7fBic9gzIaKhb/svzbxrc+QzPanGgpqoqWf\n v37LV1hlvCwxp+rqigGi78nnHKcy+tA0DzUCds7x5AXHa7diqoYBgtoFDPmho2spB0FpJq5Bjxc\n tqwNeITJyA=","X-Received":"by 2002:a05:600c:621a:b0:48a:592c:e642 with SMTP id\n 5b1f17b1804b1-48a592ce867mr333974625e9.18.1777277302759;\n Mon, 27 Apr 2026 01:08:22 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Markus Armbruster ,\n\tqemu-devel@nongnu.org","Subject":"[PATCH v4 06/32] monitor/meson: Use SPICE with migration HMP commands","Date":"Mon, 27 Apr 2026 10:07:12 +0200","Message-ID":"<20260427080738.77138-7-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260427080738.77138-1-philmd@linaro.org>","References":"<20260427080738.77138-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When moving code around in commit 27be86351ec (\"migration: Move\nthe QMP command from monitor/ to migration/\") we forgot to update\nthe meson rule about SPICE pkg-config flags.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n migration/meson.build | 2 +-\n monitor/meson.build | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/migration/meson.build b/migration/meson.build\nindex c9f0f5f9f21..e583822dec6 100644\n--- a/migration/meson.build\n+++ b/migration/meson.build\n@@ -23,7 +23,6 @@ system_ss.add(files(\n 'fd.c',\n 'file.c',\n 'global_state.c',\n- 'migration-hmp-cmds.c',\n 'migration.c',\n 'multifd.c',\n 'multifd-device-state.c',\n@@ -37,6 +36,7 @@ system_ss.add(files(\n 'socket.c',\n 'tls.c',\n ), gnutls, zlib)\n+system_ss.add([spice_headers, files('migration-hmp-cmds.c'), spice])\n \n if get_option('replication').allowed()\n system_ss.add(files('colo-failover.c', 'colo.c', 'multifd-colo.c'))\ndiff --git a/monitor/meson.build b/monitor/meson.build\nindex 2647100e04c..585251804e4 100644\n--- a/monitor/meson.build\n+++ b/monitor/meson.build\n@@ -5,8 +5,8 @@ system_ss.add(files(\n 'hmp-cmds.c',\n 'hmp.c',\n 'qemu-config-qmp.c',\n+ 'qmp-cmds.c',\n ))\n-system_ss.add([spice_headers, files('qmp-cmds.c')])\n \n specific_ss.add(when: 'CONFIG_SYSTEM_ONLY',\n- if_true: [files('hmp-target.c'), spice])\n+ if_true: [files('hmp-target.c')])\n","prefixes":["v4","06/32"]}