{"id":2228624,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228624/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/42d22e6eaa404394dbf805b966429e023cbe45f9.1777272283.git.weijie.gao@mediatek.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<42d22e6eaa404394dbf805b966429e023cbe45f9.1777272283.git.weijie.gao@mediatek.com>","date":"2026-04-27T07:09:27","name":"[v3,03/10] cmd: ubi: use void * for buf parameter in ubi_volume_read","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2eb2da0cac5889c794c261891f723eb57aa0e8b1","submitter":{"id":75269,"url":"http://patchwork.ozlabs.org/api/1.1/people/75269/?format=json","name":"Weijie Gao","email":"weijie.gao@mediatek.com"},"delegate":{"id":1691,"url":"http://patchwork.ozlabs.org/api/1.1/users/1691/?format=json","username":"hs","first_name":"Heiko","last_name":"Schocher","email":"hs@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/42d22e6eaa404394dbf805b966429e023cbe45f9.1777272283.git.weijie.gao@mediatek.com/mbox/","series":[{"id":501588,"url":"http://patchwork.ozlabs.org/api/1.1/series/501588/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=501588","date":"2026-04-27T07:09:11","name":"Add support for ubi environment to create volumes (v3)","version":3,"mbox":"http://patchwork.ozlabs.org/series/501588/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228624/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228624/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=GjgNdlf+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com\n header.b=\"GjgNdlf+\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=weijie.gao@mediatek.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3vpW1Sy1z1xvV\n\tfor ; Mon, 27 Apr 2026 17:10:11 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6328B84178;\n\tMon, 27 Apr 2026 09:09:40 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8D8578423D; Mon, 27 Apr 2026 09:09:39 +0200 (CEST)","from mailgw02.mediatek.com (unknown [210.61.82.184])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1FA6784144\n for ; Mon, 27 Apr 2026 09:09:35 +0200 (CEST)","from mtkmbs09n1.mediatek.inc [(172.21.101.35)] by\n mailgw02.mediatek.com (envelope-from )\n (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256)\n with ESMTP id 1169535087; Mon, 27 Apr 2026 15:09:29 +0800","from mtkmbs11n2.mediatek.inc (172.21.101.187) by\n MTKMBS09N2.mediatek.inc (172.21.101.94) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.29; Mon, 27 Apr 2026 15:09:28 +0800","from mcddlt001.gcn.mediatek.inc (10.19.240.15) by\n mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id\n 15.2.2562.29 via Frontend Transport; Mon, 27 Apr 2026 15:09:28 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,\n UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2","X-UUID":["08c0392a420811f19a16598d5ca7f8ec-20260427","08c0392a420811f19a16598d5ca7f8ec-20260427"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com;\n s=dk;\n h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From;\n bh=1QawkPYweEe1ue7zTOLEOAieBmmTjs8nbybMpMFN/nc=;\n b=GjgNdlf+1NQLx7aw/B4B6gSputfuOQ5bIVZesPOK/K0enTgSXCTGxdzlyAxX+P9VqveS4anB5NmLCObD7bcF2De+AGpoGoDGmA+IedVBp3ny6u73lbDDjLQZfQkSdUjNV+R7dJxXJtZYFrRHiOhasHLjGcoOFEAPjwRyDQgYlF4=;","X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:5fcf843e-8b52-4d32-acab-54345eafb492,\n IP:0,\n U\n RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO\n N:release,TS:-25","X-CID-META":"VersionHash:e7bac3a, CLOUDID:7005f58f-6df4-4a3d-a7a4-fbdc42d669ce,\n B\n ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|865|888|898,TC:-5,Cont\n ent:0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0\n ,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","From":"Weijie Gao ","To":"","CC":"GSS_MTK_Uboot_upstream , Tom Rini\n , Marek Vasut , Simon\n Glass , Weijie Gao ","Subject":"[PATCH v3 03/10] cmd: ubi: use void * for buf parameter in\n ubi_volume_read","Date":"Mon, 27 Apr 2026 15:09:27 +0800","Message-ID":"\n <42d22e6eaa404394dbf805b966429e023cbe45f9.1777272283.git.weijie.gao@mediatek.com>","X-Mailer":"git-send-email 2.17.0","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Type":"text/plain","X-MTK":"N","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Use void * to avoid explicit type casting as what ubi_volume_write has done\nalready.\n\nSigned-off-by: Weijie Gao \nReviewed-by: Simon Glass \n---\nv2: new\nv3: not changed\n---\n cmd/ubi.c | 4 ++--\n env/ubi.c | 4 ++--\n include/ubi_uboot.h | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/cmd/ubi.c b/cmd/ubi.c\nindex f75ceff11ee..8e3cfaaddbb 100644\n--- a/cmd/ubi.c\n+++ b/cmd/ubi.c\n@@ -505,7 +505,7 @@ int ubi_volume_write(const char *volume, const void *buf, loff_t offset,\n \treturn ret;\n }\n \n-int ubi_volume_read(const char *volume, char *buf, loff_t offset, size_t size)\n+int ubi_volume_read(const char *volume, void *buf, loff_t offset, size_t size)\n {\n \tint err, lnum, off, len, tbuf_size;\n \tvoid *tbuf;\n@@ -877,7 +877,7 @@ static int do_ubi(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])\n \t\t}\n \n \t\tif (argc == 3) {\n-\t\t\treturn ubi_volume_read(argv[3], (char *)addr, 0, size);\n+\t\t\treturn ubi_volume_read(argv[3], (void *)addr, 0, size);\n \t\t}\n \t}\n \ndiff --git a/env/ubi.c b/env/ubi.c\nindex e9865b45ebc..46970ba754f 100644\n--- a/env/ubi.c\n+++ b/env/ubi.c\n@@ -132,14 +132,14 @@ static int env_ubi_load(void)\n \t\treturn -EIO;\n \t}\n \n-\tread1_fail = ubi_volume_read(CONFIG_ENV_UBI_VOLUME, (void *)tmp_env1, 0,\n+\tread1_fail = ubi_volume_read(CONFIG_ENV_UBI_VOLUME, tmp_env1, 0,\n \t\t\t\t CONFIG_ENV_SIZE);\n \tif (read1_fail)\n \t\tprintf(\"\\n** Unable to read env from %s:%s **\\n\",\n \t\t CONFIG_ENV_UBI_PART, CONFIG_ENV_UBI_VOLUME);\n \n \tread2_fail = ubi_volume_read(CONFIG_ENV_UBI_VOLUME_REDUND,\n-\t\t\t\t (void *)tmp_env2, 0, CONFIG_ENV_SIZE);\n+\t\t\t\t tmp_env2, 0, CONFIG_ENV_SIZE);\n \tif (read2_fail)\n \t\tprintf(\"\\n** Unable to read redundant env from %s:%s **\\n\",\n \t\t CONFIG_ENV_UBI_PART, CONFIG_ENV_UBI_VOLUME_REDUND);\ndiff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\nindex a949d1b80dd..dd22ec7537a 100644\n--- a/include/ubi_uboot.h\n+++ b/include/ubi_uboot.h\n@@ -50,7 +50,7 @@ void ubi_exit(void);\n int ubi_part(const char *part_name, const char *vid_header_offset);\n int ubi_volume_write(const char *volume, const void *buf, loff_t offset,\n \t\t size_t size);\n-int ubi_volume_read(const char *volume, char *buf, loff_t offset, size_t size);\n+int ubi_volume_read(const char *volume, void *buf, loff_t offset, size_t size);\n \n extern struct ubi_device *ubi_devices[];\n int cmd_ubifs_mount(char *vol_name);\n","prefixes":["v3","03/10"]}