{"id":2228604,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228604/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260427061721.E775A4BAD171@sourceware.org/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260427061721.E775A4BAD171@sourceware.org>","date":"2026-04-27T06:16:53","name":"tree-optimization/125019 - fix ICE with recurrence vectorization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a3148f8acc0b7a58646223512badb5915b859655","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/1.1/people/4338/?format=json","name":"Richard Biener","email":"rguenther@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260427061721.E775A4BAD171@sourceware.org/mbox/","series":[{"id":501582,"url":"http://patchwork.ozlabs.org/api/1.1/series/501582/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501582","date":"2026-04-27T06:16:53","name":"tree-optimization/125019 - fix ICE with recurrence vectorization","version":1,"mbox":"http://patchwork.ozlabs.org/series/501582/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228604/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228604/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=cNy7abYJ;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=R0jYVHQ3;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=cNy7abYJ;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=R0jYVHQ3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=cNy7abYJ;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=R0jYVHQ3;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=cNy7abYJ;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=R0jYVHQ3","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","sourceware.org; spf=pass smtp.mailfrom=suse.de","server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.131","smtp-out2.suse.de;\n\tnone"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3tdd5gclz1yJX\n\tfor ; Mon, 27 Apr 2026 16:17:24 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id E775A4BAD171\n\tfor ; Mon, 27 Apr 2026 06:17:21 +0000 (GMT)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n by sourceware.org (Postfix) with ESMTPS id 4B0A54BAD16B\n for ; Mon, 27 Apr 2026 06:16:55 +0000 (GMT)","from murzim.nue2.suse.org (unknown [10.168.4.243])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 23E465BD00;\n Mon, 27 Apr 2026 06:16:54 +0000 (UTC)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org E775A4BAD171","OpenDKIM Filter v2.11.0 sourceware.org 4B0A54BAD16B"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 4B0A54BAD16B","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 4B0A54BAD16B","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777270615; cv=none;\n b=rjNs13NNwUQgtGqKEv7l7IpMU/7tiTF7n4u/NP9LuqDnPfcqRU43P6pKlQnBFFIcXwzwnmToCm5qhx5H25AEML7qujARZowkZBbOV4TZbsQmWYzaLxao6pxpg22eBsvBLZiJkIPZ7HJMCLEuocCiubbDV3LLiBPWJ4bKbyMEeIM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777270615; c=relaxed/simple;\n bh=ThML07xBv0wrNjlk1tvy0zhnwrhBMOGzbEyLSwOhTVA=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:MIME-Version;\n b=esfMknrxSd/LmMtZjy2HouyutxXznTfqPKKQHK9I2lhCRIZEhiXssZEiQRR7zL2CAxGzfooyZB6PlLQNJ8FaNxpJpBSl0qmX49KtNyEOQ2FK+3CZuJwFiGnXg6wGDTEMRlhXFfezvHQtA70eXjaeBAWc0BLE0jUKSUc58bkR8Cw=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777270614;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=w79+/zM3jTRSEiBxldIP06ctBKdu2p2MfFVud9bck3k=;\n b=cNy7abYJ2QHjFVmpo7A2fWynf9jotVk2PYSUto1mihmJgDR2cqj1r9rFAhZzZLlGXwXIqc\n JNbHLMRb8XFDE1NEtZeoKpT3PonRa0cHkVmkoeOb9+2gZ9N8G9N4lx4AwGeni14vsr3BJG\n gQBJV/r+2aGzymMEgT7a1qgku9lVXjw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777270614;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=w79+/zM3jTRSEiBxldIP06ctBKdu2p2MfFVud9bck3k=;\n b=R0jYVHQ3TDqz2WPoCy4Rz0Sd+D5NR7kRnmACLviu2ubSiUxWe60bhofkic+AQfbG+tIVLM\n 72CD4zBfoMHrMNAQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777270614;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=w79+/zM3jTRSEiBxldIP06ctBKdu2p2MfFVud9bck3k=;\n b=cNy7abYJ2QHjFVmpo7A2fWynf9jotVk2PYSUto1mihmJgDR2cqj1r9rFAhZzZLlGXwXIqc\n JNbHLMRb8XFDE1NEtZeoKpT3PonRa0cHkVmkoeOb9+2gZ9N8G9N4lx4AwGeni14vsr3BJG\n gQBJV/r+2aGzymMEgT7a1qgku9lVXjw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777270614;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=w79+/zM3jTRSEiBxldIP06ctBKdu2p2MfFVud9bck3k=;\n b=R0jYVHQ3TDqz2WPoCy4Rz0Sd+D5NR7kRnmACLviu2ubSiUxWe60bhofkic+AQfbG+tIVLM\n 72CD4zBfoMHrMNAQ=="],"Date":"Mon, 27 Apr 2026 08:16:53 +0200 (CEST)","From":"Richard Biener ","To":"gcc-patches@gcc.gnu.org","cc":"Jakub Jelinek ","Subject":"[PATCH] tree-optimization/125019 - fix ICE with recurrence\n vectorization","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","X-Spamd-Result":"default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MISSING_XM_UA(0.00)[]; FROM_HAS_DN(0.00)[];\n MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0];\n RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[tree-vect-loop.cc:url,\n murzim.nue2.suse.org:helo]","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org","Message-Id":"<20260427061721.E775A4BAD171@sourceware.org>"},"content":"This fixes an oversight with the PR124677 fix.\n\nBootstrapped and tested on x86_64-unknown-linux-gnu, pushed to trunk.\n\nOK for 16 branch?\n\nThanks,\nRichard.\n\n\tPR tree-optimization/125019\n\t* tree-vect-loop.cc (vectorizable_recurr): Properly guard\n\tagainst hitting last stmt when searching for the insertion\n\tplace.\n\n\t* gcc.dg/pr125019.c: New testcase.\n---\n gcc/testsuite/gcc.dg/pr125019.c | 12 ++++++++++++\n gcc/tree-vect-loop.cc | 2 +-\n 2 files changed, 13 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/gcc.dg/pr125019.c","diff":"diff --git a/gcc/testsuite/gcc.dg/pr125019.c b/gcc/testsuite/gcc.dg/pr125019.c\nnew file mode 100644\nindex 00000000000..0cdb5906de7\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/pr125019.c\n@@ -0,0 +1,12 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O3 -fno-vect-cost-model -fno-tree-dce -fno-tree-pre\" } */\n+\n+int a, b, c, d;\n+void e(unsigned f) {\n+ for (c = 0; c < 2; c++) {\n+ b = d;\n+ d = f;\n+ for (a = 0; a < 2; a++)\n+ ;\n+ }\n+}\ndiff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc\nindex 05abc04fc54..ca200dc14da 100644\n--- a/gcc/tree-vect-loop.cc\n+++ b/gcc/tree-vect-loop.cc\n@@ -8862,7 +8862,7 @@ vectorizable_recurr (loop_vec_info loop_vinfo, stmt_vec_info stmt_info,\n }\n /* Skip inserted vectorized stmts for the latch definition. We have to\n insert after those. */\n- while (gimple_uid (gsi_stmt (gsi2)) == 0);\n+ while (gsi_stmt (gsi2) && gimple_uid (gsi_stmt (gsi2)) == 0);\n \n for (unsigned i = 0; i < ncopies; ++i)\n {\n","prefixes":[]}