{"id":2228493,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228493/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/5788c76c1ee122a3ed00189e88dcf9df1fba226c.1777214801.git.lucien.xin@gmail.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<5788c76c1ee122a3ed00189e88dcf9df1fba226c.1777214801.git.lucien.xin@gmail.com>","date":"2026-04-26T14:46:41","name":"[net,v2,2/2] sctp: discard stale INIT after handshake completion","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":true,"hash":"5c92dcc9c3ed88b26465a4aeabc8cdb448abace9","submitter":{"id":61073,"url":"http://patchwork.ozlabs.org/api/1.1/people/61073/?format=json","name":"Xin Long","email":"lucien.xin@gmail.com"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/1.1/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/5788c76c1ee122a3ed00189e88dcf9df1fba226c.1777214801.git.lucien.xin@gmail.com/mbox/","series":[{"id":501540,"url":"http://patchwork.ozlabs.org/api/1.1/series/501540/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501540","date":"2026-04-26T14:46:39","name":"sctp: fix a vtag verification failure caused by stale INITs","version":2,"mbox":"http://patchwork.ozlabs.org/series/501540/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228493/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228493/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=NenE3BRc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12201-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"NenE3BRc\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.219.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3V2s2lJ9z1y2d\n\tfor ; Mon, 27 Apr 2026 00:49:25 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 763133003BF9\n\tfor ; Sun, 26 Apr 2026 14:49:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4787E33D4F0;\n\tSun, 26 Apr 2026 14:49:03 +0000 (UTC)","from mail-qv1-f50.google.com (mail-qv1-f50.google.com\n [209.85.219.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E0FD23507C\n\tfor ; Sun, 26 Apr 2026 14:49:01 +0000 (UTC)","by mail-qv1-f50.google.com with SMTP id\n 6a1803df08f44-8acae26e564so113142676d6.2\n for ;\n Sun, 26 Apr 2026 07:49:01 -0700 (PDT)","from wsfd-netdev58.anl.eng.rdu2.dc.redhat.com ([66.187.232.140])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02aebc655sm232579146d6.48.2026.04.26.07.48.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 07:48:59 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777214942; cv=none;\n b=Ko+qj0NJYK1DDi95y36k9g/WyZS3JuaTynt1LJc3CQ82ZG9icRuqiXCC2rRQ1AwwkVEVmEJYckFVk6/THWNKtxwORfSUwyx7J6SnN7FPO/f6ogC/zAI9tNCE+jGuvOxx+qWyMuGF08n4uTLqebbxXjvS+mFB0b/3boDVYMDx4GY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777214942; c=relaxed/simple;\n\tbh=vsm/Vin6fhEHMK5Rg/gfXmdGW6NjOiPfcld3a7a7Zqo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=GJnWuwQLrcF90zBPGcHXWcu2NoqPkFOZIKCynJPEWo9KfDzaeDm+fxYhVtLHnZVClqkvAXmX+KlrhSAjZHKuWmZX4OelO3U0sNtJd6mY9dc4rNgT8cEcPaBaHXAB6Nkh9DmUkdiytlo7PikI6CQzjSZvnm44nMd+9gri/KLTIkY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=NenE3BRc; arc=none smtp.client-ip=209.85.219.50","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777214941; x=1777819741;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZLYe3X7mIdfpi7a+4xLOp68gaR+hsDkG8LtdUaDQjF4=;\n b=NenE3BRcLW34Jayeyr81Rdt1Zunk2n3OcSKDbKUkSndZ0irM9vsWGeFB2cTG+SK39g\n f2ZRdW8UlOO/tGmmespooz6WOSBI1CBQoYWX6oLnkpqeEQDp3hcU3LwsU1RNTpd1nI7o\n /WNuy3zwMo751bQ3AJW7Ij0y8BrNIT0M+Js8Thf89EX03zHW3f0+CLdB9/yweyKi7m0g\n vcByteO/ISTpDr+pQcDLCovC6WC3LJBMdP8s0IgY2ic+pJg6DowPYqoL60Oyt4qSd3By\n 1AiR1DnQuGNNmmHfmtw55B5QLnq8xQx3vMqTQBjEd7M3mn8C4pJsQ7bXphAUzPtcv88g\n rE+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777214941; x=1777819741;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZLYe3X7mIdfpi7a+4xLOp68gaR+hsDkG8LtdUaDQjF4=;\n b=j1UTOfyFMGwFA+SnzktoYHsHxtbVCNB0aSieYAONvb6QTOD9/38jvb3QT53grqsfnL\n dBaX1zQM/8ymbg8eq/DK3djtJ871iCguprV1g+BgLxnOyIGr/CyIv6o9LE53ESShTtb8\n NohlxItjWeJyVr2zaQ3I2SFQ09AlmYxtTmjBReK2r8clKQdrkVrlF0tuOkm09fi+oGdi\n jTK0BAnzOFuJSGA6WjchuiFFO0p9VdjEuQjzLFIIa0POXkuVje3b2QOxXF9Q8d7+eKky\n IOqa5iIf/mQEbQ7AxcZDvHK/dd07t5eGCxfJQYcxRBicPKLo0qCKn9X7FFTK5NEzeAbA\n u49Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/bbXbIPbWwJBfO5nZMV66jbXN24BH7EKvlSppHjJdNz/33NxiZStS2fVrDp+j2oi9aCrzHL5/wSD4AyHVQb28=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzNo3p6FpYXP+cTjPulIgXX5Pj+9Ff5pzLM+S6N/tmHukr5aGI5\n\tBkl8vwpciF/mNyQcKCabCnwtxNrCiQ5amrsMA8qI+B33VJozgzb1L1XG","X-Gm-Gg":"AeBDieuv+2PxMK78LaAfqJu3hVYZZFoHPXL0Sw7RtNV8DRKd9pTdToKtTwP84Fd2eya\n\tY0+f3E/j991RWmJbaIJYJkflRKXfI8cTuowtJpUnsjJNaDSwoxsyPS7GFjxyrMSYxSiZh0Vbd+/\n\t8ojiZo8CPsGowrWnTndo6tzpNAQu4+4VTtW9AmCj3KOBAXicxeqHRWQSQ4EJ3X/eq0Sje9fRdob\n\tsKlA0fNVRPKpGKedjdhaiAQICq2IcRWkUnVgfJ/uAT+LYbevZm5Gn9fJbnDDSgQyhDtCiLLE8Fj\n\tmCXsiIbsnUHUJHfIanPxYV4VUOadnW/cTiI0FoRBl02VAQgNl34stTaZzQM7HpnzGO/m/cx2m2v\n\t7pIyl7e/pSg5M9xm0T/k6I9HQAjD5nIvjcckTSioiX3OefAg8n7Gk13KpjCIZVxF5c0LZDihV+z\n\tz2sSbgqfkzEcca8TpzUGp21RPu2UEiEOweL3R7k+FXq1VpDYHhK77bRrYvqbhlSw8DtQoJhHEcH\n\tNvyVhLPTDc0TYzoLdfRWqoRzf7kAlUj6P72IcCfVg1wBTpyL+tX0BWghqKMVVHev1CBU4iTkqk=","X-Received":"by 2002:ad4:5bef:0:b0:8ac:ae21:46e with SMTP id\n 6a1803df08f44-8b03a1885ecmr509647676d6.31.1777214940620;\n Sun, 26 Apr 2026 07:49:00 -0700 (PDT)","From":"Xin Long ","To":"network dev ,\n\tnetfilter-devel@vger.kernel.org,\n\tlinux-sctp@vger.kernel.org","Cc":"davem@davemloft.net,\n\tkuba@kernel.org,\n\tEric Dumazet ,\n\tPaolo Abeni ,\n\tSimon Horman ,\n\tPablo Neira Ayuso ,\n\tFlorian Westphal ,\n\tPhil Sutter ,\n\tMarcelo Ricardo Leitner ,\n\tYi Chen ","Subject":"[PATCH net v2 2/2] sctp: discard stale INIT after handshake\n completion","Date":"Sun, 26 Apr 2026 10:46:41 -0400","Message-ID":"\n <5788c76c1ee122a3ed00189e88dcf9df1fba226c.1777214801.git.lucien.xin@gmail.com>","X-Mailer":"git-send-email 2.47.1","In-Reply-To":"","References":"","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"After an association reaches ESTABLISHED, the peer’s init_tag is already\nknown from the handshake. Any subsequent INIT with the same init_tag is\nnot a valid restart, but a delayed or duplicate INIT.\n\nDrop such INIT chunks in sctp_sf_do_unexpected_init() instead of\nprocessing them as new association attempts.\n\nFixes: 1da177e4c3f4 (\"Linux-2.6.12-rc2\")\nSigned-off-by: Xin Long \nAcked-by: Marcelo Ricardo Leitner \n---\nv2:\n - Fix INIT tag comparison by converting the on-wire init_tag to host byte\n order before comparing it with asoc->peer.i.init_tag.\n---\n net/sctp/sm_statefuns.c | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c\nindex 7b823d759141..8e89a870780c 100644\n--- a/net/sctp/sm_statefuns.c\n+++ b/net/sctp/sm_statefuns.c\n@@ -1556,6 +1556,12 @@ static enum sctp_disposition sctp_sf_do_unexpected_init(\n \t/* Tag the variable length parameters. */\n \tchunk->param_hdr.v = skb_pull(chunk->skb, sizeof(struct sctp_inithdr));\n \n+\tif (asoc->state >= SCTP_STATE_ESTABLISHED) {\n+\t\t/* Discard INIT matching peer vtag after handshake completion (stale INIT). */\n+\t\tif (ntohl(chunk->subh.init_hdr->init_tag) == asoc->peer.i.init_tag)\n+\t\t\treturn sctp_sf_pdiscard(net, ep, asoc, type, arg, commands);\n+\t}\n+\n \t/* Verify the INIT chunk before processing it. */\n \terr_chunk = NULL;\n \tif (!sctp_verify_init(net, ep, asoc, chunk->chunk_hdr->type,\n","prefixes":["net","v2","2/2"]}