{"id":2228491,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228491/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/ee56c3e416452b2a40589a2a85245ac2ad5e9f4b.1777214801.git.lucien.xin@gmail.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"","date":"2026-04-26T14:46:40","name":"[net,v2,1/2] netfilter: skip recording stale or retransmitted INIT","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":true,"hash":"0eb2264699201e2d907a422737610b296e2dec02","submitter":{"id":61073,"url":"http://patchwork.ozlabs.org/api/1.1/people/61073/?format=json","name":"Xin Long","email":"lucien.xin@gmail.com"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/1.1/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/ee56c3e416452b2a40589a2a85245ac2ad5e9f4b.1777214801.git.lucien.xin@gmail.com/mbox/","series":[{"id":501540,"url":"http://patchwork.ozlabs.org/api/1.1/series/501540/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501540","date":"2026-04-26T14:46:39","name":"sctp: fix a vtag verification failure caused by stale INITs","version":2,"mbox":"http://patchwork.ozlabs.org/series/501540/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228491/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228491/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=drDRW9oD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12200-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"drDRW9oD\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.219.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3V2n5tq8z1y2d\n\tfor ; Mon, 27 Apr 2026 00:49:21 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 2697B300FB56\n\tfor ; Sun, 26 Apr 2026 14:49:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7AF98367F33;\n\tSun, 26 Apr 2026 14:49:01 +0000 (UTC)","from mail-qv1-f47.google.com (mail-qv1-f47.google.com\n [209.85.219.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CADCA23507C\n\tfor ; Sun, 26 Apr 2026 14:48:59 +0000 (UTC)","by mail-qv1-f47.google.com with SMTP id\n 6a1803df08f44-8a48deebe95so73244616d6.0\n for ;\n Sun, 26 Apr 2026 07:48:59 -0700 (PDT)","from wsfd-netdev58.anl.eng.rdu2.dc.redhat.com ([66.187.232.140])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02aebc655sm232579146d6.48.2026.04.26.07.48.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 07:48:57 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777214941; cv=none;\n b=r6LW+HR7yuMxbpR3AKMCEeSKIL5/M+k9hVgDPlriIVyXhES40YJmoJbYajkligNiWIN8qOs5k81ewzgy9bb3BQwZEKGQbOehdYegXKQPoKutqWKzD+ld4aTwkr+r+ph538DMNCKmzlm3PHaVmvziDT//oYL9q9OZCmA3e927v54=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777214941; c=relaxed/simple;\n\tbh=EzaF9ukZm+IAKve3Rcdx43rJkgsEruseuaZXvOJfxUQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=aSOPoLr/FZYMy4n6J4j//Bblcu7FxNfaD2PBIfmZ5UtQFyG7RBxyVxgKvvi6Q42MsLNaUlfDrOyFeHJNHIUaiZb/u0AexQvZLjBZ9LfANFMExXizppAviciE6F/Tnya0QtyH+210DOq0r5GuKYJVduOix4K1xzxM08/KYaeOaeg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=drDRW9oD; arc=none smtp.client-ip=209.85.219.47","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777214939; x=1777819739;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pagQ43wFSn3iS5OfTh2ag4EpAzA+S21IQdQp4DAN0tc=;\n b=drDRW9oDKstVlaxXvZmK7xt0hNw0a+hWj1qkNKcTFwMMcBlivtzWqtXDFHf0fcpr8U\n Jium+jf3yPX1QcY1TGs9u9XBni6BmJeQJk10fGoZdtJQSg0+hxXuwU4DPS5CL9S7jDWh\n KkflcSraz8MADhna7IscqciRiJUSLDDNsNRKWFMOtSDxfQAelGM0Y/XpFqRnQut2sDtF\n TEBhq4je2/DXQpy8vvelvtroAQ1Fso2P9cmqQL6XZ0I/Wg7mb+GbQ43SF1eN+C057Tx1\n 6S9QE18KAIOkfHJup+ksoRGDBPlKrKDSrXCju+YoSRfWZxXCrP6Dm30G6q4sEleLcefs\n bmbA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777214939; x=1777819739;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pagQ43wFSn3iS5OfTh2ag4EpAzA+S21IQdQp4DAN0tc=;\n b=iuso+uOrIBpU8u+GUK8GBcb+0xsOL+rbToVZOsVEIXflqiXWv2d0ZDSTvYZq35tea2\n /R6OPufJkdu/gKdce2uAelTJ1CGvaL/MIeX80x6hvaVCndYtx/hP+hKLvnxJwHlFKCm+\n PARW5gWg8PTBQmzPm1KDWfG+luW3B7QbhrOFxLt9icV30RYsiDSIAW0yV268ElRv0Gqg\n ny/Tg28dHAxzDkv7iF4laYnlOVbZ/5vrowe5wc0CJ9H1cABkBikgcJeYx0SK4QBaX0N6\n 4Ng7pT1jOrzNqyon22LKixLze5IJaCM6nVPKzWPsRygr+V/GwT24y9gdZIAaTwmvSdwx\n kVSQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9M71SZ0mPRLGR9/4PkAj8t8JP8yW9BWULRnfFn6hAV2WOoFXYQkHdJ5LnWUT3GSsmV+LaoLmJj8wIuuX3tF8I=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yz78Ld54p9WjvCQbRTqUObzPL9UDq9Bi0qiZhbhtLAnsHn4eGat\n\tuPs1oibHt2/K5beqcVA+6jOIszhOfhOGh5xOZSy235aG2O5uEbXfKf2a","X-Gm-Gg":"AeBDies3emhuUxZS2KIdEcNIjxUgL024RKUrHWNLzQyoMlHJouI6im+8KShpSOmxFEU\n\t8/h4loI0ll90FVYgeSvaipp/qGkivy9jnzfu1UCqnRg1IynGIMfMXQXrCsxlU9DTNAKXfFkbMO1\n\txanhTreMLbr6Ql1F2U/3XBq2Kb4v//eANG+5UZKEP4IiujR/dct/FJ1xT6yuBdItML/xCVcVGIO\n\tJnAOHo23hhu9OJpxhxe8h0lC4LWCyTSONsi7Y7pYBIfKWAysnMbIM8yV5nQcYTWeAbUjEwbZ0QU\n\teMHSTsBauvF2WJ3XdXaLVVM9bS577wmCUo5MLjWogm0HdSwbhTppSFrPoyi1l0wNEesiXTFzdeM\n\tXcIUxOJGX5qlZ5Li8YRPYqjoxdaJvAGd6xwFcMCg7654TaPrj7D5EGzjGyX7FZH+wa0jHQAchd2\n\tncFOHKmd75jIw/m77ckCMhmH90fTo5MWcOzwipEvbtjTqKPEM6A8DNN1ZlubGvNvanASiXfXa0I\n\t1vczON9UBtMHFfFp1r4PBGGV3m/n8yWgdturv2EspNJAyzrKKQH05ue1th/YZvQxV1ORvvga1s=","X-Received":"by 2002:a05:6214:43c8:b0:8ac:b1ad:3a1f with SMTP id\n 6a1803df08f44-8b0281108f1mr602566766d6.35.1777214938809;\n Sun, 26 Apr 2026 07:48:58 -0700 (PDT)","From":"Xin Long ","To":"network dev ,\n\tnetfilter-devel@vger.kernel.org,\n\tlinux-sctp@vger.kernel.org","Cc":"davem@davemloft.net,\n\tkuba@kernel.org,\n\tEric Dumazet ,\n\tPaolo Abeni ,\n\tSimon Horman ,\n\tPablo Neira Ayuso ,\n\tFlorian Westphal ,\n\tPhil Sutter ,\n\tMarcelo Ricardo Leitner ,\n\tYi Chen ","Subject":"[PATCH net v2 1/2] netfilter: skip recording stale or retransmitted\n INIT","Date":"Sun, 26 Apr 2026 10:46:40 -0400","Message-ID":"\n ","X-Mailer":"git-send-email 2.47.1","In-Reply-To":"","References":"","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"An INIT whose init_tag matches the peer's vtag does not provide new state\ninformation. It indicates either:\n\n- a stale INIT (after INIT-ACK has already been seen on the same side), or\n- a retransmitted INIT (after INIT has already been recorded on the same\n side).\n\nIn both cases, the INIT must not update ct->proto.sctp.init[] state, since\nit does not advance the handshake tracking and may otherwise corrupt\nINIT/INIT-ACK validation logic.\n\nAllow INIT processing only when the conntrack entry is newly created\n(SCTP_CONNTRACK_NONE), or when the init_tag differs from the stored peer\nvtag.\n\nNote it skips the check for the ct with old_state SCTP_CONNTRACK_NONE in\nnf_conntrack_sctp_packet(), as it is just created in sctp_new() where it\nset ct->proto.sctp.vtag[IP_CT_DIR_REPLY] = ih->init_tag.\n\nFixes: 9fb9cbb1082d (\"[NETFILTER]: Add nf_conntrack subsystem.\")\nSigned-off-by: Xin Long \nReviewed-by: Marcelo Ricardo Leitner \nAcked-by: Florian Westphal \n---\n net/netfilter/nf_conntrack_proto_sctp.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c\nindex 645d2c43ebf7..7e10fa65cbdd 100644\n--- a/net/netfilter/nf_conntrack_proto_sctp.c\n+++ b/net/netfilter/nf_conntrack_proto_sctp.c\n@@ -466,9 +466,13 @@ int nf_conntrack_sctp_packet(struct nf_conn *ct,\n \t\t\tif (!ih)\n \t\t\t\tgoto out_unlock;\n \n-\t\t\tif (ct->proto.sctp.init[dir] && ct->proto.sctp.init[!dir])\n-\t\t\t\tct->proto.sctp.init[!dir] = 0;\n-\t\t\tct->proto.sctp.init[dir] = 1;\n+\t\t\t/* Do not record INIT matching peer vtag (stale or retransmitted INIT). */\n+\t\t\tif (old_state == SCTP_CONNTRACK_NONE ||\n+\t\t\t ct->proto.sctp.vtag[!dir] != ih->init_tag) {\n+\t\t\t\tif (ct->proto.sctp.init[dir] && ct->proto.sctp.init[!dir])\n+\t\t\t\t\tct->proto.sctp.init[!dir] = 0;\n+\t\t\t\tct->proto.sctp.init[dir] = 1;\n+\t\t\t}\n \n \t\t\tpr_debug(\"Setting vtag %x for dir %d\\n\", ih->init_tag, !dir);\n \t\t\tct->proto.sctp.vtag[!dir] = ih->init_tag;\n","prefixes":["net","v2","1/2"]}