{"id":2228473,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228473/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-39-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-39-richard.henderson@linaro.org>","date":"2026-04-26T13:39:15","name":"[38/84] fpu: Return struct from float16_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5bba9fb279ca716c310e8ecbe238cd7f1ae595ee","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-39-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228473/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228473/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=tgeS1dxk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Std4xz9z1xvV\n\tfor ; Sun, 26 Apr 2026 23:57:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGzkf-0001CW-8m; Sun, 26 Apr 2026 09:42:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGzk9-0000Ku-2P\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:54 -0400","from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzk5-0000Nk-CX\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:52 -0400","by mail-pl1-x633.google.com with SMTP id\n d9443c01a7336-2ab077e3f32so39831975ad.3\n for ; Sun, 26 Apr 2026 06:41:48 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.41.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:41:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210908; x=1777815708; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=aS1gs1RvelZlceNbvZcAlxYN3xyEvlj7p2J5cTIwkbw=;\n b=tgeS1dxk7z7N9j9HjL1KYoIIokjc0MK+P8MEotSU3ITeOq7GpVMZtVswJk+uq1B2c1\n zqq6lJeTGGUxmjg371/JUC2QOIVNUgSX/48CQb4gahn7/dCaa+nAMaxY4Z7kNieRU3gN\n 2CxCq2wpL1ldES3g79OCRkMpzKefEh2cqqrlsnuh4vGWQyuQMUXy88u0cdY2IU2VSJP5\n AnLSM0d7YkJTz/HZiFEgcrtR0P12J4WmHBYEDRTqhi1hMVYGHYC1i6lD3Hc6+LNeqvG4\n TzAGomMC2bpWIJGHKPj46O5yamChTRt/0uPplji69JYz96y3jdBipmsyqXbJEaytnaxe\n JF7A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210908; x=1777815708;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=aS1gs1RvelZlceNbvZcAlxYN3xyEvlj7p2J5cTIwkbw=;\n b=gl8BUBdZJ9ve415OENt1fFySuknA/Diule1f1jAA/biPYGBc9w9nGYLErDch7epyVd\n EaKZouNuJoWD86IbKOqmAgOpN1G4QVSkYMhRxLEGQviBcKTtSHRabrCmgkWgq3OFgRGH\n wSU+Ku1X1qCJSZrAVgKNxrsDUCwOG6FsNaVUzfz58XQGJWcPPJwL8yrs+214VoBdtHUb\n H1SgpSnFXUBWfeWABGeUJh0R4b38O4ECNszXayAKXTp7ffZVEl1TtH1hXtMWNI58M302\n 1TjTTqlh/ZZ+c3Sx7tZ5K+ffg5RWLuXvliVRk1O9gNKRGR3KeDXJA6uGTk6F+zxCW3P2\n V/5w==","X-Gm-Message-State":"AOJu0Yw/csjUIlj3CZAqLf94nZK/UvRKPt3h0w7ast5p5XnfdAsbOm9u\n 4fM+YsXIH+mr3g9o9wtB6NqusQlufEzyU7cji1ISRQ5BjE/zjJ1+FtibLnbZvIfHXk6aQh/wVIM\n lbHxzHjI=","X-Gm-Gg":"AeBDiesNR+QrdH/PQO2ThAyr1MdFXDaWnzGjXFezW780VkCNr1xXL0dlYMBCv5kPU5c\n YzShfw9ob8Lw1pNamaUgtpX1sBsO9nosW1YUBTPkwwizlg66Rd8I8qP9X4luUAOyGOf/m+nUXBz\n M61EtHU1Ct5/joj5BKyhxzvwtViZpEy6vb0bZcqbn2Ers8q5Es8wsZYPMrbwiLWcChHQVUm7kxB\n wP+4oLUIMBy83Yv9QXFe/CAvXS9GtubAbCLS4h1qX8JwSGhzcXhOhNFdKX3/hygaW0MfVPeYks+\n He1To+jIOzqLOQNYfSPe2+gzdsgqjrK1gHFrD1Rfky0Ms5FeAgLR1nTui/VDbOt7xkrdJ53ZXJT\n P9V9Xo4qMySPx7eRzDyWcWHiE7zoXGW/L/IcOUZR8dhCEyVB95OSWRuqRN6TAaVElMwE3RIrVqH\n w0jMTkN1r+sPqK0ZJbvNGXBARlbI3+J/cWEk99YX4d","X-Received":"by 2002:a17:903:384c:b0:2b0:7e4d:f390 with SMTP id\n d9443c01a7336-2b5f9fb1b9cmr382189115ad.41.1777210907946;\n Sun, 26 Apr 2026 06:41:47 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 38/84] fpu: Return struct from float16_unpack_canonical","Date":"Sun, 26 Apr 2026 23:39:15 +1000","Message-ID":"<20260426134002.865628-39-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::633;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Richard Henderson \n---\n fpu/softfloat.c | 94 +++++++++++++++++--------------------------------\n 1 file changed, 32 insertions(+), 62 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex dee5dcd0d2..3612d2fceb 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -1482,10 +1482,9 @@ static FloatParts64 float16a_unpack_canonical(float16 f, float_status *s,\n return p;\n }\n \n-static void float16_unpack_canonical(FloatParts64 *p, float16 f,\n- float_status *s)\n+static FloatParts64 float16_unpack_canonical(float16 f, float_status *s)\n {\n- *p = float16a_unpack_canonical(f, s, &float16_params);\n+ return float16a_unpack_canonical(f, s, &float16_params);\n }\n \n static void bfloat16_unpack_canonical(FloatParts64 *p, bfloat16 f,\n@@ -1718,11 +1717,9 @@ static floatx80 floatx80_round_pack_canonical(FloatParts128 *p,\n static float16 QEMU_FLATTEN\n float16_addsub(float16 a, float16 b, float_status *status, bool subtract)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- float16_unpack_canonical(&pa, a, status);\n- float16_unpack_canonical(&pb, b, status);\n- pr = parts64_addsub(&pa, &pb, status, subtract);\n+ FloatParts64 pa = float16_unpack_canonical(a, status);\n+ FloatParts64 pb = float16_unpack_canonical(b, status);\n+ FloatParts64 *pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float16_round_pack_canonical(pr, status);\n }\n@@ -1952,11 +1949,9 @@ floatx80 floatx80_sub(floatx80 a, floatx80 b, float_status *status)\n \n float16 QEMU_FLATTEN float16_mul(float16 a, float16 b, float_status *status)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- float16_unpack_canonical(&pa, a, status);\n- float16_unpack_canonical(&pb, b, status);\n- pr = parts64_mul(&pa, &pb, status);\n+ FloatParts64 pa = float16_unpack_canonical(a, status);\n+ FloatParts64 pb = float16_unpack_canonical(b, status);\n+ FloatParts64 *pr = parts64_mul(&pa, &pb, status);\n \n return float16_round_pack_canonical(pr, status);\n }\n@@ -2066,12 +2061,11 @@ float16 QEMU_FLATTEN\n float16_muladd_scalbn(float16 a, float16 b, float16 c,\n int scale, int flags, float_status *status)\n {\n- FloatParts64 pa, pb, pc, *pr;\n-\n- float16_unpack_canonical(&pa, a, status);\n- float16_unpack_canonical(&pb, b, status);\n- float16_unpack_canonical(&pc, c, status);\n- pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n+ FloatParts64 pa = float16_unpack_canonical(a, status);\n+ FloatParts64 pb = float16_unpack_canonical(b, status);\n+ FloatParts64 pc = float16_unpack_canonical(c, status);\n+ FloatParts64 *pr =\n+ parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n /* Round before applying negate result. */\n parts64_uncanon(pr, status, &float16_params, false);\n@@ -2326,11 +2320,9 @@ float128 QEMU_FLATTEN float128_muladd(float128 a, float128 b, float128 c,\n \n float16 float16_div(float16 a, float16 b, float_status *status)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- float16_unpack_canonical(&pa, a, status);\n- float16_unpack_canonical(&pb, b, status);\n- pr = parts64_div(&pa, &pb, status);\n+ FloatParts64 pa = float16_unpack_canonical(a, status);\n+ FloatParts64 pb = float16_unpack_canonical(b, status);\n+ FloatParts64 *pr = parts64_div(&pa, &pb, status);\n \n return float16_round_pack_canonical(pr, status);\n }\n@@ -2969,9 +2961,8 @@ floatx80 float128_to_floatx80(float128 a, float_status *s)\n \n float16 float16_round_to_int(float16 a, float_status *s)\n {\n- FloatParts64 p;\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n \n- float16_unpack_canonical(&p, a, s);\n parts64_round_to_int(&p, s->float_rounding_mode, 0, s, &float16_params);\n return float16_round_pack_canonical(&p, s);\n }\n@@ -3032,36 +3023,28 @@ floatx80 floatx80_round_to_int(floatx80 a, float_status *status)\n int8_t float16_to_int8_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s);\n }\n \n int16_t float16_to_int16_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t float16_to_int32_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t float16_to_int64_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n@@ -3530,36 +3513,28 @@ int64_t float64_to_int64_modulo(float64 a, FloatRoundMode rmode,\n uint8_t float16_to_uint8_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT8_MAX, s);\n }\n \n uint16_t float16_to_uint16_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT16_MAX, s);\n }\n \n uint32_t float16_to_uint32_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT32_MAX, s);\n }\n \n uint64_t float16_to_uint64_scalbn(float16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- float16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT64_MAX, s);\n }\n \n@@ -4316,11 +4291,9 @@ float128 uint128_to_float128(Int128 a, float_status *status)\n \n static float16 float16_minmax(float16 a, float16 b, float_status *s, int flags)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- float16_unpack_canonical(&pa, a, s);\n- float16_unpack_canonical(&pb, b, s);\n- pr = parts64_minmax(&pa, &pb, s, flags);\n+ FloatParts64 pa = float16_unpack_canonical(a, s);\n+ FloatParts64 pb = float16_unpack_canonical(b, s);\n+ FloatParts64 *pr = parts64_minmax(&pa, &pb, s, flags);\n \n return float16_round_pack_canonical(pr, s);\n }\n@@ -4401,10 +4374,9 @@ MINMAX_2(float128)\n static FloatRelation QEMU_FLATTEN\n float16_do_compare(float16 a, float16 b, float_status *s, bool is_quiet)\n {\n- FloatParts64 pa, pb;\n+ FloatParts64 pa = float16_unpack_canonical(a, s);\n+ FloatParts64 pb = float16_unpack_canonical(b, s);\n \n- float16_unpack_canonical(&pa, a, s);\n- float16_unpack_canonical(&pb, b, s);\n return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n@@ -4594,9 +4566,8 @@ FloatRelation floatx80_compare_quiet(floatx80 a, floatx80 b, float_status *s)\n \n float16 float16_scalbn(float16 a, int n, float_status *status)\n {\n- FloatParts64 p;\n+ FloatParts64 p = float16_unpack_canonical(a, status);\n \n- float16_unpack_canonical(&p, a, status);\n parts64_scalbn(&p, n, status);\n return float16_round_pack_canonical(&p, status);\n }\n@@ -4654,9 +4625,8 @@ floatx80 floatx80_scalbn(floatx80 a, int n, float_status *status)\n \n float16 QEMU_FLATTEN float16_sqrt(float16 a, float_status *status)\n {\n- FloatParts64 p;\n+ FloatParts64 p = float16_unpack_canonical(a, status);\n \n- float16_unpack_canonical(&p, a, status);\n parts64_sqrt(&p, status, &float16_params);\n return float16_round_pack_canonical(&p, status);\n }\n","prefixes":["38/84"]}