{"id":2228469,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228469/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-79-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-79-richard.henderson@linaro.org>","date":"2026-04-26T13:39:55","name":"[78/84] fpu: Hoist nan check in partsN_addsub","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0d247b04dadcf8ba044eaf97213d305336d94795","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-79-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228469/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228469/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pI195jRp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3StX51HYz1xvV\n\tfor ; Sun, 26 Apr 2026 23:57:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGzpf-0000P0-NV; Sun, 26 Apr 2026 09:47:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGzot-0006bv-V7\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:46:48 -0400","from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzop-0001sA-T5\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:46:46 -0400","by mail-pl1-x62c.google.com with SMTP id\n d9443c01a7336-2b4650d5f5cso35019985ad.0\n for ; Sun, 26 Apr 2026 06:46:43 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5faa34ea7sm280544085ad.34.2026.04.26.06.46.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:46:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777211202; x=1777816002; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VMfXr5S8cPMC+8Vry/EpCZiImkLfaNYbWDc+T09/bCA=;\n b=pI195jRpmUUasChWb3m7R/FBD9ddkE4CCll8Wtqt6b557kHvvT4W6Hna3bdg2bpdaL\n 8h9Dj92GfFhtY876DGxRY/x80gd5ZpWkeAR4VC0tmyvtA8BUP9ZTCgXLk9fCz9i4QPVH\n /7ybrBL2HAcUpsgWFk7aczC/7j2ory9hZ3MFKLCsvqxjC3DhW/PoBHCK+WitUzCX1LYp\n 5+hWiTzi6NGHx/fdo+XGnYSEQM4w8uFYM+JyayUixPbDs8XzQZBFKMWqE5qPSkiKngdJ\n 7n40mIZHIFYKMtfWBrvI8eLzSTfdP8FCFqWqWpa265cMNz50jCxAARTOlnyiJ3wplrNn\n +xiA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777211202; x=1777816002;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=VMfXr5S8cPMC+8Vry/EpCZiImkLfaNYbWDc+T09/bCA=;\n b=P5wRPFrCEqQn5F+OdpOQkTAfrz/A4Su2wgJpvGM5qNjwmtSNrZmZ+i0JscKIhfjEqI\n 246/k3sU+xkfLe+BQIMlaR0Z1brghkHRMYFL9y7EOev7uynSuAURyS4pd30pQ7Ebjd9D\n 82gujd4bq/Lhf4PTzHX8xxO5/FXOrUVUf0CusSFv2Gwm6Y4TwmKfcJc/yuZUva87o6X6\n PO086LcWHcs9R+KjrFHOQ5fYp44w0NAVFGp2qmo954zUJ3ZnsDkFl3dtGymB9AZfz3pf\n RBbXjwngwePtmUCnlYILwme3lnz1Wobon7TqbGVhIJDaA+pxukKqWSLhVLmZmNnbZk/m\n xycQ==","X-Gm-Message-State":"AOJu0YxA0FJcHSslvAmnsdWtZPWpq+Y9aIY24rQ0Piiy227ELY2lYuiT\n VZsD+BWNZmbzwU3as72GCyAtGP9RPrjCPPFq7Ee7OMQ/kdleLFHwXZJtrA/2G0oRQxdIHtV3E3c\n AOT3xhtw=","X-Gm-Gg":"AeBDieulIhYtl6/Svx8FIF+cADcNyDbofXwvfNigs2rYHtt25/N945BTYiHLGr1EXG4\n rdjJrmM1DcW2PVTfC96zyrvSyMYIc5iHfFafbTWMWmqvJSp3PcCKZh9IPaJaPqC52k3OOctPuHM\n 08qUQ8D+Bprou9+5emEVnBgaUC31zt0fVkpeqXqSfdptL3mrkfLJMVtGfjKDzkI+TuQ13Zeoc3l\n FBJLxUpcPwZ0offDSQLnWvu7PzmFzpVCR5o6QiWfLxS26E4x2Et7GCo817FAIH7XK5wXUOWhvfu\n SuF3x5u517Dwf3tfhJoCemHGSP2iDQ7U9+Rh5V5vghQMynFxReuKW9qtFoOlcYn8rNHeioaPMk2\n o3pZ2HF7KR8+kR8Dwa0pqbbi31jwl3brcsv0V5EnEgkHPhHO8flLqUlrIjhwWGeH0CG1gS1NxWR\n Q0dlJWl0HIFbmMHjjm9tiJbgketoBGWEciNqsv5sUP","X-Received":"by 2002:a17:903:3c24:b0:2b0:445a:8c7b with SMTP id\n d9443c01a7336-2b5f9edf973mr419506295ad.15.1777211202462;\n Sun, 26 Apr 2026 06:46:42 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 78/84] fpu: Hoist nan check in partsN_addsub","Date":"Sun, 26 Apr 2026 23:39:55 +1000","Message-ID":"<20260426134002.865628-79-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The nan test had been down below because it was unlikely.\nBut if we have to have one anyway because of denormals,\nwe might as well take care of them right away.\n\nSigned-off-by: Richard Henderson \n---\n fpu/softfloat-parts.c.inc | 21 ++++++---------------\n 1 file changed, 6 insertions(+), 15 deletions(-)","diff":"diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex dca751fb94..244fdd90d2 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -530,13 +530,16 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n bool b_sign = b->sign ^ subtract;\n int ab_mask = float_cmask(a->cls) | float_cmask(b->cls);\n \n+ if (unlikely(ab_mask & float_cmask_anynan)) {\n+ *a = partsN(pick_nan)(a, b, s);\n+ return a;\n+ }\n+\n /*\n * For addition and subtraction, we will consume an\n * input denormal unless the other input is a NaN.\n */\n- if (!(ab_mask & float_cmask_anynan)) {\n- record_denormals_used(ab_mask, s);\n- }\n+ record_denormals_used(ab_mask, s);\n \n if (a->sign != b_sign) {\n /* Subtraction */\n@@ -553,10 +556,6 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n return a;\n }\n \n- if (unlikely(ab_mask & float_cmask_anynan)) {\n- goto p_nan;\n- }\n-\n if (ab_mask & float_cmask_inf) {\n if (a->cls != float_class_inf) {\n /* N - Inf */\n@@ -582,10 +581,6 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n return a;\n }\n \n- if (unlikely(ab_mask & float_cmask_anynan)) {\n- goto p_nan;\n- }\n-\n if (ab_mask & float_cmask_inf) {\n a->cls = float_class_inf;\n return a;\n@@ -602,10 +597,6 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n return_b:\n b->sign = b_sign;\n return b;\n-\n- p_nan:\n- *a = partsN(pick_nan)(a, b, s);\n- return a;\n }\n \n /*\n","prefixes":["78/84"]}