{"id":2228465,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228465/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-26-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-26-richard.henderson@linaro.org>","date":"2026-04-26T13:39:02","name":"[25/84] fpu: Drop parts_compare","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"33d3c35b8760849816f1f223581df3e3b19c90ba","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-26-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228465/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228465/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gyZzasYr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Ss66VcZz1xvV\n\tfor ; Sun, 26 Apr 2026 23:55:54 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGzja-0007Zd-2u; Sun, 26 Apr 2026 09:41:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGzjZ-0007Z1-7D\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:17 -0400","from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzjX-0000Ak-Jl\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:16 -0400","by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2b7d3ecc10dso14931645ad.2\n for ; Sun, 26 Apr 2026 06:41:15 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.41.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:41:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210874; x=1777815674; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=APzXi2KVCIYa0t0D3NstU7yyhE+V3SOxwz+wKn9uFgg=;\n b=gyZzasYr5CTjm8ic4RLLBzQ40p3AmsG6AL1pB2yJpghKArI8ds5n9oAuwcH44YJauh\n mOb0h41DgYfKrM6VPudxGTJfNwAoGApsfJPOO2GxzkpHEf0RKUxCC2+vxW3HJsDHsPar\n 51/whs4VKQGLRwx/2DnoXDaAMaX+xvmAWg1GpFyDvVHCeYerPHnEDl0h/LJ8VSOg2Gq0\n +6q2+sOJec7W1OrxoyEa7R0gcW5dip5yrV1t1ikOOi9+Y0UmY4Gvg4OAykomB82LZP/Z\n rQ6CWUHTFK+9sT0btbqudJeE0Fl58rlUCQ6CKST32Tk5w7tJTfQmzdHzSdtIzLLuY7Wy\n I7pA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210874; x=1777815674;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=APzXi2KVCIYa0t0D3NstU7yyhE+V3SOxwz+wKn9uFgg=;\n b=OuEDZiIp9i/KtBbJtieLOwnaOmhUaftk18cTbIMnTDd8sAxE+fkl1t5d/kpLlJipTP\n qT0dv/WPLFhIJeBCwA7Uyv4QGlAaed7AQFZFHYitBcQjq0keNNkNgtzdGjhE1s6FCm3o\n DDsAiFkW76yY/vyNKAgML2Tsvhn26XS+z9KoqleZeeb69a4vYrqswVjXXLEcbZmy/1C+\n lLt3wTDNACEknzTg0IjeR6XiWMS3lfScSwv2iiDNkque00uaNfLRybhbdAzrj01/Vy4u\n Y6YCcyVR5g+hxPQhlswT/tpWyGTlmxkJrG6+53YnZQncIoEPovWn3hQn5PateqHDBrV7\n n1YA==","X-Gm-Message-State":"AOJu0Yw5crlBcWOsXQ1c6TDypuKhPDi/VAeaIJc/QXaj+fbOcdBSUThZ\n Cw0VnooFIBNCP4xC2B3TTxVUuUUnEd0/Ryl3jrpghkWfEh1vPIi94aWBgyuUEurwk1LUaIF8LHw\n csSuYWI0=","X-Gm-Gg":"AeBDietketqKbuSXlmuXLDt4h44/QBhg4mhFIFvjfXKKA69BZS9oH3GuzV5A5Nvjnj8\n Y1NLIRHAz790JBQbHumseIQ4Is9fURKyt8aMei4j6OZ4EMUinZwmX0H6+IQqbqdmqBU7SYK9xmK\n CCuEzNrIj6RSocdfAAg6ZsSV92qMFaxoiz3zPFncECNn7fOAqc8Oz5LpqxMhFh9SdJpF7vUH+o/\n 1b6W8+f/EKbqDLqPsjWIpHNvRmPPiAUuztXhD3l4BZxb3y4rOTLo5iTCmhKGR8bPK9xYwqYBYz9\n F6P2rb3gBsQucVnDfgjUVAI50M9UlmCjnRhhg+VF8wvtKYBxiGECjLpOIHNjMAeNv5MMFd9MuG9\n NGJzu3hWsSTgYMWs0SRJh5sEAlREOMHyktdwrAH6PrSFnFWYgrkEfQBzpaOGsszGMBF/4iD3+qH\n aCakzMaHZAdOXY7lSVkAkC0yb9XrAFAH1nf+9ooLyy","X-Received":"by 2002:a17:903:2283:b0:2b0:54dc:63e with SMTP id\n d9443c01a7336-2b5f9fadcd4mr427273585ad.33.1777210874209;\n Sun, 26 Apr 2026 06:41:14 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 25/84] fpu: Drop parts_compare","Date":"Sun, 26 Apr 2026 23:39:02 +1000","Message-ID":"<20260426134002.865628-26-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::629;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_compare at each call site.\n\nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 22 +++++++---------------\n 1 file changed, 7 insertions(+), 15 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 158d539376..3aebe4a058 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,14 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static FloatRelation parts64_compare(FloatParts64 *a, FloatParts64 *b,\n- float_status *s, bool q);\n-static FloatRelation parts128_compare(FloatParts128 *a, FloatParts128 *b,\n- float_status *s, bool q);\n-\n-#define parts_compare(A, B, S, Q) \\\n- PARTS_GENERIC_64_128(compare, A)(A, B, S, Q)\n-\n static void parts64_scalbn(FloatParts64 *a, int n, float_status *s);\n static void parts128_scalbn(FloatParts128 *a, int n, float_status *s);\n \n@@ -4494,7 +4486,7 @@ float16_do_compare(float16 a, float16 b, float_status *s, bool is_quiet)\n \n float16_unpack_canonical(&pa, a, s);\n float16_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation float16_compare(float16 a, float16 b, float_status *s)\n@@ -4514,7 +4506,7 @@ float32_do_compare(float32 a, float32 b, float_status *s, bool is_quiet)\n \n float32_unpack_canonical(&pa, a, s);\n float32_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n static FloatRelation QEMU_FLATTEN\n@@ -4568,7 +4560,7 @@ float64_do_compare(float64 a, float64 b, float_status *s, bool is_quiet)\n \n float64_unpack_canonical(&pa, a, s);\n float64_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n static FloatRelation QEMU_FLATTEN\n@@ -4622,7 +4614,7 @@ bfloat16_do_compare(bfloat16 a, bfloat16 b, float_status *s, bool is_quiet)\n \n bfloat16_unpack_canonical(&pa, a, s);\n bfloat16_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation bfloat16_compare(bfloat16 a, bfloat16 b, float_status *s)\n@@ -4642,7 +4634,7 @@ float128_do_compare(float128 a, float128 b, float_status *s, bool is_quiet)\n \n float128_unpack_canonical(&pa, a, s);\n float128_unpack_canonical(&pb, b, s);\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts128_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation float128_compare(float128 a, float128 b, float_status *s)\n@@ -4664,7 +4656,7 @@ floatx80_do_compare(floatx80 a, floatx80 b, float_status *s, bool is_quiet)\n !floatx80_unpack_canonical(&pb, b, s)) {\n return float_relation_unordered;\n }\n- return parts_compare(&pa, &pb, s, is_quiet);\n+ return parts128_compare(&pa, &pb, s, is_quiet);\n }\n \n FloatRelation floatx80_compare(floatx80 a, floatx80 b, float_status *s)\n@@ -5518,7 +5510,7 @@ static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b,\n saved_r_precise_sign = r_precise->sign;\n r->sign = false;\n r_precise->sign = false;\n- if (parts_compare(r, r_precise, status, true) <\n+ if (parts64_compare(r, r_precise, status, true) <\n float_relation_equal) {\n *dxc = 0x8;\n } else {\n","prefixes":["25/84"]}