{"id":2228457,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228457/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-41-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-41-richard.henderson@linaro.org>","date":"2026-04-26T13:39:17","name":"[40/84] fpu: Return struct from bfloat16_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"989e0f5891dc3f3c13d5c7781b80c0cbf643e94c","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-41-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228457/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228457/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=e6w9dCAC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Smg40Rlz1yHg\n\tfor ; Sun, 26 Apr 2026 23:52:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGznI-0005FL-S6; Sun, 26 Apr 2026 09:45:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGznC-0005CD-Cf\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:45:02 -0400","from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzn8-000107-R5\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:45:02 -0400","by mail-pl1-x636.google.com with SMTP id\n d9443c01a7336-2b2503753efso97400225ad.0\n for ; Sun, 26 Apr 2026 06:44:58 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5faa34ea7sm280544085ad.34.2026.04.26.06.44.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:44:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777211097; x=1777815897; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XRyWdsWWDBWhjEZurZCmmfQh5TH8x0OJuXWPwMpCiKw=;\n b=e6w9dCACOVfjK+FffcTQWYsde08GhMJCkv9wikHPM1hGClOhu1aKG1ObhJeyvl2KGt\n 2Ryz8IMeIA4saLlleYOgIPnKAeSRgv0s0eSsdfBH55zw4ax71MWt0gZt237GLJrrP6fw\n 9UJdRKYSKebSennIwKpNBYjh3DubcEriqYVfftM8b/tSjymvYccl6FrWUlY9C1KLyxKH\n l2TCAsFGaGza735B2F9vTIAhSqFB1rnETuTISALzUF3dLnCehycG1nxkIAe2F8EFToch\n 67/DVvtifeZFLoUM/YL/MvkE5myoSqHuMJSZQ8ytRH6m2KnDpyQM1HqZJ25JKTv/0a7b\n i3Pw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777211097; x=1777815897;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=XRyWdsWWDBWhjEZurZCmmfQh5TH8x0OJuXWPwMpCiKw=;\n b=SWP5y4sDxj11YbrsZeALA9CRoNsMAmOhfsU6XPRxqUjygpTJpLRcrzA0kvaAYd4aZq\n bQtlPa1i3Ul81vcFw/8PtOos7OlK/ahu1gTa8iqEnncrMe9tm4BYFmFVcjt3l7LSuhWJ\n ZDxI+RLCRie/+BgXPlboKZ2DqN8zZBoTaQ+AR+CxuskE4tqaI7krR04V03FV1jx6buSK\n B0/CDkB/kUullpbkdBf/SVk1QSIBxkjHbsux0G/1AemTV7DVOXyQa1rL7vFi5p5/ADic\n f0yivaAzYdGEq4H3CUNOeznBVcK4EUify8civ9Do/hGSxrX9fCdH3Oi8hUmkDm7TALfM\n 96Yg==","X-Gm-Message-State":"AOJu0YwXeAoK+d9kwQQpyhFpIpInEYwLb5uQsWLh6VnAFa+TiBaKnYt9\n ZsF9oE27qokkGlJcVYbuuJoamKOG7ZclUrwgEYsDHdQytEycfSAgFNI5a5+kO5TPf2HpzkJo0qp\n Xz9eZgy0=","X-Gm-Gg":"AeBDievOmGCRNenFB6/Chh9wd0btJVE0ScH2AOtppEj/Hjt+Wy/TT58beGqsL/Vb5Xz\n 1INBVJ2Ykb1K6BCeGY5Mf3Daf4P2vioSdSVaVa6m7VHj8FgAQd9O8tx2zDbnwOng2V0MKPXtyQf\n 32hIg05UDLnZJgcgGGc7wlX7RxJjgfUAKA1acWO99P5DVdtKaoY2JaSkmGgp93Bacl1foCAAI7b\n olysNPFKa/BJu/tA4Y/AH7rZCW/NpccN07oO03sMoTdHl4HydqfHgKxPX0M1aiSOYNoqcLk3EQg\n O01JaBHb6CF3OQyj/hYmqo4HQc3pJk5xaZQdvhXAJuyFIAhYyhF7SZu+Vict7JYCzW8tqrgBHsP\n /WCAjB9nWhyiWOHu1XmSTlKLrzIBhj2+Jt1f3Ue9xBrIx7pvnSBF6h2V955TYHt3KCFq1sp81mz\n w2LxSb0tLK30KDj56BuylNyE4I71bNO/XZexXvBHWU","X-Received":"by 2002:a17:903:17cb:b0:2b2:67cd:9963 with SMTP id\n d9443c01a7336-2b5f9fd5c04mr397208345ad.38.1777211097069;\n Sun, 26 Apr 2026 06:44:57 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 40/84] fpu: Return struct from bfloat16_unpack_canonical","Date":"Sun, 26 Apr 2026 23:39:17 +1000","Message-ID":"<20260426134002.865628-41-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::636;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Richard Henderson \n---\n fpu/softfloat.c | 108 +++++++++++++++++-------------------------------\n 1 file changed, 37 insertions(+), 71 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 566154a729..19cca8fb85 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -1482,11 +1482,11 @@ static FloatParts64 float16_unpack_canonical(float16 f, float_status *s)\n return float16a_unpack_canonical(f, s, &float16_params);\n }\n \n-static void bfloat16_unpack_canonical(FloatParts64 *p, bfloat16 f,\n- float_status *s)\n+static FloatParts64 bfloat16_unpack_canonical(bfloat16 f, float_status *s)\n {\n- *p = unpack_raw64(&bfloat16_params, f);\n- parts64_canonicalize(p, s, &bfloat16_params);\n+ FloatParts64 p = unpack_raw64(&bfloat16_params, f);\n+ parts64_canonicalize(&p, s, &bfloat16_params);\n+ return p;\n }\n \n static float8_e4m3 float8_e4m3_round_pack_canonical(FloatParts64 *p,\n@@ -1873,11 +1873,9 @@ float64 float64r32_sub(float64 a, float64 b, float_status *status)\n static bfloat16 QEMU_FLATTEN\n bfloat16_addsub(bfloat16 a, bfloat16 b, float_status *status, bool subtract)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- bfloat16_unpack_canonical(&pa, a, status);\n- bfloat16_unpack_canonical(&pb, b, status);\n- pr = parts64_addsub(&pa, &pb, status, subtract);\n+ FloatParts64 pa = bfloat16_unpack_canonical(a, status);\n+ FloatParts64 pb = bfloat16_unpack_canonical(b, status);\n+ FloatParts64 *pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return bfloat16_round_pack_canonical(pr, status);\n }\n@@ -2013,11 +2011,9 @@ float64 float64r32_mul(float64 a, float64 b, float_status *status)\n bfloat16 QEMU_FLATTEN\n bfloat16_mul(bfloat16 a, bfloat16 b, float_status *status)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- bfloat16_unpack_canonical(&pa, a, status);\n- bfloat16_unpack_canonical(&pb, b, status);\n- pr = parts64_mul(&pa, &pb, status);\n+ FloatParts64 pa = bfloat16_unpack_canonical(a, status);\n+ FloatParts64 pb = bfloat16_unpack_canonical(b, status);\n+ FloatParts64 *pr = parts64_mul(&pa, &pb, status);\n \n return bfloat16_round_pack_canonical(pr, status);\n }\n@@ -2276,12 +2272,10 @@ float64 float64r32_muladd(float64 a, float64 b, float64 c,\n bfloat16 QEMU_FLATTEN bfloat16_muladd(bfloat16 a, bfloat16 b, bfloat16 c,\n int flags, float_status *status)\n {\n- FloatParts64 pa, pb, pc, *pr;\n-\n- bfloat16_unpack_canonical(&pa, a, status);\n- bfloat16_unpack_canonical(&pb, b, status);\n- bfloat16_unpack_canonical(&pc, c, status);\n- pr = parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n+ FloatParts64 pa = bfloat16_unpack_canonical(a, status);\n+ FloatParts64 pb = bfloat16_unpack_canonical(b, status);\n+ FloatParts64 pc = bfloat16_unpack_canonical(c, status);\n+ FloatParts64 *pr = parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n parts64_uncanon(pr, status, &bfloat16_params, false);\n@@ -2418,11 +2412,9 @@ float64 float64r32_div(float64 a, float64 b, float_status *status)\n bfloat16 QEMU_FLATTEN\n bfloat16_div(bfloat16 a, bfloat16 b, float_status *status)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- bfloat16_unpack_canonical(&pa, a, status);\n- bfloat16_unpack_canonical(&pb, b, status);\n- pr = parts64_div(&pa, &pb, status);\n+ FloatParts64 pa = bfloat16_unpack_canonical(a, status);\n+ FloatParts64 pb = bfloat16_unpack_canonical(b, status);\n+ FloatParts64 *pr = parts64_div(&pa, &pb, status);\n \n return bfloat16_round_pack_canonical(pr, status);\n }\n@@ -2791,36 +2783,32 @@ float32 float64_to_float32(float64 a, float_status *s)\n \n float8_e4m3 bfloat16_to_float8_e4m3(bfloat16 a, bool saturate, float_status *s)\n {\n- FloatParts64 p;\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n \n- bfloat16_unpack_canonical(&p, a, s);\n parts64_float_to_float(&p, s);\n return float8_e4m3_round_pack_canonical(&p, s, saturate);\n }\n \n float8_e5m2 bfloat16_to_float8_e5m2(bfloat16 a, bool saturate, float_status *s)\n {\n- FloatParts64 p;\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n \n- bfloat16_unpack_canonical(&p, a, s);\n parts_float_to_e5m2(&p, s, saturate);\n return float8_e5m2_round_pack_canonical(&p, s, saturate);\n }\n \n float32 bfloat16_to_float32(bfloat16 a, float_status *s)\n {\n- FloatParts64 p;\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n \n- bfloat16_unpack_canonical(&p, a, s);\n parts64_float_to_float(&p, s);\n return float32_round_pack_canonical(&p, s);\n }\n \n float64 bfloat16_to_float64(bfloat16 a, float_status *s)\n {\n- FloatParts64 p;\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n \n- bfloat16_unpack_canonical(&p, a, s);\n parts64_float_to_float(&p, s);\n return float64_round_pack_canonical(&p, s);\n }\n@@ -2982,9 +2970,8 @@ float64 float64_round_to_int(float64 a, float_status *s)\n \n bfloat16 bfloat16_round_to_int(bfloat16 a, float_status *s)\n {\n- FloatParts64 p;\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n \n- bfloat16_unpack_canonical(&p, a, s);\n parts64_round_to_int(&p, s->float_rounding_mode, 0, s, &bfloat16_params);\n return bfloat16_round_pack_canonical(&p, s);\n }\n@@ -3100,36 +3087,28 @@ int64_t float64_to_int64_scalbn(float64 a, FloatRoundMode rmode, int scale,\n int8_t bfloat16_to_int8_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s);\n }\n \n int16_t bfloat16_to_int16_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t bfloat16_to_int32_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t bfloat16_to_int64_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,\n float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n@@ -3590,36 +3569,28 @@ uint64_t float64_to_uint64_scalbn(float64 a, FloatRoundMode rmode, int scale,\n uint8_t bfloat16_to_uint8_scalbn(bfloat16 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT8_MAX, s);\n }\n \n uint16_t bfloat16_to_uint16_scalbn(bfloat16 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT16_MAX, s);\n }\n \n uint32_t bfloat16_to_uint32_scalbn(bfloat16 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT32_MAX, s);\n }\n \n uint64_t bfloat16_to_uint64_scalbn(bfloat16 a, FloatRoundMode rmode,\n int scale, float_status *s)\n {\n- FloatParts64 p;\n-\n- bfloat16_unpack_canonical(&p, a, s);\n+ FloatParts64 p = bfloat16_unpack_canonical(a, s);\n return parts64_float_to_uint(&p, rmode, scale, UINT64_MAX, s);\n }\n \n@@ -4296,11 +4267,9 @@ static float16 float16_minmax(float16 a, float16 b, float_status *s, int flags)\n static bfloat16 bfloat16_minmax(bfloat16 a, bfloat16 b,\n float_status *s, int flags)\n {\n- FloatParts64 pa, pb, *pr;\n-\n- bfloat16_unpack_canonical(&pa, a, s);\n- bfloat16_unpack_canonical(&pb, b, s);\n- pr = parts64_minmax(&pa, &pb, s, flags);\n+ FloatParts64 pa = bfloat16_unpack_canonical(a, s);\n+ FloatParts64 pb = bfloat16_unpack_canonical(b, s);\n+ FloatParts64 *pr = parts64_minmax(&pa, &pb, s, flags);\n \n return bfloat16_round_pack_canonical(pr, s);\n }\n@@ -4496,10 +4465,9 @@ FloatRelation float64_compare_quiet(float64 a, float64 b, float_status *s)\n static FloatRelation QEMU_FLATTEN\n bfloat16_do_compare(bfloat16 a, bfloat16 b, float_status *s, bool is_quiet)\n {\n- FloatParts64 pa, pb;\n+ FloatParts64 pa = bfloat16_unpack_canonical(a, s);\n+ FloatParts64 pb = bfloat16_unpack_canonical(b, s);\n \n- bfloat16_unpack_canonical(&pa, a, s);\n- bfloat16_unpack_canonical(&pb, b, s);\n return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n@@ -4587,9 +4555,8 @@ float64 float64_scalbn(float64 a, int n, float_status *status)\n \n bfloat16 bfloat16_scalbn(bfloat16 a, int n, float_status *status)\n {\n- FloatParts64 p;\n+ FloatParts64 p = bfloat16_unpack_canonical(a, status);\n \n- bfloat16_unpack_canonical(&p, a, status);\n parts64_scalbn(&p, n, status);\n return bfloat16_round_pack_canonical(&p, status);\n }\n@@ -4711,9 +4678,8 @@ float64 float64r32_sqrt(float64 a, float_status *status)\n \n bfloat16 QEMU_FLATTEN bfloat16_sqrt(bfloat16 a, float_status *status)\n {\n- FloatParts64 p;\n+ FloatParts64 p = bfloat16_unpack_canonical(a, status);\n \n- bfloat16_unpack_canonical(&p, a, status);\n parts64_sqrt(&p, status, &bfloat16_params);\n return bfloat16_round_pack_canonical(&p, status);\n }\n","prefixes":["40/84"]}