{"id":2228437,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228437/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-12-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-12-richard.henderson@linaro.org>","date":"2026-04-26T13:38:48","name":"[11/84] fpu: Drop parts_addsub","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e5622e41a194ea5d73c6fa72cf5f1430dc66a4f7","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-12-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228437/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228437/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sGTJiSEp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Sl22FdXz1yHg\n\tfor ; Sun, 26 Apr 2026 23:50:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGzjE-00078m-FV; Sun, 26 Apr 2026 09:40:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGziy-00071U-Rn\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:41 -0400","from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzix-0008Nh-4F\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:40 -0400","by mail-pj1-x102d.google.com with SMTP id\n 98e67ed59e1d1-35da1af3e10so8680467a91.3\n for ; Sun, 26 Apr 2026 06:40:38 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.40.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:40:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210838; x=1777815638; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=W8mF2w2Bv+oA3MTgv0hQ1Dx793tAYzL7cdErwHzJOq0=;\n b=sGTJiSEp2w2bX9D3m0pYJN51VAAfDT5ieeBWmikyL8hjEIF7TuQXq9bc01fNbaBdl1\n DJEazEw+/HDpETs2ekN/qcEsu5vgSIIZff2gGDe8epKX52CUBloFj6u9/vuSI9u0fov4\n sB1FSY3E2lYyBqrlFualRMqy6Fa3hbKlLrvneMsfT4FZtsmixR5leSux6haXqeB1K8lA\n f4fffM2Sig8dPsVbplczdCQmbTuvh6orsxN0y94yG5mYvaJ3iYb5N1Q7NYlcaVlE2FUU\n 4Fx6N+yN66BDx2aLPfqOhtT/sIQgwf06xYqkmEfDVGEEE6eLCs6+XlyunN9ffPv6uK2e\n saVg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210838; x=1777815638;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=W8mF2w2Bv+oA3MTgv0hQ1Dx793tAYzL7cdErwHzJOq0=;\n b=UTqN/y0czQzMBkTBFIyBKQyDIWqoLIGtLJ08sQWUbgZ39avjAJDLlb20GAbrHQWcPW\n wEhQ/js43xm1dsW9Yk4kfA8WoCqaew9CgYjH/nWMxq0kd8MC46s3WlScCSeLuJapXT8S\n OqXaRGMt+7BeLWDT+YhW6K4wwjnc17WnHIHKwDNey3xq0l9MiNmovUrIafQnFWNCazUw\n CWnyNrSbTF3+edUyn1p4j7u/9Lhf8W4TFE10yAknnTiXj/8nRr/XqqThLbCo9isPZqy1\n tLDF3PYjbBVkrF+L2CRWWfeQib+4rh2089OmDFL6XjSxAxbIisA4I65DXYJvkEwmErpZ\n WDzg==","X-Gm-Message-State":"AOJu0Yy0FT3jMMiqv1Gf2EGqfnZqCIDKMb4ivg345wcjw47ofVBHyAFU\n NUn8AsdMA641p+2h91I5XdQS7pG6IqGQvZ92JgKCsJu7MahJntDom1OSjdcQx/peb9478YA1cIi\n ww0pnAN0=","X-Gm-Gg":"AeBDievIw4y8Wwd8w8Psu0DXJTS719NTTergGWvbB4DZuGQJpK4DehN4/lzK/U9qePq\n NF/sjc9Xc7mzdQEtOKYUcSkfycaoMDcrfkeKc5jR4pQkynkoJVBQljUrJYs5WP0RvujUbxY4bZs\n WxNPChz7/vbULTiAkRW7o47raOPn78pdItu4xNen+a4zlv7o6G6YSzWEd9OvEntGViyg+HAbcgi\n xDmWp6q4/1hlgFxLNWt+7ItWP7dZys4gZhcbv9Pe8Kzg5H3VXUziFoEfGItXkNTvU0IrY/VxDcG\n UAJ9AHrx1fM3y9uKrwmO/GxvGvS2tzlqhtx+W+VnNBjB43bwysf9J8KmX2NKaSfPCN1kEjjPClz\n lRtFQSDoeyFoXTk7ARW6jj7mF59v2LNNjA5W8vsnoKXs5gLaG4OiVd/haq2akTaCRui+S2wY4B9\n ns/uBAPCpNI/J1yCkRlmzBSnVw6t+QxGzCwWVHTFXa","X-Received":"by 2002:a17:903:17cf:b0:2b0:6829:9414 with SMTP id\n d9443c01a7336-2b5f9e64c6cmr397266395ad.8.1777210837582;\n Sun, 26 Apr 2026 06:40:37 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 11/84] fpu: Drop parts_addsub","Date":"Sun, 26 Apr 2026 23:38:48 +1000","Message-ID":"<20260426134002.865628-12-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_addsub at each call site.\n\nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 22 +++++++---------------\n 1 file changed, 7 insertions(+), 15 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 117c335d66..dc5ce53105 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,14 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_addsub(FloatParts64 *a, FloatParts64 *b,\n- float_status *s, bool subtract);\n-static FloatParts128 *parts128_addsub(FloatParts128 *a, FloatParts128 *b,\n- float_status *s, bool subtract);\n-\n-#define parts_addsub(A, B, S, Z) \\\n- PARTS_GENERIC_64_128(addsub, A)(A, B, S, Z)\n-\n static FloatParts64 *parts64_mul(FloatParts64 *a, FloatParts64 *b,\n float_status *s);\n static FloatParts128 *parts128_mul(FloatParts128 *a, FloatParts128 *b,\n@@ -1923,7 +1915,7 @@ float16_addsub(float16 a, float16 b, float_status *status, bool subtract)\n \n float16_unpack_canonical(&pa, a, status);\n float16_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float16_round_pack_canonical(pr, status);\n }\n@@ -1945,7 +1937,7 @@ soft_f32_addsub(float32 a, float32 b, float_status *status, bool subtract)\n \n float32_unpack_canonical(&pa, a, status);\n float32_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float32_round_pack_canonical(pr, status);\n }\n@@ -1967,7 +1959,7 @@ soft_f64_addsub(float64 a, float64 b, float_status *status, bool subtract)\n \n float64_unpack_canonical(&pa, a, status);\n float64_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float64_round_pack_canonical(pr, status);\n }\n@@ -2064,7 +2056,7 @@ static float64 float64r32_addsub(float64 a, float64 b, float_status *status,\n \n float64_unpack_canonical(&pa, a, status);\n float64_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return float64r32_round_pack_canonical(pr, status);\n }\n@@ -2086,7 +2078,7 @@ bfloat16_addsub(bfloat16 a, bfloat16 b, float_status *status, bool subtract)\n \n bfloat16_unpack_canonical(&pa, a, status);\n bfloat16_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts64_addsub(&pa, &pb, status, subtract);\n \n return bfloat16_round_pack_canonical(pr, status);\n }\n@@ -2108,7 +2100,7 @@ float128_addsub(float128 a, float128 b, float_status *status, bool subtract)\n \n float128_unpack_canonical(&pa, a, status);\n float128_unpack_canonical(&pb, b, status);\n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts128_addsub(&pa, &pb, status, subtract);\n \n return float128_round_pack_canonical(pr, status);\n }\n@@ -2133,7 +2125,7 @@ floatx80_addsub(floatx80 a, floatx80 b, float_status *status, bool subtract)\n return floatx80_default_nan(status);\n }\n \n- pr = parts_addsub(&pa, &pb, status, subtract);\n+ pr = parts128_addsub(&pa, &pb, status, subtract);\n return floatx80_round_pack_canonical(pr, status);\n }\n \n","prefixes":["11/84"]}