{"id":2228431,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228431/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-17-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-17-richard.henderson@linaro.org>","date":"2026-04-26T13:38:53","name":"[16/84] fpu: Drop parts_sqrt","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"621c043abbc0f422e417f33d2b9789f0af0e97b9","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-17-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228431/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228431/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=iFxjp62a;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Sj36rtLz1y2d\n\tfor ; Sun, 26 Apr 2026 23:48:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGzjG-0007CG-Sh; Sun, 26 Apr 2026 09:40:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGzjC-00076X-7e\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:54 -0400","from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzj9-0008RG-Hv\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:53 -0400","by mail-pl1-x62a.google.com with SMTP id\n d9443c01a7336-2b2503753efso97383435ad.0\n for ; Sun, 26 Apr 2026 06:40:51 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.40.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:40:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210850; x=1777815650; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Q2IzZbTZBi1/HYn+Kd6HNy8yKoIRF/IKgPHtP/RDOts=;\n b=iFxjp62aSy8WrjbqR6WdVEaatpL0fR3hY6zRff8fWrYnmca7BjZaHmIt+ctY3EmISq\n t/KsgfVDTXw2tqervA4dJoBSAgn4j0du0Hsj3gmrhvtOBk/CFFSn0B9VHFeIgVaMLMXY\n r8XA1EOcJPIRMO+Iahu5MlETqcocU76HVwPR6wb+8PbUhJDrds2NOa/sDDlqcCqbfI9/\n Wq6QnignvH7TXx56M9SpfHdkxS2Ocs3kSwhanPSrL6F+tukwTGYk0bP1k4K94RbZwCW5\n VBhHy0QmNi/B+gBOWD23e9baRy3OUGjAPNaoEk09ITItqdHPImdyJoz+Jb0O8WoPdsVg\n tK8Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210850; x=1777815650;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Q2IzZbTZBi1/HYn+Kd6HNy8yKoIRF/IKgPHtP/RDOts=;\n b=QpRuLckMuz3qgFsZt5ksXOhZ2uK3812S8F2dx2ae3PJHunKdwg3k3Laf3NnTlfm/O9\n JB78fKdCEbdOwjVzPkyrEHOck7I5JBzsqBWIZvOd4/kNbS8T1MAoKmBOWNLHvNQaK1YM\n z8k1gVnBgdmGyIj3cmBMUH7/10M/w2eD83zljG6nlUv7z9xlPix7LtkS8nWUdV4FFJrL\n DjuQJV4TsXC/Bge033gfMnLpMt/Wn1tDCGI/rU3YJzq6JAVgeqNYV39RuxttpxwHwoiv\n ETnn7uPUleYapqhjJMJBslWw9G40TSM6CHWokXItmJ/BtAxreXko54R8QOruTG2ypmQn\n wy9w==","X-Gm-Message-State":"AOJu0YwXjUkaMs8oUift3eNRURy+kVWord9LqXSjVef6lzqzN3nAMj1h\n O8lmmoia5SlSKFJoeuPKEoFTmyv2OpJlGxUYLbVe509/KZDKzqVpiWJMpGac1kx0aFdEulXkrIS\n 67kclKis=","X-Gm-Gg":"AeBDietAWH8n6QBhVyxm0lW3HIp0+7/q0qna4aTUjz/Bujf6bmQuTL0VfZpWXTOyV8a\n Bex15ttUrGh2iuc0KAUtNlwcZ8swo+7c6pENiXq4jkwKLChPDvhadXHuSPtd5FyeT4kI4UVOOdW\n T4dv+RfswHP2q8YZ9EuR4Uw/Jmg1xX+SY23WAx/EBRJiBOCNKQMID/4ZpdJhEQQgqDl4ocUrPQ6\n zbJmQmKtvDOEi6GqgVDnS8vG1HL7Jx0pdAkwlJ8AKEOuYNip+CbBlxIhYOg/sFM/cTY4EAOjhz2\n uLie4bLmWDqdqkFMOZ2PO6M2pj80yKitzvKEKag3s8J8QhNZKt+TM4Lu0hpzupKMOjDV7GTAWX2\n y2qnuM9fGBek0wPEq2fiknxs4JBsl0czJTajaN0eRQWDtMoNlEO3H/rUFJMoQqmrdJ8/yZTyeuG\n G5/8FHEXN9OFlXfetHJsje001CAC9GNuWwuuyb2fgkIpPk4CNaxu4=","X-Received":"by 2002:a17:903:1b45:b0:2b2:4d36:7aa with SMTP id\n d9443c01a7336-2b5f9fb36ccmr431356495ad.35.1777210850140;\n Sun, 26 Apr 2026 06:40:50 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 16/84] fpu: Drop parts_sqrt","Date":"Sun, 26 Apr 2026 23:38:53 +1000","Message-ID":"<20260426134002.865628-17-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_sqrt at each call site.\n\nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 20 +++++++-------------\n 1 file changed, 7 insertions(+), 13 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 91d8e48ce4..0a6bc6d580 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,12 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n FloatParts128 *: parts128_##NAME, \\\n FloatParts256 *: parts256_##NAME)\n \n-static void parts64_sqrt(FloatParts64 *a, float_status *s, const FloatFmt *f);\n-static void parts128_sqrt(FloatParts128 *a, float_status *s, const FloatFmt *f);\n-\n-#define parts_sqrt(A, S, F) \\\n- PARTS_GENERIC_64_128(sqrt, A)(A, S, F)\n-\n static bool parts64_round_to_int_normal(FloatParts64 *a, FloatRoundMode rm,\n int scale, int frac_size);\n static bool parts128_round_to_int_normal(FloatParts128 *a, FloatRoundMode r,\n@@ -4757,7 +4751,7 @@ float16 QEMU_FLATTEN float16_sqrt(float16 a, float_status *status)\n FloatParts64 p;\n \n float16_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float16_params);\n+ parts64_sqrt(&p, status, &float16_params);\n return float16_round_pack_canonical(&p, status);\n }\n \n@@ -4767,7 +4761,7 @@ soft_f32_sqrt(float32 a, float_status *status)\n FloatParts64 p;\n \n float32_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float32_params);\n+ parts64_sqrt(&p, status, &float32_params);\n return float32_round_pack_canonical(&p, status);\n }\n \n@@ -4777,7 +4771,7 @@ soft_f64_sqrt(float64 a, float_status *status)\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float64_params);\n+ parts64_sqrt(&p, status, &float64_params);\n return float64_round_pack_canonical(&p, status);\n }\n \n@@ -4840,7 +4834,7 @@ float64 float64r32_sqrt(float64 a, float_status *status)\n FloatParts64 p;\n \n float64_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float64_params);\n+ parts64_sqrt(&p, status, &float64_params);\n return float64r32_round_pack_canonical(&p, status);\n }\n \n@@ -4849,7 +4843,7 @@ bfloat16 QEMU_FLATTEN bfloat16_sqrt(bfloat16 a, float_status *status)\n FloatParts64 p;\n \n bfloat16_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &bfloat16_params);\n+ parts64_sqrt(&p, status, &bfloat16_params);\n return bfloat16_round_pack_canonical(&p, status);\n }\n \n@@ -4858,7 +4852,7 @@ float128 QEMU_FLATTEN float128_sqrt(float128 a, float_status *status)\n FloatParts128 p;\n \n float128_unpack_canonical(&p, a, status);\n- parts_sqrt(&p, status, &float128_params);\n+ parts128_sqrt(&p, status, &float128_params);\n return float128_round_pack_canonical(&p, status);\n }\n \n@@ -4869,7 +4863,7 @@ floatx80 floatx80_sqrt(floatx80 a, float_status *s)\n if (!floatx80_unpack_canonical(&p, a, s)) {\n return floatx80_default_nan(s);\n }\n- parts_sqrt(&p, s, &floatx80_params[s->floatx80_rounding_precision]);\n+ parts128_sqrt(&p, s, &floatx80_params[s->floatx80_rounding_precision]);\n return floatx80_round_pack_canonical(&p, s);\n }\n \n","prefixes":["16/84"]}