{"id":2228430,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228430/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-35-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-35-richard.henderson@linaro.org>","date":"2026-04-26T13:39:11","name":"[34/84] fpu: Return struct from float8_e4m3_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"66af9b2b481cbd214d046c84217f9bc7e5db9949","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-35-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228430/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228430/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=mL6Lp/FX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Shy5Wqqz1y2d\n\tfor ; Sun, 26 Apr 2026 23:48:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGzkR-0000cm-0Q; Sun, 26 Apr 2026 09:42:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGzjw-000073-N1\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:41 -0400","from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzjv-0000KD-1j\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:40 -0400","by mail-pl1-x636.google.com with SMTP id\n d9443c01a7336-2b45cb89f7eso58476825ad.0\n for ; Sun, 26 Apr 2026 06:41:38 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.41.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:41:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210898; x=1777815698; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=PMksPAG3r8+VLSRLaiSYmqjI0xhM/jgzuN3RWr1+Zpg=;\n b=mL6Lp/FXRdIbe6Dp7R/cL99R40N40c2qphu/LUMvmMq/aMnc5KgDntplGteauGDQVl\n f4x+Iw2eeDvo3F8DQgR5g8AN8gD5WaY2mbTCoJzmGxXiYr9qw2BDWu3moVDNBXyI0sAZ\n ymaMmDvtZJAqSDo2Kc16JEizUMUNUdUQTReTVj3tvflAhWz3moL9s0muqVLxp+EbgWZW\n Twzl9OuMZNEbWppUmmsg0fskzYJdt8/t6B+REVA5/EkP/1hqEoeLfB3iIOqSnXejj03I\n XHvliUasX0MUTVWSv0MUd4CU63AqAYnXgUfYIciIiaYHdXXOz3/qwz3N68r/94zXcVz9\n hnaw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210898; x=1777815698;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=PMksPAG3r8+VLSRLaiSYmqjI0xhM/jgzuN3RWr1+Zpg=;\n b=PLSl60WbY8/8CWYvcsfNVf6GnYDTWFVlnHee1gSoKsXTfLy7gbq3mCClvfN0r7hlYe\n vuxfl6ZpMPsvbL863M+TLGNHkL+hLRT1t4odV2lkKmX7BAdYXbPPFNqjEw5/tL+Xvarw\n yK12fPNSS120NW60nyl+DUPdAxP3QLxAwj7VRyKLADL2kGzkvx8IlaZHi4Od/ujph3gM\n mgsH+UeW0fJ4dXMgD/hbIQBCXTeU83ydCiwEBQjD7jk8O8VR36wzjKKbRMoYWziCoYvD\n 0LYi9Bh8u7VsNp5y12huSdlFm5lKk0Ox+OJLrsI4knwQiJ7sbvp3hu9cEC2+h04fQvHn\n 5Hwg==","X-Gm-Message-State":"AOJu0Yy5az5bn09y4C9N5mghTD/8Tlsap0FOItTA1t97fDaWYhnEZ703\n aaIv7UZ3g0kmNHvbJdFpy8SUDYRY+coViNi8lkSrpz7zKh26fXYlLOuzG0liAn1E1BL9njgso8Q\n NVp9VmXk=","X-Gm-Gg":"AeBDieu0uCepuRD1MrJbWRYlo3/bQQvKfHPWLWkE+BwvLHtXUD2rUzqs3hPuMBat3Xg\n m0d89eP3oEICurVlL6FLZv3pXjBB9ggCt/GoCYImSyRYOQ0gQXrqK4hZJCKtelBVqPeIQ8T0UV5\n XE+tMLmBCYU4S67ppotrqmdFR4KZEsioST1vQzINXszGzFtK0E5hO//71JYAqdOOdrVRemZvEbb\n s+0bi26Oj0h0kG0Rawh90CBfxhmBqIR3Llzgu2mr0t4kT2YNg1C6T9Z9cHNXGUWxjJIjNVqF4vq\n h+gu8MPQ3ymtraiqJsdmEX776qMeWind2I1vgxCvQy7ThSrdhLQG/4X/jQ0/GAuuR9Sm8NpRDcY\n +pPguavsNJuTJYPsuFBYbububhbVgDD19mgY8HqTIhIL6+7Ll6GhSiqNVtGJUEfeCmV73oWjArr\n lso1xAM3EdE34n3e9tUBaKyCxn3UFgVSOL9ktnQirO","X-Received":"by 2002:a17:902:bcc8:b0:2b7:af0e:5942 with SMTP id\n d9443c01a7336-2b7af0e8224mr102957755ad.26.1777210897505;\n Sun, 26 Apr 2026 06:41:37 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 34/84] fpu: Return struct from float8_e4m3_unpack_canonical","Date":"Sun, 26 Apr 2026 23:39:11 +1000","Message-ID":"<20260426134002.865628-35-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::636;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Inline float8_e4m3_unpack_raw at the same time.\n\nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 17 +++++------------\n 1 file changed, 5 insertions(+), 12 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex c1d0140484..c1b03f30ab 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -646,11 +646,6 @@ static FloatParts64 unpack_raw64(const FloatFmt *fmt, uint64_t raw)\n };\n }\n \n-static void QEMU_FLATTEN float8_e4m3_unpack_raw(FloatParts64 *p, float8_e4m3 f)\n-{\n- *p = unpack_raw64(&float8_e4m3_params, f);\n-}\n-\n static void QEMU_FLATTEN float8_e5m2_unpack_raw(FloatParts64 *p, float8_e5m2 f)\n {\n *p = unpack_raw64(&float8_e5m2_params, f);\n@@ -1475,11 +1470,11 @@ static FloatParts64 float4_e2m1_unpack_canonical(float4_e2m1 f, float_status *s)\n return p;\n }\n \n-static void float8_e4m3_unpack_canonical(FloatParts64 *p, float8_e4m3 f,\n- float_status *s)\n+static FloatParts64 float8_e4m3_unpack_canonical(float8_e4m3 f, float_status *s)\n {\n- float8_e4m3_unpack_raw(p, f);\n- parts64_canonicalize(p, s, &float8_e4m3_params);\n+ FloatParts64 p = unpack_raw64(&float8_e4m3_params, f);\n+ parts64_canonicalize(&p, s, &float8_e4m3_params);\n+ return p;\n }\n \n static void float8_e5m2_unpack_canonical(FloatParts64 *p, float8_e5m2 f,\n@@ -2701,9 +2696,7 @@ float8_e4m3 float4_e2m1_to_float8_e4m3(float4_e2m1 a, float_status *s)\n \n bfloat16 float8_e4m3_to_bfloat16(float8_e4m3 a, float_status *s)\n {\n- FloatParts64 p;\n-\n- float8_e4m3_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float8_e4m3_unpack_canonical(a, s);\n parts64_float_to_float(&p, s);\n return bfloat16_round_pack_canonical(&p, s);\n }\n","prefixes":["34/84"]}