{"id":2228427,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228427/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-44-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-44-richard.henderson@linaro.org>","date":"2026-04-26T13:39:20","name":"[43/84] fpu: Return struct from float{32,64}_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d3c8d3637d2a793ddf1cfddb29f8ad4c59d8ba01","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-44-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228427/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228427/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=wOwxHjl9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3ShX5vZ9z1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 23:48:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGznO-0005Rc-TG; Sun, 26 Apr 2026 09:45:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGznL-0005HF-1G\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:45:11 -0400","from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGznH-0001FB-2g\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:45:09 -0400","by mail-pj1-x102d.google.com with SMTP id\n 98e67ed59e1d1-362e50b4641so1620316a91.0\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 06:45:06 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5faa34ea7sm280544085ad.34.2026.04.26.06.45.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:45:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777211106; x=1777815906; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=i0Sl15CbZuOenLUjRBqqIJLCi1jF+twJX10P6o1IkLU=;\n b=wOwxHjl9cghebyaUsvxIPjrRUgglyGsauRVYxoYHO1gq/0HrDU1eHpH12hh4QJ05WA\n pzvz6G4QzDBJGXOGbhMWfCASik9lUgAVph4OCWZVlS3tCQ5yMIY0bCqGiKr8nWI4znRC\n ihQ6XD4OuU+SIAPuyylEb8QNKZKBhyTZoWriRwC/J/rVDyLcSOfuc5rT0tqLT0dfdgKI\n WJCfJmti9wX1v2DWaVsTyBAfeXRMvYvJ4zIjMcvCukCrOVB/1eSUO9uk1pPSsWoPFJld\n xkjcVc1IREHHrrzSh1GS1oFLq7MsCgjyks2wEEt5FXvgOyG0fo4wfviPNMTOX8jq3Hgk\n afxw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777211106; x=1777815906;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=i0Sl15CbZuOenLUjRBqqIJLCi1jF+twJX10P6o1IkLU=;\n b=drSMDso/uRN+XbPDc1/xj9jv5I+oeQDuCQqDu1Cd3xW/s0989RQHRXQJq5j+00nuHO\n JdYgQnNYgT+QRnpcS93nRzZ6W47VCsoXLi0/5xzobi35e4bJR9x850s6rD8hLE71AFmK\n jiO9JnG1F+RbykD1WpBgMKkdCFQP8vCxbQ5hjPcg6aRAGgpETnrG2yux/h8H5QQmC7Fy\n LNWn0lBs4CC5jJQI9ABzO0OsSkTaZT2raGwjsHxupWMuiNTED3xipnIYUphzY4/ygzHC\n l0vJlAhcjYP8dOo+VbUS2d1mXQu1YJ51/uZxNEgPGpXPE4aOuGf38BUQiLJaFoslfiyJ\n 3MoQ==","X-Gm-Message-State":"AOJu0YzzJNXiod+LC+O2/7TWBONeUhmYVP9xzSOrmDoyM9TLx2xXbNuR\n Ka6YWypgXs/zlHmoeqDdP1X9Nv5sk7MUoaSXjU3v6Prgp+VKaC8xdklu+dJadE1Oj9tI9EWLEbp\n g/EsPkvE=","X-Gm-Gg":"AeBDietnQn+O2b+FC/C+E9v5MTWAfbwxYomaYCfE5EUjlhlaMvzP/aqIK/Y9+mnQP+w\n Xp47USBagfPbeloslJBA/4bDd+V4aDdV91HSW00YEW+PdjDpIE/GOSQF72/+gmv/AiUlZqvezKu\n dk/b0wtX9Njysd9MrXFsF66sIKKkaWrsmMHe6oNdyGTWNS5qFd7LMGVxqY0rTEyVgmE0SXF+5GT\n JoRSi2xu+oHT9MbGTnDlVWwbGQA41zBmKqfUFX84nvwn8oBnZmxuI4q5O1iR3eftEFJ45M8NjfC\n d1/YUcHCRHM6W4UPpp219A+QZWJ1XZVWWXlI69QzbaYxxB8uz7z32aySOv5gs6ZMTm7eDxvksDG\n LPejckrzCx1WhvP8Kn6V6ur4kRL+R0sUlBhef/NRVbiaAcQ6BNRGhGtZzbk48atNf3CH3tvUY45\n z3nIMWAmXSUeTnMgjgTi4LPbnfhMYKG2JiP2jd+cwK","X-Received":"by 2002:a17:903:907:b0:2ae:54b2:27c7 with SMTP id\n d9443c01a7336-2b5f9fecc37mr394644285ad.39.1777211105496;\n Sun, 26 Apr 2026 06:45:05 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 43/84] fpu: Return struct from float{32,64}_unpack_canonical","Date":"Sun, 26 Apr 2026 23:39:20 +1000","Message-ID":"<20260426134002.865628-44-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"We must change float32 and float64 at once because\nof the DEFINE_S390_DIVIDE_TO_INTEGER macro.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 300 +++++++++++++++++-------------------------------\n 1 file changed, 107 insertions(+), 193 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex e1b92b38b6..b3208c1891 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -1516,11 +1516,11 @@ static bfloat16 bfloat16_round_pack_canonical(FloatParts64 *p,\n     return bfloat16_pack_raw(p);\n }\n \n-static void float32_unpack_canonical(FloatParts64 *p, float32 f,\n-                                     float_status *s)\n+static FloatParts64 float32_unpack_canonical(float32 f, float_status *s)\n {\n-    *p = unpack_raw64(&float32_params, f);\n-    parts64_canonicalize(p, s, &float32_params);\n+    FloatParts64 p = unpack_raw64(&float32_params, f);\n+    parts64_canonicalize(&p, s, &float32_params);\n+    return p;\n }\n \n static float32 float32_round_pack_canonical(FloatParts64 *p,\n@@ -1530,11 +1530,11 @@ static float32 float32_round_pack_canonical(FloatParts64 *p,\n     return float32_pack_raw(p);\n }\n \n-static void float64_unpack_canonical(FloatParts64 *p, float64 f,\n-                                     float_status *s)\n+static FloatParts64 float64_unpack_canonical(float64 f, float_status *s)\n {\n-    *p = unpack_raw64(&float64_params, f);\n-    parts64_canonicalize(p, s, &float64_params);\n+    FloatParts64 p = unpack_raw64(&float64_params, f);\n+    parts64_canonicalize(&p, s, &float64_params);\n+    return p;\n }\n \n static float64 float64_round_pack_canonical(FloatParts64 *p,\n@@ -1722,11 +1722,9 @@ float16 float16_sub(float16 a, float16 b, float_status *status)\n static float32 QEMU_SOFTFLOAT_ATTR\n soft_f32_addsub(float32 a, float32 b, float_status *status, bool subtract)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float32_unpack_canonical(&pa, a, status);\n-    float32_unpack_canonical(&pb, b, status);\n-    pr = parts64_addsub(&pa, &pb, status, subtract);\n+    FloatParts64 pa = float32_unpack_canonical(a, status);\n+    FloatParts64 pb = float32_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_addsub(&pa, &pb, status, subtract);\n \n     return float32_round_pack_canonical(pr, status);\n }\n@@ -1744,11 +1742,9 @@ static float32 soft_f32_sub(float32 a, float32 b, float_status *status)\n static float64 QEMU_SOFTFLOAT_ATTR\n soft_f64_addsub(float64 a, float64 b, float_status *status, bool subtract)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    pr = parts64_addsub(&pa, &pb, status, subtract);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_addsub(&pa, &pb, status, subtract);\n \n     return float64_round_pack_canonical(pr, status);\n }\n@@ -1841,11 +1837,9 @@ float64_sub(float64 a, float64 b, float_status *s)\n static float64 float64r32_addsub(float64 a, float64 b, float_status *status,\n                                  bool subtract)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    pr = parts64_addsub(&pa, &pb, status, subtract);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_addsub(&pa, &pb, status, subtract);\n \n     return float64r32_round_pack_canonical(pr, status);\n }\n@@ -1942,11 +1936,9 @@ float16 QEMU_FLATTEN float16_mul(float16 a, float16 b, float_status *status)\n static float32 QEMU_SOFTFLOAT_ATTR\n soft_f32_mul(float32 a, float32 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float32_unpack_canonical(&pa, a, status);\n-    float32_unpack_canonical(&pb, b, status);\n-    pr = parts64_mul(&pa, &pb, status);\n+    FloatParts64 pa = float32_unpack_canonical(a, status);\n+    FloatParts64 pb = float32_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_mul(&pa, &pb, status);\n \n     return float32_round_pack_canonical(pr, status);\n }\n@@ -1954,11 +1946,9 @@ soft_f32_mul(float32 a, float32 b, float_status *status)\n static float64 QEMU_SOFTFLOAT_ATTR\n soft_f64_mul(float64 a, float64 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    pr = parts64_mul(&pa, &pb, status);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_mul(&pa, &pb, status);\n \n     return float64_round_pack_canonical(pr, status);\n }\n@@ -1989,11 +1979,9 @@ float64_mul(float64 a, float64 b, float_status *s)\n \n float64 float64r32_mul(float64 a, float64 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    pr = parts64_mul(&pa, &pb, status);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_mul(&pa, &pb, status);\n \n     return float64r32_round_pack_canonical(pr, status);\n }\n@@ -2066,12 +2054,10 @@ float32 QEMU_SOFTFLOAT_ATTR\n float32_muladd_scalbn(float32 a, float32 b, float32 c,\n                       int scale, int flags, float_status *status)\n {\n-    FloatParts64 pa, pb, pc, *pr;\n-\n-    float32_unpack_canonical(&pa, a, status);\n-    float32_unpack_canonical(&pb, b, status);\n-    float32_unpack_canonical(&pc, c, status);\n-    pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n+    FloatParts64 pa = float32_unpack_canonical(a, status);\n+    FloatParts64 pb = float32_unpack_canonical(b, status);\n+    FloatParts64 pc = float32_unpack_canonical(c, status);\n+    FloatParts64 *pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n     /* Round before applying negate result. */\n     parts64_uncanon(pr, status, &float32_params, false);\n@@ -2085,12 +2071,10 @@ float64 QEMU_SOFTFLOAT_ATTR\n float64_muladd_scalbn(float64 a, float64 b, float64 c,\n                       int scale, int flags, float_status *status)\n {\n-    FloatParts64 pa, pb, pc, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    float64_unpack_canonical(&pc, c, status);\n-    pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 pc = float64_unpack_canonical(c, status);\n+    FloatParts64 *pr = parts64_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n     /* Round before applying negate result. */\n     parts64_uncanon(pr, status, &float64_params, false);\n@@ -2244,12 +2228,10 @@ float64_muladd(float64 xa, float64 xb, float64 xc, int flags, float_status *s)\n float64 float64r32_muladd(float64 a, float64 b, float64 c,\n                           int flags, float_status *status)\n {\n-    FloatParts64 pa, pb, pc, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    float64_unpack_canonical(&pc, c, status);\n-    pr = parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 pc = float64_unpack_canonical(c, status);\n+    FloatParts64 *pr = parts64_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n     /* Round before applying negate result. */\n     parts64_uncanon(pr, status, &float32_params, false);\n@@ -2309,11 +2291,9 @@ float16 float16_div(float16 a, float16 b, float_status *status)\n static float32 QEMU_SOFTFLOAT_ATTR\n soft_f32_div(float32 a, float32 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float32_unpack_canonical(&pa, a, status);\n-    float32_unpack_canonical(&pb, b, status);\n-    pr = parts64_div(&pa, &pb, status);\n+    FloatParts64 pa = float32_unpack_canonical(a, status);\n+    FloatParts64 pb = float32_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_div(&pa, &pb, status);\n \n     return float32_round_pack_canonical(pr, status);\n }\n@@ -2321,11 +2301,9 @@ soft_f32_div(float32 a, float32 b, float_status *status)\n static float64 QEMU_SOFTFLOAT_ATTR\n soft_f64_div(float64 a, float64 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    pr = parts64_div(&pa, &pb, status);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_div(&pa, &pb, status);\n \n     return float64_round_pack_canonical(pr, status);\n }\n@@ -2390,11 +2368,9 @@ float64_div(float64 a, float64 b, float_status *s)\n \n float64 float64r32_div(float64 a, float64 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    pr = parts64_div(&pa, &pb, status);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_div(&pa, &pb, status);\n \n     return float64r32_round_pack_canonical(pr, status);\n }\n@@ -2440,22 +2416,18 @@ floatx80 floatx80_div(floatx80 a, floatx80 b, float_status *status)\n \n float32 float32_rem(float32 a, float32 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float32_unpack_canonical(&pa, a, status);\n-    float32_unpack_canonical(&pb, b, status);\n-    pr = parts64_modrem(&pa, &pb, NULL, status);\n+    FloatParts64 pa = float32_unpack_canonical(a, status);\n+    FloatParts64 pb = float32_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_modrem(&pa, &pb, NULL, status);\n \n     return float32_round_pack_canonical(pr, status);\n }\n \n float64 float64_rem(float64 a, float64 b, float_status *status)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, status);\n-    float64_unpack_canonical(&pb, b, status);\n-    pr = parts64_modrem(&pa, &pb, NULL, status);\n+    FloatParts64 pa = float64_unpack_canonical(a, status);\n+    FloatParts64 pb = float64_unpack_canonical(b, status);\n+    FloatParts64 *pr = parts64_modrem(&pa, &pb, NULL, status);\n \n     return float64_round_pack_canonical(pr, status);\n }\n@@ -2688,28 +2660,25 @@ float64 float16_to_float64(float16 a, bool ieee, float_status *s)\n \n float8_e4m3 float32_to_float8_e4m3(float32 a, bool saturate, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n \n-    float32_unpack_canonical(&p, a, s);\n     parts64_float_to_float(&p, s);\n     return float8_e4m3_round_pack_canonical(&p, s, saturate);\n }\n \n float8_e5m2 float32_to_float8_e5m2(float32 a, bool saturate, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n \n-    float32_unpack_canonical(&p, a, s);\n     parts_float_to_e5m2(&p, s, saturate);\n     return float8_e5m2_round_pack_canonical(&p, s, saturate);\n }\n \n float16 float32_to_float16(float32 a, bool ieee, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n     const FloatFmt *fmt;\n \n-    float32_unpack_canonical(&p, a, s);\n     if (ieee) {\n         parts64_float_to_float(&p, s);\n         fmt = &float16_params;\n@@ -2723,9 +2692,8 @@ float16 float32_to_float16(float32 a, bool ieee, float_status *s)\n static float64 QEMU_SOFTFLOAT_ATTR\n soft_float32_to_float64(float32 a, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n \n-    float32_unpack_canonical(&p, a, s);\n     parts64_float_to_float(&p, s);\n     return float64_round_pack_canonical(&p, s);\n }\n@@ -2748,10 +2716,9 @@ float64 float32_to_float64(float32 a, float_status *s)\n \n float16 float64_to_float16(float64 a, bool ieee, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     const FloatFmt *fmt;\n \n-    float64_unpack_canonical(&p, a, s);\n     if (ieee) {\n         parts64_float_to_float(&p, s);\n         fmt = &float16_params;\n@@ -2764,9 +2731,8 @@ float16 float64_to_float16(float64 a, bool ieee, float_status *s)\n \n float32 float64_to_float32(float64 a, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n \n-    float64_unpack_canonical(&p, a, s);\n     parts64_float_to_float(&p, s);\n     return float32_round_pack_canonical(&p, s);\n }\n@@ -2805,18 +2771,16 @@ float64 bfloat16_to_float64(bfloat16 a, float_status *s)\n \n bfloat16 float32_to_bfloat16(float32 a, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n \n-    float32_unpack_canonical(&p, a, s);\n     parts64_float_to_float(&p, s);\n     return bfloat16_round_pack_canonical(&p, s);\n }\n \n bfloat16 float64_to_bfloat16(float64 a, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n \n-    float64_unpack_canonical(&p, a, s);\n     parts64_float_to_float(&p, s);\n     return bfloat16_round_pack_canonical(&p, s);\n }\n@@ -2843,20 +2807,18 @@ float64 float128_to_float64(float128 a, float_status *s)\n \n float128 float32_to_float128(float32 a, float_status *s)\n {\n-    FloatParts64 p64;\n+    FloatParts64 p64 = float32_unpack_canonical(a, s);\n     FloatParts128 p128;\n \n-    float32_unpack_canonical(&p64, a, s);\n     parts_float_to_float_widen(&p128, &p64, s);\n     return float128_round_pack_canonical(&p128, s);\n }\n \n float128 float64_to_float128(float64 a, float_status *s)\n {\n-    FloatParts64 p64;\n+    FloatParts64 p64 = float64_unpack_canonical(a, s);\n     FloatParts128 p128;\n \n-    float64_unpack_canonical(&p64, a, s);\n     parts_float_to_float_widen(&p128, &p64, s);\n     return float128_round_pack_canonical(&p128, s);\n }\n@@ -2901,20 +2863,18 @@ float128 floatx80_to_float128(floatx80 a, float_status *s)\n \n floatx80 float32_to_floatx80(float32 a, float_status *s)\n {\n-    FloatParts64 p64;\n+    FloatParts64 p64 = float32_unpack_canonical(a, s);\n     FloatParts128 p128;\n \n-    float32_unpack_canonical(&p64, a, s);\n     parts_float_to_float_widen(&p128, &p64, s);\n     return floatx80_round_pack_canonical(&p128, s);\n }\n \n floatx80 float64_to_floatx80(float64 a, float_status *s)\n {\n-    FloatParts64 p64;\n+    FloatParts64 p64 = float64_unpack_canonical(a, s);\n     FloatParts128 p128;\n \n-    float64_unpack_canonical(&p64, a, s);\n     parts_float_to_float_widen(&p128, &p64, s);\n     return floatx80_round_pack_canonical(&p128, s);\n }\n@@ -2942,18 +2902,16 @@ float16 float16_round_to_int(float16 a, float_status *s)\n \n float32 float32_round_to_int(float32 a, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n \n-    float32_unpack_canonical(&p, a, s);\n     parts64_round_to_int(&p, s->float_rounding_mode, 0, s, &float32_params);\n     return float32_round_pack_canonical(&p, s);\n }\n \n float64 float64_round_to_int(float64 a, float_status *s)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n \n-    float64_unpack_canonical(&p, a, s);\n     parts64_round_to_int(&p, s->float_rounding_mode, 0, s, &float64_params);\n     return float64_round_pack_canonical(&p, s);\n }\n@@ -3023,54 +2981,42 @@ int64_t float16_to_int64_scalbn(float16 a, FloatRoundMode rmode, int scale,\n int16_t float32_to_int16_scalbn(float32 a, FloatRoundMode rmode, int scale,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float32_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n     return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t float32_to_int32_scalbn(float32 a, FloatRoundMode rmode, int scale,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float32_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n     return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t float32_to_int64_scalbn(float32 a, FloatRoundMode rmode, int scale,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float32_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n     return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n int16_t float64_to_int16_scalbn(float64 a, FloatRoundMode rmode, int scale,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_sint(&p, rmode, scale, INT16_MIN, INT16_MAX, s);\n }\n \n int32_t float64_to_int32_scalbn(float64 a, FloatRoundMode rmode, int scale,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_sint(&p, rmode, scale, INT32_MIN, INT32_MAX, s);\n }\n \n int64_t float64_to_int64_scalbn(float64 a, FloatRoundMode rmode, int scale,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);\n }\n \n@@ -3455,18 +3401,14 @@ static int64_t parts64_float_to_sint_modulo(FloatParts64 *p,\n int32_t float64_to_int32_modulo(float64 a, FloatRoundMode rmode,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_sint_modulo(&p, rmode, 31, s);\n }\n \n int64_t float64_to_int64_modulo(float64 a, FloatRoundMode rmode,\n                                 float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_sint_modulo(&p, rmode, 63, s);\n }\n \n@@ -3505,54 +3447,42 @@ uint64_t float16_to_uint64_scalbn(float16 a, FloatRoundMode rmode, int scale,\n uint16_t float32_to_uint16_scalbn(float32 a, FloatRoundMode rmode, int scale,\n                                   float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float32_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n     return parts64_float_to_uint(&p, rmode, scale, UINT16_MAX, s);\n }\n \n uint32_t float32_to_uint32_scalbn(float32 a, FloatRoundMode rmode, int scale,\n                                   float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float32_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n     return parts64_float_to_uint(&p, rmode, scale, UINT32_MAX, s);\n }\n \n uint64_t float32_to_uint64_scalbn(float32 a, FloatRoundMode rmode, int scale,\n                                   float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float32_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float32_unpack_canonical(a, s);\n     return parts64_float_to_uint(&p, rmode, scale, UINT64_MAX, s);\n }\n \n uint16_t float64_to_uint16_scalbn(float64 a, FloatRoundMode rmode, int scale,\n                                   float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_uint(&p, rmode, scale, UINT16_MAX, s);\n }\n \n uint32_t float64_to_uint32_scalbn(float64 a, FloatRoundMode rmode, int scale,\n                                   float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_uint(&p, rmode, scale, UINT32_MAX, s);\n }\n \n uint64_t float64_to_uint64_scalbn(float64 a, FloatRoundMode rmode, int scale,\n                                   float_status *s)\n {\n-    FloatParts64 p;\n-\n-    float64_unpack_canonical(&p, a, s);\n+    FloatParts64 p = float64_unpack_canonical(a, s);\n     return parts64_float_to_uint(&p, rmode, scale, UINT64_MAX, s);\n }\n \n@@ -4266,22 +4196,18 @@ static bfloat16 bfloat16_minmax(bfloat16 a, bfloat16 b,\n \n static float32 float32_minmax(float32 a, float32 b, float_status *s, int flags)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float32_unpack_canonical(&pa, a, s);\n-    float32_unpack_canonical(&pb, b, s);\n-    pr = parts64_minmax(&pa, &pb, s, flags);\n+    FloatParts64 pa = float32_unpack_canonical(a, s);\n+    FloatParts64 pb = float32_unpack_canonical(b, s);\n+    FloatParts64 *pr = parts64_minmax(&pa, &pb, s, flags);\n \n     return float32_round_pack_canonical(pr, s);\n }\n \n static float64 float64_minmax(float64 a, float64 b, float_status *s, int flags)\n {\n-    FloatParts64 pa, pb, *pr;\n-\n-    float64_unpack_canonical(&pa, a, s);\n-    float64_unpack_canonical(&pb, b, s);\n-    pr = parts64_minmax(&pa, &pb, s, flags);\n+    FloatParts64 pa = float64_unpack_canonical(a, s);\n+    FloatParts64 pb = float64_unpack_canonical(b, s);\n+    FloatParts64 *pr = parts64_minmax(&pa, &pb, s, flags);\n \n     return float64_round_pack_canonical(pr, s);\n }\n@@ -4347,10 +4273,9 @@ FloatRelation float16_compare_quiet(float16 a, float16 b, float_status *s)\n static FloatRelation QEMU_SOFTFLOAT_ATTR\n float32_do_compare(float32 a, float32 b, float_status *s, bool is_quiet)\n {\n-    FloatParts64 pa, pb;\n+    FloatParts64 pa = float32_unpack_canonical(a, s);\n+    FloatParts64 pb = float32_unpack_canonical(b, s);\n \n-    float32_unpack_canonical(&pa, a, s);\n-    float32_unpack_canonical(&pb, b, s);\n     return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n@@ -4401,10 +4326,9 @@ FloatRelation float32_compare_quiet(float32 a, float32 b, float_status *s)\n static FloatRelation QEMU_SOFTFLOAT_ATTR\n float64_do_compare(float64 a, float64 b, float_status *s, bool is_quiet)\n {\n-    FloatParts64 pa, pb;\n+    FloatParts64 pa = float64_unpack_canonical(a, s);\n+    FloatParts64 pb = float64_unpack_canonical(b, s);\n \n-    float64_unpack_canonical(&pa, a, s);\n-    float64_unpack_canonical(&pb, b, s);\n     return parts64_compare(&pa, &pb, s, is_quiet);\n }\n \n@@ -4527,18 +4451,16 @@ float16 float16_scalbn(float16 a, int n, float_status *status)\n \n float32 float32_scalbn(float32 a, int n, float_status *status)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, status);\n \n-    float32_unpack_canonical(&p, a, status);\n     parts64_scalbn(&p, n, status);\n     return float32_round_pack_canonical(&p, status);\n }\n \n float64 float64_scalbn(float64 a, int n, float_status *status)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, status);\n \n-    float64_unpack_canonical(&p, a, status);\n     parts64_scalbn(&p, n, status);\n     return float64_round_pack_canonical(&p, status);\n }\n@@ -4586,9 +4508,8 @@ float16 QEMU_FLATTEN float16_sqrt(float16 a, float_status *status)\n static float32 QEMU_SOFTFLOAT_ATTR\n soft_f32_sqrt(float32 a, float_status *status)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, status);\n \n-    float32_unpack_canonical(&p, a, status);\n     parts64_sqrt(&p, status, &float32_params);\n     return float32_round_pack_canonical(&p, status);\n }\n@@ -4596,9 +4517,8 @@ soft_f32_sqrt(float32 a, float_status *status)\n static float64 QEMU_SOFTFLOAT_ATTR\n soft_f64_sqrt(float64 a, float_status *status)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, status);\n \n-    float64_unpack_canonical(&p, a, status);\n     parts64_sqrt(&p, status, &float64_params);\n     return float64_round_pack_canonical(&p, status);\n }\n@@ -4659,9 +4579,8 @@ float64 QEMU_FLATTEN float64_sqrt(float64 xa, float_status *s)\n \n float64 float64r32_sqrt(float64 a, float_status *status)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, status);\n \n-    float64_unpack_canonical(&p, a, status);\n     parts64_sqrt(&p, status, &float64_params);\n     return float64r32_round_pack_canonical(&p, status);\n }\n@@ -4822,18 +4741,16 @@ static void parts64_log2(FloatParts64 *a, float_status *s, const FloatFmt *fmt)\n \n float32 float32_log2(float32 a, float_status *status)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float32_unpack_canonical(a, status);\n \n-    float32_unpack_canonical(&p, a, status);\n     parts64_log2(&p, status, &float32_params);\n     return float32_round_pack_canonical(&p, status);\n }\n \n float64 float64_log2(float64 a, float_status *status)\n {\n-    FloatParts64 p;\n+    FloatParts64 p = float64_unpack_canonical(a, status);\n \n-    float64_unpack_canonical(&p, a, status);\n     parts64_log2(&p, status, &float64_params);\n     return float64_round_pack_canonical(&p, status);\n }\n@@ -5321,10 +5238,9 @@ static const float64 float32_exp2_coefficients[15] =\n \n float32 float32_exp2(float32 a, float_status *status)\n {\n-    FloatParts64 xp, xnp, tp, rp;\n-    int i;\n+    FloatParts64 xnp, tp, rp;\n+    FloatParts64 xp = float32_unpack_canonical(a, status);\n \n-    float32_unpack_canonical(&xp, a, status);\n     if (unlikely(xp.cls != float_class_normal)) {\n         switch (xp.cls) {\n         case float_class_denormal:\n@@ -5344,14 +5260,13 @@ float32 float32_exp2(float32 a, float_status *status)\n \n     float_raise(float_flag_inexact, status);\n \n-    float64_unpack_canonical(&tp, float64_ln2, status);\n+    tp = float64_unpack_canonical(float64_ln2, status);\n     xp = *parts64_mul(&xp, &tp, status);\n     xnp = xp;\n \n-    float64_unpack_canonical(&rp, float64_one, status);\n-    for (i = 0 ; i < 15 ; i++) {\n-\n-        float64_unpack_canonical(&tp, float32_exp2_coefficients[i], status);\n+    rp = float64_unpack_canonical(float64_one, status);\n+    for (int i = 0; i < 15; i++) {\n+        tp = float64_unpack_canonical(float32_exp2_coefficients[i], status);\n         rp = *parts64_muladd_scalbn(&tp, &xnp, &rp, 0, 0, status);\n         xnp = *parts64_mul(&xnp, &xp, status);\n     }\n@@ -5504,10 +5419,9 @@ void floatN ## _s390_divide_to_integer(floatN a, floatN b,                     \\\n                                        uint32_t *cc, int *dxc,                 \\\n                                        float_status *status)                   \\\n {                                                                              \\\n-    FloatParts64 pa, pb, pr, pn;                                               \\\n-                                                                               \\\n-    floatN ## _unpack_canonical(&pa, a, status);                               \\\n-    floatN ## _unpack_canonical(&pb, b, status);                               \\\n+    FloatParts64 pa = floatN ## _unpack_canonical(a, status);                  \\\n+    FloatParts64 pb = floatN ## _unpack_canonical(b, status);                  \\\n+    FloatParts64 pr, pn;                                                       \\\n     parts_s390_divide_to_integer(&pa, &pb, final_quotient_rounding_mode,       \\\n                                  mask_underflow, mask_inexact,                 \\\n                                  &floatN ## _params,                           \\\n","prefixes":["43/84"]}