{"id":2228417,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228417/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-38-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-38-richard.henderson@linaro.org>","date":"2026-04-26T13:39:14","name":"[37/84] fpu: Return struct from float16a_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"171b5b73a2dfeb86015dacd3293b83df5c056f0b","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-38-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228417/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228417/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=XYW+Xj+u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Sgm00JQz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 23:47:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGzki-0001Vn-Bz; Sun, 26 Apr 2026 09:42:28 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzk7-0000Ir-Cd\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:52 -0400","from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzk3-0000MW-BF\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:49 -0400","by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-2b461310af5so36489775ad.1\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 06:41:46 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.41.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:41:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210905; x=1777815705; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=t2oP1AoPp9GVb73a8OxFUw9mtARZFRgHS2lzcILL9oU=;\n b=XYW+Xj+u/Yp2jS8KUoRexC8323XaO4zY3voJnf/O2bXkZfaYzctRww/c3vOqa9yymk\n ZFLIjmF0LXoL+VhLoqXP4lMAB0GUBwXFjFA15Oj+mKSD8XmBFRXWrd0Ntm6pQOYpDNWz\n Uy0jNaR+5jiUsy6Qe+c0IUlZk4sPCNhTmwNu5Z/INRSJmxQL7f83So89I2HCF1kWXoWK\n aG68VPxC37b7s43pbfE/2BueKMo/wME5ZYZ4yvQxS6gda0QApyYjT+KqIPyJ1PmVo5Mm\n 5VcmE4LaOXLSeEeP0Q0CoPyBTSjsddqAy/PcwicjuRirofDwT7BlMLt+4I92qPGKmv/3\n hXcw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210905; x=1777815705;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=t2oP1AoPp9GVb73a8OxFUw9mtARZFRgHS2lzcILL9oU=;\n b=darqGoJmSI/MoQ8zh1GnV6E7lS7ECkpVRzyFGfIgU+tZ7XXhR8NLnRHbaloBYG7OWG\n hNSqndy+iV1LlmgIx3tBiqa4akclfx+opLldYe5t2Rne29I0FIF6c3s/TPrDnfFqBASp\n TgcA5YoTlf+bxk/ks7FiYntG7F+SDlwZ/qly9feg2F6rSJ7e4dTUIb8SqcmAcN55Vgz9\n VWJ9gAd8en3A9tgJKwoxgMpm5SSbtmHYRVoY0myn5RwNoKMR40bHmGUJFMP7llosmU6t\n pyO/gy9c11PphpMD/Vci9OJMh6ZiJhRgIIbk8aG7LolQomTQEzKbhErGg1sHBhmckiWE\n bI0A==","X-Gm-Message-State":"AOJu0YyO+PjwGFeBABi/nUfh9Zl+gEtn3jKdFVMqv6990Puw+4IFPeXi\n bol0O5JBkGKSM50l4Qja9yVB0AUpOxcYOHqhcaD76i3q6Q2LD5h0uyAMVl9VxYFou50ZrF9tdIH\n TFGRxK7s=","X-Gm-Gg":"AeBDiesHQ0iS7CupokpEl/xFzoq3dVMR+RXFS6bA6vHL44eQswxxdKuSnaRFyNRl+fj\n yZKU8kt3MnKTuf3uvuXXLoPlclYffkMjHY1NylCwhruFtt4KAIU0iKsUtsuz9qAk1NT6kMbOkso\n h9YBgi0+/Qk9F2OZQh+MTXQ6pvWCiUnjsqKOf7gq4RH+ZUwSVwOUYn8fRCiLm99vqjBQCatIuNw\n dHcTnRvLMuAy8OrqTpF4q1p7ITZaX9hqMp7mSraCZNP3eVwkozqichjild701xfJxGdqDg8OPef\n CpWEGSwzRlD0WYBnzXR1VWXMhQJo1rHdyD1fU27+n7mU2ZdkGEzjgHZKxTn0OJJVEihoRp/FZ8z\n qBOqAqqB4QsNlDPU1MCKpAq2qr0kc4W1E8Lxro5Ze+RwsuJRvRAHa7uCeKHh+VN+UtSOBU7PubC\n ZlhNpNryetrux7I4nUGEPR3fO3VAi4rjk0TjqqyNqtKjYI4n3r718=","X-Received":"by 2002:a17:903:1ae7:b0:2b4:5e85:efc with SMTP id\n d9443c01a7336-2b5f9ea55b6mr335417835ad.18.1777210905330;\n Sun, 26 Apr 2026 06:41:45 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 37/84] fpu: Return struct from float16a_unpack_canonical","Date":"Sun, 26 Apr 2026 23:39:14 +1000","Message-ID":"<20260426134002.865628-38-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex cdf95a8517..dee5dcd0d2 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -1474,17 +1474,18 @@ static FloatParts64 float8_e5m2_unpack_canonical(float8_e5m2 f, float_status *s)\n     return p;\n }\n \n-static void float16a_unpack_canonical(FloatParts64 *p, float16 f,\n-                                      float_status *s, const FloatFmt *params)\n+static FloatParts64 float16a_unpack_canonical(float16 f, float_status *s,\n+                                              const FloatFmt *params)\n {\n-    *p = unpack_raw64(&float16_params, f);\n-    parts64_canonicalize(p, s, params);\n+    FloatParts64 p = unpack_raw64(&float16_params, f);\n+    parts64_canonicalize(&p, s, params);\n+    return p;\n }\n \n static void float16_unpack_canonical(FloatParts64 *p, float16 f,\n                                      float_status *s)\n {\n-    float16a_unpack_canonical(p, f, s, &float16_params);\n+    *p = float16a_unpack_canonical(f, s, &float16_params);\n }\n \n static void bfloat16_unpack_canonical(FloatParts64 *p, bfloat16 f,\n@@ -2701,9 +2702,8 @@ bfloat16 float8_e5m2_to_bfloat16(float8_e5m2 a, float_status *s)\n float32 float16_to_float32(float16 a, bool ieee, float_status *s)\n {\n     const FloatFmt *fmt16 = ieee ? &float16_params : &float16_params_ahp;\n-    FloatParts64 p;\n+    FloatParts64 p = float16a_unpack_canonical(a, s, fmt16);\n \n-    float16a_unpack_canonical(&p, a, s, fmt16);\n     parts64_float_to_float(&p, s);\n     return float32_round_pack_canonical(&p, s);\n }\n@@ -2711,9 +2711,8 @@ float32 float16_to_float32(float16 a, bool ieee, float_status *s)\n float64 float16_to_float64(float16 a, bool ieee, float_status *s)\n {\n     const FloatFmt *fmt16 = ieee ? &float16_params : &float16_params_ahp;\n-    FloatParts64 p;\n+    FloatParts64 p = float16a_unpack_canonical(a, s, fmt16);\n \n-    float16a_unpack_canonical(&p, a, s, fmt16);\n     parts64_float_to_float(&p, s);\n     return float64_round_pack_canonical(&p, s);\n }\n","prefixes":["37/84"]}