{"id":2228405,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228405/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-34-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-34-richard.henderson@linaro.org>","date":"2026-04-26T13:39:10","name":"[33/84] fpu: Return struct from float4_e2m1_unpack_canonical","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc12500b43674fedc8c9c78952cd9f4dbce838f9","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-34-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228405/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228405/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=mbSuGjoG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3SZT5srcz1xvV\n\tfor ; Sun, 26 Apr 2026 23:43:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGzkI-0000SP-V2; Sun, 26 Apr 2026 09:42:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGzjt-0008QF-NW\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:38 -0400","from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGzjs-0000JQ-5v\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:41:37 -0400","by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2ad21f437eeso60062755ad.0\n for ; Sun, 26 Apr 2026 06:41:35 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.41.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:41:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210895; x=1777815695; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=k2ikRVouriB7GIa9TEl517IjfNmkcqYdyy4JW83l2dw=;\n b=mbSuGjoGuEKmc1aUkvJegaPXCKAzAUGXu7pTJWJMR0Wf+dmD/dS+4axmgBP1Kb+rTF\n pVotZ1Nh4paI9OAsoSjKTK0XVsa8O9TWgv5NajAwtjJIpLpb1JKOGU5v9sB9ZEXclcXs\n Q3k+WtMe8dngeGyEHlr+FB6dHvyXoqqD77XmBpVEcV6ica1abWSYqA30/sWrf78uUbrp\n NzspjNVqee2arEblY2rypvc5DE3trd2v8stbabPRXpkRUQfo1So4PcGsicUaCO3r+f9C\n oMD2r/jkziigVYYxJKhnnQ+KxN5ITJZ0T0QJCVZRhvixZ+DsLLXynwrexrX56kNvZsls\n n0Fw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210895; x=1777815695;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=k2ikRVouriB7GIa9TEl517IjfNmkcqYdyy4JW83l2dw=;\n b=OWBr7+cv0BAMwXLgRcPpXq+GL/BOh/ysPbaJGq7uiA1jjMd0ih/MSywPgWQSBmmDVP\n sVKoqOPTsnLFhhFkMpJrwEX/I24keLwTZETw8s/p31Hnh20SI9la7MiiGivX0f41jur7\n ViBDvlUSmqNdeAuo7GUcMSWnHHZ0+5mDA7g4rEVW9lz27O6Qv7u9OcZZrKzYN3LVmEGm\n rXM43x3AitGjW9rC0qVTi3x2TmEVWuEWpdLKhHrSnTuHtJu73wKZw6LdTVGx1ZKFYSeq\n FbnHiBiuYvUEiGLhZsUG3W3nzmkxDjrOB8c1R66ot7CgOwNYDaM9Rbog7jfkb1Bcch2u\n Ns/g==","X-Gm-Message-State":"AOJu0YxMXF7UgQyeqtNcF+uGV9nGUOihJ6B690NtriN0+gX5TOnP0EiX\n 0lkDOkCCDu8hFYl2vYR8bxC8lVD17PBCXlhv7sBhyy+haNUMjd72lsx21QhkxaWM6zvddlQp99e\n nTRltYVk=","X-Gm-Gg":"AeBDievqv1WJkEsn8J/3AbxB5o1y5QAQliupB30BN5wn67QPyPt7eMf4mjzQpK1AHlf\n irQO1xTv+5qU+iw48KxMiCFpxUFLh2NOQj13jjnY0VeL5JJpRWvRKteJmVciHsuY+2fqK2HW/Wm\n pn6LM7s3QSeVvep9iTCIKXVIkeEL/KhqlQuKLaY1uQCYoNvirvDfoSc3/XQIW96SWy12fsdWM5Z\n WGRMF5zTbPqhA/3pEjBDlKlOP3Qq4oYg7I7IqpUdGhG1CJMMq8MOQhRc8WaTeoXk3w4jlwdnbCA\n pS/Nmn6XdNskGk8/+quu3qZWGjwR0LAYcybbF52Dp+Oh+WHW08OL+ugwWpdhdKkm98B9ZMUP1Kk\n kWaFY7+9kY351VuA9YT9qycsjSqDEMfKgHTtcnGD4E1qIYelNehrHI8Yz/TIUTq6ubBO4SK1gdf\n hX9DMfptD+FiF1FKrCORr4LkGEj6aYnF51cciYCguo","X-Received":"by 2002:a17:902:7612:b0:2b0:5450:a910 with SMTP id\n d9443c01a7336-2b5f9e95060mr243977355ad.17.1777210894750;\n Sun, 26 Apr 2026 06:41:34 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 33/84] fpu: Return struct from float4_e2m1_unpack_canonical","Date":"Sun, 26 Apr 2026 23:39:10 +1000","Message-ID":"<20260426134002.865628-34-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::629;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Inline float4_e2m1_unpack_raw at the same time.\n\nSigned-off-by: Richard Henderson \n---\n fpu/softfloat.c | 17 +++++------------\n 1 file changed, 5 insertions(+), 12 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 99b1cce894..c1d0140484 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -646,11 +646,6 @@ static FloatParts64 unpack_raw64(const FloatFmt *fmt, uint64_t raw)\n };\n }\n \n-static void QEMU_FLATTEN float4_e2m1_unpack_raw(FloatParts64 *p, float4_e2m1 f)\n-{\n- *p = unpack_raw64(&float4_e2m1_params, f);\n-}\n-\n static void QEMU_FLATTEN float8_e4m3_unpack_raw(FloatParts64 *p, float8_e4m3 f)\n {\n *p = unpack_raw64(&float8_e4m3_params, f);\n@@ -1473,11 +1468,11 @@ static const uint16_t rsqrt_tab[128] = {\n * Pack/unpack routines with a specific FloatFmt.\n */\n \n-static void float4_e2m1_unpack_canonical(FloatParts64 *p, float4_e2m1 f,\n- float_status *s)\n+static FloatParts64 float4_e2m1_unpack_canonical(float4_e2m1 f, float_status *s)\n {\n- float4_e2m1_unpack_raw(p, f);\n- parts64_canonicalize(p, s, &float4_e2m1_params);\n+ FloatParts64 p = unpack_raw64(&float4_e2m1_params, f);\n+ parts64_canonicalize(&p, s, &float4_e2m1_params);\n+ return p;\n }\n \n static void float8_e4m3_unpack_canonical(FloatParts64 *p, float8_e4m3 f,\n@@ -2699,9 +2694,7 @@ static void parts_float_to_float_widen(FloatParts128 *a, FloatParts64 *b,\n \n float8_e4m3 float4_e2m1_to_float8_e4m3(float4_e2m1 a, float_status *s)\n {\n- FloatParts64 p;\n-\n- float4_e2m1_unpack_canonical(&p, a, s);\n+ FloatParts64 p = float4_e2m1_unpack_canonical(a, s);\n parts64_float_to_float(&p, s);\n return float8_e4m3_round_pack_canonical(&p, s, false);\n }\n","prefixes":["33/84"]}