{"id":2228404,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228404/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-13-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-13-richard.henderson@linaro.org>","date":"2026-04-26T13:38:49","name":"[12/84] fpu: Drop parts_mul","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dcb519e0c8a603a3d7cebee535d9fa02c9a0fb32","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-13-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228404/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228404/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ThKRN8Y0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3SZH0KXsz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 23:43:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGzjF-00079L-6V; Sun, 26 Apr 2026 09:40:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzj1-00072I-QD\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:45 -0400","from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGziz-0008OM-Qg\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:43 -0400","by mail-pj1-x1035.google.com with SMTP id\n 98e67ed59e1d1-362e50b4641so1619094a91.0\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 06:40:41 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.40.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:40:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210840; x=1777815640; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=O1deF2a9CTcLPY51+HToPZPvFKlSh0LTVXG903qSvbY=;\n b=ThKRN8Y01bLQ6a+V0VLvmiC/zVbpOVOZ0G0cefIE7oeumXYz34wiTkCcce6IRLlcbB\n PkSma2WBf9Qwj2uPkRZ3t4BOsddzCwcTfMcSVl5SxUiHwJxcII22HP5O9bcA8F+9KgD0\n +9N/vzwhOu6zYz0+zyuQNr7x/j6qOr0gNA/8bvLBS3RSS3o/boVcVUbKTqMWNk+gwrMg\n Yue6EGouJCutnqRyeKt/Tpn5I/E3MVSyfeufc6vLQ3JIVNC/6/nTwZF202xkdJxo68z9\n Cf2Nxg/ctrHV5To50iBNV5HrzekJybzHwtjWTgFJ6TlOTQKp3ImEfN6x/ihndnwh1HFp\n TCZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210840; x=1777815640;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=O1deF2a9CTcLPY51+HToPZPvFKlSh0LTVXG903qSvbY=;\n b=O6oLWtBkyYz5IYREwDybHFf+AcwgZb6lk2YHdbhHiVN+fktqcKJagLWbUNDnErc4M9\n 5uZTzekwcRSv+8aypqm+ySduLvuPpEHD5cH5uM6yakRY3T94RJRjv+SDdTqHDyqxWHPM\n 92CLVznsI951JXNdF+W3vEbzk4KVTqdgaNVW8tuXIUZaS1jxhQDXSRcN+i5DNV5pVNQU\n K/dSrSJJfu8SOn3AsCJL818bgBRyPsV+xMLjvRv5ZzGxHWgXcB33YzksX65YUsSLdPAf\n i0+yXyAUWufIQmrUZ6HBrU8+/sTPuOhvn7xHp/rAVhKUMe8HfIR61ABSlSf+cNB3txh+\n BrUw==","X-Gm-Message-State":"AOJu0Yz717YO/OE5YWx8QFNaF25iz6OCD0UgZVk/DAuw/H74I3gvyVjy\n 0hM0ihngy/nLSseASMIWer2M7vmtfHWUBMCwZnSI6DYXLNAyRrqU5W0UiU4hwf+N54Z74oyNnK9\n /QuFpyL0=","X-Gm-Gg":"AeBDiesy+GhYQR+OsNDjy9TYt/6ZH6gwG57bjtZ5SiC/gY3SUqHXPRmKgR8b3zg4lGm\n YZLtBsmyoyg/GfUlThiN4XuAm34y56fkkndrydgmhizROerIWzm5EKJRxhnt/gv7plNArk2luHY\n /yKgHe6v9QIxcmRMkCZHD8tZS1hbWGTBG4yIGwF2sTFC7cd2oSA7D6gxxrWyhoX7CxQldHlHRt6\n wDv/u9+Pupv8OiuyihNEbXoRA4iet/CaD8Iq27N0DfksIZfARztLU7mkg3/gjVNIstmq9cmopOi\n WakOccARZOSCnxSNn6rr2fJAQt9F7hqGIto0WK7ckiQQ6v1D3xUtdkXM13xABMx9kk5yWlJngiA\n VRmo/YLnbhVeUISeV2pKAPIo/aC6GCL6UeWsNzRKwK12amKqcN8f09r4jtDNqX/bASKxOMoez/p\n Bb/tA8lbNkZzLTPjAzT3UjyG/g/lZSi3P7wcPaebAC","X-Received":"by 2002:a17:902:cf08:b0:2ab:230d:2d96 with SMTP id\n d9443c01a7336-2b5f9eaf621mr421690415ad.11.1777210840181;\n Sun, 26 Apr 2026 06:40:40 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 12/84] fpu: Drop parts_mul","Date":"Sun, 26 Apr 2026 23:38:49 +1000","Message-ID":"<20260426134002.865628-13-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1035;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_mul at each call site.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 26 +++++++++-----------------\n 1 file changed, 9 insertions(+), 17 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex dc5ce53105..8adc73c863 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,14 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n                   FloatParts128 *: parts128_##NAME, \\\n                   FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_mul(FloatParts64 *a, FloatParts64 *b,\n-                                 float_status *s);\n-static FloatParts128 *parts128_mul(FloatParts128 *a, FloatParts128 *b,\n-                                   float_status *s);\n-\n-#define parts_mul(A, B, S) \\\n-    PARTS_GENERIC_64_128(mul, A)(A, B, S)\n-\n static FloatParts64 *parts64_muladd_scalbn(FloatParts64 *a, FloatParts64 *b,\n                                            FloatParts64 *c, int scale,\n                                            int flags, float_status *s);\n@@ -2149,7 +2141,7 @@ float16 QEMU_FLATTEN float16_mul(float16 a, float16 b, float_status *status)\n \n     float16_unpack_canonical(&pa, a, status);\n     float16_unpack_canonical(&pb, b, status);\n-    pr = parts_mul(&pa, &pb, status);\n+    pr = parts64_mul(&pa, &pb, status);\n \n     return float16_round_pack_canonical(pr, status);\n }\n@@ -2161,7 +2153,7 @@ soft_f32_mul(float32 a, float32 b, float_status *status)\n \n     float32_unpack_canonical(&pa, a, status);\n     float32_unpack_canonical(&pb, b, status);\n-    pr = parts_mul(&pa, &pb, status);\n+    pr = parts64_mul(&pa, &pb, status);\n \n     return float32_round_pack_canonical(pr, status);\n }\n@@ -2173,7 +2165,7 @@ soft_f64_mul(float64 a, float64 b, float_status *status)\n \n     float64_unpack_canonical(&pa, a, status);\n     float64_unpack_canonical(&pb, b, status);\n-    pr = parts_mul(&pa, &pb, status);\n+    pr = parts64_mul(&pa, &pb, status);\n \n     return float64_round_pack_canonical(pr, status);\n }\n@@ -2208,7 +2200,7 @@ float64 float64r32_mul(float64 a, float64 b, float_status *status)\n \n     float64_unpack_canonical(&pa, a, status);\n     float64_unpack_canonical(&pb, b, status);\n-    pr = parts_mul(&pa, &pb, status);\n+    pr = parts64_mul(&pa, &pb, status);\n \n     return float64r32_round_pack_canonical(pr, status);\n }\n@@ -2220,7 +2212,7 @@ bfloat16_mul(bfloat16 a, bfloat16 b, float_status *status)\n \n     bfloat16_unpack_canonical(&pa, a, status);\n     bfloat16_unpack_canonical(&pb, b, status);\n-    pr = parts_mul(&pa, &pb, status);\n+    pr = parts64_mul(&pa, &pb, status);\n \n     return bfloat16_round_pack_canonical(pr, status);\n }\n@@ -2232,7 +2224,7 @@ float128_mul(float128 a, float128 b, float_status *status)\n \n     float128_unpack_canonical(&pa, a, status);\n     float128_unpack_canonical(&pb, b, status);\n-    pr = parts_mul(&pa, &pb, status);\n+    pr = parts128_mul(&pa, &pb, status);\n \n     return float128_round_pack_canonical(pr, status);\n }\n@@ -2247,7 +2239,7 @@ floatx80_mul(floatx80 a, floatx80 b, float_status *status)\n         return floatx80_default_nan(status);\n     }\n \n-    pr = parts_mul(&pa, &pb, status);\n+    pr = parts128_mul(&pa, &pb, status);\n     return floatx80_round_pack_canonical(pr, status);\n }\n \n@@ -5443,7 +5435,7 @@ float32 float32_exp2(float32 a, float_status *status)\n     float_raise(float_flag_inexact, status);\n \n     float64_unpack_canonical(&tp, float64_ln2, status);\n-    xp = *parts_mul(&xp, &tp, status);\n+    xp = *parts64_mul(&xp, &tp, status);\n     xnp = xp;\n \n     float64_unpack_canonical(&rp, float64_one, status);\n@@ -5451,7 +5443,7 @@ float32 float32_exp2(float32 a, float_status *status)\n \n         float64_unpack_canonical(&tp, float32_exp2_coefficients[i], status);\n         rp = *parts_muladd_scalbn(&tp, &xnp, &rp, 0, 0, status);\n-        xnp = *parts_mul(&xnp, &xp, status);\n+        xnp = *parts64_mul(&xnp, &xp, status);\n     }\n \n     return float32_round_pack_canonical(&rp, status);\n","prefixes":["12/84"]}