{"id":2228400,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-16-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-16-richard.henderson@linaro.org>","date":"2026-04-26T13:38:52","name":"[15/84] fpu: Drop parts_modrem","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cc275de44e02d8c520c60914bbc8ee3196bd4926","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-16-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228400/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228400/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=igbknsB2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3SY11zNCz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 23:41:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGzjG-0007As-4R; Sun, 26 Apr 2026 09:40:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzj9-00075F-JD\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:51 -0400","from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzj7-0008QS-2C\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:51 -0400","by mail-pg1-x52c.google.com with SMTP id\n 41be03b00d2f7-c79467f128cso3450969a12.3\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 06:40:48 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.40.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:40:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210848; x=1777815648; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8b2W9gnYSMYefVuUFksO85W3oVzQ2QH9P08u6esF1Pc=;\n b=igbknsB2XASvMr8/uyiqr80p6lgkY66IFZEOF6ftr8Xxm+AJwPat6q8YL41p8SdzL/\n QHyaiISRrMfjfWXVcamZwQ4P6FGwpWjGwulW9lmA6zFRFIjNTLjg9sPcjIoC5EiWKOUL\n jvLKGR4ku/Hz7VcQTvhM/aKzoBnERB4XAMqQd6Nn6PNUzlXaqoTs3Iw5ysRz5+Ii1Mk5\n GYq7GmQVTCrk1UUZZdY5gvEQmJ24B5lm33Dqz0SeiaveeFpPHtti2PInh4rMa/HSm7hw\n 5wa1Y0ReP2eDQ6HYEfF4wSWUjfNiurKIJ98VrJ2nvXXTIfupHl6PrnRLVdMiNePn5gQt\n XMgw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210848; x=1777815648;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8b2W9gnYSMYefVuUFksO85W3oVzQ2QH9P08u6esF1Pc=;\n b=mpv1jfirnpsXCz72nm2HVk1tNWpQuNKoEG8smCJqlQP6/iOSo+zX2JOY30BTjCljB7\n fCBwq52rKn5TO+p05c/7ePruzFsbGNLD5BovMs8RTxVD7rBII7NSBbFiuByCHfdMa5Nq\n WEn/NBmfYJqk0LrdFS2SxoEacM/ma0AQjnPX5Mh9ZH/quGbk17MX+6UQhWmi3jm+a7s1\n Q+EawcjRUhPRtkH9g9ZaJjjBjNIEzQM/PrinqYPOjemSmj95G9QzW2TZq1sDRPjdflQP\n gnwK98kSqTyosBy66vkAvePfXJow4d3fVjL1DZAUoOSmZDm0IcfqG3X5kYt52wb2rMFZ\n hpoA==","X-Gm-Message-State":"AOJu0YwSfo0jwNBIc9M4Uhn6ub0UV+7byZHhm9ozLk1PV+92mGowzSft\n uOeCWmnBb5q1K1gYEFKfkspTPd23SYTn/w+NiT/mV09hmCtSQGa6GypfnsxBBXv1tFHnFaeJmy3\n oc6ktxd0=","X-Gm-Gg":"AeBDiesSdCYofSuhCU1ZMlLgmz52Iylyvri8eKOdKbP1BzDLsCJOCF7SdIbFpLwCsUH\n G+llVSsS1rXktjulnvAtP5pGC9RHH8wzPLaUXtaOl7H1DhvEEVaWOcxiT1s0/Bf6Wf7upNReNjH\n wmmunakdLjd2QyCDQxPsqbH6mXqhj84CwNatXj8c2wPJRr8cjJn34cIhPojUrBllfSkwh4BTHUX\n WD3XvfLPmI2Lv1tOoNbH+/Ryq75ghEHa/xL8jTS2ssUuP/APrr4i8EwTUcZ4aLowq7pJcDkPlMk\n Olh2Su8I7KTyisSgltZCSvrUPreRz6SBwxK9fw+wKxpXNlNH8zHAUXYEBrB4EgruAJLFTXbINyH\n wC4iSPnvkfg+DhUQRdNbtTF9s7A7Jt7iRp2OaldliUF857k3FMWH3tarX7BbHUKby5vGBvwnR45\n KH0ZHCESRIlPr9mk4hJj6GoWAVzEO1AMJD4u7Vi5WV","X-Received":"by 2002:a17:903:17c3:b0:2b0:708f:4dc7 with SMTP id\n d9443c01a7336-2b5f9f3b367mr433182745ad.29.1777210847608;\n Sun, 26 Apr 2026 06:40:47 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 15/84] fpu: Drop parts_modrem","Date":"Sun, 26 Apr 2026 23:38:52 +1000","Message-ID":"<20260426134002.865628-16-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::52c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_modrem at each call site.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 16 ++++------------\n 1 file changed, 4 insertions(+), 12 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex b885eae629..91d8e48ce4 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,14 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n                   FloatParts128 *: parts128_##NAME, \\\n                   FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_modrem(FloatParts64 *a, FloatParts64 *b,\n-                                    uint64_t *mod_quot, float_status *s);\n-static FloatParts128 *parts128_modrem(FloatParts128 *a, FloatParts128 *b,\n-                                      uint64_t *mod_quot, float_status *s);\n-\n-#define parts_modrem(A, B, Q, S) \\\n-    PARTS_GENERIC_64_128(modrem, A)(A, B, Q, S)\n-\n static void parts64_sqrt(FloatParts64 *a, float_status *s, const FloatFmt *f);\n static void parts128_sqrt(FloatParts128 *a, float_status *s, const FloatFmt *f);\n \n@@ -2642,7 +2634,7 @@ float32 float32_rem(float32 a, float32 b, float_status *status)\n \n     float32_unpack_canonical(&pa, a, status);\n     float32_unpack_canonical(&pb, b, status);\n-    pr = parts_modrem(&pa, &pb, NULL, status);\n+    pr = parts64_modrem(&pa, &pb, NULL, status);\n \n     return float32_round_pack_canonical(pr, status);\n }\n@@ -2653,7 +2645,7 @@ float64 float64_rem(float64 a, float64 b, float_status *status)\n \n     float64_unpack_canonical(&pa, a, status);\n     float64_unpack_canonical(&pb, b, status);\n-    pr = parts_modrem(&pa, &pb, NULL, status);\n+    pr = parts64_modrem(&pa, &pb, NULL, status);\n \n     return float64_round_pack_canonical(pr, status);\n }\n@@ -2664,7 +2656,7 @@ float128 float128_rem(float128 a, float128 b, float_status *status)\n \n     float128_unpack_canonical(&pa, a, status);\n     float128_unpack_canonical(&pb, b, status);\n-    pr = parts_modrem(&pa, &pb, NULL, status);\n+    pr = parts128_modrem(&pa, &pb, NULL, status);\n \n     return float128_round_pack_canonical(pr, status);\n }\n@@ -2688,7 +2680,7 @@ floatx80 floatx80_modrem(floatx80 a, floatx80 b, bool mod,\n         !floatx80_unpack_canonical(&pb, b, status)) {\n         return floatx80_default_nan(status);\n     }\n-    pr = parts_modrem(&pa, &pb, mod ? quotient : NULL, status);\n+    pr = parts128_modrem(&pa, &pb, mod ? quotient : NULL, status);\n \n     return floatx80_round_pack_canonical(pr, status);\n }\n","prefixes":["15/84"]}