{"id":2228397,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228397/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-8-richard.henderson@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426134002.865628-8-richard.henderson@linaro.org>","date":"2026-04-26T13:38:44","name":"[07/84] fpu: Drop parts_pick_nan","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"517890ea9ad56f5c16a7d44b6eb2e76baa2b83c2","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.1/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-8-richard.henderson@linaro.org/mbox/","series":[{"id":501533,"url":"http://patchwork.ozlabs.org/api/1.1/series/501533/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533","date":"2026-04-26T13:38:37","name":"fpu: Export some internals for targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/501533/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228397/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228397/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NCV3ODXJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3SXR0Y37z1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 23:41:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGzj9-00074v-SU; Sun, 26 Apr 2026 09:40:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzio-0006u7-Hf\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:32 -0400","from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzim-0008Kx-B8\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:30 -0400","by mail-pl1-x62d.google.com with SMTP id\n d9443c01a7336-2b24fcc2b5dso58382585ad.1\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 06:40:27 -0700 (PDT)","from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.40.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:40:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210827; x=1777815627; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5pFIOX/z0+aGze4rLka9drPNkmHdGrfhz/CpEbxvoxw=;\n b=NCV3ODXJo0xM5MnNXxBhLXkMWAjjiXZOaPCd7RvQ6RJc4pDyLj5IkDSs9meCriZ+e8\n qJhPoQW9VD47kgn2AtULqAHn/sqUQ19vznUKSY8E/5ZPYbzmkEvXWmKRTzbl2Jkkz0f7\n aqwjFDrXypy9mCcEUTE7VLcnrpujkZC0/UT+JuW1OreG2Z374wu3ZCMojAMtuJkexpa4\n 6GxaKTls2/aapjK8DL6QBULbKpGlxA+Jcff7rLN7Ukg5aKVbCKtTDIr8YzhvtEuvqf/T\n rk1F7rTSDqci57/Ysga48E2iP/n4b97UwCCsDrXeEp+wuefer5FOSA0PcmJV9+r689C5\n TwBA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210827; x=1777815627;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=5pFIOX/z0+aGze4rLka9drPNkmHdGrfhz/CpEbxvoxw=;\n b=Jefh5H4O+T0teQjd+h8TFRIpD3A1R794PLVHXD6GCc5zKrpYTP+3n7Ak12XE7mgxEj\n iCqv/fiIsePCtwMhMhSq4XQZIujkMHHX5xcQyyEyAn5flQC7B/RkWGsHX4xnLaz1rgci\n 32VB2qVIG/ipbhAVV39XgM6C2+6qRsJ0nBmKzBq727PMpIKRq1AEk5As82n9mWaqV3p2\n bxxvF0iMsV6lRqQn8TErZNynAlWhl9sP085Mq2bj3Wp7pEWnximqzpS3dqelQXo3wJd8\n dKo8zL4VIlSVQUVPLs62bUUmjl5Dpy4Yeg8n/0JpLcYl+BmVJbjCaNNkHu4rik/Zw2e3\n yW3g==","X-Gm-Message-State":"AOJu0Yx1x1cyPBeRH/0up4318cO6Y2Xt7HRr54eySqH3q311Vqqzuyju\n WScZKfDSGCLcCpmo14XwpQm4U7+W0tRMQbfnj7zXBU/L1ZPgFs3D3SDmCXLJ31ABKITusJqKqLN\n yCHQqokY=","X-Gm-Gg":"AeBDietcMPILek1VTWYkyUHfAeWWuD+LyHp7d+/qraoLwX+oYlr/KVJ0EG+gUXJj1LN\n Fysn9XYvGuCRjKJ7ZgbLDE0XbNBQUrrolFcwdwHwxcbuK3E+KYt5/6N0fbLjwX6s83ln3o4BwRE\n CfSq4U6E/EC7Tq/ND/3PpEOtI297WyQoNGjmXi+3sERisup8bOoBCmmjV1mJoZ5IzYU+kTjeHfA\n yUKVWRAkLacmbsscesMt1623tO6I01sXJJr6E+YK+1J0buWuj5dlFsEswieqb83KM8plvBWhair\n 1E1dM4KDQ1TqexzCNIvPilT+ep45kOlV26XH2szQICRpxza6EE5SEEA2uw7ouFjF0ObsukxKixb\n mP+T09dmRXaRNK5vh2Ujgg7YUtXI8gmamr0XoUZli3iI+zsAbbrC+wdVaUSa9hBcD++iMzClMbN\n +DSEYILiSR+84hky5PJpWIbnFMpwM7mZ5YE2o4K4Gx","X-Received":"by 2002:a17:903:b8f:b0:2b2:5857:583e with SMTP id\n d9443c01a7336-2b5f9fc0641mr398974785ad.31.1777210826884;\n Sun, 26 Apr 2026 06:40:26 -0700 (PDT)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org","Subject":"[PATCH 07/84] fpu: Drop parts_pick_nan","Date":"Sun, 26 Apr 2026 23:38:44 +1000","Message-ID":"<20260426134002.865628-8-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426134002.865628-1-richard.henderson@linaro.org>","References":"<20260426134002.865628-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use parts{64,128}_pick_nan at each call site.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c           | 11 ++---------\n fpu/softfloat-parts.c.inc | 10 +++++-----\n 2 files changed, 7 insertions(+), 14 deletions(-)","diff":"diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 50a625fd0a..98ddc00936 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -779,13 +779,6 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n                   FloatParts128 *: parts128_##NAME, \\\n                   FloatParts256 *: parts256_##NAME)\n \n-static FloatParts64 *parts64_pick_nan(FloatParts64 *a, FloatParts64 *b,\n-                                      float_status *s);\n-static FloatParts128 *parts128_pick_nan(FloatParts128 *a, FloatParts128 *b,\n-                                        float_status *s);\n-\n-#define parts_pick_nan(A, B, S)    PARTS_GENERIC_64_128(pick_nan, A)(A, B, S)\n-\n static FloatParts64 *parts64_pick_nan_muladd(FloatParts64 *a, FloatParts64 *b,\n                                              FloatParts64 *c, float_status *s,\n                                              int ab_mask, int abc_mask);\n@@ -5175,7 +5168,7 @@ floatx80 propagateFloatx80NaN(floatx80 a, floatx80 b, float_status *status)\n         return floatx80_default_nan(status);\n     }\n \n-    pr = parts_pick_nan(&pa, &pb, status);\n+    pr = parts128_pick_nan(&pa, &pb, status);\n     return floatx80_round_pack_canonical(pr, status);\n }\n \n@@ -5525,7 +5518,7 @@ static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b,\n {\n     /* POp table \"Results: DIVIDE TO INTEGER (Part 1 of 2)\" */\n     if ((float_cmask(a->cls) | float_cmask(b->cls)) & float_cmask_anynan) {\n-        *r = *parts_pick_nan(a, b, status);\n+        *r = *parts64_pick_nan(a, b, status);\n         *n = *r;\n         *cc = 1;\n     } else if (a->cls == float_class_inf || b->cls == float_class_zero) {\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 3bde254bfe..1a2eb7852d 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -604,7 +604,7 @@ static FloatPartsN *partsN(addsub)(FloatPartsN *a, FloatPartsN *b,\n     return b;\n \n  p_nan:\n-    return parts_pick_nan(a, b, s);\n+    return partsN(pick_nan)(a, b, s);\n }\n \n /*\n@@ -646,7 +646,7 @@ static FloatPartsN *partsN(mul)(FloatPartsN *a, FloatPartsN *b,\n     }\n \n     if (unlikely(ab_mask & float_cmask_anynan)) {\n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     /* Multiply by 0 or Inf */\n@@ -832,7 +832,7 @@ static FloatPartsN *partsN(div)(FloatPartsN *a, FloatPartsN *b,\n \n     /* All the NaN cases */\n     if (unlikely(ab_mask & float_cmask_anynan)) {\n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     if ((ab_mask & float_cmask_denormal) && b->cls != float_class_zero) {\n@@ -890,7 +890,7 @@ static FloatPartsN *partsN(modrem)(FloatPartsN *a, FloatPartsN *b,\n \n     /* All the NaN cases */\n     if (unlikely(ab_mask & float_cmask_anynan)) {\n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     /* Inf % N; N % 0 */\n@@ -1592,7 +1592,7 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b,\n             return is_nan(a->cls) ? b : a;\n         }\n \n-        return parts_pick_nan(a, b, s);\n+        return partsN(pick_nan)(a, b, s);\n     }\n \n     if (ab_mask & float_cmask_denormal) {\n","prefixes":["07/84"]}