{"id":2228386,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228386/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260426113937.30818-1-ddiss@suse.de/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426113937.30818-1-ddiss@suse.de>","date":"2026-04-26T11:39:37","name":"smb/client: remove unused smb3_parse_opt()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1c963f5c099f572f0b1c02cbd5eb7e7a51becfd8","submitter":{"id":26890,"url":"http://patchwork.ozlabs.org/api/1.1/people/26890/?format=json","name":"David Disseldorp","email":"ddiss@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260426113937.30818-1-ddiss@suse.de/mbox/","series":[{"id":501527,"url":"http://patchwork.ozlabs.org/api/1.1/series/501527/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501527","date":"2026-04-26T11:39:37","name":"smb/client: remove unused smb3_parse_opt()","version":1,"mbox":"http://patchwork.ozlabs.org/series/501527/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228386/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228386/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=tN0zX9my;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=rQsn9D3n;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=tN0zX9my;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=rQsn9D3n;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11130-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"tN0zX9my\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"rQsn9D3n\";\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"tN0zX9my\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"rQsn9D3n\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.131","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.de","smtp-out2.suse.de;\n\tdkim=pass header.d=suse.de header.s=susede2_rsa header.b=tN0zX9my;\n\tdkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rQsn9D3n"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3PrT570Kz1xvV\n\tfor ; Sun, 26 Apr 2026 21:40:09 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 88C75300FEC2\n\tfor ; Sun, 26 Apr 2026 11:40:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E2B94286D73;\n\tSun, 26 Apr 2026 11:40:06 +0000 (UTC)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB49225403\n\tfor ; Sun, 26 Apr 2026 11:40:05 +0000 (UTC)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id 8EBB65BD1F;\n\tSun, 26 Apr 2026 11:40:03 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B2FCA593B0;\n\tSun, 26 Apr 2026 11:40:01 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid +CHwGJH57Wm0ewAAD6G6ig\n\t(envelope-from ); Sun, 26 Apr 2026 11:40:01 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777203606; cv=none;\n b=BgWWkSwePaCBvezxNSGE9T9CNd5B+O/0LtnGKEQArucCXjYG+6UM/j0HTRcKQnAql2+zeXs3mJEzi1dZVa8iE+2PAABfuZEpMQKlXycLVrCEBqwKK4W6NeHhckG6PCzPxZizD3A3Cad2ue4zh1E04njLXZrgfDdj0NbZ4ABFIS0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777203606; c=relaxed/simple;\n\tbh=uUSWvtReHSlFTIbCuzSEBV2iRHYiwBnsryAviXJOa88=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=H/ye5sustyQui2v2Wf4yMSlfNCw91cfs7pylAX9fr+kTqz9tuMgg/7RtDqlPhqab52kVBdzKzOgvsvRpnybSHL3CxlUaaqPifXBxDjKRU3omim9DKqFmEioKPjhk9N34IYoOax8/XCZD4qtStkyp4V7rMa6KzSriAJQx6urcV0I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de;\n spf=pass smtp.mailfrom=suse.de;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=tN0zX9my;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=rQsn9D3n;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=tN0zX9my;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=rQsn9D3n; arc=none smtp.client-ip=195.135.223.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777203603;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n\tbh=k7CUfRvC2GQWVFD5dgWSAr1t4h4XzQuC/Gopo1bQkaY=;\n\tb=tN0zX9myvyJDu4FF1C5TytJTK1AwB4LTElk395KN+x/We8hVR+0AKGg/1xi4NsP7THOEQf\n\tCW1OXyetzz9m1vK+oYJadWocHcuLAoNfvhcqOA4kg7Q9yiJT1tB9mROyovf4AakafkFa5D\n\tRQfpGRJFfZLP2vOjKtUnkzGPQKHxQiE=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777203603;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n\tbh=k7CUfRvC2GQWVFD5dgWSAr1t4h4XzQuC/Gopo1bQkaY=;\n\tb=rQsn9D3nJJcJXLzty0AdkVmvMP7DwktBdYIIEwnjiyIwcOAmARKHwbH4W+hfRYupcHRLTu\n\tdVK9265JCAxiS+BQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777203603;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n\tbh=k7CUfRvC2GQWVFD5dgWSAr1t4h4XzQuC/Gopo1bQkaY=;\n\tb=tN0zX9myvyJDu4FF1C5TytJTK1AwB4LTElk395KN+x/We8hVR+0AKGg/1xi4NsP7THOEQf\n\tCW1OXyetzz9m1vK+oYJadWocHcuLAoNfvhcqOA4kg7Q9yiJT1tB9mROyovf4AakafkFa5D\n\tRQfpGRJFfZLP2vOjKtUnkzGPQKHxQiE=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777203603;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n\tbh=k7CUfRvC2GQWVFD5dgWSAr1t4h4XzQuC/Gopo1bQkaY=;\n\tb=rQsn9D3nJJcJXLzty0AdkVmvMP7DwktBdYIIEwnjiyIwcOAmARKHwbH4W+hfRYupcHRLTu\n\tdVK9265JCAxiS+BQ=="],"From":"David Disseldorp ","To":"linux-cifs@vger.kernel.org","Cc":"Steve French ,\n\tPaulo Alcantara ,\n\tDavid Disseldorp ","Subject":"[PATCH] smb/client: remove unused smb3_parse_opt()","Date":"Sun, 26 Apr 2026 21:39:37 +1000","Message-ID":"<20260426113937.30818-1-ddiss@suse.de>","X-Mailer":"git-send-email 2.51.0","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.01 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tMID_CONTAINS_FROM(1.00)[];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tR_MISSING_CHARSET(0.50)[];\n\tR_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMX_GOOD(-0.01)[];\n\tURIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tTO_DN_SOME(0.00)[];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tARC_NA(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tFREEMAIL_CC(0.00)[gmail.com,manguebit.org,suse.de];\n\tRCVD_TLS_ALL(0.00)[];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tFROM_HAS_DN(0.00)[];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tDNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n\tDKIM_TRACE(0.00)[suse.de:+];\n\tRCPT_COUNT_THREE(0.00)[4];\n\tFREEMAIL_ENVRCPT(0.00)[gmail.com]","X-Rspamd-Queue-Id":"8EBB65BD1F","X-Spam-Flag":"NO","X-Spam-Score":"-3.01","X-Spam-Level":""},"content":"Commit abdb1742a3123 (\"cifs: get rid of mount options string parsing\")\nremoved the last caller.\n\nSigned-off-by: David Disseldorp \n---\n fs/smb/client/cifsproto.h | 1 -\n fs/smb/client/fs_context.c | 31 -------------------------------\n 2 files changed, 32 deletions(-)","diff":"diff --git a/fs/smb/client/cifsproto.h b/fs/smb/client/cifsproto.h\nindex 884bfa1cf0b42..b7cd67b64a833 100644\n--- a/fs/smb/client/cifsproto.h\n+++ b/fs/smb/client/cifsproto.h\n@@ -89,7 +89,6 @@ int cifs_handle_standard(struct TCP_Server_Info *server,\n \t\t\t struct mid_q_entry *mid);\n char *smb3_fs_context_fullpath(const struct smb3_fs_context *ctx, char dirsep);\n int smb3_parse_devname(const char *devname, struct smb3_fs_context *ctx);\n-int smb3_parse_opt(const char *options, const char *key, char **val);\n int cifs_ipaddr_cmp(struct sockaddr *srcaddr, struct sockaddr *rhs);\n bool cifs_match_ipaddr(struct sockaddr *srcaddr, struct sockaddr *rhs);\n int cifs_discard_remaining_data(struct TCP_Server_Info *server);\ndiff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c\nindex a46764c247107..6433eb2093dce 100644\n--- a/fs/smb/client/fs_context.c\n+++ b/fs/smb/client/fs_context.c\n@@ -536,37 +536,6 @@ cifs_parse_smb_version(struct fs_context *fc, char *value, struct smb3_fs_contex\n \treturn 0;\n }\n \n-int smb3_parse_opt(const char *options, const char *key, char **val)\n-{\n-\tint rc = -ENOENT;\n-\tchar *opts, *orig, *p;\n-\n-\torig = opts = kstrdup(options, GFP_KERNEL);\n-\tif (!opts)\n-\t\treturn -ENOMEM;\n-\n-\twhile ((p = strsep(&opts, \",\"))) {\n-\t\tchar *nval;\n-\n-\t\tif (!*p)\n-\t\t\tcontinue;\n-\t\tif (strncasecmp(p, key, strlen(key)))\n-\t\t\tcontinue;\n-\t\tnval = strchr(p, '=');\n-\t\tif (nval) {\n-\t\t\tif (nval == p)\n-\t\t\t\tcontinue;\n-\t\t\t*nval++ = 0;\n-\t\t\t*val = kstrdup(nval, GFP_KERNEL);\n-\t\t\trc = !*val ? -ENOMEM : 0;\n-\t\t\tgoto out;\n-\t\t}\n-\t}\n-out:\n-\tkfree(orig);\n-\treturn rc;\n-}\n-\n /*\n * Remove duplicate path delimiters. Windows is supposed to do that\n * but there are some bugs that prevent rename from working if there are\n","prefixes":[]}