{"id":2228347,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228347/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426-gtk-clipboard-v3-1-09555aaeda34@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260426-gtk-clipboard-v3-1-09555aaeda34@gmail.com>","date":"2026-04-26T07:52:33","name":"[v3,1/2] ui/gtk: Use non-blocking clipboard retrieval","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0f38497f1308aee2a9e58cbf570b48e1f6ef1a63","submitter":{"id":4408,"url":"http://patchwork.ozlabs.org/api/1.1/people/4408/?format=json","name":"Jindřich Makovička","email":"makovick@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426-gtk-clipboard-v3-1-09555aaeda34@gmail.com/mbox/","series":[{"id":501511,"url":"http://patchwork.ozlabs.org/api/1.1/series/501511/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501511","date":"2026-04-26T07:52:32","name":"Fix and re-enable GTK clipboard","version":3,"mbox":"http://patchwork.ozlabs.org/series/501511/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228347/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228347/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=qhSWPHoa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Jpv2YM7z1yJJ\n\tfor ; Sun, 26 Apr 2026 17:53:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGuII-0000cz-KO; Sun, 26 Apr 2026 03:52:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGuIC-0000bk-T9\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 03:52:41 -0400","from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGuIA-0006N9-PP\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 03:52:40 -0400","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so114657015e9.2\n for ; Sun, 26 Apr 2026 00:52:38 -0700 (PDT)","from [192.168.0.10] ([2a03:ab00:1000:1b60:331a:b316:78f6:effc])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb74c68asm224080045e9.3.2026.04.26.00.52.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 00:52:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777189957; x=1777794757; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=tMkUi0r7yzmpH9iWXuskk1HxFeNLDP8o5ANaBDDxtg0=;\n b=qhSWPHoaT3HFtCjuALP1zI/fsMKkAI0rK/V14QTYaYqEhOgz09sbrvhE+WzAKLE6he\n 2jTi17Cg+z8stzINwTDj3sOAAp6b/TyTla+pxWtFzeBshpMVh6XFubjEpMq1IVZqAekD\n ptdCQpYXUtvta1ytfPCGDfvv9SUxhDRNCskyeE+v450Jwo9OuPoDzgqdph317mgjcoZw\n 1mRlKVwSkdfGjsxFx/yCk65HxN0i8BQQ+9LERhwjT17P5PElHi+OY8ujh3aLkknK+7aP\n mit/xDz8gpUNz4KEq5AE1DOLREPDNqANVq/2Hdt9+6b9SC+sE4N764wJZM3mUAo7TyZC\n X3Gw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777189957; x=1777794757;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=tMkUi0r7yzmpH9iWXuskk1HxFeNLDP8o5ANaBDDxtg0=;\n b=qHZjUKgJFuLw1PX95D3bUzcVbwKLpDAsq3dTa00LA9gcUu3BislNujiW5isjCzlLH6\n aDPG9HujJICZxJIi7wVreo2X+XRL2u4FVvq8mfZ12Nu6LRPSff0GVL/y7ni80OT4Dpja\n nbPSFy2yMCKCb6uVYxLDRXd/Okru5jNxCaiBkb4iTOCaH5za3bwBQW2msqrh6gjt5QWZ\n Qw7PLHNccJrFifiBl/sbTaQ4En4h4yfApHh39NZ5kRJK/0/UuL7LqezHGvpjyzPRiwXj\n J7DOLG+X3thXoMCs3Jxic8EmFKLLiFPD6J9IUK3UHI7U4wToaoMAzPh96bPRsnVEhCSE\n umvQ==","X-Gm-Message-State":"AOJu0YwpeVtmX4n83LyBAD89VG2kqQn1S7w63Yqtfntsh+SJKntYOnWc\n jTF81sNyPXLs+kY0LfWhVZwiCG1VLdUp/4YKBCa/Z1OMxNp6F2ESTtSNLwhDfNY1","X-Gm-Gg":"AeBDiev1U9km5wwVQKYlpOKiCR41DXJ6mPHH/JaLYCGPw018i3OZVCwptQnXJIgz7RS\n isfUSYnYDhpFVfehpsUSBwryuXmloVu8Ak5GncUWrGQgAYf+y9WiCtI95xmklDiCn/M+ufSE/8W\n T5v64/kPBEgd4HpGXviwrmFmFOOyMWpSqJpvXL89yvGnoUthZelbO1C5KfzgQ/s1gbR5XLaKHNt\n xmCCVVBzZehZHXkDxDBRy78gtxLKOkWWdmoWhe5hFugnKqsDwgOiC3PAPgx4H++F0g5C08cyXmQ\n S/eZySt+hvVU3GRegl3ClKGLHHC6XcT1fEjW/OxILC3lyHX7TNQWluRqmOsmCqiXBEcTEH93UIM\n aw1vCB/Hw0JX+gCQHQ0ADOZnEPIOIEzph9/OEDoDuTiQuOZ00x9BmQAWoNEXLxthVlfM921Ao9t\n 9H52RXez7JKOyqphDi00M4RcajNAVy6QcWmaaBB8EEmquwrpso6Q==","X-Received":"by 2002:a05:600c:c10a:b0:483:2c98:4368 with SMTP id\n 5b1f17b1804b1-488fb771613mr417462105e9.18.1777189956679;\n Sun, 26 Apr 2026 00:52:36 -0700 (PDT)","From":"=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= ","Date":"Sun, 26 Apr 2026 09:52:33 +0200","Subject":"[PATCH v3 1/2] ui/gtk: Use non-blocking clipboard retrieval","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260426-gtk-clipboard-v3-1-09555aaeda34@gmail.com>","References":"<20260426-gtk-clipboard-v3-0-09555aaeda34@gmail.com>","In-Reply-To":"<20260426-gtk-clipboard-v3-0-09555aaeda34@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n Pierrick Bouvier ,\n Jindrich Makovicka ","X-Mailer":"b4 0.14.3","Received-SPF":"pass client-ip=2a00:1450:4864:20::333;\n envelope-from=makovick@gmail.com; helo=mail-wm1-x333.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Jindrich Makovicka \n---\n ui/gtk-clipboard.c | 52 +++++++++++++++++++++++++++++++++++++++-------------\n 1 file changed, 39 insertions(+), 13 deletions(-)","diff":"diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c\nindex 65d89ec601..691784697d 100644\n--- a/ui/gtk-clipboard.c\n+++ b/ui/gtk-clipboard.c\n@@ -136,26 +136,54 @@ static void gd_clipboard_notify(Notifier *notifier, void *data)\n }\n }\n \n+static void\n+gd_clipboard_request_text_received_callback(GtkClipboard *clipboard,\n+ const gchar *text,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+\n+ if (text) {\n+ qemu_clipboard_set_data(info->owner, info, QEMU_CLIPBOARD_TYPE_TEXT,\n+ strlen(text), text, true);\n+ }\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_clipboard_request(QemuClipboardInfo *info,\n QemuClipboardType type)\n {\n GtkDisplayState *gd = container_of(info->owner, GtkDisplayState, cbpeer);\n- char *text;\n \n switch (type) {\n case QEMU_CLIPBOARD_TYPE_TEXT:\n- text = gtk_clipboard_wait_for_text(gd->gtkcb[info->selection]);\n- if (text) {\n- qemu_clipboard_set_data(&gd->cbpeer, info, type,\n- strlen(text), text, true);\n- g_free(text);\n- }\n+ qemu_clipboard_info_ref(info);\n+ gtk_clipboard_request_text(gd->gtkcb[info->selection],\n+ gd_clipboard_request_text_received_callback,\n+ info);\n break;\n default:\n break;\n }\n }\n \n+static void gd_clipboard_owner_change_contents_received_callback(\n+ GtkClipboard *clipboard,\n+ GtkSelectionData *selection_data,\n+ gpointer data)\n+{\n+ QemuClipboardInfo *info = (QemuClipboardInfo *)data;\n+\n+ if (selection_data) {\n+ if (gtk_selection_data_targets_include_text(selection_data)) {\n+ info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n+ }\n+ }\n+\n+ qemu_clipboard_update(info);\n+ qemu_clipboard_info_unref(info);\n+}\n+\n static void gd_owner_change(GtkClipboard *clipboard,\n GdkEvent *event,\n gpointer data)\n@@ -173,12 +201,10 @@ static void gd_owner_change(GtkClipboard *clipboard,\n switch (event->owner_change.reason) {\n case GDK_OWNER_CHANGE_NEW_OWNER:\n info = qemu_clipboard_info_new(&gd->cbpeer, s);\n- if (gtk_clipboard_wait_is_text_available(clipboard)) {\n- info->types[QEMU_CLIPBOARD_TYPE_TEXT].available = true;\n- }\n-\n- qemu_clipboard_update(info);\n- qemu_clipboard_info_unref(info);\n+ gtk_clipboard_request_contents(\n+ clipboard, gdk_atom_intern_static_string(\"TARGETS\"),\n+ gd_clipboard_owner_change_contents_received_callback,\n+ info);\n break;\n default:\n qemu_clipboard_peer_release(&gd->cbpeer, s);\n","prefixes":["v3","1/2"]}