{"id":2228337,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228337/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260426061356.581852-1-andrew.pinski@oss.qualcomm.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.1/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260426061356.581852-1-andrew.pinski@oss.qualcomm.com>","date":"2026-04-26T06:13:56","name":"match: Optimize `signed < 0 ? positive : min` into `(signed)min<(unsigned), (unsigned)positive>` [PR110262]","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"45597864338d81d321f6b8378b3f79dd10859ee2","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/1.1/people/91428/?format=json","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260426061356.581852-1-andrew.pinski@oss.qualcomm.com/mbox/","series":[{"id":501503,"url":"http://patchwork.ozlabs.org/api/1.1/series/501503/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=501503","date":"2026-04-26T06:13:56","name":"match: Optimize `signed < 0 ? positive : min` into `(signed)min<(unsigned), (unsigned)positive>` [PR110262]","version":1,"mbox":"http://patchwork.ozlabs.org/series/501503/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228337/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228337/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=dBzpjci2;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Umqg1fhs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=dBzpjci2;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Umqg1fhs","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=205.220.180.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3GdH22Slz1xvV\n\tfor ; Sun, 26 Apr 2026 16:14:37 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 137DC4BB58BA\n\tfor ; Sun, 26 Apr 2026 06:14:34 +0000 (GMT)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n by sourceware.org (Postfix) with ESMTPS id 422174BB3BC7\n for ; Sun, 26 Apr 2026 06:14:05 +0000 (GMT)","from pps.filterd (m0279873.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63Q3w24v3584454\n for ; Sun, 26 Apr 2026 06:14:04 GMT","from mail-pj1-f69.google.com (mail-pj1-f69.google.com\n [209.85.216.69])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drnnf2a9p-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Sun, 26 Apr 2026 06:14:04 +0000 (GMT)","by mail-pj1-f69.google.com with SMTP id\n 98e67ed59e1d1-3568090851aso22145229a91.1\n for ; Sat, 25 Apr 2026 23:14:04 -0700 (PDT)","from xeond2.wrightpinski.org ([98.97.37.24])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-3613fab1c5fsm10406305a91.4.2026.04.25.23.14.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 25 Apr 2026 23:14:01 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 137DC4BB58BA","OpenDKIM Filter v2.11.0 sourceware.org 422174BB3BC7"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 422174BB3BC7","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 422174BB3BC7","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777184045; cv=none;\n b=Z0gEwMkk2SU+O2WFdBoOfU7EPsfnnXQn6eovAbDEqx4k/8Fb+5w4mouNe/WdfSN5NkOcjd1Q60asjNP3hPrDilM8mJPVRTXsVDPjUfhzU49GCwidgJELO8aNUGy8weAg0ThVp+CMJKSiFYaRh6QnwkhfO9rFmhSfaG5JuOvAY+Y=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777184045; c=relaxed/simple;\n bh=ld8xhyj4IPchusM2gqopye8ILdSuzzRf5BLyxdln+wU=;\n h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID:\n MIME-Version;\n b=uvdZgTZA5KgLzbjXDOYOkNRnE92biJBeDe/+/zbpM0n3wQFoGUdqSjn76DXXqrq5vYRH+7PiG5WSR61T9Z+9VQSSRt+SmDidxrlOxTA6txvcjHYJhtPrgadxrdCd63niltfXUKGFevG2nZG2fmAYn/2eVM1l4lKZE13+uGrNz9Q=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=qcppdkim1; bh=iOMdW5DvdYkSpFQmNqBmsTsBFFHZ206P8b8\n nuGF4S8M=; b=dBzpjci2X4gApdEAW8yFR65s4M0XTT8zNOljzoOrsOFaTFv8Urn\n xJOGvwrPiQNiBUE4oYIGHQAc5Sh/dkjmRpIfsD2IlgTF4Jvi9ZV335Rl6gZaJXWI\n UIuAj7XbdjL9QmiPdTIFkLsk7mqdC74fOoL7Rp0zVEqIyab33wc5shkNk6METhQW\n henniYdCOe5zShHmGul9h8xAaQ+fMCUuAHkHl97xsxTtXRVRSLc9VrRHfDFm9iyK\n ychSdHMe7UFi39gQ3WGkH2ynOqazPnly9shAYaTB9PEpcEpkL5WACQu0mbH9HjuZ\n 1ldNcu7Y3NBGBwjmULtvlciA/eCLsjcZs8w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777184043; x=1777788843; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=iOMdW5DvdYkSpFQmNqBmsTsBFFHZ206P8b8nuGF4S8M=;\n b=Umqg1fhsvZItxC2PwH51AKkxb9ck9emRc+Jb4ht58JeWm86G7Imr01vbWUZPJUPXcU\n 5DWC66ufU3BorDGOR2RxU35XyIW9jwiA236eRqJtY+bHOHsv37yeu0diKY7jkiXB0MJ1\n Om7iNDMhLbcWElZh3NcFHR59Y79L2DXPgGtB4IvPw1HCxgtA2k2DdIsydEyVr6BGMz49\n gepMRGeDv2Ya0gwIHJHeIQ+R0yWa4gMLnI6HTm1AGM2BlJrYSf1x54L28i48WVnO/RFB\n i/n02bSIZQZe6IxnkLNzJmG+9m23ZJgXgBDuITnHSPvqs599Uwr3o3jM44BrVlz51Dr3\n p0tQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777184043; x=1777788843;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=iOMdW5DvdYkSpFQmNqBmsTsBFFHZ206P8b8nuGF4S8M=;\n b=hTE9jz0bPea4Xws/Ke5VfR39RR/DBYAFfCLJ+0xAfPn/JkGEhpyG+2TtKnT9P4nYvN\n zJHw9cJoIJev7MekSlMGzLTyoyybADtaNk+k04dzHkpJn18pGqe+GVmFLhKt28YGIyLZ\n Y4ZTv6oBNZM6XVtjYyFl+c6pQTcXXF0+UffgV8lSstlAKm2wMAdOmESQcgcwU9j25e6l\n OaKBpZaz38CUFyWH6DuG/bnIYZvPP2Nios9YW6STla79jujQx2vBTcxrncKn6ftIweHY\n nvnrDKi9XKsQPMAVD41U1m2vKKbeO1ra1gKz8afWiGkxXZ72fYvclrrph7GOnG5Nd6V/\n E/gA==","X-Gm-Message-State":"AOJu0Yz/4xveXoCuqnOSNa3vMhTI2A3bflJS6u/EKpRv+OY0xgOui/f5\n NrpiCyGHSE7i0yWtTQMklMieQP6yRFXA7Qh3ouStffSfFHFDkK7X2L8FyfR810oUCFym2Rj4d2Q\n mQNCJuV1Saf2qUM8wwDyfGT4G007v04xOWlFHJuvfjxQpzuLXbTJS1WXKQrR6cnFf28KK","X-Gm-Gg":"AeBDietSqxJmmUgDTFCHXbVq4cK3ZNI9Zdaw7xlNEfagN1FWksZ8kMewDXoWU/jO7Gr\n I9l+AskR6+JcG3FLuAg7LytHn7JnaAePJ8gZGJeH5AAMW8Npw4iyFyDbiua50MRGR/vcA/DfV7K\n SQPn8qmnBl/iOukc+qGEouMJNp/Qx87fezUgQ2/sRp/E3hmS86Xva90KHZ8MY6y3bjYjYsAr47b\n AvjNum6mb/bRyWRsif01b69hIcqLMP1vLRCDmDeAjnolWdtfTkSLxpKvl2ATYpuV+KR51ChMnAL\n kST4Ws05SQfA1ko7HwK2uHO+als7tW3+5DjNi5tyPWCNSTEpJxwfCHS8HLdgBKzM7J4j4MZdRQ6\n 1/kgnD6Lm8w+H2acmMYb/5Djl9/ctq4XnmaCiEWnFfrUzuYZSA4qeO7kV0Q==","X-Received":["by 2002:a17:90b:2fc4:b0:35f:b6d3:da7d with SMTP id\n 98e67ed59e1d1-361404635e6mr37055646a91.17.1777184042719;\n Sat, 25 Apr 2026 23:14:02 -0700 (PDT)","by 2002:a17:90b:2fc4:b0:35f:b6d3:da7d with SMTP id\n 98e67ed59e1d1-361404635e6mr37055630a91.17.1777184042138;\n Sat, 25 Apr 2026 23:14:02 -0700 (PDT)"],"From":"Andrew Pinski ","To":"gcc-patches@gcc.gnu.org","Cc":"Andrew Pinski ","Subject":"[PATCH] match: Optimize `signed < 0 ? positive : min` into `(signed)min<(unsigned), (unsigned)positive>` [PR110262]","Date":"Sat, 25 Apr 2026 23:13:56 -0700","Message-ID":"<20260426061356.581852-1-andrew.pinski@oss.qualcomm.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"T1L8LJ0Vnpj0VF3UpLKHQ0tqd8o1qtSb","X-Authority-Analysis":"v=2.4 cv=Y5rIdBeN c=1 sm=1 tr=0 ts=69edad2c cx=c_pps\n a=vVfyC5vLCtgYJKYeQD43oA==:117 a=w0PkusDaE8KgHugK57MH4g==:17\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8\n a=SyJGv6KNqAElQuYKShYA:9 a=rl5im9kqc5Lf4LNbBjHf:22","X-Proofpoint-GUID":"T1L8LJ0Vnpj0VF3UpLKHQ0tqd8o1qtSb","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI2MDA2MyBTYWx0ZWRfXyxwXs1whUOE5\n XnbXfVpKePgVJahR5kApINeUTU4Cb1/a7Pf4zgKuH6nWGnUyNbsOM99OUqB9aYQH5oeI8FGub/M\n qnGIgxXJ+VaxNZfYnygqG/PcezWdCzWagK3JmsPlNA3F9aadJN6WtdLyvf3om7JQMpxDHnWv7L4\n prGTN7SUKq5ppMEvgsN4AVtSTj1tfzPEfx+ZMZsWKYpR867A3pfZaHb2a6Ya9GnfFFBW3a04uhG\n 52Ki0iqoqZSMW3Go2D019+DbebpxlLYsmY6nWLOPOEArlndFKWAThJAPVdEBNb+I+4ZGK4K+McL\n uy2eCPmEuDObD0MQ1ELxhyUlWLMvg2C0hbwNwZGPNCdDGP6a9ug0EMawoC+dGpUHJ4VctaUH/IX\n fzzdPoB1tlerZkfXNPAYTUw1sgvfAQafU7VVjUSqmEmyHgxcSgwnzWnfMCXGuXdQwnVnK99iGF6\n im+P7MtLrtLH0PgO3oQ==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-26_02,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 phishscore=0 adultscore=0 clxscore=1015 priorityscore=1501\n lowpriorityscore=0 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604260063","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"While looking into PR 110252 a few years back, I noticed this missed\noptimization in code from sel-sched.cc. I only realized today\nI could generalize it to handle more than just 1 to all positive\nvalues.\nThis adds the pattern to optimize:\nsigned < 0 ? positive : min\ninto:\nunsigned ts = signed;\nunsigned ps = positive;\nunsigned ru = min;\n(signed)ru\n\nBootstrapped and tested on x86_64-linux-gnu.\n\n\tPR tree-optimization/110262\n\ngcc/ChangeLog:\n\n\t* match.pd (`signed < 0 ? positive : min`): New\n\tpattern.\n\ngcc/testsuite/ChangeLog:\n\n\t* gcc.dg/pr110262-1.c: New test.\n\t* gcc.dg/tree-ssa/phi-opt-46.c: New test.\n\t* gcc.dg/tree-ssa/phi-opt-47.c: New test.\n\nSigned-off-by: Andrew Pinski \n---\n gcc/match.pd | 11 ++++++++++\n gcc/testsuite/gcc.dg/pr110262-1.c | 12 +++++++++++\n gcc/testsuite/gcc.dg/tree-ssa/phi-opt-46.c | 15 ++++++++++++++\n gcc/testsuite/gcc.dg/tree-ssa/phi-opt-47.c | 24 ++++++++++++++++++++++\n 4 files changed, 62 insertions(+)\n create mode 100644 gcc/testsuite/gcc.dg/pr110262-1.c\n create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/phi-opt-46.c\n create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/phi-opt-47.c","diff":"diff --git a/gcc/match.pd b/gcc/match.pd\nindex 94f69185adf..f1be45b1993 100644\n--- a/gcc/match.pd\n+++ b/gcc/match.pd\n@@ -7109,6 +7109,17 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)\n \t\t TYPE_SIGN (type)))\n (max @2 @4)))))))\n \n+/* Optimize signed < 0 ? positive : MIN to\n+ MIN<(unsigned)signed, (unsigned)positive>. */\n+(simplify\n+ (cond (lt @0 integer_zerop)\n+ tree_expr_nonnegative_p@1\n+ (min:c @0 @1))\n+ (if (INTEGRAL_TYPE_P (type)\n+ && !TYPE_UNSIGNED (type))\n+ (with { tree utype = unsigned_type_for (type); }\n+ (convert (min (convert:utype @0) (convert:utype @1))))))\n+\n #if GIMPLE\n /* These patterns should be after min/max detection as simplifications\n of `(type)(zero_one ==/!= 0)` to `(type)(zero_one)`\ndiff --git a/gcc/testsuite/gcc.dg/pr110262-1.c b/gcc/testsuite/gcc.dg/pr110262-1.c\nnew file mode 100644\nindex 00000000000..61cc079710a\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/pr110262-1.c\n@@ -0,0 +1,12 @@\n+/* PR tree-optimization/110262 */\n+/* { dg-do compile } */\n+/* { dg-options \"-O1 -fdump-tree-gimple\" } */\n+\n+int g(int min_need_stall)\n+{\n+ return min_need_stall < 0 ? 1 : ((min_need_stall) < (1) ? (min_need_stall) : (1));\n+}\n+\n+/* { dg-final { scan-tree-dump \"MIN_EXPR <\" \"gimple\" } } */\n+/* { dg-final { scan-tree-dump-not \"if \" \"gimple\" } } */\n+\ndiff --git a/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-46.c b/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-46.c\nnew file mode 100644\nindex 00000000000..a86aa168d39\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-46.c\n@@ -0,0 +1,15 @@\n+/* PR tree-optimization/110262 */\n+/* { dg-do compile } */\n+/* { dg-options \"-O1 -fdump-tree-phiopt2\" } */\n+\n+int g(int min_need_stall)\n+{\n+ int t = ((min_need_stall) < (1) ? (min_need_stall) : (1));\n+ return min_need_stall < 0 ? 1 : t;\n+}\n+\n+/* This should be converted into (int)MIN<(unsigned)min_need_stall, 1u> */\n+\n+/* { dg-final { scan-tree-dump \"MIN_EXPR <\" \"phiopt2\" } } */\n+/* { dg-final { scan-tree-dump-not \"if \" \"phiopt2\" } } */\n+\ndiff --git a/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-47.c b/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-47.c\nnew file mode 100644\nindex 00000000000..c42e5dd046f\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-47.c\n@@ -0,0 +1,24 @@\n+/* PR tree-optimization/110262 */\n+/* { dg-do compile } */\n+/* { dg-options \"-O1 -fdump-tree-phiopt2\" } */\n+int g(int a, int b)\n+{\n+ b = b < 0 ? 0 : b;\n+ int t = ((a) < (b) ? (a) : (b));\n+ return a < 0 ? b : t;\n+}\n+\n+int g1(int a, int b, unsigned short c)\n+{\n+ b = c;\n+ int t = ((a) < (b) ? (a) : (b));\n+ return a < 0 ? b : t;\n+}\n+\n+/* Both of the last statement of these functions should be converted into:\n+ (int)MIN<(unsigned)a, (unsigned)b>. */\n+\n+/* { dg-final { scan-tree-dump \"MIN_EXPR <\" \"phiopt2\" } } */\n+/* { dg-final { scan-tree-dump-not \"if \" \"phiopt2\" } } */\n+/* { dg-final { scan-tree-dump-times \"Removing basic block\" 2 \"phiopt2\" } } */\n+\n","prefixes":[]}