{"id":2228335,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228335/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260426043006.48113-1-atrajeev@linux.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260426043006.48113-1-atrajeev@linux.ibm.com>","date":"2026-04-26T04:30:06","name":"[V2] tools/perf: Fix the check for parameterized field in event term","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b375f1b66f444ec13a5d6b0c6968261ac6d67cdb","submitter":{"id":90290,"url":"http://patchwork.ozlabs.org/api/1.1/people/90290/?format=json","name":"Athira Rajeev","email":"atrajeev@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260426043006.48113-1-atrajeev@linux.ibm.com/mbox/","series":[{"id":501501,"url":"http://patchwork.ozlabs.org/api/1.1/series/501501/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501501","date":"2026-04-26T04:30:06","name":"[V2] tools/perf: Fix the check for parameterized field in event term","version":2,"mbox":"http://patchwork.ozlabs.org/series/501501/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228335/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2228335/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=F6nXxNSl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20101-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=F6nXxNSl;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3DJv6gtpz1yHv\n\tfor ; Sun, 26 Apr 2026 14:30:38 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g3DJl3Ggzz2yjm;\n\tSun, 26 Apr 2026 14:30:31 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g3DJj486vz2y8F\n\tfor ; Sun, 26 Apr 2026 14:30:28 +1000 (AEST)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63Q3GNnc914057;\n\tSun, 26 Apr 2026 04:30:24 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn44bfd8-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tSun, 26 Apr 2026 04:30:23 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63Q4NkY1024125;\n\tSun, 26 Apr 2026 04:30:22 GMT","from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds9eh0a4u-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tSun, 26 Apr 2026 04:30:22 +0000 (GMT)","from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com\n [10.20.54.103])\n\tby smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63Q4UIxX51904986\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tSun, 26 Apr 2026 04:30:18 GMT","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 863B72004B;\n\tSun, 26 Apr 2026 04:30:18 +0000 (GMT)","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 7A12D20040;\n\tSun, 26 Apr 2026 04:30:13 +0000 (GMT)","from localhost.localdomain (unknown [9.124.219.109])\n\tby smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tSun, 26 Apr 2026 04:30:13 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777177831;\n\tcv=none;\n b=bsHF++G0RF+I3WL/Al3jqJF/ZW8opdUCYfrn8QHn7uUHxkT2MZQ0BqyzJ0PPzgJ3hVQfYF766+R8ZbQxlyMVxfcY6hmu5WICSFE21tviPfxJ5eJdPoPaqjqf8Yx+i/WUf56Y/cv4VmzpSXXj8n8mrYSgFkS9pOBqLLifypp6Zn7LF1+Bje/5HqmPm115ZboDWHBImAcr8LqkJFgrsvWstor2aok5edFH01abFdhlV7a/fQdsInZ8DsQCgT2ima09oo+pXI6kb1ZsEjloePEtkhtovVJ8CBKko1GLmpqo2nL1aTaGdOAgy0A+dsyY/avFR5DR2H/zDYc7S/ynT2evtg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777177831; c=relaxed/relaxed;\n\tbh=UbpnkkD17mjRaoD/hBY4G1yToQSHbb1q74evgOmCHtc=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=DfeL8T/sDRo/Si4xFcZ20j/rFdlTyfCKeNfcP/hrDRbUJ+p/0CNlJmyja+UV8hU3zR6bx/45uIegbD1UCfjri3z046AEG7hXRUDngSn+lq1cB4uCTLdhjQEUud81kZWJhQ5QIDNWkvE8MxZU9mkvjgMVvHM6KU89K5XhkkB+Nec4lHKOwIjw/V5QKPo64u5m+pwiVb0EDPywW52WfDc1s/8C82E/KkWs5WoZVNtq1812HKs15PQvAPU9DI2EXt2Hts7N8Szg+Gvh8NMKLylSXHr0DG6v83TyAlejKeRN22EY6Fm0opdo+32LenYc5KtvLOuIEPo2P5X9nICy4gTDFw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=F6nXxNSl; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=pp1; bh=UbpnkkD17mjRaoD/hBY4G1yToQSHbb1q74evgOmCH\n\ttc=; b=F6nXxNSlkl/OXVDMjOMjQS4lXCb9s3+febEB3V7NL9J5c07lXoxbVzCu+\n\t3rmsC/tR7XiRkaI5l0hDDAH+9Lex56rFMi/zx5giSmxTdDmJrwFF8wxahDLsyMP1\n\tfKdbOGGfYtrLKFxxZdPMcq2TxhfMr2nwb3Irbpjj5dK81FSDol4UA8xVt5+gm422\n\tLHUi2yfjxXV05yWZaNdhAlhsSlMJl8RL5lf4C5peQ2acvl7lwzVH/sBjuaI4p3Mr\n\tRkzhi3qFNquS3PMczeNMKVitdmSJyD+IJAcwlN4lqJbNOKvgyAA085O4hMOBldzu\n\tlJP7n6Bg6qBPF0PYErZZsfuxuApYw==","From":"Athira Rajeev ","To":"acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,\n mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,\n irogers@google.com, namhyung@kernel.org","Cc":"linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com,\n Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, Shivani.Nittor@ibm.com","Subject":"[PATCH V2] tools/perf: Fix the check for parameterized field in event\n term","Date":"Sun, 26 Apr 2026 10:00:06 +0530","Message-Id":"<20260426043006.48113-1-atrajeev@linux.ibm.com>","X-Mailer":"git-send-email 2.39.5 (Apple Git-154)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"qXGTHI65qyGxKZWnTTR4wM6lfjFZt84Z","X-Authority-Analysis":"v=2.4 cv=Ft81OWrq c=1 sm=1 tr=0 ts=69ed94e0 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=KlCRr-_lrQmZq1rU:21 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8\n a=MfJl6_LkDses9f4lsXYA:9","X-Proofpoint-GUID":"Mkut2OD8pt8J4TwjODCmICOj1IDEMz7y","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI2MDA0MSBTYWx0ZWRfX5LwI0sjURNYf\n iBO8r66/cfwkG09UmCxmG5mbXEOohGNXO05oLiOiy9C8KEI6a7nEbCzUHfiKh/KePcjHnRlI05r\n 7eA0frEaTZl+OYCj7wQGwen7B7p44ZUzRAxsE717Z3K4pOnEMlUqSjSOSKDffnWqGmChzxqtx1r\n 1abRkY1FbQY62+HvtnT2RVV5Lsr2OgsAXFKc/kZlgnAl33Kx7LAosNNSb6w3AL4X6OccGlHA/rb\n YdG0S1wl6Myaws8GhaffMbDM8gTPFYT1t+vT4XqtWIl8QVQQ3O80mQUZhlhT7K3sh6KlkYQE0GG\n jnGrvQ65h4FfJrrUZiN0sk0QlL1j7pBAcueaFpWCVUWsabeDKX9tfrvwk5Hoj1eGgBd8Uw/6XJk\n dx0OlYz6Dk9RmwdqwfftOiy+OJ/djNZx/3itbt6tRcxFbJ3DsjZkUc4W4t8euKyVeUczPcsEMYx\n 4RK24GljN0oB6Y4ExRg==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-26_02,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0\n clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604260041","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The format_alias() function in util/pmu.c has a check to\ndetect whether the event has parameterized field ( =? ).\nThe string alias->terms contains the event and if the event\nhas user configurable parameter, there will be presence of\nsub string \"=?\" in the alias->terms.\n\nSnippet of code:\n\n /* Paramemterized events have the parameters shown. */\n if (strstr(alias->terms, \"=?\")) {\n /* No parameters. */\n snprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n\nif \"strstr\" contains the substring, it returns a pointer\nand hence enters the above check which is not the expected\ncheck. And hence \"perf list\" doesn't have the parameterized\nfields in the result.\n\nFix this check to use:\n\nif (str_ends_with(alias->terms, \"=?\")) {\n\nWith this change, perf list shows the events correctly with\nthe strings showing parameters.\n\nOther changes in this patch:\n- Replace snprintf with scnprintf in buffer offset calculations to\nensure the 'used' count will not exceed the \"len\"\n- If a parameterized event uses a built-in perf keyword for its\nparameter name (eg, config=?), the lexer parses it as a predefined\nterm token, which sets term->config to NULL. Add check to use\nparse_events__term_type_str() if term->config is NULL\n\nSigned-off-by: Athira Rajeev \n---\nChangelog:\nv1 -> v2:\nAfter review from Sashiko, added below changes:\nReplace snprintf with scnprintf in buffer offset calculations to\nensure the 'used' count will not exceed the \"len\"\n- If a parameterized event uses a built-in perf keyword for its\nparameter name (eg, config=?), the lexer parses it as a predefined\nterm token, which sets term->config to NULL. Add check to use\nparse_events__term_type_str() if term->config is NULL\n\n tools/perf/util/pmu.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)","diff":"diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c\nindex 23337d2fa281..fad7ef4c8e5d 100644\n--- a/tools/perf/util/pmu.c\n+++ b/tools/perf/util/pmu.c\n@@ -2117,7 +2117,7 @@ static char *format_alias(char *buf, int len, const struct perf_pmu *pmu,\n \t\t\t\t\t\t skip_duplicate_pmus);\n \n \t/* Paramemterized events have the parameters shown. */\n-\tif (strstr(alias->terms, \"=?\")) {\n+\tif (!strstr(alias->terms, \"=?\")) {\n \t\t/* No parameters. */\n \t\tsnprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n \t\treturn buf;\n@@ -2129,15 +2129,19 @@ static char *format_alias(char *buf, int len, const struct perf_pmu *pmu,\n \t\tpr_err(\"Failure to parse '%s' terms '%s': %d\\n\",\n \t\t\talias->name, alias->terms, ret);\n \t\tparse_events_terms__exit(&terms);\n-\t\tsnprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n+\t\tscnprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n \t\treturn buf;\n \t}\n-\tused = snprintf(buf, len, \"%.*s/%s\", (int)pmu_name_len, pmu->name, alias->name);\n+\tused = scnprintf(buf, len, \"%.*s/%s\", (int)pmu_name_len, pmu->name, alias->name);\n \n \tlist_for_each_entry(term, &terms.terms, list) {\n+\t\tconst char *name = term->config;\n+\n+\t\tif (!name)\n+\t\t\tname = parse_events__term_type_str(term->type_term);\n \t\tif (term->type_val == PARSE_EVENTS__TERM_TYPE_STR)\n-\t\t\tused += snprintf(buf + used, sub_non_neg(len, used),\n-\t\t\t\t\t\",%s=%s\", term->config,\n+\t\t\tused += scnprintf(buf + used, sub_non_neg(len, used),\n+\t\t\t\t\t\",%s=%s\", name,\n \t\t\t\t\tterm->val.str);\n \t}\n \tparse_events_terms__exit(&terms);\n","prefixes":["V2"]}