{"id":2228329,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228329/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260426000309.54959-1-sashal@kernel.org/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/1.1/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260426000309.54959-1-sashal@kernel.org>","date":"2026-04-26T00:03:09","name":"phy: tegra: xusb: Make USB_CONN_GPIO select conditional on GPIOLIB","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8bccfe1b52799dede84811e8b1131f9fc5232bd6","submitter":{"id":75065,"url":"http://patchwork.ozlabs.org/api/1.1/people/75065/?format=json","name":"Sasha Levin","email":"sashal@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260426000309.54959-1-sashal@kernel.org/mbox/","series":[{"id":501495,"url":"http://patchwork.ozlabs.org/api/1.1/series/501495/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=501495","date":"2026-04-26T00:03:09","name":"phy: tegra: xusb: Make USB_CONN_GPIO select conditional on GPIOLIB","version":1,"mbox":"http://patchwork.ozlabs.org/series/501495/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228329/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228329/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=osHy50Ln;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13967-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"osHy50Ln\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g36Nw5xgxz1yHv\n\tfor ; Sun, 26 Apr 2026 10:03:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9FE2C301F5F5\n\tfor ; Sun, 26 Apr 2026 00:03:12 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 749F3F507;\n\tSun, 26 Apr 2026 00:03:12 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 384C23D544;\n\tSun, 26 Apr 2026 00:03:11 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D6804C2BCB0;\n\tSun, 26 Apr 2026 00:03:10 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777161792; cv=none;\n b=MGmYeu/hImnXjR3i0QHewQfcWbAXxpx5jJmSJmefrQuk6B456NjRyHrYC0a/V+gTEdKwNkBqYjYQ5dXOHkmirrwOnkdSnEf5pml+F3qgVy0bcItwJAJXUtzf+lWgONZbGt/WKfvrs5hFmm4y/GpvEpFEfC+P+o/BiLPkSS4bTS4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777161792; c=relaxed/simple;\n\tbh=+O/Umb/ZYAjq527NytNL00ALTjlEFwQ5skbkPFWkgqQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type;\n b=nBK8/okxl9cfzRfvne+SuvLnomV0MvbwlKDtNrmBSPNWxyf0CH0lvC+rtVazMnS+0U2HDNM8uVvnC9DYh5Vfd83/ou304Jq/AUFlPbPL15jSulNuvy29BHy2NmSJ1vLQwNTRc/PZ7O5VrEf0aI7/w6uk97g819RkkyJ+Z9VxWE4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=osHy50Ln; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777161791;\n\tbh=+O/Umb/ZYAjq527NytNL00ALTjlEFwQ5skbkPFWkgqQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=osHy50LniNL4jDtdCNjXKaH6VqEarx3uxf9xps0723ubaAIzirklHlvUUSWhfakip\n\t /eWmWFU6J1M2aqL9QqC1XvYtknzXkpnUVMRQKZVHpOcOfrYVhUb/GrUHds4sNH3LnM\n\t LpJ2VCzBOGtIPbaJAR98l94bdOBj4axkyk/ks4XcxGFTSwrRPJJBNfGplwnjw1RbVd\n\t BInvibsFMpFWxfkjAlKomQB3bX1oUi/4eXMsxBQCmW1D9DRADr8WT5dlp7dWJoq6Jg\n\t U83PITy4cW8o5h/nDUF0jInAVUa18JbzK7bm211YhhWoFjJ4qIumbN9XbZIWIK6ioh\n\t UhbOTk/jPfV5w==","From":"Sasha Levin ","To":"Vinod Koul ","Cc":"Neil Armstrong ,\n\tThierry Reding ,\n\tJonathan Hunter ,\n\tNiklas Cassel ,\n\tVidya Sagar ,\n\tSasha Levin ,\n\tlinux-phy@lists.infradead.org,\n\tlinux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] phy: tegra: xusb: Make USB_CONN_GPIO select conditional on\n GPIOLIB","Date":"Sat, 25 Apr 2026 20:03:09 -0400","Message-ID":"<20260426000309.54959-1-sashal@kernel.org>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"kconfiglint reports:\n\n K006: config PHY_TEGRA_XUSB selects USB_CONN_GPIO which depends on\n GPIOLIB, but PHY_TEGRA_XUSB does not depend on GPIOLIB\n K002: config PHY_TEGRA_XUSB selects visible symbol USB_CONN_GPIO\n which has dependencies\n\nUSB_CONN_GPIO was introduced in commit 4602f3bff266 (\"usb: common: add USB\nGPIO based connection detection driver\") with a hard dependency on GPIOLIB,\nsince it needs GPIO pins to detect USB cable connection state.\n\nCommit f67213cee2b3 (\"phy: tegra: xusb: Add usb-role-switch support\") added\n`select USB_CONN_GPIO` to PHY_TEGRA_XUSB to support USB role switching via\nGPIO-based detection. At that time, PHY_TEGRA_XUSB depended only on\n`ARCH_TEGRA`, and both the ARM32 and ARM64 ARCH_TEGRA Kconfig definitions\nselect GPIOLIB, so the missing explicit GPIOLIB guard was not a functional\nproblem — GPIOLIB is always available when ARCH_TEGRA is enabled.\n\nLater, commit 0d5c9bc7c680 (\"phy: tegra: Select USB_COMMON for\nusb_get_maximum_speed()\") added `depends on USB_SUPPORT` but still did not\naddress the GPIOLIB gap.\n\nThe select can force USB_CONN_GPIO on without its GPIOLIB dependency being\nsatisfied if the Kconfig dependencies were ever restructured. Make the\nselect conditional with `select USB_CONN_GPIO if GPIOLIB` to make the\ndependency explicit. This mirrors how other drivers handle optional\nGPIO-dependent selects throughout the kernel.\n\nAssisted-by: Claude:claude-opus-4-6 kconfiglint\nSigned-off-by: Sasha Levin \n---\n drivers/phy/tegra/Kconfig | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig\nindex 342fb736da4b1..f0734415fc94c 100644\n--- a/drivers/phy/tegra/Kconfig\n+++ b/drivers/phy/tegra/Kconfig\n@@ -3,7 +3,7 @@ config PHY_TEGRA_XUSB\n \ttristate \"NVIDIA Tegra XUSB pad controller driver\"\n \tdepends on ARCH_TEGRA && USB_SUPPORT\n \tselect USB_COMMON\n-\tselect USB_CONN_GPIO\n+\tselect USB_CONN_GPIO if GPIOLIB\n \tselect USB_PHY\n \thelp\n \t Choose this option if you have an NVIDIA Tegra SoC.\n","prefixes":[]}