{"id":2228328,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228328/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260426000304.54912-1-sashal@kernel.org/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/1.1/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260426000304.54912-1-sashal@kernel.org>","date":"2026-04-26T00:03:04","name":"soc/tegra: Add PM dependency to SOC_TEGRA_PMC Kconfig","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"70d99b48ce2cfc0de0167588579c0b924212d88a","submitter":{"id":75065,"url":"http://patchwork.ozlabs.org/api/1.1/people/75065/?format=json","name":"Sasha Levin","email":"sashal@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260426000304.54912-1-sashal@kernel.org/mbox/","series":[{"id":501494,"url":"http://patchwork.ozlabs.org/api/1.1/series/501494/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=501494","date":"2026-04-26T00:03:04","name":"soc/tegra: Add PM dependency to SOC_TEGRA_PMC Kconfig","version":1,"mbox":"http://patchwork.ozlabs.org/series/501494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228328/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228328/checks/","tags":{},"headers":{"Return-Path":"\n <linux-tegra+bounces-13966-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=r1tc8J6/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13966-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"r1tc8J6/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g36NW0Z3sz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 10:03:23 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id F30BB300C92C\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 00:03:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CBB2DEADC;\n\tSun, 26 Apr 2026 00:03:07 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E73840DFDA;\n\tSun, 26 Apr 2026 00:03:07 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 57194C2BCB0;\n\tSun, 26 Apr 2026 00:03:06 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777161787; cv=none;\n b=W+G0INebiluUQunIlCbxk5J0DK5blBuNgR7IPLs1ip/S3AyoWXwaoiWYn4QGq1Zj2DI/Tv1dHJFniL8anrSaeAyIpDfheUESZH1F2crGUugLePsehkQPr7zILnBRnFFqGf/I33Yukbewoo02o39Jk1av7SZIiGjYVEEGtTxYw9I=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777161787; c=relaxed/simple;\n\tbh=UKRM1hcCiFIy3YjCIeGUJWgvZ2WNyZQxMIWelrm3mcU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=vArk0T8j4lS17LOKfKfwbkpX7FgnXrD2GAQtmR4InM8UGequMcDjHz4UOl0f8AVgfdUvszDxrUSxZA0Mijkyki8L3ygPvs4VSccrxvCI8lUho6Rd5o1jgAtQZMGmNCSbNH5KGA6qBHtGVsTLHGcOAWxTqRMILB6Ul9Rc3g1Nj1k=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=r1tc8J6/; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777161787;\n\tbh=UKRM1hcCiFIy3YjCIeGUJWgvZ2WNyZQxMIWelrm3mcU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=r1tc8J6/pSGk4TiJfden2r5oxgFtwTU6Md6EH247cB+uHzJApefCYJemuWjoOZDx6\n\t fs+oW/mCskvGDyCpBk6diLy0PLey0voKlyhYCb6oocxKcy/+e5/WCnL3ol2HPojCZo\n\t WiMDBhVuIL045YvxwXG5hRQZjKPBTRPozO+pxCgwKMHo2eHpMsOOWiX6ekKy4NLTS3\n\t 697C70+ldpRMpgIYEA1QcaibZFwOD7R6absLisbrEQg/TD8vTK97Ze66yzpaIpSGl2\n\t CGBxnOBqv7iDJoY6CTJei8llLZ1HGcoPPG7rjVU7fidGQ5fQAbROBWpbMAlSe4yIFN\n\t W02LcAmRfWz6Q==","From":"Sasha Levin <sashal@kernel.org>","To":"Thierry Reding <thierry.reding@kernel.org>","Cc":"Jonathan Hunter <jonathanh@nvidia.com>,\n\tLinus Walleij <linusw@kernel.org>,\n\tAaron Kling <webgeek1234@gmail.com>,\n\tSasha Levin <sashal@kernel.org>,\n\tKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,\n\tlinux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] soc/tegra: Add PM dependency to SOC_TEGRA_PMC Kconfig","Date":"Sat, 25 Apr 2026 20:03:04 -0400","Message-ID":"<20260426000304.54912-1-sashal@kernel.org>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"kconfiglint reports:\n\n  K006: config SOC_TEGRA_PMC selects PM_GENERIC_DOMAINS which depends on PM,\n        but SOC_TEGRA_PMC does not depend on PM\n\nSOC_TEGRA_PMC is an internal bool symbol (no prompt) that is selected by\nARCH_TEGRA_*_SOC options to enable the Power Management Controller driver.\nIt was originally introduced in commit 5e7d4c652941 (\"soc/tegra: Implement\nTegra186 PMC support\") as a bare `bool` with no\nselects of its own.\n\nOver time, additional selects were added:\n- Commit 5098e2b95e8e (\"soc/tegra: pmc: Select GENERIC_PINCONF\") added\n  select GENERIC_PINCONF\n- Commit 28dbe8231066 (\"soc/tegra: pmc: Select IRQ_DOMAIN_HIERARCHY\") added\n  select IRQ_DOMAIN_HIERARCHY\n- Commit f880ee9e9688 (\"soc/tegra: pmc: Add core power domain\") added select PM_OPP and select PM_GENERIC_DOMAINS to\n  support core power domain voltage scaling\n\nPM_GENERIC_DOMAINS is defined in kernel/power/Kconfig as:\n\n  config PM_GENERIC_DOMAINS\n      bool\n      depends on PM\n\nWhen commit f880ee9e9688 (\"soc/tegra: pmc: Add core power domain\") added\nthe select, it did not add a corresponding `depends on PM` to\nSOC_TEGRA_PMC. This was not a functional problem because all callers of\nSOC_TEGRA_PMC are inside `if ARCH_TEGRA` blocks, and both the ARM32\ndefinition (arch/arm/mach-tegra/Kconfig) and the ARM64 definition\n(arch/arm64/Kconfig.platforms) of ARCH_TEGRA select PM. Thus PM is always\nenabled when SOC_TEGRA_PMC is selected in practice.\n\nHowever, the dependency chain is implicit rather than explicit. Add\n`depends on PM` to SOC_TEGRA_PMC to make the requirement explicit and\nprevent a theoretical misconfiguration if SOC_TEGRA_PMC were ever selected\noutside the ARCH_TEGRA context.\n\nAssisted-by: Claude:claude-opus-4-6 kconfiglint\nSigned-off-by: Sasha Levin <sashal@kernel.org>\n---\n drivers/soc/tegra/Kconfig | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig\nindex 073346c1542ba..8b6fdb9ad1ea3 100644\n--- a/drivers/soc/tegra/Kconfig\n+++ b/drivers/soc/tegra/Kconfig\n@@ -171,6 +171,7 @@ config SOC_TEGRA_FLOWCTRL\n \n config SOC_TEGRA_PMC\n \tbool\n+\tdepends on PM\n \tselect GENERIC_PINCONF\n \tselect IRQ_DOMAIN_HIERARCHY\n \tselect PM_OPP\n","prefixes":[]}