{"id":2228165,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228165/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20260425154959.2796261-2-john.madieu.xa@bp.renesas.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.1/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260425154959.2796261-2-john.madieu.xa@bp.renesas.com>","date":"2026-04-25T15:49:58","name":"[1/2] rtc: isl1208: Fix returning errno as irqreturn_t in IRQ handler","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5b08e2f148d4d1443184b2170ce8dfac9c1f495e","submitter":{"id":89876,"url":"http://patchwork.ozlabs.org/api/1.1/people/89876/?format=json","name":"John Madieu","email":"john.madieu.xa@bp.renesas.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20260425154959.2796261-2-john.madieu.xa@bp.renesas.com/mbox/","series":[{"id":501447,"url":"http://patchwork.ozlabs.org/api/1.1/series/501447/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=501447","date":"2026-04-25T15:49:58","name":"rtc: isl1208: Fix IRQ return value and wake reference leak","version":1,"mbox":"http://patchwork.ozlabs.org/series/501447/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228165/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228165/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.a=rsa-sha256 header.s=selector1 header.b=CX3smKdd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6418-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=\"CX3smKdd\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.229.68","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bp.renesas.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=bp.renesas.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2vTK68Bfz1yHv\n\tfor ; Sun, 26 Apr 2026 01:51:49 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C99363009B26\n\tfor ; Sat, 25 Apr 2026 15:51:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3CE3A2D3A69;\n\tSat, 25 Apr 2026 15:51:46 +0000 (UTC)","from TY3P286CU002.outbound.protection.outlook.com\n (mail-japaneastazon11010068.outbound.protection.outlook.com [52.101.229.68])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id ABC0B14F70;\n\tSat, 25 Apr 2026 15:51:44 +0000 (UTC)","from TY6PR01MB17377.jpnprd01.prod.outlook.com (2603:1096:405:35b::6)\n by TYCPR01MB7315.jpnprd01.prod.outlook.com (2603:1096:400:f1::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.24; Sat, 25 Apr\n 2026 15:51:42 +0000","from TY6PR01MB17377.jpnprd01.prod.outlook.com\n ([fe80::f373:26d6:86c4:6aa3]) by TY6PR01MB17377.jpnprd01.prod.outlook.com\n ([fe80::f373:26d6:86c4:6aa3%6]) with mapi id 15.20.9846.022; Sat, 25 Apr 2026\n 15:51:42 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777132306; cv=fail;\n b=bQxrjJLmqYC+A6+Xz+V+kWuIAbyvvg4zJ/4hmGzpvvlVXtUfa7QWJ53voUvcVxpyC+hoslXCPFl8JfqvLpTE+fAceKMh4hfyRlpwnFsQ66GYxSxQ52IhUOmOX0Y9/537WfIcqEW50WERghsHRa0YUIP5LlIJcI86BAoRmrT6qjA=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=WB8UvyNMDDzR5pPiK31BCqsH/7g5nJx8x+C844WiIcW1IMNpqUCYpmG2EYfONA8aP/Y+NS0ub2bbx519FJPdtJ0zRSr6ZPkIO+iItYi3Q6BCDnnW3I1rQgkuOT+MhZrYnyiTlHUPNW3AgKc+ZzVI4PlZ83wLfyzT6dmLwGGjWvpHIKK8TWspK3UsI1DZWW9oWNyws5Hxna91iqaTmaqfGk3gTPZ4fTrJvYnXhsNx1xmc2HyTOgWfx6TJFRjbPWlNOXpWaNObS3Z8MLDOCirE603e3ZxIx9bFcjkLvYCS6Hlo7AZ2YLcaRF9vQF7tTQOQOapVuwTPSa4xB3H648Li7g=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777132306; c=relaxed/simple;\n\tbh=gUxeMeW4Hfw1f8k8xWKVHEqwLKy/QKjZhZydgZfYiOQ=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=Kr9axot3XX3gyOWqpACO+3253sT9Y5SwSrCekmgiUeJSAM8m21cyExpeLg6wrWGwjo+GD1pk4GhQVvNuf6hfxEa3CVqoDvl5MTRk5kYt9K7xMX4pSYxdBvwFdtsTXm1ARgDQjNE0+AvqSuZmMUPRB6osvwa31RsMLbdoeyBOXFs=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=SgLPNY1mwTRtNHDgct6ujuu84+CN1chjenKtp8sAv2A=;\n b=iPB89I3GvhCu1Lk2Zg7ofJHVgGdVHTFe2Dn1LurGICFdRQ0Z9k+F0RtyfF9BtZF19B98Hl72Oq1vGTbW+/jvLTk6VjP7M7MbEUkjEe3bpr5QXhpb4K1PnNxHGYR5w/nG/eX0eRmg09or3qjI2ksHfEiPIQ4ggKz0svvrs4FcD7LJ5sD6VNk7dveAxSqNZAzPuwr8yM/5Ssccv8G/hpmJOkXGTcLkQU0ppl6ymqkAHXxJgKCoV7oiKeBo3gVcV9F3rfCo53p7TVPdjzQmuUam5rzzsMs9ewNWwtOnxEKXih1ehD21mjZ1KY5V2jSslBuLiPVhkorpX1TOT+fQ+l9qCQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com;\n spf=pass smtp.mailfrom=bp.renesas.com;\n dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=CX3smKdd; arc=fail smtp.client-ip=52.101.229.68","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=bp.renesas.com; dmarc=pass action=none\n header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=SgLPNY1mwTRtNHDgct6ujuu84+CN1chjenKtp8sAv2A=;\n b=CX3smKddvxnV9iMlvrGKPZGJtKlQtLvT4U9bNAd8QGa3CN0yRI0BiEWtZ0FYGQPApCPJ6E1Mf4i4TuO6CFaybzUdFCkJeWtmmwoaSrhTYaZ+XeVwJhKHySe7jYmyjhQZsPRj8WYxiHo9Pr8c61PA7mrjxKTbG19d6YdCXsglWaU=","From":"John Madieu ","To":"alexandre.belloni@bootlin.com","Cc":"ryan@bluewatersys.com,\n\takpm@linux-foundation.org,\n\tm.grzeschik@pengutronix.de,\n\tDenis.Osterland@diehl.com,\n\tlinux-rtc@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tbiju.das.jz@bp.renesas.com,\n\tjohn.madieu@gmail.com,\n\tJohn Madieu ","Subject":"[PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in IRQ\n handler","Date":"Sat, 25 Apr 2026 15:49:58 +0000","Message-Id":"<20260425154959.2796261-2-john.madieu.xa@bp.renesas.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20260425154959.2796261-1-john.madieu.xa@bp.renesas.com>","References":"<20260425154959.2796261-1-john.madieu.xa@bp.renesas.com>","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"PA7P264CA0117.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:34c::20) To OS7PR01MB17371.jpnprd01.prod.outlook.com\n (2603:1096:604:43e::6)","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"TY6PR01MB17377:EE_|TYCPR01MB7315:EE_","X-MS-Office365-Filtering-Correlation-Id":"815cc159-34af-43be-c21f-08dea2e28aaf","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|52116014|376014|1800799024|366016|38350700014|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n\tjbB6D8ia+7GbxYfHVVEf8E1KT1tFnE8wjImGlkGPLqcKV+RKcFxcBAbEReH7PwkaK+GDhy/0QRmYr4E2uuALI3RZ3vqei8SvORHGDsqWf6r/s/PpOiBe1FPjvTjC1rsG+XAJyomeiB9kY9mIpIrsg2Sz33nGdn2nkKyL6FHWXoft0T0MZ3NlSY7/lrxQTnR9Iewo4gJDiX+urAUJBTMm/ULBgMj2pV3f7g/1jlQkfDuGvKj0PSCunKmwVO/fAGcVoE8Q2BSokJ44mwMK9/AxSI8I3c7KpjmtcVPF7SmTrJdtD0p03WI+9AL2DHi2csFmR4bOdFqIg/Y+wPBjOnsVTOeXY/riFYv0Qqmm2nJWk/LjZOtOv2sZ6QYyswHm6CDRlqfOISjt9bO/k1+njVXTJR4rwRcmE17gwCoCxNFN/tffix6wnn5ONvbC1hz6sWiE2EiDaqqn+/Daj3Nkaz+yoxT5QEEOx3tCEGgRf80j6tr+u0IkxDFl1izriVweM9wqyl6kW3Skf5Keb+9cCagAukksEsaUdqm2mslEoAywY5jCNdXhEhUIVdaS9OHR2/K0gk5HglzhMgRvwMoKPyR6Ex52g4gRIxQkjTgflxCpRsjGBPrwtY23If21xrP8Wvjvk5oVxSAlDiaCUaJ8REWeVhgPO/zhUyJj1VvRl88vO77klOM6z57tDvcJQiMhp2JSwwfdqXIwoXQT3/5sQIbnhzHsobh9SiZVHuUwsC22q4KdSPjkq3uV37tgIUvAjR1UtlVU22Kyq+zxPBy7I9+bq9sjRKVGFiffZCOGmfkW6LQ=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY6PR01MB17377.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n xaEPHCtH43QuVrFZGIH5QqweIoL1mW/vF1CGwQXp9cEwMKFEIkbS+NmNubC0xGMGzXKNkxGbBzqT3TuRcl13yJkbn5dEcddK9ZPZ1Lna9NGkwEIduQgp+St409L4EQzkpUIS8QdIT4WFdx8rpty9qd2X6/Pd2zvOKC73S/Fv8+DUfaI5ENTwnhWHM0hgFc175OblndBlSP+Q2f3+yunMB+Aa8TeWXTxCk4BXiD/8aYMf02fDajKZWehF0VITkVlACY+p/YQ4jOwqJLuUjud1g4alyCVOMBd9SHKGu5il6ubZCykIkQinR0fmkzgmJAr6UI3JeejcKZZW31LgUNvK3YeWJw7WJZAjqZlVXWg3cUtv/nT7hLhvRJScztoUWty0ey2pn3GCvVpLdX7MpyJzNvuYD79gyivRNW6F6QwyCA4YZVd1rc/9zxMyQf+EGBI1xujno176zh/7yFwX3/AP1nL1LqBBzIYLXziYWKfVpMHAU5fB7aEam3w249KuYQBeEqG85NKWfan3PathLLp96crfEUngX1hv6MThn4RHg74CvXoqT1+FAMy/yYj+v+UIf30EqN4a18BaYBnCnzO9us412Fw1wxX//cbxCUJxg0sGgUweoxCMNtQJOBtP0W2pqS6A8Ozho40DjKx2n3XHEn1i+Gc+X1gbEer7WDXIkkLxEKZGXyh84B69Wekl2HeBKWT28deDNQpeQnyTLdw6WGyn4/xVNb9ZvKqhGQNGBBunQQnqNHKFE5wsBHL+OaGov7zG7WmC0S2TNuCBlyIS2/RE/5mjVKFqWrLuUcscXPMCzXoqcdmzphAYc52EwOP7VTKYF2cM9Ml5fcRwQxqjs+Z5SE3HxcHfCJzviCh/8C9DU2doAskhPLEAnbWeXiHMBblsal4M0gwL5uejhdCfyDVekbu9bNIdR8t9abmT6i8L+539Hwi2JERuMLurDOSNU+eUGl0dkhd/4jRjSHF9YGVC/SDyniboAN6U3VQD5OGmNP2Lv0KO/AYvcaK34V0SnvmEi9OsG7hjIPlKvDvur7T55BmaN2uBHKi5ZPw1n6NDQgMQoPJJVIiEdglna/xoQX+LIBAzuq6rj3yC7NXnCP6+Lwx8AFIMNzudFvE+wx4d5LgF/mLXNsNK9irvNQZA8ce3HZT9jS9OyQGo8G8BORV7zIHsZUoIHDevEBRZbNFaCIsLMagNWiS0EfTDipfVUdQY26hQQ6zsnxb1grNetGXdPG0TeXHPQQCobxVU2W5srozOcUhwz38ljAD4/xHY1wsC9jkqhNqwcQhabn/69m8vAxNkMNmNVW6E07C1o2A5u1z/reaDOIcBxbsRCjnm1359WUIAtpOrAL8SLuWduDf/O8dIuMfnGtspvFlaVj2ZsXx4Kw1lRDYpCbIdlv/L2sZg0cdJHtSqcDpuPo80D5ubXAjm+SJ/XIIKQUElyFtF2jNhWfWfMjUyXJKBuuvvnEj6dHi3qaA7JqYT+Whg8f8dRRY7DHi11SERsc4WvYLS1bPaCsrtZwnQbhlwEGsrHI1GWk2WewlzLzwfnEaoCiPUulJIP8kYl8g8GhD2oZwxypEAB2nek6zGd7IbyvHAZxw2SK3DhI4SWQtHS1HkS3wcxtRgy57eAeUVUQ4AkMu0bLbBSFwrLIbCZEys23Zj9ddWAONKQdJ0Wba/73qx0sry6dpIuIR/TAQTu9gJiNXgPqryRulsK6YiFIutIabQ65nsMsd4U6nAoN89pFOeIeGGDa4PgDUVeF5QIvRsuo8=","X-OriginatorOrg":"bp.renesas.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 815cc159-34af-43be-c21f-08dea2e28aaf","X-MS-Exchange-CrossTenant-AuthSource":"OS7PR01MB17371.jpnprd01.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"25 Apr 2026 15:51:40.8113\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"53d82571-da19-47e4-9cb4-625a166a4a2a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n qxm8JCLCo/7NcN9hdN683tkcS3BtKqOnjNrrq1dXZ2v+QKskkxhnHgM1regGNbuUvpHqEDolOHvHY54fej0ETobni5hrJKhlc9TPzX9ZZR0=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TYCPR01MB7315"},"content":"isl1208_rtc_interrupt() is of irqreturn_t type but two paths\nreturn a negative i2c errno instead of an IRQ_* value:\n\n - The SR-poll loop on timeout: `return sr;`\n - The post-alarm cleanup path: `return err;`\n\ngenirq's note_interrupt() casts the return to unsigned int and\nflags any value above IRQ_HANDLED|IRQ_WAKE_THREAD as a bogus\nreturn, logging \"irq event N: bogus return value X\" each time it\nhappens.\n\nReturn IRQ_NONE when the SR read failed (no progress, can't claim\nthe interrupt) and IRQ_HANDLED when toggle_alarm failed.\n\nFixes: cf044f0ed526 (\"drivers/rtc/rtc-isl1208.c: add alarm support\")\nSigned-off-by: John Madieu \n---\n drivers/rtc/rtc-isl1208.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c\nindex f71a6bb77b2a..c93998c53e7a 100644\n--- a/drivers/rtc/rtc-isl1208.c\n+++ b/drivers/rtc/rtc-isl1208.c\n@@ -654,7 +654,7 @@ isl1208_rtc_interrupt(int irq, void *data)\n \t\tif (time_after(jiffies, timeout)) {\n \t\t\tdev_err(&client->dev, \"%s: reading SR failed\\n\",\n \t\t\t\t__func__);\n-\t\t\treturn sr;\n+\t\t\treturn IRQ_NONE;\n \t\t}\n \t}\n \n@@ -666,7 +666,7 @@ isl1208_rtc_interrupt(int irq, void *data)\n \t\t/* Disable the alarm */\n \t\terr = isl1208_rtc_toggle_alarm(client, 0);\n \t\tif (err)\n-\t\t\treturn err;\n+\t\t\treturn IRQ_HANDLED;\n \n \t\tfsleep(275);\n \n","prefixes":["1/2"]}