{"id":2228140,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228140/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260425125426.3855807-19-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260425125426.3855807-19-dhowells@redhat.com>","date":"2026-04-25T12:54:22","name":"[v3,18/19] afs: Fix afs_get_link() to take validate_lock around afs_read_single()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e283b1bec39c92e283419b506382aaf1b6ff4758","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260425125426.3855807-19-dhowells@redhat.com/mbox/","series":[{"id":501437,"url":"http://patchwork.ozlabs.org/api/1.1/series/501437/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501437","date":"2026-04-25T12:54:04","name":"netfs: Miscellaneous fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/501437/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228140/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228140/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=HeTcD2Jy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11127-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"HeTcD2Jy\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2qn85mNsz1yHv\n\tfor ; Sat, 25 Apr 2026 23:05:16 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 2BCDC303CE88\n\tfor ; Sat, 25 Apr 2026 12:57:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2AEE539D6F0;\n\tSat, 25 Apr 2026 12:56:10 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C71E3396B9D\n\tfor ; Sat, 25 Apr 2026 12:56:08 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-445-mOWP0i8_M_KNCYMj24Mf9A-1; Sat,\n 25 Apr 2026 08:56:02 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DC28B1956080;\n\tSat, 25 Apr 2026 12:56:00 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.48.17])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D1F5630078C2;\n\tSat, 25 Apr 2026 12:55:57 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777121770; cv=none;\n b=fP4lu5aGJOSwxzgVHUHAy6SMbt3sh9UZTrAr0t7j+PPSbYwtcq84CBRzZSEukIk4ot8QQswipv/vKVjbRHsnWIRUpqaz7FJyeOFueOhR+M+hRhJHiPUL21RzEpusd7iEJOvHNl2MV/KZ+vOFu59ZiI5mTj2N4N9StrNqUWI9CCw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777121770; c=relaxed/simple;\n\tbh=3aYouAujFzp76xqqlG9o4vknZZvSlVMk3kOrrxli+y8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=uZ3pybJ7X/WVT2uHcRhJSvkFKpJsMiSLePsIyGkC4lOFhTfggSGlpHmLIJrXCixUnkCCRvzm+iZij7VMgSziJ9eM13mjQtczTf54lWhFhrluhcay+JgnUpJEYO/pbDf9sJNQbtM8+Cy0f1BcC0BwQKmbyI9kObbPrjpXBDVahKg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=HeTcD2Jy; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777121768;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=CEaZFT1kA2C9fmI8tLKUXOafS9Zq2QwNR5SdFuG0lEc=;\n\tb=HeTcD2JyjLlfIiryfvg7CzeYjoYx/zoDcypuvESaeiG0G+N4qvDZ+nZOj7X2vLy/PBG7cJ\n\tjpt+5a9oxNNP/S4+ZFLP6/UmKulHdMIUK5THmTAGWf7YujDI/y24a4ohMLwWOhcQfOWuvH\n\t480RJVnqgiKCuhEj+es0TLMZNYPFboE=","X-MC-Unique":"mOWP0i8_M_KNCYMj24Mf9A-1","X-Mimecast-MFC-AGG-ID":"mOWP0i8_M_KNCYMj24Mf9A_1777121761","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMarc Dionne ","Subject":"[PATCH v3 18/19] afs: Fix afs_get_link() to take validate_lock around\n afs_read_single()","Date":"Sat, 25 Apr 2026 13:54:22 +0100","Message-ID":"<20260425125426.3855807-19-dhowells@redhat.com>","In-Reply-To":"<20260425125426.3855807-1-dhowells@redhat.com>","References":"<20260425125426.3855807-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4"},"content":"Fix afs_get_link() to take the validate_lock around afs_read_single() to\nprevent races between multiple ->get_link() calls.\n\nFixes: eae9e78951bb (\"afs: Use netfslib for symlinks, allowing them to be cached\")\nCloses: https://sashiko.dev/#/patchset/20260326104544.509518-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Marc Dionne \ncc: linux-afs@lists.infradead.org\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/afs/inode.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)","diff":"diff --git a/fs/afs/inode.c b/fs/afs/inode.c\nindex 06e25e1b12df..5207c4a003f6 100644\n--- a/fs/afs/inode.c\n+++ b/fs/afs/inode.c\n@@ -78,10 +78,19 @@ const char *afs_get_link(struct dentry *dentry, struct inode *inode,\n \t\tgoto good;\n \n fetch:\n-\tret = afs_read_single(vnode, NULL);\n-\tif (ret < 0)\n-\t\treturn ERR_PTR(ret);\n-\tset_bit(AFS_VNODE_DIR_READ, &vnode->flags);\n+\tif (down_write_killable(&vnode->validate_lock) < 0)\n+\t\treturn ERR_PTR(-ERESTARTSYS);\n+\tif (test_and_clear_bit(AFS_VNODE_ZAP_DATA, &vnode->flags) ||\n+\t !test_bit(AFS_VNODE_DIR_READ, &vnode->flags)) {\n+\t\tret = afs_read_single(vnode, NULL);\n+\t\tif (ret < 0) {\n+\t\t\tup_write(&vnode->validate_lock);\n+\t\t\treturn ERR_PTR(ret);\n+\t\t}\n+\t\tset_bit(AFS_VNODE_DIR_READ, &vnode->flags);\n+\t}\n+\n+\tup_write(&vnode->validate_lock);\n \n good:\n \tfolio = folioq_folio(vnode->directory, 0);\n","prefixes":["v3","18/19"]}