{"id":2228138,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228138/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260425125426.3855807-17-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260425125426.3855807-17-dhowells@redhat.com>","date":"2026-04-25T12:54:20","name":"[v3,16/19] netfs: Fix netfs_read_folio() to wait on writeback","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e9afe122dccf225caab21ae0a1e056b8b8fa770b","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260425125426.3855807-17-dhowells@redhat.com/mbox/","series":[{"id":501437,"url":"http://patchwork.ozlabs.org/api/1.1/series/501437/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501437","date":"2026-04-25T12:54:04","name":"netfs: Miscellaneous fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/501437/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228138/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228138/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WR3hOmLr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11125-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"WR3hOmLr\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2qkl1NNHz1xvV\n\tfor ; Sat, 25 Apr 2026 23:03:11 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D5A79307C8BD\n\tfor ; Sat, 25 Apr 2026 12:56:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 789B8398902;\n\tSat, 25 Apr 2026 12:55:59 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F1DE039B958\n\tfor ; Sat, 25 Apr 2026 12:55:57 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-Na8Yz6jpPquSI5nYWvFL3g-1; Sat,\n 25 Apr 2026 08:55:53 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B19071800473;\n\tSat, 25 Apr 2026 12:55:51 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.48.17])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B747C1944CED;\n\tSat, 25 Apr 2026 12:55:48 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777121759; cv=none;\n b=GzNTNhDh1Mum/rMVut6/t0BDJjPsAgb4UPTEUiwEuAP+KAdQR0o+8HsNubBW++trQd6XWIfgDnk8pp4SRzchFJF0qEebRbyCdwI6WxVp003m27N7FC0hv0UvSPYztbYsvW5al4IgY4HzQbR8tEdo05mkbsU4QeEGxEQU7+SRW4w=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777121759; c=relaxed/simple;\n\tbh=yF/XUG1fEGGiljws/ocbnY4IAhkOM1E5pMkNLbFWRK8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=jH2SQ84yutZUE6311Ju7NlXYjvi6wrqkEltqUDXHf0NVhRXQg9Gly4biQdLZwNXMSlKG+vMkZP7Vp59CHWPVvA4lwhr4ALkZBD/D3cbHJUALSUTlJuWL8xnKwA21seflC1f7auK1C5z67cZH2qjUij/5pN38QOCdvMbklsk3Y9s=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=WR3hOmLr; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777121757;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=g1vxGFe1KJh0FZqySywfbvIcxTlJD3j+jfO/PbnF32U=;\n\tb=WR3hOmLrMXG5ZRaYoRKOZ0OD3eb8bxIdDiQ+wmahSrxZsB9njk+yK3g8Q0nsTXZnA1JT5o\n\tRxzwS5OfgpiKFu1/LyWiLr1Y4JH83JjAPI0kFm53aOZjJzJg36M6VSBMwSsjcB68InFRV/\n\tN9xlPapRB7b96oR+uNr68uzQl7RyF20=","X-MC-Unique":"Na8Yz6jpPquSI5nYWvFL3g-1","X-Mimecast-MFC-AGG-ID":"Na8Yz6jpPquSI5nYWvFL3g_1777121751","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox ","Subject":"[PATCH v3 16/19] netfs: Fix netfs_read_folio() to wait on writeback","Date":"Sat, 25 Apr 2026 13:54:20 +0100","Message-ID":"<20260425125426.3855807-17-dhowells@redhat.com>","In-Reply-To":"<20260425125426.3855807-1-dhowells@redhat.com>","References":"<20260425125426.3855807-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17"},"content":"Fix netfs_read_folio() to wait for an ongoing writeback to complete so that\nit can trust the dirty flag and whatever is attached to folio->private\n(folio->private may get cleaned up by the collector before it clears the\nwriteback flag).\n\nFixes: ee4cdf7ba857 (\"netfs: Speed up buffered reading\")\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_read.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c\nindex f1cbd6e10ad7..2de849bd780f 100644\n--- a/fs/netfs/buffered_read.c\n+++ b/fs/netfs/buffered_read.c\n@@ -506,6 +506,8 @@ int netfs_read_folio(struct file *file, struct folio *folio)\n \tstruct netfs_inode *ctx = netfs_inode(mapping->host);\n \tint ret;\n \n+\tfolio_wait_writeback(folio);\n+\n \tif (folio_test_dirty(folio))\n \t\treturn netfs_read_gaps(file, folio);\n \n","prefixes":["v3","16/19"]}