{"id":2228128,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228128/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260425125426.3855807-5-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260425125426.3855807-5-dhowells@redhat.com>","date":"2026-04-25T12:54:08","name":"[v3,04/19] netfs: Defer the emission of trace_netfs_folio()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eeae13355e240d14c660beca98208a46de092958","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260425125426.3855807-5-dhowells@redhat.com/mbox/","series":[{"id":501437,"url":"http://patchwork.ozlabs.org/api/1.1/series/501437/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501437","date":"2026-04-25T12:54:04","name":"netfs: Miscellaneous fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/501437/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228128/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228128/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=YYGaOR/7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11113-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"YYGaOR/7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2qfF00bdz1y2d\n\tfor ; Sat, 25 Apr 2026 22:59:16 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 7627A3056FE3\n\tfor ; Sat, 25 Apr 2026 12:55:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7CEBC383C92;\n\tSat, 25 Apr 2026 12:55:05 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E7AAB36D9EE\n\tfor ; Sat, 25 Apr 2026 12:55:02 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-5PRO9NDeOx2vHYS6roDNgg-1; Sat,\n 25 Apr 2026 08:54:56 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C9B2019560B5;\n\tSat, 25 Apr 2026 12:54:54 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.48.17])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C86A919560AB;\n\tSat, 25 Apr 2026 12:54:51 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777121705; cv=none;\n b=cwVo4PIPGyJ82LhICb7XxtRxRwFtQneBs4idomkOxYb1FITCvEvDJp+bpw8d5YGRR0d0gJ0HRrPtdt9EjDv7RbcW+PMoWzunOWw6M4l9qCqAobYbqCs1xO7JjIQRz4Lasod685voi4zaVuP2VG2sTwzGSzsLVUGeDWbVsIZBd/c=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777121705; c=relaxed/simple;\n\tbh=iJP+dqhWiqGi1MbPHkt833HZLa0pKEjFDuPHSK/G9uw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Gks/Qx3eccFPa29rk8KIz1/kZUre+OySOUsAGsfdHZGs8Ih+/e3RE5eV1+NoNi3LWUEwuAL6903kOPg+yS/fkNTiGsMhmO0GXpLvBhCynCOv56+tw3EDaRuuXsbuYf6eGRlZf98pvc4pBEULo/AXTyJ0FEkyC0UimU/CqI0Ubn0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=YYGaOR/7; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777121702;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=sFPwIBabIrcPkQ/URaUD6QY+l0UbTbUVhLLrjRDCqFg=;\n\tb=YYGaOR/75NYZajPWh+Oqt1Z4QyAdJP/votRpkd3P9kJB9Q6AhbyYn3dcF6O8a2tS/8xIK1\n\tMuVm1DHqNxIphdra87r/rCw22SwXzTzvm2NfMrY2Mf1hTWylhTe5EAaAoNDCpoOYNuWxQR\n\tVdkVtx/oYpSEupM4tl/I8vNtzIoIAE0=","X-MC-Unique":"5PRO9NDeOx2vHYS6roDNgg-1","X-Mimecast-MFC-AGG-ID":"5PRO9NDeOx2vHYS6roDNgg_1777121695","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox ","Subject":"[PATCH v3 04/19] netfs: Defer the emission of trace_netfs_folio()","Date":"Sat, 25 Apr 2026 13:54:08 +0100","Message-ID":"<20260425125426.3855807-5-dhowells@redhat.com>","In-Reply-To":"<20260425125426.3855807-1-dhowells@redhat.com>","References":"<20260425125426.3855807-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12"},"content":"Change netfs_perform_write() to keep the netfs_folio trace value in a\nvariable and emit it later to make it easier to choose the value displayed.\nThis is a prerequisite for a subsequent patch.\n\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_write.c | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)","diff":"diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c\nindex 05ea5b0cc0e8..fab172252759 100644\n--- a/fs/netfs/buffered_write.c\n+++ b/fs/netfs/buffered_write.c\n@@ -149,6 +149,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t}\n \n \tdo {\n+\t\tenum netfs_folio_trace trace;\n \t\tstruct netfs_folio *finfo;\n \t\tstruct netfs_group *group;\n \t\tunsigned long long fpos;\n@@ -222,7 +223,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\t\tif (unlikely(copied == 0))\n \t\t\t\tgoto copy_failed;\n \t\t\tnetfs_set_group(folio, netfs_group);\n-\t\t\ttrace_netfs_folio(folio, netfs_folio_is_uptodate);\n+\t\t\ttrace = netfs_folio_is_uptodate;\n \t\t\tgoto copied;\n \t\t}\n \n@@ -238,7 +239,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\t\tfolio_zero_segment(folio, offset + copied, flen);\n \t\t\t__netfs_set_group(folio, netfs_group);\n \t\t\tfolio_mark_uptodate(folio);\n-\t\t\ttrace_netfs_folio(folio, netfs_modify_and_clear);\n+\t\t\ttrace = netfs_modify_and_clear;\n \t\t\tgoto copied;\n \t\t}\n \n@@ -256,7 +257,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\t\t}\n \t\t\t__netfs_set_group(folio, netfs_group);\n \t\t\tfolio_mark_uptodate(folio);\n-\t\t\ttrace_netfs_folio(folio, netfs_whole_folio_modify);\n+\t\t\ttrace = netfs_whole_folio_modify;\n \t\t\tgoto copied;\n \t\t}\n \n@@ -283,7 +284,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\t\tif (unlikely(copied == 0))\n \t\t\t\tgoto copy_failed;\n \t\t\tnetfs_set_group(folio, netfs_group);\n-\t\t\ttrace_netfs_folio(folio, netfs_just_prefetch);\n+\t\t\ttrace = netfs_just_prefetch;\n \t\t\tgoto copied;\n \t\t}\n \n@@ -297,7 +298,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\t\tif (offset == 0 && copied == flen) {\n \t\t\t\t__netfs_set_group(folio, netfs_group);\n \t\t\t\tfolio_mark_uptodate(folio);\n-\t\t\t\ttrace_netfs_folio(folio, netfs_streaming_filled_page);\n+\t\t\t\ttrace = netfs_streaming_filled_page;\n \t\t\t\tgoto copied;\n \t\t\t}\n \n@@ -312,7 +313,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\t\tfinfo->dirty_len = copied;\n \t\t\tfolio_attach_private(folio, (void *)((unsigned long)finfo |\n \t\t\t\t\t\t\t NETFS_FOLIO_INFO));\n-\t\t\ttrace_netfs_folio(folio, netfs_streaming_write);\n+\t\t\ttrace = netfs_streaming_write;\n \t\t\tgoto copied;\n \t\t}\n \n@@ -332,9 +333,9 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\t\t\t\tfolio_detach_private(folio);\n \t\t\t\tfolio_mark_uptodate(folio);\n \t\t\t\tkfree(finfo);\n-\t\t\t\ttrace_netfs_folio(folio, netfs_streaming_cont_filled_page);\n+\t\t\t\ttrace = netfs_streaming_cont_filled_page;\n \t\t\t} else {\n-\t\t\t\ttrace_netfs_folio(folio, netfs_streaming_write_cont);\n+\t\t\t\ttrace = netfs_streaming_write_cont;\n \t\t\t}\n \t\t\tgoto copied;\n \t\t}\n@@ -350,6 +351,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,\n \t\tcontinue;\n \n \tcopied:\n+\t\ttrace_netfs_folio(folio, trace);\n \t\tflush_dcache_folio(folio);\n \n \t\t/* Update the inode size if we moved the EOF marker */\n","prefixes":["v3","04/19"]}