{"id":2228042,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228042/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260425014842.1036981-1-boolli@google.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.1/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260425014842.1036981-1-boolli@google.com>","date":"2026-04-25T01:48:42","name":"[iwl-next,v2] libie: log more info when virtchnl fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a2336489a26978ce432fa9982a593bde4d5e2079","submitter":{"id":92373,"url":"http://patchwork.ozlabs.org/api/1.1/people/92373/?format=json","name":"Li Li","email":"boolli@google.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260425014842.1036981-1-boolli@google.com/mbox/","series":[{"id":501415,"url":"http://patchwork.ozlabs.org/api/1.1/series/501415/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501415","date":"2026-04-25T01:48:42","name":"[iwl-next,v2] libie: log more info when virtchnl fails","version":2,"mbox":"http://patchwork.ozlabs.org/series/501415/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228042/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228042/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=w5lImyBa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2Xmx4QNXz1yHS\n\tfor ; Sat, 25 Apr 2026 11:49:03 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 1B28681871;\n\tSat, 25 Apr 2026 01:49:01 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id T3d7OZ896imG; Sat, 25 Apr 2026 01:48:59 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 031D48186E;\n\tSat, 25 Apr 2026 01:48:59 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 580CA194\n for ; Sat, 25 Apr 2026 01:48:57 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 3E47C8186E\n for ; Sat, 25 Apr 2026 01:48:57 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Tf22Tyf__H6B for ;\n Sat, 25 Apr 2026 01:48:56 +0000 (UTC)","from mail-dl1-x1249.google.com (mail-dl1-x1249.google.com\n [IPv6:2607:f8b0:4864:20::1249])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 925028186A\n for ; Sat, 25 Apr 2026 01:48:56 +0000 (UTC)","by mail-dl1-x1249.google.com with SMTP id\n a92af1059eb24-12dbf4f678eso15237934c88.0\n for ; Fri, 24 Apr 2026 18:48:56 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 031D48186E","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 925028186A"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777081739;\n\tbh=81CODhtfCeY5gOXc4AcZuOqtvysUpw25zIQcp3J/FQg=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=w5lImyBaiD1q7bM/tF+w8OsAOqJvk60y66ZIngYOGhsysQ3s2Q0W9Sm4ot3MNDfxL\n\t tddv8nbH4zdus/TK46u83gvHsjcRNgzSj93G/XYYJc4Hke4knKJ97u4maX1tjzVqER\n\t faas8qJTikEVzY4nlLfP6lO5JaWL1VWNOoj2gyNrrzelg2NWQVeYNyY2lCAXZ8Vi64\n\t HoCGt5qUX31ykako+2muNz7A6RhjwEpca2gFQolyqNK+jvo2MvgMDz2+zjOJEY2hlt\n\t TRKtAs2G3qHoLZklxuL0fndWRfCwcFehuZJQyFw0CHP5u8PEg9//vEOMC4QPM6xOJ8\n\t 4SKhUVGS+bzZw==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::1249; helo=mail-dl1-x1249.google.com;\n envelope-from=3hx3saqykd8gp22zzwu22uzs.q20w17sz-aw5sr-zo1zw676.26826z.25u@flex--boolli.bounces.google.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 925028186A","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777081735; x=1777686535;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=81CODhtfCeY5gOXc4AcZuOqtvysUpw25zIQcp3J/FQg=;\n b=XHa6WdgkpOhaSPZagbdBopnHDkXPzhfHMIHo6L6dcjLG7Xp1XV61uvGzyptsi8mJCs\n uVkikozemhS+VtSOMPSTmOfTgR/nuG6CGD7EGFEizmDn6Znyh3krK71Xh3iRjHcUNzo0\n 9Z5xsMVFtcdP318ydrYI5eKYwOSwn9mV1NO6odYaRfCK/PLoBM9zmO+8ncQj32FMaTqt\n HZXJH60SjATqcQoIvpCEjs2EqGh67GR28sir68osaFl3PGIam/zucCvEY35RTWdmzO0J\n SeWb5Jzz9BCgyXSzHvG5qJ2bHcEe5Szj+D1dGYKuIf8ex7DmRf6XQ9F7ytgM14UpIcqp\n 0cmg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ952LhmzdEAUpm9h9PZnumsK+je3WG74nyvDFwJK8m0zvOJYpsGTx/1usQXfWY7tEsncWmamLbZ/ohtwzEJLhk=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YxUacytZe/Ioz+W1cgMZvmTyF6PbLdRnJw58IpDGEibpTnMbwjC\n zKRHAcA8DQy0HkdCTqWopTXEJrcpB3e6OKzOIw6eDC/401299RuLWZoK+U/llfrhchzftbcWw+B\n /v98Pjw==","X-Received":"from dlea14-n1.prod.google.com\n ([2002:a05:701b:420e:10b0:12c:49a5:e4a4])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7022:60c:b0:12a:713b:8958\n with SMTP id a92af1059eb24-12c73f7596bmr17260924c88.10.1777081735213; Fri, 24\n Apr 2026 18:48:55 -0700 (PDT)","Date":"Sat, 25 Apr 2026 01:48:42 +0000","Mime-Version":"1.0","X-Mailer":"git-send-email 2.54.0.rc2.544.gc7ae2d5bb8-goog","Message-ID":"<20260425014842.1036981-1-boolli@google.com>","To":"Tony Nguyen ,\n Przemek Kitszel ,\n \"David S. Miller\" ,\n Jakub Kicinski , Eric Dumazet ,\n intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny ,\n Anjali Singhai ,\n Sridhar Samudrala ,\n Brian Vazquez ,\n Li Li , emil.s.tantilov@intel.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1777081735; x=1777686535; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=81CODhtfCeY5gOXc4AcZuOqtvysUpw25zIQcp3J/FQg=;\n b=AvJJeVshBsMlzxkY0OdCErk+W1EIbNn2I1aQyslE/4beHf+OJCpqjZwB5ZxAdkliFq\n 2egzciVy8jJ4fN1MIjquyB8L/KusQOpTdMhxtgQqU0ay29tVq/2Xix91WT7po7E0Xs8/\n sP/wI7+zdF9ktcQTeFZ7kckyFjkDdE2Ycod/yKWVtEKRDb6Oah0TR30TashmX+2uPUmT\n FIAQBvifOWNP/TuRmXySM1IQK0hlZBN35xAdA87NoeFxAf6aqoA1fW/js4BuKBFIzIP3\n ACJMz+aC7eP+IEMGAVbrI8Y0Q0GQpJZNZjFc32tA6XkSt6EHFWTSQcqts37Iq2tf72Ci\n Cncg==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=AvJJeVsh"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v2] libie: log more info when\n virtchnl fails","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Li via Intel-wired-lan ","Reply-To":"Li Li ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Virtchnl failures can be hard to debug without logs. Logging the details\nof virtchnl transactions can be useful for debugging virtchnl-related\nissues.\n\nTested: Built and booted on a test machine.\n\nSigned-off-by: Li Li \n---\nv2:\n - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on\n reviewer feedback.\n\n drivers/net/ethernet/intel/libie/controlq.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c\nindex ebc05355e39d..bf200fea1e12 100644\n--- a/drivers/net/ethernet/intel/libie/controlq.c\n+++ b/drivers/net/ethernet/intel/libie/controlq.c\n@@ -762,6 +762,16 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params,\n \tstatus = ctlq_msg->chnl_retval ? -EFAULT : 0;\n \n \txn = &xnm->ring[xn_index];\n+\n+\tif (ctlq_msg->chnl_retval) {\n+\t\tdev_err_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Non-zero virtchnl ret val (msg op: %u, ret val: %u, msg_cookie: %u, data_len: %u); xn op: %u, id: %u, cookie: %u\\n\",\n+\t\t\tctlq_msg->chnl_opcode, ctlq_msg->chnl_retval,\n+\t\t\tmsg_cookie, ctlq_msg->data_len, xn->virtchnl_opcode,\n+\t\t\txn->index, xn->cookie);\n+\t}\n+\n \tif (ctlq_msg->chnl_opcode != xn->virtchnl_opcode ||\n \t msg_cookie != xn->cookie)\n \t\treturn false;\n@@ -1011,6 +1021,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params)\n \t\tparams->recv_mem = xn->recv_mem;\n \t\tbreak;\n \tdefault:\n+\t\tdev_warn_ratelimited(\n+\t\t\tparams->ctlq->dev,\n+\t\t\t\"Transaction failed (op %u, xn state: %d, id: %u, cookie: %u, size: %zu)\\n\",\n+\t\t\tparams->chnl_opcode, xn->state, xn->index, xn->cookie,\n+\t\t\txn->recv_mem.iov_len);\n \t\tret = -EBADMSG;\n \t\tbreak;\n \t}\n","prefixes":["iwl-next","v2"]}