{"id":2228040,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2228040/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260425014029.438186-1-rosenp@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260425014029.438186-1-rosenp@gmail.com>","date":"2026-04-25T01:40:29","name":"pinctrl: starfive: jh7110: use struct_size","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ee4384016ff366ac7691b7155965990c9d1ae50f","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/1.1/people/70304/?format=json","name":"Rosen Penev","email":"rosenp@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260425014029.438186-1-rosenp@gmail.com/mbox/","series":[{"id":501413,"url":"http://patchwork.ozlabs.org/api/1.1/series/501413/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=501413","date":"2026-04-25T01:40:29","name":"pinctrl: starfive: jh7110: use struct_size","version":1,"mbox":"http://patchwork.ozlabs.org/series/501413/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228040/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228040/checks/","tags":{},"headers":{"Return-Path":"\n <linux-gpio+bounces-35520-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=aJvTVP9i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35520-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"aJvTVP9i\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.215.181","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2Xbf1JvBz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 11:41:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id E43A23023A4F\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 01:40:54 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D8E9021CFEF;\n\tSat, 25 Apr 2026 01:40:50 +0000 (UTC)","from mail-pg1-f181.google.com (mail-pg1-f181.google.com\n [209.85.215.181])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F1C1C5F27\n\tfor <linux-gpio@vger.kernel.org>; Sat, 25 Apr 2026 01:40:49 +0000 (UTC)","by mail-pg1-f181.google.com with SMTP id\n 41be03b00d2f7-c70c112cb61so5509582a12.0\n        for <linux-gpio@vger.kernel.org>;\n Fri, 24 Apr 2026 18:40:49 -0700 (PDT)","from ryzen ([2601:644:8000:5b5d::8bd])\n        by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c7976f0811fsm18694358a12.0.2026.04.24.18.40.45\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Fri, 24 Apr 2026 18:40:47 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777081250; cv=none;\n b=qB9hhrVhLq2B77pYiamWOjJYtTVQ6ZTKiZtxxcTYgcdXoRJc+010hlLrBOv4ZXs/8lpW3HPXmU38nXIUD4Mny0EaO0b2iatqlnWRiNpIZqASRxm0xGxPw4nTqA7KCAxfDaYjr3xtAhWZRZPxrLZXHcLoSURp0U9KVZu/oIprIB8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777081250; c=relaxed/simple;\n\tbh=s7xRw2+FvzK5g98p/kRflojZycaFuy0Jd6uptcZKYT8=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Dtj4fGrJ98H2XGXXNmNnoh7xzdKhK6JUqG+x6I8BGWluJ6yfwkzevsGoUU8CTd7j4L92HCm2SDfY/i6zJAL7bxWE2OZgEgHsJQJZy0z2ACFnKFZrMVr9k5LVA4E8AvYEpNehRc26B4MTLukOzl3XGSXeqcjTb6NCspTe53zq10I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=aJvTVP9i; arc=none smtp.client-ip=209.85.215.181","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1777081248; x=1777686048;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:from:to:cc:subject:date:message-id:reply-to;\n        bh=oxYF7ui2BPFGy0dMMzZR3KyJQqUuOE+azCNCA95w7Vk=;\n        b=aJvTVP9irXwPzHfYR8rRujCbjERMNfW0EkjAh7QkYALbudMRPNPX6ftxsiK5/fOG0c\n         RqtfwStOZnxirqfIOhwSlWa8sZzTO7e0NMeg6ABZ+ClHUjjOLHDG37MjHDJ5dJlun/Bq\n         0aIfTDyexDM7/tNiIspzV6NsPdQsCog3OdAVXqoy8L13c4DH5az9hI6dl2QCZK1gSfZ8\n         udG176foGiGoJnzVE3sqh2xs9fhx1xZ4FIeMqBdmXNwh8RmTp+fbPRYDrCB+daWeh8ap\n         lX+it7Oxg6BRh7f8ZHFf2F3mr9JyioXrap1keY2ZwHQ33PhN/30E6g2+4gOmq7+vl0JK\n         782w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777081248; x=1777686048;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=oxYF7ui2BPFGy0dMMzZR3KyJQqUuOE+azCNCA95w7Vk=;\n        b=r7OWZ8TIf03xcyv85Z7t+54S8cZXYXzmPSfwDeObLcAvGEC4Glb+SAxxge9KzLFjwj\n         ysbcGwYURmC1zjnhPbKq8lR+0g+5GXnvVwJXhYQmiU9UL7E9n8i0q8lQ5D0WgQoZtZLR\n         xKW9ezUlgwwRUZHnm8XwgyePFdvTKMyTjpq4vYZS5I+eFFk9R6g1EFIRrePOBxhwUkMU\n         vzqIJ5+IiH/WV5Wz4UA+00tEeZJwYcU5gRIIIRGQQLMFlQBZGtmuRc78BQ59jxdHgSM9\n         uLyYskVVG0Utw9sC/0uxt3K1k86ZVHidG+2T/RC17WUtQuXaUEjysxPuLZ9jFc4fUnwY\n         J7+w==","X-Gm-Message-State":"AOJu0Ywdd36O+ci+U/fOLpUedlOMk5XISI6vUobu2BFERMiRzLEDJ9KA\n\tn+xSrH+4EMiasYTFnohei3vbKcCihyziakBIhbasEyRlkfFCxNpJkc0Z69nP4g==","X-Gm-Gg":"AeBDiesxXof7xx2QhdCOVOwkdInHumGoVUFsvAjp2Y4eSRYF9OETViaL47+DnBOcGut\n\tCXzRK8wPUuCeD+cWtEFleJPUiLdkJB1Iw4WdUMznoxryfySxI8+A3PxIW53CywQG3QC9VuEGraS\n\toVYTd+ahRH/RDW81PvO82J1lGD7Newa91y+cm9fSDa5rcFR9xi7tCs3D45+pg3s/NqsRIi48QHc\n\tULIwBoR3FKFHSkOLTBBrjkEODQqFEVzjdVAuTM5QDqPxdK2TdO/YKGAiI4Iy5M14MxKetIyx13U\n\tYNGafzCugIhbvjC732+B+r+z26ptXMRskv2CUINuqdIITSn2LYumttOCG8uJLY0OfvEf+voA+cS\n\tP5IokNq9Wd23IldbYfa5V3RDUsQXj73VagICcsq404bhTD8uf2ktlEP0xMtQszxOBy/fSAeM2kL\n\tbFjpahaPbu0f4xE0nCZP84nCA9Wyi7J1+P685+QtEYRSQs+sQsUQdIjErP6hFqLSqXIEwzvoYkj\n\tuLZvRsh9CgqYcHNh0BCmTmQkw==","X-Received":"by 2002:a05:6a20:6a0d:b0:398:9d1e:1c6 with SMTP id\n adf61e73a8af0-3a08d28d04fmr37529929637.0.1777081248013;\n        Fri, 24 Apr 2026 18:40:48 -0700 (PDT)","From":"Rosen Penev <rosenp@gmail.com>","To":"linux-gpio@vger.kernel.org","Cc":"Emil Renner Berthing <kernel@esmil.dk>,\n\tHal Feng <hal.feng@starfivetech.com>,\n\tLinus Walleij <linusw@kernel.org>,\n\tlinux-kernel@vger.kernel.org (open list)","Subject":"[PATCH] pinctrl: starfive: jh7110: use struct_size","Date":"Fri, 24 Apr 2026 18:40:29 -0700","Message-ID":"<20260425014029.438186-1-rosenp@gmail.com>","X-Mailer":"git-send-email 2.54.0","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Instead of an extra kcalloc, Use a flexible array member to combine\nallocations. Saves a pointer in the struct.\n\nSigned-off-by: Rosen Penev <rosenp@gmail.com>\n---\n drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 12 +++++-------\n drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h |  2 +-\n 2 files changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c\nindex e44480e71ea8..3572e8edd9f3 100644\n--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c\n+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c\n@@ -857,17 +857,15 @@ int jh7110_pinctrl_probe(struct platform_device *pdev)\n \t\treturn -EINVAL;\n \t}\n \n+#if IS_ENABLED(CONFIG_PM_SLEEP)\n+\tsfp = devm_kzalloc(dev, struct_size(sfp, saved_regs, info->nsaved_regs),\n+\t\t\tGFP_KERNEL);\n+#else\n \tsfp = devm_kzalloc(dev, sizeof(*sfp), GFP_KERNEL);\n+#endif\n \tif (!sfp)\n \t\treturn -ENOMEM;\n \n-#if IS_ENABLED(CONFIG_PM_SLEEP)\n-\tsfp->saved_regs = devm_kcalloc(dev, info->nsaved_regs,\n-\t\t\t\t       sizeof(*sfp->saved_regs), GFP_KERNEL);\n-\tif (!sfp->saved_regs)\n-\t\treturn -ENOMEM;\n-#endif\n-\n \tsfp->base = devm_platform_ioremap_resource(pdev, 0);\n \tif (IS_ERR(sfp->base))\n \t\treturn PTR_ERR(sfp->base);\ndiff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h\nindex 2da2d6858008..188fc9d96269 100644\n--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h\n+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.h\n@@ -21,7 +21,7 @@ struct jh7110_pinctrl {\n \t/* register read/write mutex */\n \tstruct mutex mutex;\n \tconst struct jh7110_pinctrl_soc_info *info;\n-\tu32 *saved_regs;\n+\tu32 saved_regs[];\n };\n \n struct jh7110_gpio_irq_reg {\n","prefixes":[]}