{"id":2227994,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227994/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260424190513.32823-3-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260424190513.32823-3-pablo@netfilter.org>","date":"2026-04-24T19:05:04","name":"[net,02/11] netfilter: nf_tables: use list_del_rcu for netlink hooks","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2eab15c5b5fcf7fe7f949ed4685a57122659c327","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/1.1/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260424190513.32823-3-pablo@netfilter.org/mbox/","series":[{"id":501399,"url":"http://patchwork.ozlabs.org/api/1.1/series/501399/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501399","date":"2026-04-24T19:05:02","name":"[net,01/11] netfilter: arp_tables: fix IEEE1394 ARP payload parsing","version":1,"mbox":"http://patchwork.ozlabs.org/series/501399/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227994/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227994/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=BzwEU0ro;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12183-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"BzwEU0ro\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2Mrk3kw6z1yDD\n\tfor ; Sat, 25 Apr 2026 05:06:46 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 702663022973\n\tfor ; Fri, 24 Apr 2026 19:05:49 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 27CC93F9F51;\n\tFri, 24 Apr 2026 19:05:49 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 430B63F9F55;\n\tFri, 24 Apr 2026 19:05:47 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id DE7596027C;\n\tFri, 24 Apr 2026 21:05:44 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777057548; cv=none;\n b=tbxgk+54Ccyhgr55LPNLqpENcr4UI+HxFSNRpi+VePg5Ts53MYIQ38Vzu0n6fPTdNtmUQ1Cf3YwcebU/z/1lJidSzqTwJoW4hWQeALMAGjE3/rsfP6OfZdXdiQctJAAi35Qyj9NasxCO7d+SuT/cNsoc1rNGJgypGd4wwr1vF0Y=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777057548; c=relaxed/simple;\n\tbh=iMcD6b6Me6O6lojDg+I3aPhZLrZGIucvZy9bFgfcTzs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=DenGaZulDjol/Efk4lQKYDIjn/rt9Cb98M8Zq3qYue8TCb3j/+Br02JYuowgWQmK8JJw/DdN9mjlw6hAwpWIfhu0+K4eXuKc7ZqS+UYNOMDaOBPdKXneQqOGuqGut8oTZL8waoliD/Cyis25603mjr0DUcucH2jKGLsO/r6jhbM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=BzwEU0ro; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1777057545;\n\tbh=ZrzHuiicz9yWjCZVh3K5jv2UywpHODoIAzsY1iJMJTs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BzwEU0roZYA+OHFAaF/9H2lx7Be+8S88C7Uz++8MB684BwoFtlN8Bi9+OmvUjw8vO\n\t 3kZMCmjt0A5xjK32TObCmPlObIqUh2FMcdLgpZtWh7gtVyI8edMJrVhoEv9MsPCRVf\n\t GJ5ppJwhYHiwBe+NuUiwG7ebVVy60bOv64mA70FRPwDIPpSuDjASRqV+mo+yMj7HcY\n\t ALM75o53Ll2icDM5/bSeVR5bwMsSmlVLyXj5mE0eWYHnC0M6oqsW4elIYkGlTJtRmD\n\t fEuWnMoH++a7Tu+58/fDD4VyVOHcX44dRgQKWS6n1YLSujPGpw2S5LwwAbYNJciQI3\n\t ALErP1HzGUVhg==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org","Subject":"[PATCH net 02/11] netfilter: nf_tables: use list_del_rcu for netlink\n hooks","Date":"Fri, 24 Apr 2026 21:05:04 +0200","Message-ID":"<20260424190513.32823-3-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260424190513.32823-1-pablo@netfilter.org>","References":"<20260424190513.32823-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Florian Westphal \n\nnft_netdev_unregister_hooks and __nft_unregister_flowtable_net_hooks need\nto use list_del_rcu(), this list can be walked by concurrent dumpers.\n\nAdd a new helper and use it consistently.\n\nFixes: f9a43007d3f7 (\"netfilter: nf_tables: double hook unregistration in netns path\")\nSigned-off-by: Florian Westphal \nSigned-off-by: Pablo Neira Ayuso \n---\n net/netfilter/nf_tables_api.c | 44 ++++++++++++++---------------------\n 1 file changed, 18 insertions(+), 26 deletions(-)","diff":"diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c\nindex 8537b94653d3..07e151245765 100644\n--- a/net/netfilter/nf_tables_api.c\n+++ b/net/netfilter/nf_tables_api.c\n@@ -374,6 +374,12 @@ static void nft_netdev_hook_free_rcu(struct nft_hook *hook)\n \tcall_rcu(&hook->rcu, __nft_netdev_hook_free_rcu);\n }\n \n+static void nft_netdev_hook_unlink_free_rcu(struct nft_hook *hook)\n+{\n+\tlist_del_rcu(&hook->list);\n+\tnft_netdev_hook_free_rcu(hook);\n+}\n+\n static void nft_netdev_unregister_hooks(struct net *net,\n \t\t\t\t\tstruct list_head *hook_list,\n \t\t\t\t\tbool release_netdev)\n@@ -384,10 +390,8 @@ static void nft_netdev_unregister_hooks(struct net *net,\n \tlist_for_each_entry_safe(hook, next, hook_list, list) {\n \t\tlist_for_each_entry(ops, &hook->ops_list, list)\n \t\t\tnf_unregister_net_hook(net, ops);\n-\t\tif (release_netdev) {\n-\t\t\tlist_del(&hook->list);\n-\t\t\tnft_netdev_hook_free_rcu(hook);\n-\t\t}\n+\t\tif (release_netdev)\n+\t\t\tnft_netdev_hook_unlink_free_rcu(hook);\n \t}\n }\n \n@@ -2271,10 +2275,8 @@ void nf_tables_chain_destroy(struct nft_chain *chain)\n \n \t\tif (nft_base_chain_netdev(table->family, basechain->ops.hooknum)) {\n \t\t\tlist_for_each_entry_safe(hook, next,\n-\t\t\t\t\t\t &basechain->hook_list, list) {\n-\t\t\t\tlist_del_rcu(&hook->list);\n-\t\t\t\tnft_netdev_hook_free_rcu(hook);\n-\t\t\t}\n+\t\t\t\t\t\t &basechain->hook_list, list)\n+\t\t\t\tnft_netdev_hook_unlink_free_rcu(hook);\n \t\t}\n \t\tmodule_put(basechain->type->owner);\n \t\tif (rcu_access_pointer(basechain->stats)) {\n@@ -2974,6 +2976,7 @@ static int nf_tables_updchain(struct nft_ctx *ctx, u8 genmask, u8 policy,\n \t\t\t\tlist_for_each_entry(ops, &h->ops_list, list)\n \t\t\t\t\tnf_unregister_net_hook(ctx->net, ops);\n \t\t\t}\n+\t\t\t/* hook.list is on stack, no need for list_del_rcu() */\n \t\t\tlist_del(&h->list);\n \t\t\tnft_netdev_hook_free_rcu(h);\n \t\t}\n@@ -8852,10 +8855,8 @@ static void __nft_unregister_flowtable_net_hooks(struct net *net,\n \tlist_for_each_entry_safe(hook, next, hook_list, list) {\n \t\tlist_for_each_entry(ops, &hook->ops_list, list)\n \t\t\tnft_unregister_flowtable_ops(net, flowtable, ops);\n-\t\tif (release_netdev) {\n-\t\t\tlist_del(&hook->list);\n-\t\t\tnft_netdev_hook_free_rcu(hook);\n-\t\t}\n+\t\tif (release_netdev)\n+\t\t\tnft_netdev_hook_unlink_free_rcu(hook);\n \t}\n }\n \n@@ -8926,8 +8927,7 @@ static int nft_register_flowtable_net_hooks(struct net *net,\n \n \t\t\tnft_unregister_flowtable_ops(net, flowtable, ops);\n \t\t}\n-\t\tlist_del_rcu(&hook->list);\n-\t\tnft_netdev_hook_free_rcu(hook);\n+\t\tnft_netdev_hook_unlink_free_rcu(hook);\n \t}\n \n \treturn err;\n@@ -8937,10 +8937,8 @@ static void nft_hooks_destroy(struct list_head *hook_list)\n {\n \tstruct nft_hook *hook, *next;\n \n-\tlist_for_each_entry_safe(hook, next, hook_list, list) {\n-\t\tlist_del_rcu(&hook->list);\n-\t\tnft_netdev_hook_free_rcu(hook);\n-\t}\n+\tlist_for_each_entry_safe(hook, next, hook_list, list)\n+\t\tnft_netdev_hook_unlink_free_rcu(hook);\n }\n \n static int nft_flowtable_update(struct nft_ctx *ctx, const struct nlmsghdr *nlh,\n@@ -9028,8 +9026,7 @@ static int nft_flowtable_update(struct nft_ctx *ctx, const struct nlmsghdr *nlh,\n \t\t\t\tnft_unregister_flowtable_ops(ctx->net,\n \t\t\t\t\t\t\t flowtable, ops);\n \t\t}\n-\t\tlist_del_rcu(&hook->list);\n-\t\tnft_netdev_hook_free_rcu(hook);\n+\t\tnft_netdev_hook_unlink_free_rcu(hook);\n \t}\n \n \treturn err;\n@@ -9535,13 +9532,8 @@ static void nf_tables_flowtable_notify(struct nft_ctx *ctx,\n \n static void nf_tables_flowtable_destroy(struct nft_flowtable *flowtable)\n {\n-\tstruct nft_hook *hook, *next;\n-\n \tflowtable->data.type->free(&flowtable->data);\n-\tlist_for_each_entry_safe(hook, next, &flowtable->hook_list, list) {\n-\t\tlist_del_rcu(&hook->list);\n-\t\tnft_netdev_hook_free_rcu(hook);\n-\t}\n+\tnft_hooks_destroy(&flowtable->hook_list);\n \tkfree(flowtable->name);\n \tmodule_put(flowtable->data.type->owner);\n \tkfree(flowtable);\n","prefixes":["net","02/11"]}