{"id":2227977,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227977/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260424160019.41710-1-daniel.lezcano@oss.qualcomm.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/1.1/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260424160019.41710-1-daniel.lezcano@oss.qualcomm.com>","date":"2026-04-24T16:00:18","name":"[1/2] drivers/thermal/tegra/soctherm: Use devm_add_action_or_reset() for clock disable","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"aa842afb300af55f772c28a7f2fdd4126704b657","submitter":{"id":92879,"url":"http://patchwork.ozlabs.org/api/1.1/people/92879/?format=json","name":"Daniel Lezcano","email":"daniel.lezcano@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260424160019.41710-1-daniel.lezcano@oss.qualcomm.com/mbox/","series":[{"id":501390,"url":"http://patchwork.ozlabs.org/api/1.1/series/501390/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=501390","date":"2026-04-24T16:00:18","name":"[1/2] drivers/thermal/tegra/soctherm: Use devm_add_action_or_reset() for clock disable","version":1,"mbox":"http://patchwork.ozlabs.org/series/501390/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227977/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227977/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=NePKo4RZ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=I8l8Ea32;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13950-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"NePKo4RZ\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"I8l8Ea32\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2Hk46zyWz1yDD\n\tfor ; Sat, 25 Apr 2026 02:00:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 6232A3009F31\n\tfor ; Fri, 24 Apr 2026 16:00:42 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 385FE2236F0;\n\tFri, 24 Apr 2026 16:00:41 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B6FEE3385B6\n\tfor ; Fri, 24 Apr 2026 16:00:39 +0000 (UTC)","from pps.filterd (m0279867.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63OAErTk2447107\n\tfor ; Fri, 24 Apr 2026 16:00:39 GMT","from mail-qt1-f197.google.com (mail-qt1-f197.google.com\n [209.85.160.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dr6kpsc5x-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Fri, 24 Apr 2026 16:00:38 +0000 (GMT)","by mail-qt1-f197.google.com with SMTP id\n d75a77b69052e-50df4c130dbso114897861cf.1\n for ;\n Fri, 24 Apr 2026 09:00:38 -0700 (PDT)","from mai.box.freepro.com ([2a05:6e02:1041:c10:1ab3:98b0:9e96:47bd])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4412150a071sm25405491f8f.21.2026.04.24.09.00.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 24 Apr 2026 09:00:33 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777046441; cv=none;\n b=G7kH/D4ZwqHAgT2JYGtw1AI9+hyaUAeghSPThKGQb38/ToDt532VifC/dOiB7MS21wc8QB5Tk3PLtUtGicufW6m1bWR2In3kzPmXDeZz2jxbKyeQe3JQCHKKIUBxnFKemGKGci7nWmUE9hcB6v3HlqTrKmYmHobBsy6FdMVA7VM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777046441; c=relaxed/simple;\n\tbh=HzjZYqm7vAi1tx4pnndBYISW7omiEKfZZzMQA5Cx5yY=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=D27paPwJwXeDwb7aUGnkxCLd6fm3/OBuSuL9b6l54GtI0sfiv0Fk9NosG4izGr7WRJvqZ4sRbgBIYnTGYnWQ8nxn0TAvtxf6sZJiv4v4Sn7fTBE79qnQcLXEE1F9DWu8aXnSywcK8tuGeX4T4s02/umdYlSUyCV2HChaTz0+ymM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=NePKo4RZ;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=I8l8Ea32; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=Xu/Hi6gljTZ2SH/iawpgk1o2TY1lwdgvWw1\n\tZQJbCans=; b=NePKo4RZV+cRhiXc+5MLx+mXJjr12P8P6ZmrevcrX2SzYrWYfVN\n\t1ky+ZNeS7FaHc9iBPvwsmTlrz+rZSJv4NVYI/sdI2vTSVMox1NJoh/Zk3Xx8aXJa\n\tZoSX/1VkFeISlwWzKe23FKZHfmDXapu7uHXcO4VkmwDXV7KGXnBDUK+Q+V4cb5Kd\n\tDkWCXkz7C2w3bxebZDhxlOwfICtyA8Us9jVaGMQCdAqpWAuDiTqsiRflCNEvd8xy\n\tvEpqHI/jZHR+GG5bZbbUv1bEt7Ap19B7yPl86tT53M8/UdkDC3+QwFpe7ZwrxpLg\n\tIxi/3WfQrG56o2gYMkbSpUiQgrClnjl/F+g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777046437; x=1777651237;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Xu/Hi6gljTZ2SH/iawpgk1o2TY1lwdgvWw1ZQJbCans=;\n b=I8l8Ea325XCV/A1NkMBRZbli7Nk8QF2YV7cih2uJ0+VZAlsMxcPvxAVsxVtm8Y0PyD\n vJfX0cdEPXvit6S9swJU+5L239cMdkC1aflQpH5KeGRAesWohwGGKogXZ35fxc2d5z2z\n le7LTq0sZDtpNlMxlwlkQhcoD8DjX5Iw09/acBQ4N4W2lZAsIVxJSzLITmYhHYWWv4uQ\n ZU846XyatAFi03Vjl6PiR1SNNpaHOgsHy1dXH/5oFrPi4O3CPK+vdngrTWJt6TG+vFsp\n /f0BFVQBHRO6NEH9TK/ZROH7oKwVaTlz7zZppOFiDDZm/PSH6fOw32xYddyZxmdEoogj\n X+5Q=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777046437; x=1777651237;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Xu/Hi6gljTZ2SH/iawpgk1o2TY1lwdgvWw1ZQJbCans=;\n b=Ei6mEUYCpoya24fQ0wlVVcpzQuGlvGdMbIpebtTkQbCOzKe7ePlO4XSf2/1n9b4bs2\n /oYWjPS1XA48MO/l9rfyYGpqiD5EpFkQtT0T7yNohCq7urh6HF9kM9GsvtI4kQg9EHvs\n QYVFoG3GMUAO//PAJzgIaKhC2P4DeWh3GPIm319tQ2pPoF9hB4W+4n/aq+xqCcaBUyzV\n UhLMHMAmg47O9ldV0lwIQqdXgiZ/9/7gX1IzQocd6oTD9AVFo450d5XZSdJ7EwwMY8Rn\n JDO+A8lknI5TK6cZZZZezgqz3POnSiILoLJLm8Tc5mwGh8jy6bhSlPFfXOY/oTwd6jpB\n pErQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+GiSiHejNuY0HPd8+4NteY43AP4YkacjQCG7yq0cxc057A79WRjZ6aVzvg7rIPM9D+YF1OKh4SykHtvg==@vger.kernel.org","X-Gm-Message-State":"AOJu0YwZE+j/KwT7JkQLBLvxJDJXb4mI4AX0DXa3aumHtLn/HZbqDqKy\n\t8mmmX+PQoKOxSDRhK/+GVVaSWsDqPu2vyBKQE5SeS12I80pvqMQtx3699iI6HCyG0hAIQrhkL7M\n\ta6w+W1NwNoH7aw8DpAP8i02vpCn7CxKbcOso1RfNUAJvQ2Y7Ipi7uHhoz8qtQo1B43g==","X-Gm-Gg":"AeBDievqAWoPJnBo5qqvVUVme4xSZuScUvTLMm0roXELimKE181SNpe5pMIFZMXqhRQ\n\t2qcvY4Skuy/SzYfuiwUyd5WHDQ2zSGqvPTcVHDTiTFPr0xJEKrELEgQ7o6ZJKjEZF6wHA8YF+9F\n\tw2s4EltMY3eQThYn2V4uuClZPUl289GZPZomya+Dhpu4r1EJTlEhwHurUynITMCzf3lw/MwDY1b\n\tw2VEwy3Rpy1QisVw6riAQ/M/C6SteAFYWj5Q8kwjfk15rg5sEjp49jsXB6f4t/RSD0y/uJyzTBQ\n\t0+JZIdHSHf4LOwWkRm16ydqjtP9VzsAkU9u1GzlZhFYQHV28JJindGxZgFz9tL2hoAqTdpuzNV0\n\tKEXyydsgwc3Ks4WjVX34UDtNSYJRttgIPttJMr7QHdMVDn0zxzAyGXRL2jlcV","X-Received":["by 2002:a05:622a:53:b0:50d:9f3e:e1a with SMTP id\n d75a77b69052e-50e3661d421mr407490111cf.9.1777046435519;\n Fri, 24 Apr 2026 09:00:35 -0700 (PDT)","by 2002:a05:622a:53:b0:50d:9f3e:e1a with SMTP id\n d75a77b69052e-50e3661d421mr407487291cf.9.1777046433866;\n Fri, 24 Apr 2026 09:00:33 -0700 (PDT)"],"From":"Daniel Lezcano ","To":"rafael@kernel.org, daniel.lezcano@kernel.org, thierry.reding@gmail.com,\n jonathanh@nvidia.com","Cc":"rui.zhang@intel.com, lukasz.luba@arm.com, linux-pm@vger.kernel.org,\n linux-tegra@vger.kernel.org","Subject":"[PATCH 1/2] drivers/thermal/tegra/soctherm: Use\n devm_add_action_or_reset() for clock disable","Date":"Fri, 24 Apr 2026 18:00:18 +0200","Message-ID":"<20260424160019.41710-1-daniel.lezcano@oss.qualcomm.com>","X-Mailer":"git-send-email 2.43.0","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Authority-Analysis":"v=2.4 cv=cdDiaHDM c=1 sm=1 tr=0 ts=69eb93a6 cx=c_pps\n a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=ggozHacZmVhwqr8k6bIA:9\n a=a_PwQJl-kcHnX1M80qC6:22","X-Proofpoint-GUID":"9yVojuZGOdfgDrO6E-mAr-fj2lDHwb98","X-Proofpoint-ORIG-GUID":"9yVojuZGOdfgDrO6E-mAr-fj2lDHwb98","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI0MDE1NCBTYWx0ZWRfXwnMONGecD37J\n 954u6BuCVOuxkFIMGrrskgHz8Y2B5KQgNwQahB9qubwRovihn5TZ9DgA9bPV8EYgnY3idORy/63\n 6AKm35Noq6nLFd2r0P+cNP3KC7D6nC0u6p8B5MmovvpShYJ7kuBKGPtmg5mLoyJWVzgFBtOZywG\n VkfLtOErKdbiqIrlR3h6jW4Gv6+P2IIpGUuhoQwMeLo7EnEFkrblS0vjiL36ydRZdzYr16+4uU+\n 9tgsUBfMhYzytbUz6Me1zZ4xosJUe+3utEBPl/rksrUch7+zvnDLaKYOfvjYM9FFBOxPP0zKO0V\n 2sySAbKy/Hct/Z6lTZxkHRXdeu3ZsjjcKpuV31v2uNwjuZ22NrGmvIazd76xorM1FcrRBHOu9Pf\n ldG9w8Mtv7nth52QZDRGpf+X5U8dIccQkWw9ncmURlxQpSGq37K7hRCXE+xrUXmeCo3n5ae4wKt\n zcbag4JHEM7YLbO2yYg==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-24_01,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0\n suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240154"},"content":"Replace the manual error handling paths disabling the clocks with\ndevm_add_action_or_reset(). This ensures the clocks are properly\ndisabled on probe failure and driver removal, while simplifying the\ncode by removing the explicit error paths.\n\nSigned-off-by: Daniel Lezcano \n---\n drivers/thermal/tegra/soctherm.c | 28 +++++++++++++++-------------\n 1 file changed, 15 insertions(+), 13 deletions(-)","diff":"diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c\nindex 5d26b52beaba..40c3715e84c5 100644\n--- a/drivers/thermal/tegra/soctherm.c\n+++ b/drivers/thermal/tegra/soctherm.c\n@@ -1499,6 +1499,13 @@ static int soctherm_clk_enable(struct platform_device *pdev, bool enable)\n \treturn 0;\n }\n \n+static void soctherm_clk_disable(void *data)\n+{\n+\tstruct platform_device *pdev = data;\n+\n+\tsoctherm_clk_enable(pdev, false);\n+}\n+\n static int throt_get_cdev_max_state(struct thermal_cooling_device *cdev,\n \t\t\t\t unsigned long *max_state)\n {\n@@ -2175,6 +2182,10 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \tif (err)\n \t\treturn err;\n \n+\terr = devm_add_action_or_reset(&pdev->dev, soctherm_clk_disable, pdev);\n+\tif (err)\n+\t\treturn err;\n+\n \tsoctherm_thermtrips_parse(pdev);\n \n \tsoctherm_init_hw_throt_cdev(pdev);\n@@ -2184,10 +2195,8 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \tfor (i = 0; i < soc->num_ttgs; ++i) {\n \t\tstruct tegra_thermctl_zone *zone =\n \t\t\tdevm_kzalloc(&pdev->dev, sizeof(*zone), GFP_KERNEL);\n-\t\tif (!zone) {\n-\t\t\terr = -ENOMEM;\n-\t\t\tgoto disable_clocks;\n-\t\t}\n+\t\tif (!zone)\n+\t\t\treturn -ENOMEM;\n \n \t\tzone->reg = tegra->regs + soc->ttgs[i]->sensor_temp_offset;\n \t\tzone->dev = &pdev->dev;\n@@ -2201,7 +2210,7 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \t\t\terr = PTR_ERR(z);\n \t\t\tdev_err(&pdev->dev, \"failed to register sensor: %d\\n\",\n \t\t\t\terr);\n-\t\t\tgoto disable_clocks;\n+\t\t\treturn err;\n \t\t}\n \n \t\tzone->tz = z;\n@@ -2210,7 +2219,7 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \t\t/* Configure hw trip points */\n \t\terr = tegra_soctherm_set_hwtrips(&pdev->dev, soc->ttgs[i], z);\n \t\tif (err)\n-\t\t\tgoto disable_clocks;\n+\t\t\treturn err;\n \t}\n \n \terr = soctherm_interrupts_init(pdev, tegra);\n@@ -2218,11 +2227,6 @@ static int tegra_soctherm_probe(struct platform_device *pdev)\n \tsoctherm_debug_init(pdev);\n \n \treturn 0;\n-\n-disable_clocks:\n-\tsoctherm_clk_enable(pdev, false);\n-\n-\treturn err;\n }\n \n static void tegra_soctherm_remove(struct platform_device *pdev)\n@@ -2230,8 +2234,6 @@ static void tegra_soctherm_remove(struct platform_device *pdev)\n \tstruct tegra_soctherm *tegra = platform_get_drvdata(pdev);\n \n \tdebugfs_remove_recursive(tegra->debugfs_dir);\n-\n-\tsoctherm_clk_enable(pdev, false);\n }\n \n static int __maybe_unused soctherm_suspend(struct device *dev)\n","prefixes":["1/2"]}