{"id":2227945,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227945/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.1/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr>","date":"2026-04-24T14:17:36","name":"[v5,5/8] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b1279a20db984b35387dc9d1d4384a801dc2fc5a","submitter":{"id":93204,"url":"http://patchwork.ozlabs.org/api/1.1/people/93204/?format=json","name":"Ronald Claveau via B4 Relay","email":"devnull+linux-kernel-dev.aliel.fr@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr/mbox/","series":[{"id":501376,"url":"http://patchwork.ozlabs.org/api/1.1/series/501376/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=501376","date":"2026-04-24T14:17:34","name":"Add VIM4 MCU/FAN support","version":5,"mbox":"http://patchwork.ozlabs.org/series/501376/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227945/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227945/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oLhw+15V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17173-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"oLhw+15V\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2FbH6ggzz1yD5\n\tfor ; Sat, 25 Apr 2026 00:24:43 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D15B5307AAD1\n\tfor ; Fri, 24 Apr 2026 14:20:21 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3A6CE3DE42F;\n\tFri, 24 Apr 2026 14:20:11 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED343DC4C8;\n\tFri, 24 Apr 2026 14:20:10 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPS id 2987AC2BCFB;\n\tFri, 24 Apr 2026 14:20:10 +0000 (UTC)","from aws-us-west-2-korg-lkml-1.web.codeaurora.org\n (localhost.localdomain [127.0.0.1])\n\tby smtp.lore.kernel.org (Postfix) with ESMTP id 1FECEFED3CC;\n\tFri, 24 Apr 2026 14:20:10 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777040410; cv=none;\n b=eP8oKbjZQBvK1ChtepGDIAbYu/HTOieLo/POU5FahnBbW0htFkYlxFMJNob2Gdh6sWl//FzHgfUr02gioHG8FR6204HVOJGy6rwATgFnFxUXsS3RE2x9TE8k3HAzQK/fk06yKRSVe/YMaAjWUMrXoAfTxcRryYKhLMN8Fsrk82s=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777040410; c=relaxed/simple;\n\tbh=d9NCTi+Rcq2wKZJ9kEiQHUc4L2hpQSLttTrOJrWTet4=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=BTu2h8+mj72v/iw9hIRyLRrwBrhH5bF5uDtFfU5ydm2w4Z1Kg5UxHACyDWYKku2937sGsX5wrvuay/LERqEkITRzhaCysQHszH8HdAl9Ndap1O9CK71pXPBceiJ7d1FB/m7MVDiggcfCeNKAuzMqoP8KVn0H3HhZF6/uU2n/ftU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=oLhw+15V; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777040410;\n\tbh=d9NCTi+Rcq2wKZJ9kEiQHUc4L2hpQSLttTrOJrWTet4=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From;\n\tb=oLhw+15VW4xV0seFJuMjgOu+CAsE+QCt7gTwxnzIKtGS875pTmDzUbwccsJ06k88P\n\t aZHeXbmoTW3XiRPfYo8JS8rQyoOIbc08QqN9rLtq3UKRLIO4YSy+gpNHB6H2lsJUKF\n\t jNZ20l3d6F5hzV+sxfwfMRObSaId17VQQOG7sOMs2VAwumkTGrzSjgcraOJbp1tzSC\n\t tlurH+fHtwWOnharzpsifICH/SCW5e58a0s0tU08S0Iz4flPXgmJjC19exLPNAf9+/\n\t TCLIUSqtYyJqTvh0iZ/EsqwLQ5nFiAEL/ExcVI1P+zZFjge4g/Ye8J6yfQoEdUcwTK\n\t 1G2JI4SwQ0L9g==","From":"Ronald Claveau via B4 Relay\n ","Date":"Fri, 24 Apr 2026 16:17:36 +0200","Subject":"[PATCH v5 5/8] thermal: khadas-mcu-fan: Add fan config from\n platform data Add regulator support","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr>","References":"<20260424-add-mcu-fan-khadas-vim4-v5-0-afcfa7157b23@aliel.fr>","In-Reply-To":"<20260424-add-mcu-fan-khadas-vim4-v5-0-afcfa7157b23@aliel.fr>","To":"Neil Armstrong , Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,\n Ronald Claveau ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3485;\n i=linux-kernel-dev@aliel.fr; h=from:subject:message-id;\n bh=JiLx8eTR6rFqMVIEqmUsuF0zE3OLjg1JbYglE13jrOs=;\n b=owGbwMvMwCWm1SvKXP3cUInxtFoSQ+brGmH/3WXGDQXLVWaV9MybvSOcr8ijfqPb1/bVEy1rN\n ze/uF/VUcrCIMbFICumyNI/1/LEu8tHz3zdo54CM4eVCWQIAxenAExkRSojw7bVGryrM0pmf2hY\n +uJN0rtHS6byK7DtT03K/dCiFrne3JPhn0rJU1XTo+KfVTUCMr7JnssuzUl+2RzjWBcb0XVXZac\n UMwA=","X-Developer-Key":"i=linux-kernel-dev@aliel.fr; a=openpgp;\n fpr=DFD863F61375BF917F0012173953305EF1D0EC3E","X-Endpoint-Received":"by B4 Relay for linux-kernel-dev@aliel.fr/default with\n auth_id=744","X-Original-From":"Ronald Claveau ","Reply-To":"linux-kernel-dev@aliel.fr"},"content":"From: Ronald Claveau \n\nReplace the hardcoded MAX_LEVEL constant and fan register\nwith values read from platform_data (fan_reg, max_level),\nas new MCUs need different values.\n\nOptionally acquire and enable a \"fan\" regulator supply\nat probe time and on resume,\nso boards that gate fan power through a regulator are handled.\n\nSigned-off-by: Ronald Claveau \n---\n drivers/thermal/khadas_mcu_fan.c | 37 ++++++++++++++++++++++++++++++-------\n 1 file changed, 30 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c\nindex d35e5313bea41..5603fa099a858 100644\n--- a/drivers/thermal/khadas_mcu_fan.c\n+++ b/drivers/thermal/khadas_mcu_fan.c\n@@ -13,13 +13,15 @@\n #include \n #include \n #include \n-\n-#define MAX_LEVEL 3\n+#include \n \n struct khadas_mcu_fan_ctx {\n \tstruct khadas_mcu *mcu;\n+\tunsigned int fan_reg;\n \tunsigned int level;\n+\tunsigned int max_level;\n \tstruct thermal_cooling_device *cdev;\n+\tstruct regulator *power;\n };\n \n static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n@@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n {\n \tint ret;\n \n-\tret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,\n-\t\t\t level);\n+\tret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level);\n \tif (ret)\n \t\treturn ret;\n \n@@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev,\n \t\t\t\t\tunsigned long *state)\n {\n-\t*state = MAX_LEVEL;\n+\tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n+\n+\t*state = ctx->max_level;\n \n \treturn 0;\n }\n@@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev,\n {\n \tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n \n-\tif (state > MAX_LEVEL)\n+\tif (state > ctx->max_level)\n \t\treturn -EINVAL;\n \n \tif (state == ctx->level)\n@@ -78,6 +81,7 @@ static const struct thermal_cooling_device_ops khadas_mcu_fan_cooling_ops = {\n \n static int khadas_mcu_fan_probe(struct platform_device *pdev)\n {\n+\tconst struct khadas_mcu_fan_pdata *pdata = dev_get_platdata(&pdev->dev);\n \tstruct khadas_mcu *mcu = dev_get_drvdata(pdev->dev.parent);\n \tstruct thermal_cooling_device *cdev;\n \tstruct device *dev = &pdev->dev;\n@@ -87,7 +91,21 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)\n \tctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);\n \tif (!ctx)\n \t\treturn -ENOMEM;\n+\n \tctx->mcu = mcu;\n+\tctx->fan_reg = pdata->fan_reg;\n+\tctx->max_level = pdata->max_level;\n+\n+\tctx->power = devm_regulator_get(dev->parent, \"fan\");\n+\tif (IS_ERR(ctx->power))\n+\t\treturn PTR_ERR(ctx->power);\n+\n+\tret = regulator_enable(ctx->power);\n+\tif (ret) {\n+\t\tdev_err(dev, \"Failed to enable fan power supply: %d\\n\", ret);\n+\t\treturn ret;\n+\t}\n+\n \tplatform_set_drvdata(pdev, ctx);\n \n \tcdev = devm_thermal_of_cooling_device_register(dev->parent,\n@@ -124,12 +142,17 @@ static int khadas_mcu_fan_suspend(struct device *dev)\n \n \tctx->level = level_save;\n \n-\treturn 0;\n+\treturn regulator_disable(ctx->power);\n }\n \n static int khadas_mcu_fan_resume(struct device *dev)\n {\n \tstruct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev);\n+\tint ret;\n+\n+\tret = regulator_enable(ctx->power);\n+\tif (ret)\n+\t\treturn ret;\n \n \treturn khadas_mcu_fan_set_level(ctx, ctx->level);\n }\n","prefixes":["v5","5/8"]}