{"id":2227830,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227830/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260424103604.2616657-4-johan@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.1/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/"},"msgid":"<20260424103604.2616657-4-johan@kernel.org>","date":"2026-04-24T10:36:04","name":"[3/3] powerpc/pseries: clean up ibmebus printks","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2be94290869c4ab2b6985642c4079083edde3e78","submitter":{"id":64666,"url":"http://patchwork.ozlabs.org/api/1.1/people/64666/?format=json","name":"Johan Hovold","email":"johan@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260424103604.2616657-4-johan@kernel.org/mbox/","series":[{"id":501340,"url":"http://patchwork.ozlabs.org/api/1.1/series/501340/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=501340","date":"2026-04-24T10:36:03","name":"powerpc: switch to dynamic root devices","version":1,"mbox":"http://patchwork.ozlabs.org/series/501340/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227830/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2227830/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uhuDpIl9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20068-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uhuDpIl9;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=johan@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g28Wx6lJjz1yD5\n\tfor ; Fri, 24 Apr 2026 20:36:29 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g28Wp0rrtz2yrD;\n\tFri, 24 Apr 2026 20:36:22 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g28Wm1zkmz2ybQ\n\tfor ; Fri, 24 Apr 2026 20:36:19 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id CA06E44453;\n\tFri, 24 Apr 2026 10:36:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 64713C19425;\n\tFri, 24 Apr 2026 10:36:17 +0000 (UTC)","from johan by xi.lan with local (Exim 4.98.2)\n\t(envelope-from )\n\tid 1wGDtP-0000000Ayid-0ttq;\n\tFri, 24 Apr 2026 12:36:15 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777026981;\n\tcv=none;\n b=HQk+aJQ1iiGwJVqXKkPuAdORz0CG/oNi7EYUGzsqalSePH/vNawfpS+Xj2fEDA4Oc9SBqpis2v6W8P/wGdmGEHLL0n8bmwhK/AhBUI2XqYAbOogRLArRvwzPKiWllKpGh+3LqCp7ElnKOEQnz2sIcr4IfapIBLPIoT3ek7q1PQt3v1y6shUlS0ptK19a/UBlxJYT3FYF1pXSB2Z1kj6AvUVrXe9ca4O5JwXf8GyO68fF5/XzLp+uDvGjPmJO6UyQbmXC2MjLscUUs8HdavPEaSgeO4bgia6lfeC/10QIxLhYs+uHzroeL/TZDeXKgD+wYPI9KW3uO8geuj7FvGr4mg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777026981; c=relaxed/relaxed;\n\tbh=m5pjwrWvtX8hEGA84jOB2WzPkwcVIwZUE/Ac5wsJqXI=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=OjFj0znGHqNSa/hL7pDC48I6VYbTcSTMZJBOSQZbulB9DU4ux9oz03+oUKvMyYTJlUF+9jGKKYLp+QKp2l4OmS5q+RvI4ejDgK8qeFBr/cl05b9IbyqaMrBGlyFj5ObMhuRfB3SlhpAFOXhphc4bxFYXIzgBNsLCs57GEYM2oEGSv52dhg2tqOGXocgaiQd1gG61c/ZCHzxcCEj3VqGv++lkQBKgH0R+VXumJKjFOAwt6SmThcAt+jwWSus2CC4QNUDPpFejVj9RIF5TmjLjrBkhk6qeWBQ5fnFsBXnQs4f27vA6TvybpTVDnsztvVngqEaHKLLfXJGlX4o7GMs0IQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uhuDpIl9; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=johan@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777026977;\n\tbh=r7t9IjXKXmo4brGWblnNZdlBkkZXdXtKpLhAebYCUJw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uhuDpIl9/P8W25DmD4zGUUPjIEs4PGArX3GqU0qqG/dKcu1QBbVK620WbzuOcV0Fh\n\t mCArJVLlL4ksuM5CeqEkwLLc7LzEzeiUr6wJ0hh4guRWrl/ZcXYjoG17Lr2PVF5Gkq\n\t QyO4uEkytfkD3h1cIWYoRU/A0oA7krXkrDvNZDl4d9bh3YFHjuGFtWSmKCWRQySn3y\n\t UKQrbZs+yEKodPgcs+/hP0NRQe04fiq0qs9PeLsgPBTN0WDht3cN1HLygdra6eo4Lu\n\t NaZoehxIPU2hdr59PKcHb4x1ZIGnDetoOQBWfqO42Cu0Wo+LjZiRHqd85kApa1zRGv\n\t ZwC10VgN//vjg==","From":"Johan Hovold ","To":"Geoff Levand ,\n\tMadhavan Srinivasan ,\n\tMichael Ellerman ","Cc":"Nicholas Piggin ,\n\tChristophe Leroy ,\n\tGreg Kroah-Hartman ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org,\n\tJohan Hovold ","Subject":"[PATCH 3/3] powerpc/pseries: clean up ibmebus printks","Date":"Fri, 24 Apr 2026 12:36:04 +0200","Message-ID":"<20260424103604.2616657-4-johan@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260424103604.2616657-1-johan@kernel.org>","References":"<20260424103604.2616657-1-johan@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Clean up the imbebus printks by switching to pr_warn() and pr_err(),\nadding a missing newline and making the error messages a bit more\nuniform.\n\nSigned-off-by: Johan Hovold \n---\n arch/powerpc/platforms/pseries/ibmebus.c | 20 +++++++-------------\n 1 file changed, 7 insertions(+), 13 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c\nindex e3b41e2d844f..8797b2137d9c 100644\n--- a/arch/powerpc/platforms/pseries/ibmebus.c\n+++ b/arch/powerpc/platforms/pseries/ibmebus.c\n@@ -203,8 +203,7 @@ static int ibmebus_create_devices(const struct of_device_id *matches)\n \n \t\tret = ibmebus_create_device(child);\n \t\tif (ret) {\n-\t\t\tprintk(KERN_ERR \"%s: failed to create device (%i)\",\n-\t\t\t __func__, ret);\n+\t\t\tpr_err(\"%s: failed to create device: %d\\n\", __func__, ret);\n \t\t\tof_node_put(child);\n \t\t\tbreak;\n \t\t}\n@@ -282,8 +281,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c\n \t\t\t ibmebus_match_path);\n \tif (dev) {\n \t\tput_device(dev);\n-\t\tprintk(KERN_WARNING \"%s: %s has already been probed\\n\",\n-\t\t __func__, path);\n+\t\tpr_warn(\"%s: %s has already been probed\\n\", __func__, path);\n \t\trc = -EEXIST;\n \t\tgoto out;\n \t}\n@@ -292,8 +290,7 @@ static ssize_t probe_store(const struct bus_type *bus, const char *buf, size_t c\n \t\trc = ibmebus_create_device(dn);\n \t\tof_node_put(dn);\n \t} else {\n-\t\tprintk(KERN_WARNING \"%s: no such device node: %s\\n\",\n-\t\t __func__, path);\n+\t\tpr_warn(\"%s: no such device node: %s\\n\", __func__, path);\n \t\trc = -ENODEV;\n \t}\n \n@@ -322,8 +319,7 @@ static ssize_t remove_store(const struct bus_type *bus, const char *buf, size_t\n \t\tkfree(path);\n \t\treturn count;\n \t} else {\n-\t\tprintk(KERN_WARNING \"%s: %s not on the bus\\n\",\n-\t\t __func__, path);\n+\t\tpr_warn(\"%s: %s not on the bus\\n\", __func__, path);\n \n \t\tkfree(path);\n \t\treturn -ENODEV;\n@@ -447,20 +443,18 @@ static int __init ibmebus_bus_init(void)\n {\n \tint err;\n \n-\tprintk(KERN_INFO \"IBM eBus Device Driver\\n\");\n+\tpr_info(\"IBM eBus Device Driver\\n\");\n \n \terr = bus_register(&ibmebus_bus_type);\n \tif (err) {\n-\t\tprintk(KERN_ERR \"%s: failed to register IBM eBus.\\n\",\n-\t\t __func__);\n+\t\tpr_err(\"%s: failed to register IBM eBus\\n\", __func__);\n \t\treturn err;\n \t}\n \n \tibmebus_bus_device = root_device_register(\"ibmebus\");\n \tif (IS_ERR(ibmebus_bus_device)) {\n \t\terr = PTR_ERR(ibmebus_bus_device);\n-\t\tprintk(KERN_WARNING \"%s: root_device_register returned %i\\n\",\n-\t\t __func__, err);\n+\t\tpr_err(\"%s: failed to register root device: %d\\n\", __func__, err);\n \t\tbus_unregister(&ibmebus_bus_type);\n \n \t\treturn err;\n","prefixes":["3/3"]}