{"id":2227592,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227592/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260424-ds90ub953-v6-3-7a84efbab316@oss.nxp.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.1/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260424-ds90ub953-v6-3-7a84efbab316@oss.nxp.com>","date":"2026-04-24T01:42:26","name":"[v6,3/4] media: i2c: ds90ub953: use devm_mutex_init() to simplify code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2c5c9312efdbf086d5056603238d70d0f13cb819","submitter":{"id":86694,"url":"http://patchwork.ozlabs.org/api/1.1/people/86694/?format=json","name":"Guoniu Zhou","email":"guoniu.zhou@oss.nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260424-ds90ub953-v6-3-7a84efbab316@oss.nxp.com/mbox/","series":[{"id":501274,"url":"http://patchwork.ozlabs.org/api/1.1/series/501274/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=501274","date":"2026-04-24T01:42:23","name":"media: i2c: ds90ub953: Add back channel GPIO support","version":6,"mbox":"http://patchwork.ozlabs.org/series/501274/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227592/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227592/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-NXP1-onmicrosoft-com\n header.b=BcKTN8z+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35451-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com\n header.i=@NXP1.onmicrosoft.com header.b=\"BcKTN8z+\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.72.46","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=oss.nxp.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.nxp.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=oss.nxp.com;"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1wg95FmQz1xvV\n\tfor ; Fri, 24 Apr 2026 11:41:57 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 6587B300D579\n\tfor ; Fri, 24 Apr 2026 01:40:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 363AA299A87;\n\tFri, 24 Apr 2026 01:40:14 +0000 (UTC)","from AM0PR02CU008.outbound.protection.outlook.com\n (mail-westeuropeazon11013046.outbound.protection.outlook.com [52.101.72.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 64EA629D28F;\n\tFri, 24 Apr 2026 01:40:12 +0000 (UTC)","from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16)\n by VE1PR04MB7455.eurprd04.prod.outlook.com (2603:10a6:800:1a1::23) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Fri, 24 Apr\n 2026 01:40:08 +0000","from AS8PR04MB9080.eurprd04.prod.outlook.com\n ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com\n ([fe80::92c2:2e03:bf99:68eb%6]) with mapi id 15.20.9846.021; Fri, 24 Apr 2026\n 01:40:07 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776994813; cv=fail;\n b=h4NSG2OpzxEPjdotKtCgtqGp8rO5rqwa8fMmsEtZ9icHNpMTd8P+493lTLyCh/aFpvQ1alhfFif5ke6hfgMq0mhGA8CgBhd2Rsy5ftjFkDSC0b2BcG6CW+gcPM0tl1tnVFDsNUMKOO08lP3KifvJcL+pjodDp4sG+qNl40r7tpo=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=c9Crvm+qnuRXqgzxEF8xLIF3kkuVzAZI60ZXVxdoSVGYQkejye3Dx5ntSoENGDMciCycg193PNkvl/VavJu4aKTzAebFp8TSga4HOaPFhVCPtgyRwctvk7YFAbvNrK27oxZOGAtjAJR6xNajlIBNIWzuHAhLGzhhEpo6wQTqP9MMphrd0VIw3qI75inaIZ/gL3/gsLW9WYn/DO5hB8PydmIbe8Lp/BOEF93wCALz9vtwf2o+dsLjM1X1XMTD9umJzeZVtpSz1t3g6RlgmRBLJyUnA53SiCaFK7PHPDaFIPoStID5sgKDH+PttaSlf8Sv9VpXs6XCTkBgUaVupVh/Bg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776994813; c=relaxed/simple;\n\tbh=cLTIfnGAzIjEnDLYcdNOv8VjdnMkTIVDwIhgt3FnDhM=;\n\th=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To:\n\t To:Cc:MIME-Version;\n b=hqoqJzmdzOcfh5gCsH9YBJTqVxqAj2THShbZ8lch6aaAOeM8G4b6CPp6CSA2Q6x0/sAGatsrr8y8dJUepflr8D/IweAmAZAkVyOTkc3ljiTnE0KAdXh0Fcx9CXAjefIOkYwguSL4hQ5pF9nJ2ELfFjSrkNKq/3bMNnLjRLsFil8=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=UdtLwQJLtDVIBENIs3xfWkzAlnCbUk0cunj+tIuwIz0=;\n b=gZog3TNIO0IadhNS7YSX3HFvsMbORbKqgAqV3FfCeb5h0COQhp0vaLI0zTSsSQVcISfwmuFE8Gctc5v1MnK1G6I6pcK4+BfY/ixOUPjM2Zsl3prHVaxffaCNbCsXB7lPNaYzowNpDG05h3B7tyk1mGgtXH3gi+geoH192ocbhoVSfhZKNDi2kV3oF2eTAxgurnHKV9IZSNF8Jsi8jBVMLWKQr9stajiQyhsZbnY24DUpRQYQTuAQgwZ5lrNBaop7K/PJv3obnXrwGB3+mg/Kx0hpZk26MFJVLmocXNF1Ozc7fec5SO0zPzm0TGC88FnDmtKgZKwhrWOXhRrV11WB0A=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=oss.nxp.com;\n spf=pass smtp.mailfrom=oss.nxp.com;\n dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com\n header.i=@NXP1.onmicrosoft.com header.b=BcKTN8z+;\n arc=fail smtp.client-ip=52.101.72.46","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;\n dkim=pass header.d=oss.nxp.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n s=selector1-NXP1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=UdtLwQJLtDVIBENIs3xfWkzAlnCbUk0cunj+tIuwIz0=;\n b=BcKTN8z+q2aa37FUK7DvtUb1tI94sZMifwsDxkHVya1G5s6wYp0Q/R/sM7q5TmfUmkkcfqjfo8PkeJE0hRYA9Ln/XYx2EknqOv+tG3ilZGaMVOd4x+NW3bvgYGqwEaNP5ivlFVaoCAIR+KceoIer1TdLdkxxOiQGHtrp/W0ZZa4pV/ynxjngLRRAMLUmPsikw3A37WeXXdeYml/QdGDJ/MqKsEy5WFOcQOBqqoD7Ud52sJAt+ZCxtXTYddA2Vu6aJS4mL6EIqO8mrb+maE6YQzdVZTamk0pHJ6ifWf5tjgNo7LP+u585wonyVSBPF5r/chPPi98acvgjiDdkPkPJ0g==","From":"Guoniu Zhou ","Date":"Fri, 24 Apr 2026 09:42:26 +0800","Subject":"[PATCH v6 3/4] media: i2c: ds90ub953: use devm_mutex_init() to\n simplify code","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260424-ds90ub953-v6-3-7a84efbab316@oss.nxp.com>","References":"<20260424-ds90ub953-v6-0-7a84efbab316@oss.nxp.com>","In-Reply-To":"<20260424-ds90ub953-v6-0-7a84efbab316@oss.nxp.com>","To":"Tomi Valkeinen ,\n Mauro Carvalho Chehab , Rob Herring ,\n Krzysztof Kozlowski ,\n Conor Dooley , Frank Li ,\n Vladimir Zapolskiy , Linus Walleij ,\n Bartosz Golaszewski ","Cc":"linux-media@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, imx@lists.linux.dev,\n linux-gpio@vger.kernel.org, Guoniu Zhou ","X-Mailer":"b4 0.14.0","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1776994953; l=2757;\n i=guoniu.zhou@oss.nxp.com; s=20250815; h=from:subject:message-id;\n bh=3/WEgG1NNImg/h3VAcPVEQFyPY2QkmrMkCtpoug71jo=;\n b=OwpCwb4CaNaTWfiVeTvL1xK92BneX9OVG+JpMI12NCkR91wwnDWLxqBe/eUWiEe0/idi+zCYU\n BrePqsM5oDBBo7MT0jO5hkIwhOEmatxHw3805Gx/BSdxXHCE9iWq9a0","X-Developer-Key":"i=guoniu.zhou@oss.nxp.com; a=ed25519;\n pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo=","X-ClientProxiedBy":"MA5P287CA0164.INDP287.PROD.OUTLOOK.COM\n (2603:1096:a01:1ba::16) To AS8PR04MB9080.eurprd04.prod.outlook.com\n (2603:10a6:20b:447::16)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-Exchange-MessageSentRepresentingType":"1","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS8PR04MB9080:EE_|VE1PR04MB7455:EE_","X-MS-Office365-Filtering-Correlation-Id":"daca719e-e7c2-49f2-5eb5-08dea1a26a9e","X-MS-Exchange-SharedMailbox-RoutingAgent-Processed":"True","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|366016|7416014|376014|52116014|1800799024|19092799006|56012099003|22082099003|18002099003|38350700014;","X-Microsoft-Antispam-Message-Info":"\n\tUV/rrH+UCYcfHZtHtdyl/HvdCuaoYUikP+1KG7EyQ1gBPGq+HslQKvSMLS1VpdpUVsh6QRzKWAQkHUkck8HFKKeBo0oxhJLuL2wRLZQSRbqrvoCtn008+0kXWwKlpaawB/hf6xH844mc2gl/YYiVnUuBaVTb00edCqtBbJ6YxkoLBkVufUJKZAjx+QqqGFTEtJyaErshaS0Eihy7L54tD1vrCm3rNaxOsZCTS6o1/QFzCAvHvxGA1k0h7TNHA0AR9KofaXGjavUhr597+zoSpZ2OOYtQZuM8PD5BPtzFb+XlzIBhBV3h7S/gMXyNLrNjukEtwtYs31hZUTyddUO3W1MEWCvkca31Fmw2Qc/0amCSsq+E/0eMVBiwANhB66wUAnMoOBljLmpirl7dNamXguceMTYv61vFvOYAfGjsTB5WicNwgpTNcIlNWLJmpH1zb6NB45PEBFDxHrRper2LYwP3Nw+f9XpEogFsOgjN3z5e2u3wkuW8olQwly7i0figa6gaDO6SJkbzj3L8G8T1VfOWUC3DAyS4f3OqKf7tcc6iH9QFVqNWYx2Kz8bcR4cqe2qt5ip+1fYdEG1f9/bSM0/6YJNCOISpq9YezqwyWAMNqfZsH9/MjlQTOXnSjFNZu440aWSrNj4RbTw4q9sEP8PNVi3OxQqxpBeXcuH/MJROawSudCucQVw/ZrqfhLfG0XiOAmHtVJs63W8wnT+cr+StjcnNsvcH+B0CWhFf15wnP+4NP5jthj2SQH+TLWymE9aJqFq+3uFSPl8NpTPZHP5bWQGl5nusx4mGd26mhqc=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(52116014)(1800799024)(19092799006)(56012099003)(22082099003)(18002099003)(38350700014);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?pU+DODl82t/5OGeJ87chUGQwDpdC?=\n\t=?utf-8?q?VVOonAmxIltNwdWe8DeuJCOJt8wsiIs2DJjyezNeluMLIzrHxfMUbP/a8BmlEUCTn?=\n\t=?utf-8?q?bGIpogQ1YAqBduKphrOnSatPyUq6OeLJ9/i4XRqhW7qSFeRgQ+PHNlJS22RKyyQ9X?=\n\t=?utf-8?q?OPicSqxeYfgjMKxMsOB8wtEIcIPgPJ+YhYrtrNh1bbAYT/vjpMfohvXUavuDfqGHB?=\n\t=?utf-8?q?4B2xaVvzCBxnxUhFCvsXyC8e5GoW+UzX5CyDzqCUf5BSHzkUkEsSPIJtfDTdD88Ty?=\n\t=?utf-8?q?dtA3rTqSBr6A60RDiq3geZLuCrHB2Ivl4jW4dpHFkKlu2QiKguAtdSjd7wicVx0Vm?=\n\t=?utf-8?q?Y4rcbEOIzDOmX+JbC/yKu/WP2ulB/leWLiZ49quSyKzcCz3TyyWiwAQEw2DSE8uXm?=\n\t=?utf-8?q?9GTujsQiB21NrEZLl5NF6fnQaedD97Af/gnRcmWppuzwA6cApX9ghxUZzuzi2HBV1?=\n\t=?utf-8?q?ZvDk2dBss64ayYv+ujhSiNmc/aavhL93HHaCQA2Bf01TGrweZg6cT5YYQTFLWck7d?=\n\t=?utf-8?q?9xMimTgMJReddMTYxUv08KJcuPequHlW+RwBYGvkaFvT9ZqOONAnCjtw+iMX10iSq?=\n\t=?utf-8?q?E9DE7QZRr7bgaMx/ShOizbDZyWzwG/x7IyKmQ7iYHIiwRoMSNunA/OYkxPT3EEnSZ?=\n\t=?utf-8?q?TlGdDaPGuUxP4rUmBefzqDQpl+hB4LWRpcZGM5PWbqfQPLhz/iJxwmqqIWPg8gBHv?=\n\t=?utf-8?q?eNzBxY6FgkgUSDbUYHCQwNoW2Iuptumv9NT2vxBnpzzOfGNfJJNH8L98M95no08As?=\n\t=?utf-8?q?ZNXaNgDbbeHmeF6rFKlAgk2SLpINzMWGSRPOOYH2V58NL0KvHOeUgNXZ7n+EWGszf?=\n\t=?utf-8?q?MarX07uzHFD3pmJ5hMxLOxnIIkr/U0TdH74XmgSGI1QcmNTPa6iwwVfO5u76dQc2d?=\n\t=?utf-8?q?gvCbvutrLvoWY8zQr7sZVDAEeLCeoJhC/XHFrVW5NGk7KdVJcph31pNsSEGty7XOW?=\n\t=?utf-8?q?gn0hfeInPjg/YkltXl9gIL6Z2vJ2qak51sRHqaBfk+eblx3bf2istmUX2M6yCXY5R?=\n\t=?utf-8?q?0ZBGs7oEiZWU90i++4L4Sq40GzU9RFF2JIwkPjIRODi0h08XWdLtpXWEIH1hGl59W?=\n\t=?utf-8?q?MwDjkIKIswWEhrY37eMyFz+5IhRkrbs8gjgnAd4ZK2viIVes3MmwvL/ucF1TjMzEm?=\n\t=?utf-8?q?70wZz2Ce+7uFiIKgg4OwY61F5a8wm782rlQ9+uMCXf+/XWl9KIVvcyZaDH9jzMZB5?=\n\t=?utf-8?q?xbqVy1eWbiN0ni97IZ0fkJQ138XS/iyM1nV7jwdGUx8rwqyB9eYtPZ3Y6oownL5r1?=\n\t=?utf-8?q?1bNOPRBVC5JPtr9zH72lVKsyZkjFZl+MluK3xqACjPimFN2s6oAV+tdmAmMZcQi+F?=\n\t=?utf-8?q?+CZDb27ej9KYJlMvQ4id3Ym6oH1Viym7x3NZ4VZ40so10+KQq4+2qNLUtnV2iA/N4?=\n\t=?utf-8?q?3TjxqdTzahJwiwTh9+yZ+fHkSoc6mhcpvh378xhk+p6/tAEuag80Z68nkpehQSTG1?=\n\t=?utf-8?q?VhO/ImybDRW3ReLJ6iEPbXVHKtInQoBr2/dgWzfFlfa85O4gn3WXLv+e0auADSKoK?=\n\t=?utf-8?q?T3chfP/0hzYySq1Xvp39b1C9D2l4cedU59bcmtSwz8kkgotX+LUYa6eLb9xBUS9G8?=\n\t=?utf-8?q?s9GYJJdz32CDiwKo4vx9vUlH+mXs/UdjLXo/DbEXAgKVuosg7Xry/uTA8TfXcPMot?=\n\t=?utf-8?q?CknY3y4duPjEpD7+IKmbMBc8VHZg1Ocw=3D=3D?=","X-OriginatorOrg":"oss.nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n daca719e-e7c2-49f2-5eb5-08dea1a26a9e","X-MS-Exchange-CrossTenant-AuthSource":"AS8PR04MB9080.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Apr 2026 01:40:07.9607\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n Wwev+GKX7SpusEHlU19j/+IPbpVHNohHruLo5gH1jOp+J+0HgXmOqPMl7CQjnmOh8V1yJKd3cj1FTFp7PPrfjA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VE1PR04MB7455"},"content":"From: Guoniu Zhou \n\nUse devm_mutex_init() to simplify the code. No functional change.\n\nReviewed-by: Frank Li \nReviewed-by: Tomi Valkeinen \nSigned-off-by: Guoniu Zhou \n---\nChanges in v6:\n- Added Reviewed-by tag from Tomi Valkeinen\n\nChanges in v2:\n- Move PTR_ERR() in dev_err_probe();\n---\n drivers/media/i2c/ds90ub953.c | 33 +++++++++++++--------------------\n 1 file changed, 13 insertions(+), 20 deletions(-)","diff":"diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c\nindex da63dcfbbbc3..c37d9cbe88b9 100644\n--- a/drivers/media/i2c/ds90ub953.c\n+++ b/drivers/media/i2c/ds90ub953.c\n@@ -1299,7 +1299,9 @@ static int ub953_probe(struct i2c_client *client)\n \tif (!priv->plat_data)\n \t\treturn dev_err_probe(dev, -ENODEV, \"Platform data missing\\n\");\n \n-\tmutex_init(&priv->reg_lock);\n+\tret = devm_mutex_init(dev, &priv->reg_lock);\n+\tif (ret)\n+\t\treturn ret;\n \n \t/*\n \t * Initialize to invalid values so that the first reg writes will\n@@ -1308,32 +1310,26 @@ static int ub953_probe(struct i2c_client *client)\n \tpriv->current_indirect_target = 0xff;\n \n \tpriv->regmap = devm_regmap_init_i2c(client, &ub953_regmap_config);\n-\tif (IS_ERR(priv->regmap)) {\n-\t\tret = PTR_ERR(priv->regmap);\n-\t\tdev_err_probe(dev, ret, \"Failed to init regmap\\n\");\n-\t\tgoto err_mutex_destroy;\n-\t}\n+\tif (IS_ERR(priv->regmap))\n+\t\treturn dev_err_probe(dev, PTR_ERR(priv->regmap),\n+\t\t\t\t \"Failed to init regmap\\n\");\n \n \tpriv->clkin = devm_clk_get_optional(dev, \"clkin\");\n-\tif (IS_ERR(priv->clkin)) {\n-\t\tret = PTR_ERR(priv->clkin);\n-\t\tdev_err_probe(dev, ret, \"failed to parse 'clkin'\\n\");\n-\t\tgoto err_mutex_destroy;\n-\t}\n+\tif (IS_ERR(priv->clkin))\n+\t\treturn dev_err_probe(dev, PTR_ERR(priv->clkin),\n+\t\t\t\t \"Failed to parse 'clkin'\\n\");\n \n \tret = ub953_parse_dt(priv);\n \tif (ret)\n-\t\tgoto err_mutex_destroy;\n+\t\treturn ret;\n \n \tret = ub953_hw_init(priv);\n \tif (ret)\n-\t\tgoto err_mutex_destroy;\n+\t\treturn ret;\n \n \tret = ub953_gpiochip_probe(priv);\n-\tif (ret) {\n-\t\tdev_err_probe(dev, ret, \"Failed to init gpiochip\\n\");\n-\t\tgoto err_mutex_destroy;\n-\t}\n+\tif (ret)\n+\t\treturn dev_err_probe(dev, ret, \"Failed to init gpiochip\\n\");\n \n \tret = ub953_register_clkout(priv);\n \tif (ret) {\n@@ -1357,8 +1353,6 @@ static int ub953_probe(struct i2c_client *client)\n \tub953_subdev_uninit(priv);\n err_gpiochip_remove:\n \tub953_gpiochip_remove(priv);\n-err_mutex_destroy:\n-\tmutex_destroy(&priv->reg_lock);\n \n \treturn ret;\n }\n@@ -1373,7 +1367,6 @@ static void ub953_remove(struct i2c_client *client)\n \tub953_subdev_uninit(priv);\n \n \tub953_gpiochip_remove(priv);\n-\tmutex_destroy(&priv->reg_lock);\n }\n \n static const struct ub953_hw_data ds90ub953_hw = {\n","prefixes":["v6","3/4"]}