{"id":2227371,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227371/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423135035.50126-6-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423135035.50126-6-philmd@linaro.org>","date":"2026-04-23T13:50:31","name":"[5/9] target/s390x: Compile translate.c as common unit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eef29b266414acbe48b9952a4c3d8cd541d9da48","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423135035.50126-6-philmd@linaro.org/mbox/","series":[{"id":501199,"url":"http://patchwork.ozlabs.org/api/1.1/series/501199/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501199","date":"2026-04-23T13:50:26","name":"target/s390x/tcg: Compile various files once","version":1,"mbox":"http://patchwork.ozlabs.org/series/501199/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227371/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227371/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=tJFXNOHb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1cx614vtz1y2d\n\tfor ; Thu, 23 Apr 2026 23:52:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFuSj-0000kD-Cm; Thu, 23 Apr 2026 09:51:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFuSi-0000k2-L7\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 09:51:24 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFuSg-000616-44\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 09:51:24 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so86223205e9.2\n for ; Thu, 23 Apr 2026 06:51:21 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cb135asm57854091f8f.6.2026.04.23.06.51.17\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 23 Apr 2026 06:51:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776952280; x=1777557080; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=j6MYOyeyJGimQS2AbXbvngVBoZvDXVD0waN0vdNdT0Y=;\n b=tJFXNOHb2pCWVrudj5ewpOEb4Y6vE2UArLOriXSsTOnY7lMzn9A4Qp466fFQbKejoC\n rYhv7s+QwYygPRJAdWzXfDhL3cFXbL40DjKkdNymYUVKYFvwj1xekaz53dnji54VPcgs\n Nid+L0WXfpF95jdvtDIM3PbUszjrGMeJZ+ClNBNY51wIyFhpzVVn5R8SearwD22oOo69\n PilfnKCzs5Du1w7hdyypYG4Xy/teRxRN0n80OHzyWlA0YU0JBPrul+OnV6za5GMeYjIn\n lBwCvAvp44LIqAbLnY7LoDEFy6Sd3ZPk9zAR97dVMInaISEEeTBesg34C5swMIu4Mmb+\n mHgA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776952280; x=1777557080;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=j6MYOyeyJGimQS2AbXbvngVBoZvDXVD0waN0vdNdT0Y=;\n b=sqsVppiQpT33BdIKm6vNsopR84l0rQItcQXpNq2ODYHa6ZNMNJ4egy+Zj0U3IIQL+n\n biFlcwIJk+ucWfopP2wHDiqImYeURCasBuU3YSaEF8WaVrpRucuubTOhnmY26Nng33d1\n hhfBWWHfTMYML8CJbaD4f0lzQoXMxS6/Zf7zkkuUC/ZbN/ZHcOi2no6uuytlnl1RWDOD\n zVbc+HBQnDg7RFpRqKR0uUk7Qz/EY77E25dwM43hpEPDQwpAqWHLz+eCp22bDSk980ME\n dEnk/fUgxxcR3f2McBgCCpYdAb194WwIi+LFj205u3w3Jk9pv17pvRBHNPCs36ejqid5\n afrA==","X-Gm-Message-State":"AOJu0YwEBlXv2pgHcy/QbaAN0FT4hcejNenrSaT2F+z6xXYg9QkBj2E5\n ii6lYcvrN2b2I9JdB3GhMQ8gSqT6uxDKj8F0+GIrb0cttvmc31coPpbEDf67QM8p1IsETPo3r3K\n HbGqOWZI=","X-Gm-Gg":"AeBDievdVsw9JHnM8OtCGjhNCIoJ3SPzxkKIbMeOxQ5pobFlI89GBnHHEABV4KmxYM+\n FUFd3SDHi+9h/EVTIHPUWLzZLtdYnNyiAY0EJJbAo7muc+CWEHtVTWdA84VXB5GhpJCy4jKFZvv\n wlU9Rx/AL2PrYzNpFn420Eb7Grmvnjb4q7k9zwUg7nzqAiQDW6x/1Wyxlkt3X+PoZdIaHCah0X3\n 9oGgw3Bd2xdEZkhKbM47WVQCWXpQ9mTDsFaHIyvqOBbavh0LAgUFu3S3Jo8Ar7J3JkKINSsySvS\n DKIWR1Cn076my9wfn8f6on5s33PnX6UBXjBvYbejlAovOylweoXipD15ubppKGAMwWIhGc78NAC\n fNbD22FTheYEFLTyOfshair2Rf41m86sDJC5cR5Z3bcNz5mhxr4+lNTncwowwLntEtsLFxu+rrX\n gUfrUjzkwWEsIB/e3GFVzHp8ywmzaR7zqMEaDGKKjeM1n+GIp10hs4Nlx3gHSBJnQkjJ2eO8GrR\n KVHJPipp8k=","X-Received":"by 2002:a05:600c:4ec6:b0:489:1f98:71e3 with SMTP id\n 5b1f17b1804b1-4891f987487mr237830685e9.28.1776952279753;\n Thu, 23 Apr 2026 06:51:19 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Ilya Leoshkevich , qemu-s390x@nongnu.org,\n Matthew Rosato ,\n David Hildenbrand ,\n Richard Henderson ,\n Halil Pasic , Cornelia Huck ,\n Eric Farman ,\n Christian Borntraeger ,\n Anton Johansson ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH 5/9] target/s390x: Compile translate.c as common unit","Date":"Thu, 23 Apr 2026 15:50:31 +0200","Message-ID":"<20260423135035.50126-6-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423135035.50126-1-philmd@linaro.org>","References":"<20260423135035.50126-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In order do build translate.c as a common unit we need to\nreplace:\n\n #include \"tcg/tcg-op.h\" -> #include \"tcg/tcg-op-common.h\"\n -> #include \"tcg/tcg-op-mem.h\"\n\nand:\n\n \"accel/tcg/tcg-op-gvec.h\" -> \"accel/tcg/tcg-op-gvec-common.h\"\n\ntaking care to define TCG_ADDRESS_BITS, which is fixed\nfor this 64-bit target.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/s390x/tcg/translate.c | 6 ++++--\n target/s390x/tcg/meson.build | 2 +-\n 2 files changed, 5 insertions(+), 3 deletions(-)","diff":"diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c\nindex 0f274621e5a..82165ac1ec0 100644\n--- a/target/s390x/tcg/translate.c\n+++ b/target/s390x/tcg/translate.c\n@@ -31,8 +31,10 @@\n #include \"qemu/osdep.h\"\n #include \"cpu.h\"\n #include \"s390x-internal.h\"\n-#include \"tcg/tcg-op.h\"\n-#include \"tcg/tcg-op-gvec.h\"\n+#define TCG_ADDRESS_BITS 64\n+#include \"tcg/tcg-op-common.h\"\n+#include \"tcg/tcg-op-mem.h\"\n+#include \"tcg/tcg-op-gvec-common.h\"\n #include \"qemu/log.h\"\n #include \"qemu/host-utils.h\"\n #include \"exec/helper-proto.h\"\ndiff --git a/target/s390x/tcg/meson.build b/target/s390x/tcg/meson.build\nindex 67f31bfddd4..d1c60135411 100644\n--- a/target/s390x/tcg/meson.build\n+++ b/target/s390x/tcg/meson.build\n@@ -3,13 +3,13 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files(\n 'int_helper.c',\n 'mem_helper.c',\n 'misc_helper.c',\n- 'translate.c',\n 'vec_helper.c',\n ))\n s390x_common_ss.add(when: 'CONFIG_TCG', if_true: files(\n 'cc_helper.c',\n 'excp_helper.c',\n 'fpu_helper.c',\n+ 'translate.c',\n 'vec_fpu_helper.c',\n 'vec_int_helper.c',\n 'vec_string_helper.c',\n","prefixes":["5/9"]}