{"id":2227171,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227171/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260423095040.3169763-1-arnd@kernel.org/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423095040.3169763-1-arnd@kernel.org>","date":"2026-04-23T09:50:33","name":"[v2] smb: client: hide unused cifs_debug_dirs_proc_ops","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5af35a942b93064e33cc6bfb8178388e5d5347dc","submitter":{"id":80402,"url":"http://patchwork.ozlabs.org/api/1.1/people/80402/?format=json","name":"Arnd Bergmann","email":"arnd@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260423095040.3169763-1-arnd@kernel.org/mbox/","series":[{"id":501171,"url":"http://patchwork.ozlabs.org/api/1.1/series/501171/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501171","date":"2026-04-23T09:50:33","name":"[v2] smb: client: hide unused cifs_debug_dirs_proc_ops","version":2,"mbox":"http://patchwork.ozlabs.org/series/501171/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227171/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227171/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=itpdcWi+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11041-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"itpdcWi+\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Wmf2RmRz1yD5\n\tfor ; Thu, 23 Apr 2026 20:00:18 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 61909319CE39\n\tfor ; Thu, 23 Apr 2026 09:51:59 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6CFC03E5EC4;\n\tThu, 23 Apr 2026 09:50:46 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A633E3D94;\n\tThu, 23 Apr 2026 09:50:46 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 47362C2BCAF;\n\tThu, 23 Apr 2026 09:50:43 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776937846; cv=none;\n b=ftE41pUYOslkGyQtBsOhn/i00qG55RVsITxDK2nkLMUgBAhhZDaAx8lxJBhoaejNgzgjmCXH/o0tiv9WaICG7M7sISzRBP7J4nCynPYBfHUzxPfKkVsXnWAOegZACdzxO4WFqcVdfOZRvPEqrmJyZOraSS9mZTiJm0LF/DB+8JI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776937846; c=relaxed/simple;\n\tbh=yj1mvqHfxDhS9XGWQSouIxGCA9J6VRFxay8XYj4KAqI=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=EgrS9sDE8FbgAjjYIXEIFIC7/IQ8XFzXlXudvw6R4tWKhfoDu8cP0cLD2qkjUqk0R6MfPOqAdgTRXKHCLDFv+JNIjpFktzPCcM2ioTbhfusUny9We8eAlAdy6Hw6SN9+jueCOk9MA/JRjRz9pJB5leuqLxiJbhNIANz0+ue3dI4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=itpdcWi+; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776937845;\n\tbh=yj1mvqHfxDhS9XGWQSouIxGCA9J6VRFxay8XYj4KAqI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=itpdcWi+xx66WCNUeTN77cxm6srGySF4tJWs3DvG1M01rRsaK3527GL5gAyasSYSK\n\t kYbvFIUC4HWxkBNf/CE26YOfHBb1Yf3G0c7u56tsB3yzBptVdtNMAe8CuC3GqPtS8a\n\t DnFSKEr66p6GwiPIV6n/233sojftldOeFGu2JDTsu/ImSO9VNf6wfk7LKZyuaz9twP\n\t 7BLnHBd5prsV1y6uDuxkv8Ah5XOeTibvJvqJ7H/vavXfYEo8WT+55jbFkLiqUoHRby\n\t dTYNMxCCa6HjayI/cKkFYS94EN2hiybQzbAnms7bUfi5f8wVvj8exLW0QzWMyfDBJb\n\t 50PXF5xulqP2A==","From":"Arnd Bergmann ","To":"Steve French ,\n\tEnzo Matsumiya ","Cc":"Arnd Bergmann ,\n\tPaulo Alcantara ,\n\tRonnie Sahlberg ,\n\tShyam Prasad N ,\n\tTom Talpey ,\n\tBharath SM ,\n\tStefan Metzmacher ,\n\tNamjae Jeon ,\n\tlinux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] [v2] smb: client: hide unused cifs_debug_dirs_proc_ops","Date":"Thu, 23 Apr 2026 11:50:33 +0200","Message-Id":"<20260423095040.3169763-1-arnd@kernel.org>","X-Mailer":"git-send-email 2.39.5","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Arnd Bergmann \n\nWhen CONFIG_CIFS_DEBUG2 is disabled, the only reference to this\nfunction is hidden, causing a harmless warning:\n\nfs/smb/client/cifs_debug.c:395:30: error: 'cifs_debug_dirs_proc_ops' defined but not used [-Werror=unused-const-variable=]\n 395 | static const struct proc_ops cifs_debug_dirs_proc_ops = {\n | ^~~~~~~~~~~~~~~~~~~~~~~~\n\nSince the operations are now protected by CONFIG_CIFS_DEBUG, change\nthe reference to use the same one instead of the DEBUG2 version.\n\nFixes: 63bff18d4aa0 (\"smb: client: fix (remove) drop_dir_cache module parameter\")\nSigned-off-by: Arnd Bergmann \n---\n fs/smb/client/cifs_debug.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c\nindex f55e5cabdaee..1b5139a5e1f4 100644\n--- a/fs/smb/client/cifs_debug.c\n+++ b/fs/smb/client/cifs_debug.c\n@@ -933,11 +933,11 @@ cifs_proc_init(void)\n \tproc_create_single(\"open_files\", 0400, proc_fs_cifs,\n \t\t\tcifs_debug_files_proc_show);\n \n-#ifdef CONFIG_CIFS_DEBUG2\n+#ifdef CONFIG_CIFS_DEBUG\n \tproc_create(\"open_dirs\", 0644, proc_fs_cifs, &cifs_debug_dirs_proc_ops);\n-#else /* CONFIG_CIFS_DEBUG2 */\n+#else /* CONFIG_CIFS_DEBUG */\n \tproc_create_single(\"open_dirs\", 0400, proc_fs_cifs, cifs_debug_dirs_proc_show);\n-#endif /* !CONFIG_CIFS_DEBUG2 */\n+#endif /* !CONFIG_CIFS_DEBUG */\n \tproc_create(\"Stats\", 0644, proc_fs_cifs, &cifs_stats_proc_ops);\n \tproc_create(\"cifsFYI\", 0644, proc_fs_cifs, &cifsFYI_proc_ops);\n \tproc_create(\"traceSMB\", 0644, proc_fs_cifs, &traceSMB_proc_ops);\n","prefixes":["v2"]}