{"id":2227065,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2227065/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260423065042.1898971-1-arnd@kernel.org/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423065042.1898971-1-arnd@kernel.org>","date":"2026-04-23T06:50:30","name":"smb: client: hide unused cifs_debug_dirs_proc_ops","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dcc7dc76d7aa834efd447ed3e13f170b63c2b090","submitter":{"id":80402,"url":"http://patchwork.ozlabs.org/api/1.1/people/80402/?format=json","name":"Arnd Bergmann","email":"arnd@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260423065042.1898971-1-arnd@kernel.org/mbox/","series":[{"id":501151,"url":"http://patchwork.ozlabs.org/api/1.1/series/501151/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501151","date":"2026-04-23T06:50:30","name":"smb: client: hide unused cifs_debug_dirs_proc_ops","version":1,"mbox":"http://patchwork.ozlabs.org/series/501151/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227065/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227065/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=BnMa2Fmz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11039-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"BnMa2Fmz\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1RZt328Lz1y2d\n\tfor ; Thu, 23 Apr 2026 16:51:34 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0880D3069B99\n\tfor ; Thu, 23 Apr 2026 06:50:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A46813D34A0;\n\tThu, 23 Apr 2026 06:50:48 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 323E13D332A;\n\tThu, 23 Apr 2026 06:50:47 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 13214C2BCB5;\n\tThu, 23 Apr 2026 06:50:44 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776927048; cv=none;\n b=P6X1c5BRtSUiCVT7kh1qudcCJZ30oU3xXKw5eDXKIERtFdPXTWeujn0Clt+qWOmh3T3EOKRAOYSDkzabbC8U5vhKQCSA5Qq+rItAQLiQgi+aubMFrQXP5PuMNXc8TvK43ck17EeooPMif7rRCz3tA88nnAdNsKv5OjEeRYbekMY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776927048; c=relaxed/simple;\n\tbh=7H9ZOp6CnJc9xQUSM5oTTtu+rtc+Stelre6nEGmKuto=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=rGpEol09s5Ykl+t0YzHoIIVicGBLat55DaG4O4U1KVT/xzEy2HHezJYYXlAWPUlhBZOIGZtTl6QSK80pnIYEBFOolqPAABqk32oons7ew/L876BzjygSnjGp7ZdGUxSDQx7ua1XfzUuDt80h5K0NG+StsFbaE3WOMS7+zxvJmUk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=BnMa2Fmz; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776927047;\n\tbh=7H9ZOp6CnJc9xQUSM5oTTtu+rtc+Stelre6nEGmKuto=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=BnMa2Fmz/xve5din6HaUrbn6/WbFZzP9eBNb8kIxDzul5wqlmdJEQ5vJdMzTPUXc4\n\t loFqmghwQcAeACNsVAv6CEf/jLiT7892hLZTjP5LbowY5MqK9G29nw+/9zU6DgyWiM\n\t KyOGySsw/YiiJdBOe0ND1Hd1b1pUNjCqA9oSWCoCVir92BBgGq2dA4R1CflVt2fCJY\n\t jTZNzt3O61WbFypwTbB/2H3dZfbGZn5J+2VsfT/fG7fVp3g/OATuB6D7YoHGXcdUzD\n\t GvMeYL4oQDjsbDX3lrIv6yUgZLuZYu2DEI6S81g8ZF/iK5pUUO1pgOaolr2hnkjJgn\n\t UqG1a0jhWnsxw==","From":"Arnd Bergmann ","To":"Steve French ,\n\tEnzo Matsumiya ","Cc":"Arnd Bergmann ,\n\tPaulo Alcantara ,\n\tRonnie Sahlberg ,\n\tShyam Prasad N ,\n\tTom Talpey ,\n\tBharath SM ,\n\tStefan Metzmacher ,\n\tNamjae Jeon ,\n\tlinux-cifs@vger.kernel.org,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] smb: client: hide unused cifs_debug_dirs_proc_ops","Date":"Thu, 23 Apr 2026 08:50:30 +0200","Message-Id":"<20260423065042.1898971-1-arnd@kernel.org>","X-Mailer":"git-send-email 2.39.5","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Arnd Bergmann \n\nWhen CONFIG_CIFS_DEBUG2 is disabled, the only reference to this\nfunction is hidden, causing a harmless warning:\n\nfs/smb/client/cifs_debug.c:395:30: error: 'cifs_debug_dirs_proc_ops' defined but not used [-Werror=unused-const-variable=]\n 395 | static const struct proc_ops cifs_debug_dirs_proc_ops = {\n | ^~~~~~~~~~~~~~~~~~~~~~~~\n\nMake the #ifdef checks around them consistent by always using\nthe DEBUG2 variant.\n\nFixes: 63bff18d4aa0 (\"smb: client: fix (remove) drop_dir_cache module parameter\")\nSigned-off-by: Arnd Bergmann \n---\n fs/smb/client/cifs_debug.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c\nindex f55e5cabdaee..9a2e796161d0 100644\n--- a/fs/smb/client/cifs_debug.c\n+++ b/fs/smb/client/cifs_debug.c\n@@ -306,7 +306,7 @@ static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)\n \tLIST_HEAD(entry);\n \n \tseq_puts(m, \"# Version:1\\n\");\n-#ifdef CONFIG_CIFS_DEBUG\n+#ifdef CONFIG_CIFS_DEBUG2\n \tseq_puts(m, \"# Write 0 to this file to drop all cached directory entries\\n\");\n #endif /* CONFIG_CIFS_DEBUG */\n \tseq_puts(m, \"# Format:\\n\");\n@@ -356,7 +356,7 @@ static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)\n \treturn 0;\n }\n \n-#ifdef CONFIG_CIFS_DEBUG\n+#ifdef CONFIG_CIFS_DEBUG2\n static int cifs_debug_dirs_proc_open(struct inode *inode, struct file *file)\n {\n \treturn single_open(file, cifs_debug_dirs_proc_show, NULL);\n","prefixes":[]}