{"id":2226615,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2226615/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-15-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260422161407.118748-15-kwilczynski@kernel.org>","date":"2026-04-22T16:13:57","name":"[v6,14/24] alpha/PCI: Fix __pci_mmap_fits() overflow for zero-length BARs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"100c4fa502870b129bd76114dccda63012eede9a","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-15-kwilczynski@kernel.org/mbox/","series":[{"id":501041,"url":"http://patchwork.ozlabs.org/api/1.1/series/501041/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=501041","date":"2026-04-22T16:13:46","name":"PCI: Convert all dynamic sysfs attributes to static","version":6,"mbox":"http://patchwork.ozlabs.org/series/501041/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226615/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226615/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=rrE1j7uy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53000-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"rrE1j7uy\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14QZ2XJ0z1yD5\n\tfor ; Thu, 23 Apr 2026 02:28:06 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 09E8930DEA58\n\tfor ; Wed, 22 Apr 2026 16:15:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1915837D126;\n\tWed, 22 Apr 2026 16:15:01 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC0637CD54;\n\tWed, 22 Apr 2026 16:15:00 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7D06BC2BCB4;\n\tWed, 22 Apr 2026 16:14:57 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776874501; cv=none;\n b=XK6IhyKwqkk7CHDQpvE1uXkTLdQBhZbAVJnQeoLeA+VGfFUpvzFFiDNVsnc6Ieuxqjv9gWEF8dx2uERgq1OmtX8QFl1iqiqnQ1EY5x6RTCa/rXUIBP4QCkFJ5OXp3IbD5tyXeM2++xsy3EBfIHwqelT6TnqH4ENifq7fyWOvTjE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776874501; c=relaxed/simple;\n\tbh=dkenDLAyAT+KiwXEFM4WIJAXbFTQKkHWTcI169/tbfw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=VWWkN4eRXBnn1inhZJYWDLojCn01aAhpnM+FnM3btAr3PuQg4JvmuRY8BjuRyz5lju1vQXPLriDSj638BTT85ka38wXJEDwQr/txMo0Hq9NRR4THr833txJsRpuPjPq6mrdK3U6xRdIMKt/YJlZ+mwMEdg8ilCh/DHP5j14c9dw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=rrE1j7uy; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874500;\n\tbh=dkenDLAyAT+KiwXEFM4WIJAXbFTQKkHWTcI169/tbfw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rrE1j7uyIswhjn2yhrQSx3VK/tgsSMYjSTaeOjMIf6xQaDlUfI/U2ig03JKGS0G73\n\t 3z72S4W+GaTnOdwG+Q6AtZKdOt1fowfIdzK0ctGVLkUu6ej1jsNtlvhfYyKSeBN4b1\n\t GO0/sXri35yNoYsoLhmqaue3t5lYJeQqukI7z9COrJb3gbzUz0xZIsxu5UwPCGKX3a\n\t UJg8HyWTzAUExXlkKb1DGD3EZtVZ+S71QT7V8aB5wxpPgAM4lRdrgGnSCo9eE8+hdG\n\t dr3jT9Z90eVH8cCS/aKFoFaIfZi0J8oc95v6zs3ThvvkSSQCPzb6VUxnpm5pj+5/PG\n\t DI1b/hxppuyBw==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v6 14/24] alpha/PCI: Fix __pci_mmap_fits() overflow for\n zero-length BARs","Date":"Wed, 22 Apr 2026 16:13:57 +0000","Message-ID":"<20260422161407.118748-15-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260422161407.118748-1-kwilczynski@kernel.org>","References":"<20260422161407.118748-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, __pci_mmap_fits() computes the BAR size using\npci_resource_len() - 1, which wraps to a large value when the\nBAR length is zero, causing the bounds check to incorrectly\nsucceed.\n\nThus, add an early return for empty resources.\n\nFixes: 10a0ef39fbd1 (\"PCI/alpha: pci sysfs resources\")\nTested-by: Magnus Lindholm \nReviewed-by: Ilpo Järvinen \nAcked-by: Magnus Lindholm \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 5c29f1d2821c..8802f955256e 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -37,12 +37,16 @@ static int hose_mmap_page_range(struct pci_controller *hose,\n static int __pci_mmap_fits(struct pci_dev *pdev, int num,\n \t\t\t struct vm_area_struct *vma, int sparse)\n {\n+\tresource_size_t len = pci_resource_len(pdev, num);\n \tunsigned long nr, start, size;\n \tint shift = sparse ? 5 : 0;\n \n+\tif (!len)\n+\t\treturn 0;\n+\n \tnr = vma_pages(vma);\n \tstart = vma->vm_pgoff;\n-\tsize = ((pci_resource_len(pdev, num) - 1) >> (PAGE_SHIFT - shift)) + 1;\n+\tsize = ((len - 1) >> (PAGE_SHIFT - shift)) + 1;\n \n \tif (start < size && size - start >= nr)\n \t\treturn 1;\n","prefixes":["v6","14/24"]}